Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to isURL #500

Closed
tomgrossman opened this issue Feb 18, 2016 · 2 comments
Closed

Changes to isURL #500

tomgrossman opened this issue Feb 18, 2016 · 2 comments

Comments

@tomgrossman
Copy link
Contributor

Hi,
The following URL is falling in the isURL validator:

http://com---19.com

There shouldn't be a problem having '-' and numbers in the domain, you can check whois on this domain.
@chriso
Copy link
Collaborator

chriso commented Feb 18, 2016

The library was originally using an older version of https://gist.github.com/dperini/729294 which allowed one hyphen only. Hostnames with two adjacent hyphens were allowed in #294, and IDNA hostnames with three adjacent hyphens were allowed in #466.

I see that RFC 952 allows for any number of adjacent hyphens so I'll remove the restriction.

Thanks for reporting.

@chriso chriso closed this as completed in 1db186a Feb 18, 2016
@chriso
Copy link
Collaborator

chriso commented Feb 18, 2016

Fixed in 4.9.0

@chriso chriso mentioned this issue Feb 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriso @tomgrossman