Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for greater or less than in isFloat() #544

Closed
srkimir opened this issue Jun 16, 2016 · 3 comments
Closed

Support for greater or less than in isFloat() #544

srkimir opened this issue Jun 16, 2016 · 3 comments
Labels
🙋‍♂️feature-request

Comments

@srkimir
Copy link

srkimir commented Jun 16, 2016 •
edited
Loading

While there is support for min and max, it would be useful to have something like:

isFloat('0', {gt: 0})
@srkimir srkimir changed the title Is there a support for greater or less than? Support for greater or less than Jun 16, 2016
@chriso chriso changed the title Support for greater or less than Support for greater or less than in isFloat() Jul 15, 2016
@chriso
Copy link
Collaborator

chriso commented Sep 10, 2016

Happy to accept a PR 😄

@hkwu
Copy link
Contributor

hkwu commented Oct 4, 2016

Don't min and max already do what gt and lt would do?

@chriso
Copy link
Collaborator

chriso commented Oct 4, 2016

min and max are inclusive, i.e. gte and lte.

@chriso chriso closed this as completed in cb09637 Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋‍♂️feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriso @srkimir @hkwu