Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMobilePhone missing $ sign at end of he-IL locale #888

Closed
MatanBobi opened this issue Sep 2, 2018 · 2 comments
Closed

isMobilePhone missing $ sign at end of he-IL locale #888

MatanBobi opened this issue Sep 2, 2018 · 2 comments
Labels

Comments

@MatanBobi
Copy link
Contributor

Hi,
looks like the regex: 'he-IL': /^(\+972|0)([23489]|5[012345689]|77)[1-9]\d{6}/, is missing the $ sign at the end which causes a validation problem when not specifying locale as it will pass any string that only contains a valid (Israeli) phone at the start and not is a valid phone.
A permalink for the code here

A permalink for the associated commit here

I would gladly submit a PR if you find this as correct.
Thanks.

@chriso
Copy link
Collaborator

chriso commented Sep 2, 2018

That's definitely a bug. Happy to accept a PR 😄

@chriso chriso added the 🐛 bug label Sep 2, 2018
@MatanBobi
Copy link
Contributor Author

Sure.
Here it is: #889

@chriso chriso closed this as completed Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants