Fixed broken bindings for aria-labelby and ids #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 90.40% (diff: 100%)
@@ development #1055 diff @@
=============================================
Files 26 26
Lines 782 782
Methods 142 142
Messages 0 0
Branches 115 115
=============================================
Hits 707 707
Misses 75 75
Partials 0 0
|
|
Thanks for fix! |
jtomaszewski
pushed a commit
to jtomaszewski/ng2-bootstrap
that referenced
this pull request
Oct 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken bindings for id attributes of date-picker mode toggle button.
The rationale behind having this ARIA attribute is found in angular-ui/bootstrap/issues/2249
And here is the spec, which requires
aria-labelbyon the grid:https://www.w3.org/TR/wai-aria-practices/#datepicker