-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Dropdown injected in DOM at wrong location #1860
Comments
I also have the same issue, the expanded dropdown is added as |
Yup - its added at the same level as the 'dropdown' directive. I think its because of the new "Structural directive" (*dropdownMenu) introduced in 1.6.x but i might be wrong. |
@valorkin Can you please look into this, it really messes up the layout :( |
It was the only way to enable append to body mode, move more-menu class to dropdown-menu class |
And update css accordingly |
Greetings, If we can't have the dropdownMenu inside the dropdown directive with append to body mode, maybe there is a way we can split the component into two separate ones. Have many users experienced issues where the dropdown becomes hidden behind an element because it wasn't appended to the body? |
Additionally, this change breaks the routerLinkActive functionality rollup for dropdowns in nav-bars. Where if a link within the dropdown is active, the top level element would also be marked as active in the header. |
@valorkin would it be possible to keep both methods (previous and new ones)? Users who need the body append mode use it that way and simple folks like us use the older method |
I have an idea, dropdown menu can work as ngIf |
Hi, After i updated ng2-bootstrap from 1.4 to 1.6.1, i started getting dropdown placement issues.
The dropdown was initially opening adjacent to the toggle (
<a>More</a>
) in the code below:However after the update, now in DOM it appears one level up (adjacent to the
<li dropdown>
). This messes up the DOM structure. Am i missing an argument/setting or is this really a BUG?The text was updated successfully, but these errors were encountered: