Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): including es6-shim and es6-promise #194

Closed
wants to merge 1 commit into from
Closed

fix(demo): including es6-shim and es6-promise #194

wants to merge 1 commit into from

Conversation

binarious
Copy link

Added es6-shim and es6-promise for browsers without es6 support.

Demo: https://dl.dropboxusercontent.com/u/19031145/ng2-bootstrap/index.html
It got rid of the error Object doesn't support property or method in IE11, but now it throws:

SyntaxError: The use of a keyword for an indentifier is invalid

So maybe I broke something else.

@binarious binarious changed the title fix(demo): including es6-shim and es6-promise WIP: fix(demo): including es6-shim and es6-promise Feb 15, 2016
@ericmartinezr
Copy link

@binarious I answered you in gitter's chatroom, but maybe I'll call your attention faster in here. For your last error message there's another shim https://github.com/angular/angular/blob/master/modules/angular2/src/testing/shims_for_IE.js#L3-L14 (see @Mlaval comment angular/angular#6501 (comment))

@binarious
Copy link
Author

@valorkin There are still other issues with IE as you can see in the gitter discussion. This PR could still be merged to support other browsers without ES6 support. But: I needed to replace the referenced file in CommonsChunkPlugin to get polyfills to be loaded first. I don't know if that could break something else. Just be aware :).

@binarious binarious changed the title WIP: fix(demo): including es6-shim and es6-promise fix(demo): including es6-shim and es6-promise Feb 15, 2016
@valorkin valorkin closed this in 80b73b4 Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants