Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typeahead): Clicking an item does not raise the typeaheadOnSelect event #363

Closed
johan13 opened this issue Apr 1, 2016 · 6 comments
Closed

fix(typeahead): Clicking an item does not raise the typeaheadOnSelect event #363

johan13 opened this issue Apr 1, 2016 · 6 comments
Assignees
@valorkin
Labels
issue
Milestone
beta.14

Comments

@johan13
Copy link

johan13 commented Apr 1, 2016

Repo steps:

Result: The suggestions list disappears, but the typeaheadOnSelect is not raised and the input field is empty.
Expected: That the typeaheadOnSelect event is raised just as it would be if I'd hit enter.
@johan13
Copy link
Author

johan13 commented Apr 1, 2016

I got the same result on Mac Chrome, Mac Firefox and Windows IE11.

@valorkin valorkin changed the title Typeahead: Clicking an item does not raise the typeaheadOnSelect event fix(typeahead): Clicking an item does not raise the typeaheadOnSelect event Apr 1, 2016
@valorkin valorkin added the issue label Apr 1, 2016
@valorkin valorkin added this to the beta.14 milestone Apr 1, 2016
@rbaarsma
Copy link
Contributor

rbaarsma commented Apr 4, 2016

+1

@koodikindral
Copy link

currently a blocker

@valorkin valorkin self-assigned this Apr 5, 2016
@koodikindral
Copy link

Seems that #351 did break this, blur event seems to override select event callback for some reason.

@koodikindral koodikindral mentioned this issue Apr 9, 2016
Closed
@slintes
Copy link
Contributor

slintes commented Apr 11, 2016

ups, sorry for introducing this bug with my blur event commit. I noticed it today myself, seems I always selected by pressing enter before...

fkowal pushed a commit to fkowal/ng2-bootstrap that referenced this issue Apr 12, 2016
fix(typeahead): Blur hide with timeout, to allow other events to be t…
12c1875 
…riggered. Fixes valor-software#363
@fkowal fkowal mentioned this issue Apr 12, 2016
Merged
@fkowal
Copy link
Contributor

fkowal commented Apr 12, 2016

Hi made a fix using a different approve. #398 Which one makes more sense ?

valorkin pushed a commit that referenced this issue Apr 12, 2016
@fkowal @valorkin
fix(typeahead): Blur hide with timeout, to allow other events to be t…
1a719d0 
…riggered. (fixes #363)

closes #395 closes #389 closes #363
@valorkin valorkin changed the title fix(typeahead): Clicking an item does not raise the typeaheadOnSelect event fix(typeahead): Clicking an item does not raise the typeaheadOnSelect event Apr 12, 2016
@slintes slintes mentioned this issue Apr 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valorkin valorkin

Labels
issue
Projects
None yet
Milestone
beta.14
Development

No branches or pull requests
6 participants
@fkowal @johan13 @rbaarsma @valorkin @slintes @koodikindral