Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #16: chore(datepicker): support null value #445

Closed

Conversation

JohanSmolders
Copy link
Contributor

Introduced support for null as default value:

  • In the ngOnInit method of the datepicker-inner class the update should only emit when selectedDate is changed.
  • Extra check in compare function
  • activeDate() shouldn't return today when not set

@valorkin
Copy link
Member

hey, looks good, let me check
but for some odd reason it shows typeahead fix too

Johan Smolders added 3 commits April 26, 2016 15:38
Introduced support for null as default value:

- In the ngOnInit method of the datepicker-inner class the update should only emit when selectedDate is changed.
- Extra check in compare function
- activeDate() shouldn't return today when not set
…to select a date in pop-up. It doesn't reflect selected-date.
…to select a date in pop-up. It doesn't reflect selected-date.
@JohanSmolders
Copy link
Contributor Author

Sorry about that, fixed it.
Rebased with your master instead of develop.

@valorkin
Copy link
Member

no worries, always rebase on default branch (here it is dev) :)
merging and testing locally

@valorkin valorkin closed this in 794347e Apr 26, 2016
valorkin pushed a commit that referenced this pull request Apr 26, 2016
Introduced support for null as default value:

- In the ngOnInit method of the datepicker-inner class the update should only emit when selectedDate is changed.
- Extra check in compare function
- activeDate() shouldn't return today when not set

fixes #16, closes #445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants