Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: programmatically select active items #223

Conversation

Namek
Copy link
Contributor

@Namek Namek commented May 31, 2016

Add active property which describes currently selected items.
Remove initData property since everything works on top of active.

@Namek
Copy link
Contributor Author

Namek commented May 31, 2016

if possibly merged in, a thing that is left is to update README.md (remove info about initData and add active)

@Namek Namek force-pushed the development---set_selected_items/feat branch 2 times, most recently from e44b1f0 to c6f6298 Compare May 31, 2016 15:28
@Namek Namek mentioned this pull request Jun 1, 2016
@valorkin
Copy link
Member

valorkin commented Jun 1, 2016

@Namek ok, looks really good to me!
2 things:

  1. please add Readme update
  2. fix tslint issues :)

Add `active` property which describes currently selected items.
Remove `initData` property since everything works on top of `active`.
@Namek Namek force-pushed the development---set_selected_items/feat branch from c6f6298 to bb39a1b Compare June 1, 2016 18:27
@Namek
Copy link
Contributor Author

Namek commented Jun 1, 2016

@valorkin done, that should be it.

To make it more angular-way we should enable two-way databinding by merging active input with selected output into @Input() selected + @Output() selectedChange.

In case you didn't know what I'm talking about, these two snippets are equal:

<input type="text" class="form-control" required
  [ngModel]="model.name"
  (ngModelChange)="model.name = $event" >
<input type="text" class="form-control" required
  [(ngModel)]="model.name">

(source: https://angular.io/docs/ts/latest/guide/forms.html)

But I think if selected would be changed to selectedChange then we should also rename other outputs. I didn't PR'ed this because I'm not sure if you like it.

@achimha
Copy link

achimha commented Jun 3, 2016

Any timeline when this will be merged and released to NPM?

@valorkin
Copy link
Member

valorkin commented Jun 4, 2016

Usually Monday - Tuesday is release days

On Fri, Jun 3, 2016, 12:51 Achim Hasenmueller [email protected]
wrote:

Any timeline when this will be merged and released to NPM?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#223 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABDk440mecFLLWz-NmI2s0x7cMgiFO5Eks5qH_kPgaJpZM4Iqo0T
.

@EricSch
Copy link

EricSch commented Jun 20, 2016

When will this change merged? Seems it is still open
Thanks

@EricSch
Copy link

EricSch commented Jun 24, 2016

Am I wrong? I don't see the changes published to NPM.
Thanks

@cbergoon
Copy link

Again, any timeline on when this will be merged in?

@valorkin valorkin merged commit 1ddbcd9 into valor-software:development Jun 27, 2016
@JohnCashmore
Copy link

Any update one when it will be published to npm?

@rkralston
Copy link

I'm releasing a product and really need this now.

@ghost
Copy link

ghost commented Jun 30, 2016

Hey guys, thanks a lot for this awesome directive! I could not make [active] property works. I have tried with everything Array, any[], cast element as SelectItem but nothing, there is no way for me to set the directive with initial data. It seems to be that this issue is related to that. We are using this in PRD so the sooner you could fix this or merge the fix, will be more than appreciated. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants