Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove unreachable code (TS error) #178

Closed
born2net opened this issue Feb 12, 2016 · 2 comments
Closed

Please remove unreachable code (TS error) #178

born2net opened this issue Feb 12, 2016 · 2 comments

Comments

@born2net
Copy link

in ng2-bootstrap/components/timepicker/timepicker.component.ts

remove

// Evaluate from template
    let hours = this.getHoursFromTemplate();
    let minutes = this.getMinutesFromTemplate();
    if (isDefined(hours) && isDefined(minutes)) {
      this.selected.setHours(hours);
      this.refresh();
    }

as TS complains of non reachable code

tx

Sean

@valorkin
Copy link
Member

please use ts 1.7.5 until 1.8 is supported by ng2
duplicate of #116

@born2net
Copy link
Author

ok tx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants