Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added id parameter in tab directive #1909

Merged
merged 2 commits into from
Jun 2, 2017
Merged

Added id parameter in tab directive #1909

merged 2 commits into from
Jun 2, 2017

Conversation

akarabach
Copy link
Contributor

@akarabach akarabach commented Apr 18, 2017

For #1908

@codecov
Copy link

codecov bot commented Apr 18, 2017

Codecov Report

Merging #1909 into development will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1909      +/-   ##
===============================================
+ Coverage        85.93%   86.55%   +0.61%     
===============================================
  Files               78       85       +7     
  Lines             2098     2253     +155     
  Branches           273      290      +17     
===============================================
+ Hits              1803     1950     +147     
- Misses             202      203       +1     
- Partials            93      100       +7
Impacted Files Coverage Δ
src/tabs/tab.directive.ts 100% <100%> (ø) ⬆️
src/popover/popover.directive.ts 97.61% <0%> (-2.39%) ⬇️
demo/src/app/app.component.ts
scripts/helpers.js
src/dropdown/index.ts 100% <0%> (ø)
src/dropdown/bs-dropdown-container.component.ts 53.84% <0%> (ø)
src/dropdown/bs-dropdown-menu.directive.ts 100% <0%> (ø)
src/dropdown/bs-dropdown.config.ts 80% <0%> (ø)
scripts/helpers.ts 100% <0%> (ø)
src/dropdown/bs-dropdown.directive.ts 84.21% <0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60fe034...ab8b720. Read the comment docs.

@valorkin
Copy link
Member

Why do we need I'd param if it is not used?

@akarabach
Copy link
Contributor Author

akarabach commented Apr 21, 2017

@valorkin We integrated tabs with router and we control tabs from <my-wrapper> (see #1908), but we have tabs with the same heading and we don't know how recognize tabs for to activate the desired tab.

@valorkin
Copy link
Member

Got your point, I will be back from vacation next week and will be merging PRs

@valorkin valorkin merged commit 20c7fb8 into valor-software:development Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants