Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinning the timepicker down below zero on April 1st moves the date to May 1st #5766

Open
mbrankintrintech opened this issue Apr 15, 2020 · 0 comments
Open

Spinning the timepicker down below zero on April 1st moves the date to May 1st #5766

mbrankintrintech opened this issue Apr 15, 2020 · 0 comments
Labels
comp(timepicker) issue

Comments

@mbrankintrintech
Copy link

mbrankintrintech commented Apr 15, 2020 •
edited
Loading

A timepicker with an input date of April 1st 2020 when span below 12AM will move the date from April 1st to May 1st.

Stackblitz: https://stackblitz.com/edit/angular-t2gd1c-ssxa3g

Just keep moving the hour down until it goes past 12.

Doesn't appear to happen on other dates.

Expected: It goes around again and stays on the same date
Actual: It moves the date by an entire month
a-mcc pushed a commit to a-mcc/ngx-bootstrap that referenced this issue Jul 7, 2022
fix(timepicker): fix date overflow on short months
708b935 
change year, month, date setting on time change to be atomic, preventing overflows for short months

Closes valor-software#5766
@a-mcc a-mcc mentioned this issue Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp(timepicker) issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(timepicker): fix date overflow on short months a-mcc/ngx-bootstrap
3 participants
@valorkin @mbrankintrintech @apotapcukv