-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console error/warning for every instance of the popover attribute that is not enclosed in brackets #6544
Comments
Also seeing this! Using Chrome: 109.0.5414.87 |
so, let's use [popover]="'simple message'" as workaround to avoid some Breaking Changes, docs are fixed |
Do you know if this will be the only change to address this, or will there be a larger change in the future to move away from the Our app has about 350 instances of the Thanks! |
I think it is enough |
This solution not work when using I18n localize, for example: <button type="button" i18n-popover="@@00012" [popover]="'An Example'">Not work</Button> |
I would suggest |
@SvetlanaMuravlova the solution to enclose in additional apostrophes won't work if we use binding to some HTML template either:
So need a different solution, thanks. |
Bug description:
Chromium: 109.0.5414.87 is now showing an error in the console about popover usage.
Found a 'popover' attribute. If you are testing the popover API, you must enable Experimental Web Platform Features. If not, note that custom attributes must start with 'data-': https://html.spec.whatwg.org/multipage/dom.html#custom-data-attribute. This usage will *likely cause site breakage* when the popover API ships: https://chromestatus.com/feature/5463833265045504.
Plunker/StackBlitz that reproduces the issue:
https://stackblitz.com/edit/angular-icrdyw
same in standalone window: https://angular-icrdyw.stackblitz.io/
Versions of ngx-bootstrap, Angular, and Bootstrap:
ngx-bootstrap: 9.0
Angular: 14
Bootstrap: 4.6
Build system: Angular CLI, System.js, webpack, starter seed:
Expected behavior
No errors or warnings in console when using
popover
attribute from ngx-bootstrap.Since the latest Chromium update, we now see an error for every instance that we use
popover="simple message"
. The error goes away if we use the following syntax:[popover]="'simple message'"
The text was updated successfully, but these errors were encountered: