Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server does not fail if invalid cert is specified for grpc transport #388

Closed
edaniszewski opened this issue Apr 9, 2020 · 0 comments · Fixed by #391
Closed

server does not fail if invalid cert is specified for grpc transport #388

edaniszewski opened this issue Apr 9, 2020 · 0 comments · Fixed by #391

Comments

@edaniszewski
Copy link
Contributor

By "invalid", I mean the cert does not exist. This is because the cert is not checked for presence and is instead just passed right to the client constructor. This happens in a block where we trap errors and instead of failing, let them pass through so we can try again later. The intent being that if we fail to connect, it doesn't terminate the server.

It looks like two things could happen here:

  • a preliminary check on startup to verify that the configured file does in fact exist
  • more granular exception handling on plugin client creation so we do not fall through when this file not found error is raised
timestamp='2020-04-09T19:04:02.803746Z' logger='synse_server.plugin' level='warning' event='failed to register configured plugin - will attempt re-registering later' address='emulator-plugin:5001' protocol='tcp' error=FileNotFoundError(2, 'No such file or directory')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant