Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importance of "order" argument #6

Open
samlobe opened this issue Sep 11, 2024 · 0 comments
Open

Importance of "order" argument #6

samlobe opened this issue Sep 11, 2024 · 0 comments

Comments

@samlobe
Copy link

samlobe commented Sep 11, 2024

Hi,
This is very nice work! I have one technical question:
I noticed that ESM's developers have a multichain_util.py that mentions, "For best performance, put the target chain first in concatenation", and then proceeds to force the target chain coords to be first (see their multichain_util._concatenate_coords function).
However your multichain_util.py specifically allows either chain to be first with the "order" argument.
So you allow either the antibody or antigen to be first while ESM forces us to put the antibody first in scoring.
In other words, ESM-IF does not consider the antigen sequence when scoring log-likelihoods for the antibody, but you do. And this matters in an autoregressive model like ESM-IF.

Do you have a reason for this? I assume ESM's developers did some performance testing where they got better results by putting the target chain (e.g. antibody) first, so I'm inclined to stick with their suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant