Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tolerations, nodeSelector, and affinity are shared by controller sts and node ds; and they're strings #3

Open
mortya opened this issue Apr 3, 2023 · 0 comments

Comments

@mortya
Copy link

mortya commented Apr 3, 2023

Trying vast csi helm chart 0.1.0, with the latest helm, v3.11.2. Running into two problems:

  1. the tolerations, nodeSelector, and affinity are shared by the controller statefulset and the node daemonset. But the controller and the daemonset should have different values for these. For example, we want the daemonset to tolerate pretty much everything, because we want it running on all of our nodes, so we want it to have an expansive toleration and no node selector. But we want the controller to run on only certain stable nodes when they aren't under maintenance, so it needs a different, smaller toleration and a specific nodeSelector.
  2. the helm chart documentation implies that the toleration should be an array and the nodeSelector should be a map. But the actual implementations complain if these are not strings.

Thanks for all your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant