From 0eda50b17827b0d9c87a5c2e4395499d6c8a15eb Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:20:57 +0800 Subject: [PATCH 01/54] rename __cached_methods -> _cached_methods --- src/sage/combinat/integer_lists/base.pxd | 2 +- src/sage/cpython/getattr.pyx | 2 +- .../combinatorial_polyhedron/base.pxd | 2 +- src/sage/misc/cachefunc.pyx | 50 +++++++++---------- src/sage/misc/lazy_attribute.pyx | 6 +-- src/sage/rings/morphism.pxd | 2 +- .../rings/padics/pow_computer_relative.pxd | 2 +- .../rings/polynomial/polynomial_element.pxd | 2 +- .../schemes/elliptic_curves/mod_sym_num.pyx | 20 ++++---- src/sage/structure/category_object.pxd | 2 +- src/sage/structure/category_object.pyx | 6 +-- src/sage/structure/element.pxd | 2 +- src/sage/structure/element.pyx | 6 +-- 13 files changed, 52 insertions(+), 52 deletions(-) diff --git a/src/sage/combinat/integer_lists/base.pxd b/src/sage/combinat/integer_lists/base.pxd index ecb5550a9cf..3d373a64fe0 100644 --- a/src/sage/combinat/integer_lists/base.pxd +++ b/src/sage/combinat/integer_lists/base.pxd @@ -12,4 +12,4 @@ cdef class IntegerListsBackend(): cdef readonly min_part, max_part cdef readonly min_slope, max_slope cdef readonly Envelope floor, ceiling - cdef public dict __cached_methods # Support cached_method + cdef public dict _cached_methods # Support cached_method diff --git a/src/sage/cpython/getattr.pyx b/src/sage/cpython/getattr.pyx index 3f603b98040..16f649c083d 100644 --- a/src/sage/cpython/getattr.pyx +++ b/src/sage/cpython/getattr.pyx @@ -271,7 +271,7 @@ cpdef getattr_from_other_class(self, cls, name): Caveat: lazy attributes work with extension types only if they allow attribute assignment or have a public attribute - ``__cached_methods`` of type ````. This condition + ``_cached_methods`` of type ````. This condition is satisfied, e.g., by any class that is derived from :class:`Parent`:: diff --git a/src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd b/src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd index bdd49225ff2..030c9defa45 100644 --- a/src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd +++ b/src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pxd @@ -8,7 +8,7 @@ from .polyhedron_face_lattice cimport PolyhedronFaceLattice @cython.final cdef class CombinatorialPolyhedron(SageObject): - cdef public dict __cached_methods + cdef public dict _cached_methods # Do not assume any of those attributes to be initialized, use the corresponding methods instead. cdef tuple _Vrep # the names of VRep, if they exist diff --git a/src/sage/misc/cachefunc.pyx b/src/sage/misc/cachefunc.pyx index a307c33e32b..4c3bea61c63 100644 --- a/src/sage/misc/cachefunc.pyx +++ b/src/sage/misc/cachefunc.pyx @@ -60,7 +60,7 @@ be used:: We can proceed similarly for cached methods of Cython classes, provided that they allow attribute assignment or have a public -attribute ``__cached_methods`` of type ````. Since +attribute ``_cached_methods`` of type ````. Since :trac:`11115`, this is the case for all classes inheriting from :class:`~sage.structure.parent.Parent`. See below for a more explicit example. By :trac:`12951`, cached methods of extension classes can @@ -301,14 +301,14 @@ ought to be chosen. A typical example is By :trac:`12951`, the cached_method decorator is also supported on non-c(p)def methods of extension classes, as long as they either support attribute assignment -or have a public attribute of type ```` called ``__cached_methods``. The +or have a public attribute of type ```` called ``_cached_methods``. The latter is easy:: sage: # needs sage.misc.cython sage: cython_code = [ ....: "from sage.misc.cachefunc import cached_method", ....: "cdef class MyClass:", - ....: " cdef public dict __cached_methods", + ....: " cdef public dict _cached_methods", ....: " @cached_method", ....: " def f(self, a,b):", ....: " return a*b"] @@ -2019,7 +2019,7 @@ cdef class CachedMethodCaller(CachedFunction): This getter attempts to assign a bound method as an attribute to the given instance. If this is not possible (for example, for some extension classes), - it is attempted to find an attribute ``__cached_methods``, + it is attempted to find an attribute ``_cached_methods``, and store/retrieve the bound method there. In that way, cached methods can be implemented for extension classes deriving from :class:`~sage.structure.parent.Parent` @@ -2085,7 +2085,7 @@ cdef class CachedMethodCaller(CachedFunction): """ # This is for Parents or Elements that do not allow attribute assignment try: - return (inst.__cached_methods)[self._cachedmethod._cachedfunc.__name__] + return (inst._cached_methods)[self._cachedmethod._cachedfunc.__name__] except (AttributeError, TypeError, KeyError): pass @@ -2100,10 +2100,10 @@ cdef class CachedMethodCaller(CachedFunction): except AttributeError: pass try: - if inst.__cached_methods is None: - inst.__cached_methods = {self._cachedmethod._cachedfunc.__name__ : Caller} + if inst._cached_methods is None: + inst._cached_methods = {self._cachedmethod._cachedfunc.__name__ : Caller} else: - (inst.__cached_methods)[self._cachedmethod._cachedfunc.__name__] = Caller + (inst._cached_methods)[self._cachedmethod._cachedfunc.__name__] = Caller except AttributeError: pass return Caller @@ -2421,7 +2421,7 @@ cdef class CachedMethodCallerNoArgs(CachedFunction): This getter attempts to assign a bound method as an attribute to the given instance. If this is not possible (for example, for some extension classes), - it is attempted to find an attribute ``__cached_methods``, + it is attempted to find an attribute ``_cached_methods``, and store/retrieve the bound method there. In that way, cached methods can be implemented for extension classes deriving from :class:`~sage.structure.parent.Parent` @@ -2472,7 +2472,7 @@ cdef class CachedMethodCallerNoArgs(CachedFunction): """ # This is for Parents or Elements that do not allow attribute assignment try: - return (inst.__cached_methods)[self.__name__] + return (inst._cached_methods)[self.__name__] except (AttributeError, TypeError, KeyError): pass Caller = CachedMethodCallerNoArgs(inst, self.f, name=self.__name__, do_pickle=self.do_pickle) @@ -2482,10 +2482,10 @@ cdef class CachedMethodCallerNoArgs(CachedFunction): except AttributeError: pass try: - if inst.__cached_methods is None: - inst.__cached_methods = {self.__name__ : Caller} + if inst._cached_methods is None: + inst._cached_methods = {self.__name__ : Caller} else: - (inst.__cached_methods)[self.__name__] = Caller + (inst._cached_methods)[self.__name__] = Caller except AttributeError: pass return Caller @@ -2828,7 +2828,7 @@ cdef class CachedMethod(): except AttributeError: name = self.__name__ try: - return (inst.__cached_methods)[name] + return (inst._cached_methods)[name] except (AttributeError, TypeError, KeyError): pass # Apparently we need to construct the caller. @@ -2864,10 +2864,10 @@ cdef class CachedMethod(): except AttributeError: pass try: - if inst.__cached_methods is None: - inst.__cached_methods = {name : Caller} + if inst._cached_methods is None: + inst._cached_methods = {name : Caller} else: - (inst.__cached_methods)[name] = Caller + (inst._cached_methods)[name] = Caller except AttributeError: pass return Caller @@ -2965,12 +2965,12 @@ cdef class CachedSpecialMethod(CachedMethod): D = inst.__dict__ except (TypeError, AttributeError): try: - D = inst.__cached_methods + D = inst._cached_methods except (TypeError, AttributeError): - raise TypeError("For a cached special method, either attribute assignment or a public '__cached_methods' attribute of type is needed") + raise TypeError("For a cached special method, either attribute assignment or a public '_cached_methods' attribute of type is needed") if D is None: - # This can only happen in the case of __cached_methods - D = inst.__cached_methods = {} + # This can only happen in the case of _cached_methods + D = inst._cached_methods = {} else: try: return D[name] @@ -3298,13 +3298,13 @@ cdef class CachedInParentMethod(CachedMethod): return P.__dict__.setdefault(self._cache_name, default) except AttributeError: pass - if not hasattr(P,'__cached_methods'): + if not hasattr(P,'_cached_methods'): raise TypeError("The parent of this element does not allow attribute assignment\n" + " and does not descend from the Parent base class.\n" + " Cannot use CachedInParentMethod.") - if P.__cached_methods is None: - P.__cached_methods = {} - return (P.__cached_methods).setdefault(self._cache_name, default) + if P._cached_methods is None: + P._cached_methods = {} + return (P._cached_methods).setdefault(self._cache_name, default) def __get__(self, inst, cls): """ diff --git a/src/sage/misc/lazy_attribute.pyx b/src/sage/misc/lazy_attribute.pyx index 82a0f90b775..bdbec3b3ba1 100644 --- a/src/sage/misc/lazy_attribute.pyx +++ b/src/sage/misc/lazy_attribute.pyx @@ -111,12 +111,12 @@ cdef class _lazy_attribute(): if a is None: # when doing cls.x for cls a class and x a lazy attribute return self try: - # __cached_methods is supposed to be a public Cython attribute. + # _cached_methods is supposed to be a public Cython attribute. # Apparently, these are *not* subject to name mangling. - CM = getattr(a, '__cached_methods') + CM = getattr(a, '_cached_methods') if CM is None: CM = {} - setattr(a, '__cached_methods', CM) + setattr(a, '_cached_methods', CM) except AttributeError as msg: CM = None if CM is not None: diff --git a/src/sage/rings/morphism.pxd b/src/sage/rings/morphism.pxd index ea6089f29b4..4b8e8d052df 100644 --- a/src/sage/rings/morphism.pxd +++ b/src/sage/rings/morphism.pxd @@ -14,7 +14,7 @@ cdef class RingMap_lift(RingMap): cdef class RingHomomorphism(RingMap): cdef Morphism _lift - cdef public dict __cached_methods + cdef public dict _cached_methods cdef class RingHomomorphism_im_gens(RingHomomorphism): cdef _im_gens diff --git a/src/sage/rings/padics/pow_computer_relative.pxd b/src/sage/rings/padics/pow_computer_relative.pxd index fc7d5b21f42..e0e5aa5600e 100644 --- a/src/sage/rings/padics/pow_computer_relative.pxd +++ b/src/sage/rings/padics/pow_computer_relative.pxd @@ -18,7 +18,7 @@ cdef class PowComputer_relative(PowComputer_class): cdef Polynomial_generic_dense shift_rem cdef Polynomial_generic_dense aliasing # allow cached methods - cdef public dict __cached_methods + cdef public dict _cached_methods cdef unsigned long capdiv(self, unsigned long n) diff --git a/src/sage/rings/polynomial/polynomial_element.pxd b/src/sage/rings/polynomial/polynomial_element.pxd index 083f506b222..e6d935d28fe 100644 --- a/src/sage/rings/polynomial/polynomial_element.pxd +++ b/src/sage/rings/polynomial/polynomial_element.pxd @@ -45,7 +45,7 @@ cdef class Polynomial(CommutativePolynomial): cpdef _mul_(self, right) cpdef _floordiv_(self, right) - cdef public dict __cached_methods + cdef public dict _cached_methods cdef class Polynomial_generic_dense(Polynomial): cdef Polynomial_generic_dense _new_c(self, list coeffs, Parent P) diff --git a/src/sage/schemes/elliptic_curves/mod_sym_num.pyx b/src/sage/schemes/elliptic_curves/mod_sym_num.pyx index 65742f28d72..296a6b5d075 100644 --- a/src/sage/schemes/elliptic_curves/mod_sym_num.pyx +++ b/src/sage/schemes/elliptic_curves/mod_sym_num.pyx @@ -730,7 +730,7 @@ cdef class ModularSymbolNumerical: double _eps_plus, _eps_minus, _eps_unitary_plus, _eps_unitary_minus public RealNumber _om1, _om2 object _E, _epsQs, _Mt, _Epari - public dict __cached_methods + public dict _cached_methods Rational _twist_q Integer _D int _global_sign @@ -785,7 +785,7 @@ cdef class ModularSymbolNumerical: self._set_epsQs() self._initialise_an_coefficients() self._set_den_bounds() - self.__cached_methods = {} + self._cached_methods = {} # self.nc_sums = Integer(0) # self.nc_direct = Integer(0) @@ -1357,7 +1357,7 @@ cdef class ModularSymbolNumerical: sage: M(0) 1/5 """ - cadi = self.__cached_methods + cadi = self._cached_methods for me in cadi: cadi[me].clear_cache() @@ -1833,7 +1833,7 @@ cdef class ModularSymbolNumerical: # if called with a previous (m,z,eps) but a larger eps, # return the cached value - cac = self.__cached_methods['_kappa'].cache + cac = self._cached_methods['_kappa'].cache for ke in cac: mm, zz, eeps = ke[0] if mm == m and zz == z: @@ -2746,16 +2746,16 @@ cdef class ModularSymbolNumerical: sage: ms = ModularSymbolNumerical(E) sage: ms.manin_symbol(4,17) 1 - sage: ms.__cached_methods["_manin_symbol_with_cache"].cache # random + sage: ms._cached_methods["_manin_symbol_with_cache"].cache # random {((1, 5, 1), ()): 1, ((1, 15, 1), ()): -1, ((1, 22, 1), ()): -1, ((1, 32, 1), ()): 1} - sage: ms.__cached_methods["_manin_symbol_with_cache"].cache[(1,15,1),()] + sage: ms._cached_methods["_manin_symbol_with_cache"].cache[(1,15,1),()] -1 sage: ms.manin_symbol(4+17,-4) 0 - sage: ms.__cached_methods["_manin_symbol_with_cache"].cache # random + sage: ms._cached_methods["_manin_symbol_with_cache"].cache # random {((1, 4, 1), ()): 0, ((1, 5, 1), ()): 1, ((1, 8, 1), ()): 1, @@ -2768,7 +2768,7 @@ cdef class ModularSymbolNumerical: ((1, 29, 1), ()): 1, ((1, 32, 1), ()): 1, ((1, 33, 1), ()): 0} - sage: ms.__cached_methods["_manin_symbol_with_cache"].cache[ (1,23,1), () ] + sage: ms._cached_methods["_manin_symbol_with_cache"].cache[ (1,23,1), () ] -1 """ cdef: @@ -2903,7 +2903,7 @@ cdef class ModularSymbolNumerical: # "(%s :%s)"%(un, vn), level=3) # is it already in the cache ? - c = self.__cached_methods + c = self._cached_methods if "_manin_symbol_with_cache" in c: c = c["_manin_symbol_with_cache"] if c.is_in_cache(un,vn,sign): @@ -2919,7 +2919,7 @@ cdef class ModularSymbolNumerical: # we get for free additional values of Manin # symbols that we cache, too. # This sets 6 values in average - c = self.__cached_methods["_manin_symbol_with_cache"] + c = self._cached_methods["_manin_symbol_with_cache"] # (-v:u) = - (u:v) oi = proj_normalise(self._N_E, -v, u, &un, &vn) diff --git a/src/sage/structure/category_object.pxd b/src/sage/structure/category_object.pxd index ff3088ae9b6..83d3d4967d4 100644 --- a/src/sage/structure/category_object.pxd +++ b/src/sage/structure/category_object.pxd @@ -13,7 +13,7 @@ from sage.structure.sage_object cimport SageObject cpdef check_default_category(default_category, category) cdef class CategoryObject(SageObject): - cdef public dict __cached_methods + cdef public dict _cached_methods cdef _category cdef public _base cdef public _names diff --git a/src/sage/structure/category_object.pyx b/src/sage/structure/category_object.pyx index 3859f24095a..7f84eabd7f1 100644 --- a/src/sage/structure/category_object.pyx +++ b/src/sage/structure/category_object.pyx @@ -113,7 +113,7 @@ cdef class CategoryObject(SageObject): self._init_category_(category) def __cinit__(self): - self.__cached_methods = {} + self._cached_methods = {} self._hash_value = -1 def _init_category_(self, category): @@ -844,7 +844,7 @@ cdef class CategoryObject(SageObject): # Lookup a method or attribute from the category abstract classes. # See __getattr__ above for documentation. try: - return self.__cached_methods[name] + return self._cached_methods[name] except KeyError: if self._category is None: # Usually, this will just raise AttributeError in @@ -854,7 +854,7 @@ cdef class CategoryObject(SageObject): cls = self._category.parent_class attr = getattr_from_other_class(self, cls, name) - self.__cached_methods[name] = attr + self._cached_methods[name] = attr return attr def __dir__(self): diff --git a/src/sage/structure/element.pxd b/src/sage/structure/element.pxd index 79e86d8a5c3..20c556b985e 100644 --- a/src/sage/structure/element.pxd +++ b/src/sage/structure/element.pxd @@ -176,7 +176,7 @@ cdef class Element(SageObject): cdef class ElementWithCachedMethod(Element): - cdef public dict __cached_methods + cdef public dict _cached_methods cdef class ModuleElement(Element) # forward declaration diff --git a/src/sage/structure/element.pyx b/src/sage/structure/element.pyx index ab6ee157a94..71613de7215 100644 --- a/src/sage/structure/element.pyx +++ b/src/sage/structure/element.pyx @@ -2356,18 +2356,18 @@ cdef class ElementWithCachedMethod(Element): True """ try: - return self.__cached_methods[name] + return self._cached_methods[name] except KeyError: attr = getattr_from_other_class(self, self._parent.category().element_class, name) - self.__cached_methods[name] = attr + self._cached_methods[name] = attr return attr except TypeError: attr = getattr_from_other_class(self, self._parent.category().element_class, name) - self.__cached_methods = {name : attr} + self._cached_methods = {name : attr} return attr From f757334dfd333988f52328162958df73c2f3a37c Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:27:05 +0800 Subject: [PATCH 02/54] rename __init_fun -> _init_fun --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 2 +- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index 5edf0844f3e..cc8d0fd2776 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -104,7 +104,7 @@ ctypedef double Double cdef class Lfunction: cdef void *thisptr - cdef void __init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r) + cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r) cdef c_Complex __value(self,c_Complex s,int derivative) cdef c_Complex __hardy_z_function(self,c_Complex s) cdef int __compute_rank(self) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index 6e9005c502b..c7eafd70837 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -99,7 +99,7 @@ cdef class Lfunction: tmpc=CCC(residue[i]) r[i+1] = new_Complex(mpfr_get_d(tmpc.__re, MPFR_RNDN), mpfr_get_d(tmpc.__im, MPFR_RNDN)) - self.__init_fun(NAME, what_type, dirichlet_coefficient, Period, q, w, A, g, l, n_poles, p, r) + self._init_fun(NAME, what_type, dirichlet_coefficient, Period, q, w, A, g, l, n_poles, p, r) if name: name += ': ' @@ -408,7 +408,7 @@ cdef class Lfunction: return returnvalue # Needs to be overriden - cdef void __init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): + cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): raise NotImplementedError cdef c_Complex __value(self,c_Complex s,int derivative): @@ -497,7 +497,7 @@ cdef class Lfunction_I(Lfunction): self._repr += " with integer Dirichlet coefficients" # override - cdef void __init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): + cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): cdef int N = len(dirichlet_coeff) cdef Integer tmpi cdef int * coeffs = new_ints(N+1) #lcalc ignores 0the coefficient @@ -633,7 +633,7 @@ cdef class Lfunction_D(Lfunction): self._repr += " with real Dirichlet coefficients" # override - cdef void __init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): + cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): cdef int i cdef RealNumber tmpr cdef int N = len(dirichlet_coeff) @@ -773,7 +773,7 @@ cdef class Lfunction_C: self._repr += " with complex Dirichlet coefficients" # override - cdef void __init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): + cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): cdef int i cdef int N = len(dirichlet_coeff) cdef ComplexNumber tmpc From 65345ca98f6eb32accd9c3cc8fcc9e6571d118f3 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:27:18 +0800 Subject: [PATCH 03/54] rename __value -> _value --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 2 +- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index cc8d0fd2776..42b8dac62d3 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -105,7 +105,7 @@ ctypedef double Double cdef class Lfunction: cdef void *thisptr cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r) - cdef c_Complex __value(self,c_Complex s,int derivative) + cdef c_Complex _value(self,c_Complex s,int derivative) cdef c_Complex __hardy_z_function(self,c_Complex s) cdef int __compute_rank(self) #strange bug, replacing Double with double gives me a compile error diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index c7eafd70837..976aa891f7d 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -180,7 +180,7 @@ cdef class Lfunction: """ cdef ComplexNumber complexified_s = CCC(s) cdef c_Complex z = new_Complex(mpfr_get_d(complexified_s.__re, MPFR_RNDN), mpfr_get_d(complexified_s.__im, MPFR_RNDN)) - cdef c_Complex result = self.__value(z, derivative) + cdef c_Complex result = self._value(z, derivative) return CCC(result.real(),result.imag()) def hardy_z_function(self, s): @@ -411,7 +411,7 @@ cdef class Lfunction: cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r): raise NotImplementedError - cdef c_Complex __value(self,c_Complex s,int derivative): + cdef c_Complex _value(self,c_Complex s,int derivative): raise NotImplementedError cdef c_Complex __hardy_z_function(self,c_Complex s): @@ -507,7 +507,7 @@ cdef class Lfunction_I(Lfunction): self.thisptr=new_c_Lfunction_I(NAME, what_type, N, coeffs, Period, q, w, A, g, l, n_poles, p, r) del_ints(coeffs) - cdef inline c_Complex __value(self,c_Complex s,int derivative): + cdef inline c_Complex _value(self,c_Complex s,int derivative): return ((self.thisptr)).value(s, derivative, "pure") cdef inline c_Complex __hardy_z_function(self,c_Complex s): @@ -644,7 +644,7 @@ cdef class Lfunction_D(Lfunction): self.thisptr=new_c_Lfunction_D(NAME, what_type, N, coeffs, Period, q, w, A, g, l, n_poles, p, r) del_doubles(coeffs) - cdef inline c_Complex __value(self,c_Complex s,int derivative): + cdef inline c_Complex _value(self,c_Complex s,int derivative): return ((self.thisptr)).value(s, derivative, "pure") @@ -788,7 +788,7 @@ cdef class Lfunction_C: del_Complexes(coeffs) - cdef inline c_Complex __value(self,c_Complex s,int derivative): + cdef inline c_Complex _value(self,c_Complex s,int derivative): return ((self.thisptr)).value(s, derivative, "pure") @@ -873,7 +873,7 @@ cdef class Lfunction_Zeta(Lfunction): self.thisptr = new_c_Lfunction_Zeta() self._repr = "The Riemann zeta function" - cdef inline c_Complex __value(self,c_Complex s,int derivative): + cdef inline c_Complex _value(self,c_Complex s,int derivative): return ((self.thisptr)).value(s, derivative, "pure") From 6ec8415d1a16d24ca5500da8f791af6f35ca6615 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:27:29 +0800 Subject: [PATCH 04/54] rename __hardy_z_function -> _hardy_z_function --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 2 +- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index 42b8dac62d3..5787e5ad2b9 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -106,7 +106,7 @@ cdef class Lfunction: cdef void *thisptr cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r) cdef c_Complex _value(self,c_Complex s,int derivative) - cdef c_Complex __hardy_z_function(self,c_Complex s) + cdef c_Complex _hardy_z_function(self,c_Complex s) cdef int __compute_rank(self) #strange bug, replacing Double with double gives me a compile error cdef Double __typedN(self, double T) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index 976aa891f7d..abc7fa551f0 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -223,7 +223,7 @@ cdef class Lfunction: #This takes s -> .5 + I*s cdef ComplexNumber complexified_s = CCC(0.5)+ CCC(0,1)*CCC(s) cdef c_Complex z = new_Complex(mpfr_get_d(complexified_s.__re, MPFR_RNDN), mpfr_get_d(complexified_s.__im, MPFR_RNDN)) - cdef c_Complex result = self.__hardy_z_function(z) + cdef c_Complex result = self._hardy_z_function(z) return CCC(result.real(),result.imag()) @@ -414,7 +414,7 @@ cdef class Lfunction: cdef c_Complex _value(self,c_Complex s,int derivative): raise NotImplementedError - cdef c_Complex __hardy_z_function(self,c_Complex s): + cdef c_Complex _hardy_z_function(self,c_Complex s): raise NotImplementedError cdef int __compute_rank(self): @@ -510,7 +510,7 @@ cdef class Lfunction_I(Lfunction): cdef inline c_Complex _value(self,c_Complex s,int derivative): return ((self.thisptr)).value(s, derivative, "pure") - cdef inline c_Complex __hardy_z_function(self,c_Complex s): + cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0, "rotated pure") cdef int __compute_rank(self): @@ -648,7 +648,7 @@ cdef class Lfunction_D(Lfunction): return ((self.thisptr)).value(s, derivative, "pure") - cdef inline c_Complex __hardy_z_function(self,c_Complex s): + cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0, "rotated pure") cdef inline int __compute_rank(self): @@ -792,7 +792,7 @@ cdef class Lfunction_C: return ((self.thisptr)).value(s, derivative, "pure") - cdef inline c_Complex __hardy_z_function(self,c_Complex s): + cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0,"rotated pure") cdef inline int __compute_rank(self): @@ -877,7 +877,7 @@ cdef class Lfunction_Zeta(Lfunction): return ((self.thisptr)).value(s, derivative, "pure") - cdef inline c_Complex __hardy_z_function(self,c_Complex s): + cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0, "rotated pure") cdef inline int __compute_rank(self): From 07062aa9a225d0d640af85ed6619a98be61cf005 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:29:01 +0800 Subject: [PATCH 05/54] rename __compute_rank -> _compute_rank --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 2 +- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index 5787e5ad2b9..6ebd111a22b 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -107,7 +107,7 @@ cdef class Lfunction: cdef void _init_fun(self, char *NAME, int what_type, dirichlet_coeff, long long Period, double q, c_Complex w, int A, double *g, c_Complex *l, int n_poles, c_Complex *p, c_Complex *r) cdef c_Complex _value(self,c_Complex s,int derivative) cdef c_Complex _hardy_z_function(self,c_Complex s) - cdef int __compute_rank(self) + cdef int _compute_rank(self) #strange bug, replacing Double with double gives me a compile error cdef Double __typedN(self, double T) cdef void __find_zeros_v(self, double T1, double T2, double stepsize,doublevec *result) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index abc7fa551f0..0ac64002b78 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -249,7 +249,7 @@ cdef class Lfunction: 3 """ - return self.__compute_rank() + return self._compute_rank() def __N(self, T): """ @@ -417,7 +417,7 @@ cdef class Lfunction: cdef c_Complex _hardy_z_function(self,c_Complex s): raise NotImplementedError - cdef int __compute_rank(self): + cdef int _compute_rank(self): raise NotImplementedError cdef double __typedN(self,double T): @@ -513,7 +513,7 @@ cdef class Lfunction_I(Lfunction): cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0, "rotated pure") - cdef int __compute_rank(self): + cdef int _compute_rank(self): return ((self.thisptr)).compute_rank() cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): @@ -651,7 +651,7 @@ cdef class Lfunction_D(Lfunction): cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0, "rotated pure") - cdef inline int __compute_rank(self): + cdef inline int _compute_rank(self): return ((self.thisptr)).compute_rank() cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): @@ -795,7 +795,7 @@ cdef class Lfunction_C: cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0,"rotated pure") - cdef inline int __compute_rank(self): + cdef inline int _compute_rank(self): return ((self.thisptr)).compute_rank() @@ -880,7 +880,7 @@ cdef class Lfunction_Zeta(Lfunction): cdef inline c_Complex _hardy_z_function(self,c_Complex s): return ((self.thisptr)).value(s, 0, "rotated pure") - cdef inline int __compute_rank(self): + cdef inline int _compute_rank(self): return ((self.thisptr)).compute_rank() From 7c7eab445c8e2495e1e20fd43402478953976787 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:29:31 +0800 Subject: [PATCH 06/54] rename __typedN -> _typedN --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 4 ++-- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index 6ebd111a22b..72067d424b2 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -99,7 +99,7 @@ cdef extern from "lcalc_sage.h": ################ # strange bug, I can't compile without this trick ??? -# it's only used in __typedN +# it's only used in _typedN ctypedef double Double cdef class Lfunction: @@ -109,7 +109,7 @@ cdef class Lfunction: cdef c_Complex _hardy_z_function(self,c_Complex s) cdef int _compute_rank(self) #strange bug, replacing Double with double gives me a compile error - cdef Double __typedN(self, double T) + cdef Double _typedN(self, double T) cdef void __find_zeros_v(self, double T1, double T2, double stepsize,doublevec *result) cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec* result) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index 0ac64002b78..cd277154773 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -267,7 +267,7 @@ cdef class Lfunction: """ cdef RealNumber real_T=RRR(T) cdef double double_T = mpfr_get_d(real_T.value, MPFR_RNDN) - cdef double res_d = self.__typedN(double_T) + cdef double res_d = self._typedN(double_T) return RRR(res_d) def find_zeros(self, T1, T2, stepsize): @@ -420,7 +420,7 @@ cdef class Lfunction: cdef int _compute_rank(self): raise NotImplementedError - cdef double __typedN(self,double T): + cdef double _typedN(self,double T): raise NotImplementedError cdef void __find_zeros_v(self,double T1, double T2, double stepsize, doublevec *result): @@ -519,7 +519,7 @@ cdef class Lfunction_I(Lfunction): cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) - cdef double __typedN(self, double T): + cdef double _typedN(self, double T): return (self.thisptr).N(T) cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): @@ -657,7 +657,7 @@ cdef class Lfunction_D(Lfunction): cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) - cdef double __typedN(self, double T): + cdef double _typedN(self, double T): return (self.thisptr).N(T) cdef int __find_zeros(self, long count, long start,double max_refine, int rank, const char* message_stamp, doublevec *result): @@ -802,7 +802,7 @@ cdef class Lfunction_C: cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) - cdef double __typedN(self, double T): + cdef double _typedN(self, double T): return (self.thisptr).N(T) cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): @@ -887,7 +887,7 @@ cdef class Lfunction_Zeta(Lfunction): cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) - cdef double __typedN(self, double T): + cdef double _typedN(self, double T): return (self.thisptr).N(T) cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): From 1f0654f1ff44e0fe77a6c7d828d77506eb89477d Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:29:49 +0800 Subject: [PATCH 07/54] rename __find_zeros_v -> _find_zeros_v --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 2 +- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index 72067d424b2..f514eaee507 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -110,7 +110,7 @@ cdef class Lfunction: cdef int _compute_rank(self) #strange bug, replacing Double with double gives me a compile error cdef Double _typedN(self, double T) - cdef void __find_zeros_v(self, double T1, double T2, double stepsize,doublevec *result) + cdef void _find_zeros_v(self, double T1, double T2, double stepsize,doublevec *result) cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec* result) cdef str _repr diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index cd277154773..46cb9622482 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -323,7 +323,7 @@ cdef class Lfunction: cdef RealNumber real_T2 = RRR(T2) cdef RealNumber real_stepsize = RRR(stepsize) sig_on() - self.__find_zeros_v( mpfr_get_d(real_T1.value, MPFR_RNDN), mpfr_get_d(real_T2.value, MPFR_RNDN), mpfr_get_d(real_stepsize.value, MPFR_RNDN),&result) + self._find_zeros_v( mpfr_get_d(real_T1.value, MPFR_RNDN), mpfr_get_d(real_T2.value, MPFR_RNDN), mpfr_get_d(real_stepsize.value, MPFR_RNDN),&result) sig_off() i=result.size() returnvalue = [] @@ -423,7 +423,7 @@ cdef class Lfunction: cdef double _typedN(self,double T): raise NotImplementedError - cdef void __find_zeros_v(self,double T1, double T2, double stepsize, doublevec *result): + cdef void _find_zeros_v(self,double T1, double T2, double stepsize, doublevec *result): raise NotImplementedError cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): @@ -516,7 +516,7 @@ cdef class Lfunction_I(Lfunction): cdef int _compute_rank(self): return ((self.thisptr)).compute_rank() - cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): + cdef void _find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) cdef double _typedN(self, double T): @@ -654,7 +654,7 @@ cdef class Lfunction_D(Lfunction): cdef inline int _compute_rank(self): return ((self.thisptr)).compute_rank() - cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): + cdef void _find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) cdef double _typedN(self, double T): @@ -799,7 +799,7 @@ cdef class Lfunction_C: return ((self.thisptr)).compute_rank() - cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): + cdef void _find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) cdef double _typedN(self, double T): @@ -884,7 +884,7 @@ cdef class Lfunction_Zeta(Lfunction): return ((self.thisptr)).compute_rank() - cdef void __find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): + cdef void _find_zeros_v(self, double T1, double T2, double stepsize, doublevec *result): (self.thisptr).find_zeros_v(T1,T2,stepsize,result[0]) cdef double _typedN(self, double T): From 88823c65a11877e778c759802ba2574495510114 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:30:01 +0800 Subject: [PATCH 08/54] rename __find_zeros -> _find_zeros --- src/sage/libs/lcalc/lcalc_Lfunction.pxd | 2 +- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pxd b/src/sage/libs/lcalc/lcalc_Lfunction.pxd index f514eaee507..1d595180a6f 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pxd +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pxd @@ -111,7 +111,7 @@ cdef class Lfunction: #strange bug, replacing Double with double gives me a compile error cdef Double _typedN(self, double T) cdef void _find_zeros_v(self, double T1, double T2, double stepsize,doublevec *result) - cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec* result) + cdef int _find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec* result) cdef str _repr diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index 46cb9622482..d8b7221fe55 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -399,7 +399,7 @@ cdef class Lfunction: cdef const char* message_stamp = "" cdef doublevec result sig_on() - self.__find_zeros(count, start, max_refine, rank, message_stamp, &result) + self._find_zeros(count, start, max_refine, rank, message_stamp, &result) sig_off() returnvalue = [] for i in range(result.size()): @@ -426,7 +426,7 @@ cdef class Lfunction: cdef void _find_zeros_v(self,double T1, double T2, double stepsize, doublevec *result): raise NotImplementedError - cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): + cdef int _find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): raise NotImplementedError ############################################################################## @@ -522,7 +522,7 @@ cdef class Lfunction_I(Lfunction): cdef double _typedN(self, double T): return (self.thisptr).N(T) - cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): + cdef int _find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): (self.thisptr).find_zeros(count, start, max_refine, rank, message_stamp, result) # debug tools @@ -660,7 +660,7 @@ cdef class Lfunction_D(Lfunction): cdef double _typedN(self, double T): return (self.thisptr).N(T) - cdef int __find_zeros(self, long count, long start,double max_refine, int rank, const char* message_stamp, doublevec *result): + cdef int _find_zeros(self, long count, long start,double max_refine, int rank, const char* message_stamp, doublevec *result): (self.thisptr).find_zeros(count, start, max_refine, rank, message_stamp, result) # debug tools @@ -805,7 +805,7 @@ cdef class Lfunction_C: cdef double _typedN(self, double T): return (self.thisptr).N(T) - cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): + cdef int _find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): (self.thisptr).find_zeros(count, start, max_refine, rank, message_stamp, result) # debug tools @@ -890,7 +890,7 @@ cdef class Lfunction_Zeta(Lfunction): cdef double _typedN(self, double T): return (self.thisptr).N(T) - cdef int __find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): + cdef int _find_zeros(self, long count, long start, double max_refine, int rank, const char* message_stamp, doublevec *result): (self.thisptr).find_zeros(count, start, max_refine, rank, message_stamp, result) def __dealloc__(self): From bfe42189e78ee5649a00343df8e776e710bebfbe Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:24:36 +0800 Subject: [PATCH 09/54] rename __is_exchange_pair -> _is_exchange_pair --- src/sage/matroids/basis_exchange_matroid.pxd | 2 +- src/sage/matroids/basis_exchange_matroid.pyx | 26 ++++++++++---------- src/sage/matroids/basis_matroid.pyx | 2 +- src/sage/matroids/linear_matroid.pyx | 10 ++++---- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/sage/matroids/basis_exchange_matroid.pxd b/src/sage/matroids/basis_exchange_matroid.pxd index aec3bb54c42..b8207f92156 100644 --- a/src/sage/matroids/basis_exchange_matroid.pxd +++ b/src/sage/matroids/basis_exchange_matroid.pxd @@ -19,7 +19,7 @@ cdef class BasisExchangeMatroid(Matroid): cdef __pack(self, bitset_t, X) cdef __unpack(self, bitset_t) - cdef bint __is_exchange_pair(self, long x, long y) except -1 + cdef bint _is_exchange_pair(self, long x, long y) except -1 cdef int __exchange(self, long x, long y) except -1 cdef int __move(self, bitset_t X, bitset_t Y) except -1 cdef __fundamental_cocircuit(self, bitset_t, long x) diff --git a/src/sage/matroids/basis_exchange_matroid.pyx b/src/sage/matroids/basis_exchange_matroid.pyx index 90d10842d46..00d017d2189 100644 --- a/src/sage/matroids/basis_exchange_matroid.pyx +++ b/src/sage/matroids/basis_exchange_matroid.pyx @@ -57,9 +57,9 @@ cdef class BasisExchangeMatroid(Matroid): This base exchange graph is not stored as such, but should be provided implicitly by the child class in the form of two methods - ``__is_exchange_pair(x, y)`` and ``__exchange(x, y)``, as well as an + ``_is_exchange_pair(x, y)`` and ``__exchange(x, y)``, as well as an initial basis. At any moment, BasisExchangeMatroid keeps a current basis - `B`. The method ``__is_exchange_pair(x, y)`` should return a boolean + `B`. The method ``_is_exchange_pair(x, y)`` should return a boolean indicating whether `B - x + y` is a basis. The method ``__exchange(x, y)`` is called when the current basis `B` is replaced by said `B-x + y`. It is up to the child class to update its internal data structure to make @@ -81,14 +81,14 @@ cdef class BasisExchangeMatroid(Matroid): - :class:`BasisMatroid `: keeps a list of all bases. - - ``__is_exchange_pair(x, y)`` reduces to a query whether `B - x + y` + - ``_is_exchange_pair(x, y)`` reduces to a query whether `B - x + y` is a basis. - ``__exchange(x, y)`` has no work to do. - :class:`LinearMatroid `: keeps a matrix representation `A` of the matroid so that `A[B] = I`. - - ``__is_exchange_pair(x, y)`` reduces to testing whether `A[r, y]` + - ``_is_exchange_pair(x, y)`` reduces to testing whether `A[r, y]` is nonzero, where `A[r, x]=1`. - ``__exchange(x, y)`` should modify the matrix so that `A[B - x + y]` becomes `I`, which means pivoting on `A[r, y]`. @@ -100,7 +100,7 @@ cdef class BasisExchangeMatroid(Matroid): edge `(A_i,e)` if `e` is in the subset `A_i`. At any time you keep a maximum matching `M` of `G` covering the current basis `B`. - - ``__is_exchange_pair(x, y)`` checks for the existence of an + - ``_is_exchange_pair(x, y)`` checks for the existence of an `M`-alternating path `P` from `y` to `x`. - ``__exchange(x, y)`` replaces `M` by the symmetric difference of `M` and `E(P)`. @@ -108,7 +108,7 @@ cdef class BasisExchangeMatroid(Matroid): - ``AlgebraicMatroid`` (not yet implemented): keeps a list of polynomials in variables `E - B + e` for each variable `e` in `B`. - - ``__is_exchange_pair(x, y)`` checks whether the polynomial that + - ``_is_exchange_pair(x, y)`` checks whether the polynomial that relates `y` to `E-B` uses `x`. - ``__exchange(x, y)`` make new list of polynomials by computing resultants. @@ -252,7 +252,7 @@ cdef class BasisExchangeMatroid(Matroid): return frozenset(F) # this method needs to be overridden by child class - cdef bint __is_exchange_pair(self, long x, long y) except -1: + cdef bint _is_exchange_pair(self, long x, long y) except -1: """ Test if current_basis-x + y is a basis """ @@ -275,7 +275,7 @@ cdef class BasisExchangeMatroid(Matroid): while x >= 0: y = bitset_first(Y) while y >= 0: - if self.__is_exchange_pair(x, y): + if self._is_exchange_pair(x, y): self.__exchange(x, y) bitset_discard(Y, y) bitset_discard(X, x) @@ -295,7 +295,7 @@ cdef class BasisExchangeMatroid(Matroid): bitset_complement(self._temp, self._current_basis) y = bitset_first(self._temp) while y >= 0: - if self.__is_exchange_pair(x, y): + if self._is_exchange_pair(x, y): bitset_add(C, y) y = bitset_next(self._temp, y + 1) bitset_add(C, x) @@ -308,7 +308,7 @@ cdef class BasisExchangeMatroid(Matroid): bitset_clear(C) x = bitset_first(self._current_basis) while x >= 0: - if self.__is_exchange_pair(x, y): + if self._is_exchange_pair(x, y): bitset_add(C, x) x = bitset_next(self._current_basis, x + 1) bitset_add(C, y) @@ -335,7 +335,7 @@ cdef class BasisExchangeMatroid(Matroid): while y >= 0: x = bitset_first(self._inside) while x >= 0: - if self.__is_exchange_pair(x, y): + if self._is_exchange_pair(x, y): self.__exchange(x, y) bitset_discard(self._outside, y) bitset_discard(self._inside, x) @@ -387,7 +387,7 @@ cdef class BasisExchangeMatroid(Matroid): while x >= 0: y = bitset_first(self._outside) while y >= 0: - if self.__is_exchange_pair(x, y): + if self._is_exchange_pair(x, y): self.__exchange(x, y) bitset_discard(self._outside, y) bitset_discard(self._inside, x) @@ -2409,7 +2409,7 @@ cdef class BasisExchangeMatroid(Matroid): foundpair = False y = bitset_first(self._input2) while y >= 0: # for y in Y-X - if self.__is_exchange_pair(y, x): + if self._is_exchange_pair(y, x): foundpair = True y = -1 else: diff --git a/src/sage/matroids/basis_matroid.pyx b/src/sage/matroids/basis_matroid.pyx index 3ac43112627..c553c302989 100644 --- a/src/sage/matroids/basis_matroid.pyx +++ b/src/sage/matroids/basis_matroid.pyx @@ -263,7 +263,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): # support for parent BasisExchangeMatroid - cdef bint __is_exchange_pair(self, long x, long y) except -1: # test if current_basis-x + y is a basis + cdef bint _is_exchange_pair(self, long x, long y) except -1: # test if current_basis-x + y is a basis """ Test if `B-e + f` is a basis of the current matroid. diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index 61452e80c48..c5a6b21204b 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -391,7 +391,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): """ return characteristic(self._A) - cdef bint __is_exchange_pair(self, long x, long y) except -1: + cdef bint _is_exchange_pair(self, long x, long y) except -1: r""" Check if ``self.basis() - x + y`` is again a basis. Internal method. """ @@ -3152,7 +3152,7 @@ cdef class BinaryMatroid(LinearMatroid): """ return 2 - cdef bint __is_exchange_pair(self, long x, long y) except -1: + cdef bint _is_exchange_pair(self, long x, long y) except -1: r""" Check if ``self.basis() - x + y`` is again a basis. Internal method. """ @@ -4220,7 +4220,7 @@ cdef class TernaryMatroid(LinearMatroid): """ return 3 - cdef bint __is_exchange_pair(self, long x, long y) except -1: + cdef bint _is_exchange_pair(self, long x, long y) except -1: r""" Check if ``self.basis() - x + y`` is again a basis. Internal method. """ @@ -5122,7 +5122,7 @@ cdef class QuaternaryMatroid(LinearMatroid): """ return 2 - cdef bint __is_exchange_pair(self, long x, long y) except -1: + cdef bint _is_exchange_pair(self, long x, long y) except -1: r""" Check if ``self.basis() - x + y`` is again a basis. Internal method. """ @@ -5838,7 +5838,7 @@ cdef class RegularMatroid(LinearMatroid): """ return 0 - cdef bint __is_exchange_pair(self, long x, long y) except -1: + cdef bint _is_exchange_pair(self, long x, long y) except -1: r""" Check if ``self.basis() - x + y`` is again a basis. Internal method. """ From c8fded58e4c954f0faa8c49dcd8555ac114f4dd4 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:24:58 +0800 Subject: [PATCH 10/54] rename __exchange -> _exchange --- src/sage/matroids/basis_exchange_matroid.pxd | 2 +- src/sage/matroids/basis_exchange_matroid.pyx | 20 ++++++++++---------- src/sage/matroids/linear_matroid.pyx | 20 ++++++++++---------- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/src/sage/matroids/basis_exchange_matroid.pxd b/src/sage/matroids/basis_exchange_matroid.pxd index b8207f92156..daddb350d69 100644 --- a/src/sage/matroids/basis_exchange_matroid.pxd +++ b/src/sage/matroids/basis_exchange_matroid.pxd @@ -20,7 +20,7 @@ cdef class BasisExchangeMatroid(Matroid): cdef __pack(self, bitset_t, X) cdef __unpack(self, bitset_t) cdef bint _is_exchange_pair(self, long x, long y) except -1 - cdef int __exchange(self, long x, long y) except -1 + cdef int _exchange(self, long x, long y) except -1 cdef int __move(self, bitset_t X, bitset_t Y) except -1 cdef __fundamental_cocircuit(self, bitset_t, long x) cdef __fundamental_circuit(self, bitset_t, long y) diff --git a/src/sage/matroids/basis_exchange_matroid.pyx b/src/sage/matroids/basis_exchange_matroid.pyx index 00d017d2189..ab105ddef2f 100644 --- a/src/sage/matroids/basis_exchange_matroid.pyx +++ b/src/sage/matroids/basis_exchange_matroid.pyx @@ -57,10 +57,10 @@ cdef class BasisExchangeMatroid(Matroid): This base exchange graph is not stored as such, but should be provided implicitly by the child class in the form of two methods - ``_is_exchange_pair(x, y)`` and ``__exchange(x, y)``, as well as an + ``_is_exchange_pair(x, y)`` and ``_exchange(x, y)``, as well as an initial basis. At any moment, BasisExchangeMatroid keeps a current basis `B`. The method ``_is_exchange_pair(x, y)`` should return a boolean - indicating whether `B - x + y` is a basis. The method ``__exchange(x, y)`` + indicating whether `B - x + y` is a basis. The method ``_exchange(x, y)`` is called when the current basis `B` is replaced by said `B-x + y`. It is up to the child class to update its internal data structure to make information relative to the new basis more accessible. For instance, a @@ -83,14 +83,14 @@ cdef class BasisExchangeMatroid(Matroid): - ``_is_exchange_pair(x, y)`` reduces to a query whether `B - x + y` is a basis. - - ``__exchange(x, y)`` has no work to do. + - ``_exchange(x, y)`` has no work to do. - :class:`LinearMatroid `: keeps a matrix representation `A` of the matroid so that `A[B] = I`. - ``_is_exchange_pair(x, y)`` reduces to testing whether `A[r, y]` is nonzero, where `A[r, x]=1`. - - ``__exchange(x, y)`` should modify the matrix so that `A[B - x + y]` + - ``_exchange(x, y)`` should modify the matrix so that `A[B - x + y]` becomes `I`, which means pivoting on `A[r, y]`. - ``TransversalMatroid`` (not yet implemented): If `A` is a set of subsets @@ -102,7 +102,7 @@ cdef class BasisExchangeMatroid(Matroid): - ``_is_exchange_pair(x, y)`` checks for the existence of an `M`-alternating path `P` from `y` to `x`. - - ``__exchange(x, y)`` replaces `M` by the symmetric difference of + - ``_exchange(x, y)`` replaces `M` by the symmetric difference of `M` and `E(P)`. - ``AlgebraicMatroid`` (not yet implemented): keeps a list of polynomials @@ -110,7 +110,7 @@ cdef class BasisExchangeMatroid(Matroid): - ``_is_exchange_pair(x, y)`` checks whether the polynomial that relates `y` to `E-B` uses `x`. - - ``__exchange(x, y)`` make new list of polynomials by computing + - ``_exchange(x, y)`` make new list of polynomials by computing resultants. All but the first of the above matroids are algebraic, and all @@ -259,7 +259,7 @@ cdef class BasisExchangeMatroid(Matroid): raise NotImplementedError # if this method is overridden by a child class, the child class needs to call this method - cdef int __exchange(self, long x, long y) except -1: + cdef int _exchange(self, long x, long y) except -1: """ put current_basis <-- current_basis-x + y """ @@ -276,7 +276,7 @@ cdef class BasisExchangeMatroid(Matroid): y = bitset_first(Y) while y >= 0: if self._is_exchange_pair(x, y): - self.__exchange(x, y) + self._exchange(x, y) bitset_discard(Y, y) bitset_discard(X, x) if bitset_isempty(Y): @@ -336,7 +336,7 @@ cdef class BasisExchangeMatroid(Matroid): x = bitset_first(self._inside) while x >= 0: if self._is_exchange_pair(x, y): - self.__exchange(x, y) + self._exchange(x, y) bitset_discard(self._outside, y) bitset_discard(self._inside, x) if bitset_isempty(self._outside): @@ -388,7 +388,7 @@ cdef class BasisExchangeMatroid(Matroid): y = bitset_first(self._outside) while y >= 0: if self._is_exchange_pair(x, y): - self.__exchange(x, y) + self._exchange(x, y) bitset_discard(self._outside, y) bitset_discard(self._inside, x) if bitset_isempty(self._inside): diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index c5a6b21204b..4493a1de7d9 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -397,7 +397,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): """ return self._A.is_nonzero(self._prow[x], self._prow[y]) - cdef int __exchange(self, long x, long y) except -1: + cdef int _exchange(self, long x, long y) except -1: """ Put element indexed by ``x`` into basis, taking out element ``y``. Assumptions are that this is a valid basis exchange. @@ -420,7 +420,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): self._A.set_unsafe(px, py, pivi) self._prow[y] = px self._prow[x] = py - BasisExchangeMatroid.__exchange(self, x, y) + BasisExchangeMatroid._exchange(self, x, y) cdef __exchange_value(self, long x, long y): r""" @@ -3158,14 +3158,14 @@ cdef class BinaryMatroid(LinearMatroid): """ return (self._A).is_nonzero(self._prow[x], y) - cdef int __exchange(self, long x, long y) except -1: + cdef int _exchange(self, long x, long y) except -1: r""" Replace ``self.basis() with ``self.basis() - x + y``. Internal method, does no checks. """ cdef long p = self._prow[x] self._A.pivot(p, y) # Not a Sage matrix operation self._prow[y] = p - BasisExchangeMatroid.__exchange(self, x, y) + BasisExchangeMatroid._exchange(self, x, y) cdef __fundamental_cocircuit(self, bitset_t C, long x): r""" @@ -4226,14 +4226,14 @@ cdef class TernaryMatroid(LinearMatroid): """ return (self._A).is_nonzero(self._prow[x], y) - cdef int __exchange(self, long x, long y) except -1: + cdef int _exchange(self, long x, long y) except -1: r""" Replace ``self.basis() with ``self.basis() - x + y``. Internal method, does no checks. """ cdef long p = self._prow[x] self._A.pivot(p, y) # Not a Sage matrix operation self._prow[y] = p - BasisExchangeMatroid.__exchange(self, x, y) + BasisExchangeMatroid._exchange(self, x, y) cdef __fundamental_cocircuit(self, bitset_t C, long x): r""" @@ -5128,14 +5128,14 @@ cdef class QuaternaryMatroid(LinearMatroid): """ return (self._A).is_nonzero(self._prow[x], y) - cdef int __exchange(self, long x, long y) except -1: + cdef int _exchange(self, long x, long y) except -1: r""" Replace ``self.basis() with ``self.basis() - x + y``. Internal method, does no checks. """ cdef long p = self._prow[x] self._A.pivot(p, y) # Not a Sage matrix operation self._prow[y] = p - BasisExchangeMatroid.__exchange(self, x, y) + BasisExchangeMatroid._exchange(self, x, y) cdef __fundamental_cocircuit(self, bitset_t C, long x): r""" @@ -5844,7 +5844,7 @@ cdef class RegularMatroid(LinearMatroid): """ return (self._A).is_nonzero(self._prow[x], self._prow[y]) - cdef int __exchange(self, long x, long y) except -1: + cdef int _exchange(self, long x, long y) except -1: """ Put element indexed by ``x`` into basis, taking out element ``y``. Assumptions are that this is a valid basis exchange. @@ -5867,7 +5867,7 @@ cdef class RegularMatroid(LinearMatroid): (self._A).set(px, py, pivi) # Not a Sage matrix operation self._prow[y] = px self._prow[x] = py - BasisExchangeMatroid.__exchange(self, x, y) + BasisExchangeMatroid._exchange(self, x, y) cdef __exchange_value(self, long x, long y): r""" From 49a6a8f88913661a387ffc636e30b4f7addaf639 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:25:28 +0800 Subject: [PATCH 11/54] rename __exchange_value -> _exchange_value_internal --- src/sage/matroids/linear_matroid.pxd | 2 +- src/sage/matroids/linear_matroid.pyx | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/sage/matroids/linear_matroid.pxd b/src/sage/matroids/linear_matroid.pxd index 014c8aef57d..9aebd446b68 100644 --- a/src/sage/matroids/linear_matroid.pxd +++ b/src/sage/matroids/linear_matroid.pxd @@ -15,7 +15,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): cpdef characteristic(self) cdef list _setup_internal_representation(self, matrix, reduced_matrix, ring, keep_initial_representation) - cdef __exchange_value(self, long x, long y) + cdef _exchange_value_internal(self, long x, long y) cpdef representation(self, B=*, reduced=*, labels=*, order=*, lift_map=*) cpdef _current_rows_cols(self, B=*) diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index 4493a1de7d9..f43b5d5736a 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -422,7 +422,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): self._prow[x] = py BasisExchangeMatroid._exchange(self, x, y) - cdef __exchange_value(self, long x, long y): + cdef _exchange_value_internal(self, long x, long y): r""" Return the (x, y) entry of the current representation. """ @@ -1493,7 +1493,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): sage: M._exchange_value(1, 3) 4 """ - return self.__exchange_value(self._idx[e], self._idx[f]) + return self._exchange_value_internal(self._idx[e], self._idx[f]) cpdef fundamental_cycle(self, B, e): """ @@ -3196,7 +3196,7 @@ cdef class BinaryMatroid(LinearMatroid): bitset_add(R, y) y = bitset_next(self._inside, y + 1) - cdef __exchange_value(self, long x, long y): + cdef _exchange_value_internal(self, long x, long y): r""" Return the (x, y) entry of the current representation. """ @@ -4264,7 +4264,7 @@ cdef class TernaryMatroid(LinearMatroid): bitset_add(R, y) y = bitset_next(self._inside, y + 1) - cdef __exchange_value(self, long x, long y): + cdef _exchange_value_internal(self, long x, long y): r""" Return the (x, y) entry of the current representation. """ @@ -5166,7 +5166,7 @@ cdef class QuaternaryMatroid(LinearMatroid): bitset_add(R, y) y = bitset_next(self._inside, y + 1) - cdef __exchange_value(self, long x, long y): + cdef _exchange_value_internal(self, long x, long y): r""" Return the (x, y) entry of the current representation. """ @@ -5869,7 +5869,7 @@ cdef class RegularMatroid(LinearMatroid): self._prow[x] = py BasisExchangeMatroid._exchange(self, x, y) - cdef __exchange_value(self, long x, long y): + cdef _exchange_value_internal(self, long x, long y): r""" Return the (x, y) entry of the current representation. From 8f9f7c051a280bac80a81425a83f5be42a499186 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:31:01 +0800 Subject: [PATCH 12/54] rename __coclosure -> _coclosure_internal --- src/sage/matroids/basis_exchange_matroid.pxd | 2 +- src/sage/matroids/basis_exchange_matroid.pyx | 8 ++++---- src/sage/matroids/linear_matroid.pyx | 12 ++++++------ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/sage/matroids/basis_exchange_matroid.pxd b/src/sage/matroids/basis_exchange_matroid.pxd index daddb350d69..73bdef652e9 100644 --- a/src/sage/matroids/basis_exchange_matroid.pxd +++ b/src/sage/matroids/basis_exchange_matroid.pxd @@ -30,7 +30,7 @@ cdef class BasisExchangeMatroid(Matroid): cdef __closure(self, bitset_t, bitset_t) cdef __max_coindependent(self, bitset_t, bitset_t) cdef __cocircuit(self, bitset_t, bitset_t) - cdef __coclosure(self, bitset_t, bitset_t) + cdef _coclosure_internal(self, bitset_t, bitset_t) cdef __augment(self, bitset_t, bitset_t, bitset_t) cdef bint __is_independent(self, bitset_t F) except -1 diff --git a/src/sage/matroids/basis_exchange_matroid.pyx b/src/sage/matroids/basis_exchange_matroid.pyx index ab105ddef2f..f1017950684 100644 --- a/src/sage/matroids/basis_exchange_matroid.pyx +++ b/src/sage/matroids/basis_exchange_matroid.pyx @@ -401,7 +401,7 @@ cdef class BasisExchangeMatroid(Matroid): return x = bitset_next(self._inside, x + 1) - cdef __coclosure(self, bitset_t R, bitset_t F): + cdef _coclosure_internal(self, bitset_t R, bitset_t F): """ Bitpacked version of ``closure``. """ @@ -944,7 +944,7 @@ cdef class BasisExchangeMatroid(Matroid): """ self.__pack(self._input, F) - self.__coclosure(self._output, self._input) + self._coclosure_internal(self._output, self._input) return self.__unpack(self._output) cpdef _augment(self, X, Y): @@ -1421,7 +1421,7 @@ cdef class BasisExchangeMatroid(Matroid): Rcoflats = SetSystem(self._E) i = 0 bitset_clear(todo[0]) - self.__coclosure(coflats[0], todo[0]) + self._coclosure_internal(coflats[0], todo[0]) bitset_complement(todo[0], coflats[0]) self._coflats_rec(Rcoflats, r, coflats, todo, 0, 0) for i in range(r + 1): @@ -1443,7 +1443,7 @@ cdef class BasisExchangeMatroid(Matroid): while e >= 0: bitset_copy(self._input, coflats[i]) bitset_add(self._input, e) - self.__coclosure(coflats[i + 1], self._input) + self._coclosure_internal(coflats[i + 1], self._input) bitset_difference(todo[i], todo[i], coflats[i + 1]) bitset_difference(todo[i + 1], coflats[i + 1], coflats[i]) if bitset_first(todo[i + 1]) == e: diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index f43b5d5736a..08f48484ff1 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -3173,11 +3173,11 @@ cdef class BinaryMatroid(LinearMatroid): """ bitset_copy(C, (self._A)._M[self._prow[x]]) - cdef __coclosure(self, bitset_t R, bitset_t F): + cdef _coclosure_internal(self, bitset_t R, bitset_t F): """ Bitpacked version of ``coclosure``. - This function overrides the internal function BasisExchangeMatroid.__coclosure() of the parent class. + This function overrides the internal function BasisExchangeMatroid._coclosure_internal() of the parent class. The implementation should be more efficient for BinaryMatroid, due to the fact that in this class, __fundamental_cocircuit is much faster than __fundamental_circuit. """ @@ -4241,11 +4241,11 @@ cdef class TernaryMatroid(LinearMatroid): """ bitset_copy(C, (self._A)._M0[self._prow[x]]) - cdef __coclosure(self, bitset_t R, bitset_t F): + cdef _coclosure_internal(self, bitset_t R, bitset_t F): """ Bitpacked version of ``coclosure``. - This function overrides the internal function BasisExchangeMatroid.__coclosure() of the parent class. + This function overrides the internal function BasisExchangeMatroid._coclosure_internal() of the parent class. The implementation should be more efficient for TernaryMatroid, due to the fact that in this class, __fundamental_cocircuit is much faster than __fundamental_circuit. """ @@ -5143,11 +5143,11 @@ cdef class QuaternaryMatroid(LinearMatroid): """ bitset_union(C, (self._A)._M0[self._prow[x]], (self._A)._M1[self._prow[x]]) - cdef __coclosure(self, bitset_t R, bitset_t F): + cdef _coclosure_internal(self, bitset_t R, bitset_t F): """ Bitpacked version of ``coclosure``. - This function overrides the internal function BasisExchangeMatroid.__coclosure() of the parent class. + This function overrides the internal function BasisExchangeMatroid._coclosure_internal() of the parent class. The implementation should be more efficient for QuaternaryMatroid, due to the fact that in this class, __fundamental_cocircuit is much faster than __fundamental_circuit. """ From a91aac3c757a0fb7806a972b561b1f4ed71a4bbe Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 15:40:36 +0800 Subject: [PATCH 13/54] rename __pack -> _pack --- src/sage/matroids/basis_exchange_matroid.pxd | 2 +- src/sage/matroids/basis_exchange_matroid.pyx | 42 ++++++++++---------- src/sage/matroids/basis_matroid.pyx | 6 +-- 3 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/sage/matroids/basis_exchange_matroid.pxd b/src/sage/matroids/basis_exchange_matroid.pxd index 73bdef652e9..cde20c4e20a 100644 --- a/src/sage/matroids/basis_exchange_matroid.pxd +++ b/src/sage/matroids/basis_exchange_matroid.pxd @@ -17,7 +17,7 @@ cdef class BasisExchangeMatroid(Matroid): cdef __relabel(self, l) - cdef __pack(self, bitset_t, X) + cdef _pack(self, bitset_t, X) cdef __unpack(self, bitset_t) cdef bint _is_exchange_pair(self, long x, long y) except -1 cdef int _exchange(self, long x, long y) except -1 diff --git a/src/sage/matroids/basis_exchange_matroid.pyx b/src/sage/matroids/basis_exchange_matroid.pyx index f1017950684..6f1c6feb749 100644 --- a/src/sage/matroids/basis_exchange_matroid.pyx +++ b/src/sage/matroids/basis_exchange_matroid.pyx @@ -139,7 +139,7 @@ cdef class BasisExchangeMatroid(Matroid): This initializer sets up a correspondence between elements of ``groundset`` and ``range(len(groundset))``. ``BasisExchangeMatroid`` uses this correspondence for encoding of subsets of the groundset as - bitpacked sets of integers --- see ``__pack()`` and ``__unpack()``. In + bitpacked sets of integers --- see ``_pack()`` and ``__unpack()``. In general, methods of ``BasisExchangeMatroid`` having a name starting with two underscores deal with such encoded subsets. @@ -180,7 +180,7 @@ cdef class BasisExchangeMatroid(Matroid): self._idx[self._E[i]] = i if basis is not None: - self.__pack(self._current_basis, frozenset(basis)) + self._pack(self._current_basis, frozenset(basis)) def __dealloc__(self): bitset_free(self._current_basis) @@ -231,7 +231,7 @@ cdef class BasisExchangeMatroid(Matroid): self._heuristic_partition_var._relabel(l) # the engine - cdef __pack(self, bitset_t I, F): + cdef _pack(self, bitset_t I, F): """ Encode a subset F of the groundset into a bitpacked set of integers """ @@ -454,7 +454,7 @@ cdef class BasisExchangeMatroid(Matroid): """ Set _current_basis to subset of the groundset ``F``. """ - self.__pack(self._input, F) + self._pack(self._input, F) bitset_difference(self._inside, self._current_basis, self._input) bitset_difference(self._outside, self._input, self._current_basis) self.__move(self._inside, self._outside) @@ -630,8 +630,8 @@ cdef class BasisExchangeMatroid(Matroid): ['b', 'c', 'e', 'f'] """ - self.__pack(self._input, X) - self.__pack(self._input2, Y) + self._pack(self._input, X) + self._pack(self._input2, Y) self.__move_current_basis(self._input, self._input2) cpdef _max_independent(self, F): @@ -661,7 +661,7 @@ cdef class BasisExchangeMatroid(Matroid): see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__max_independent(self._output, self._input) return self.__unpack(self._output) @@ -692,7 +692,7 @@ cdef class BasisExchangeMatroid(Matroid): see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__max_independent(self._output, self._input) return bitset_len(self._output) @@ -729,7 +729,7 @@ cdef class BasisExchangeMatroid(Matroid): the input is indeed a subset of the ground set, see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__circuit(self._output, self._input) return self.__unpack(self._output) @@ -754,7 +754,7 @@ cdef class BasisExchangeMatroid(Matroid): sage: sorted(M._fundamental_circuit('abcd', 'e')) ['a', 'b', 'c', 'e'] """ - self.__pack(self._input, B) + self._pack(self._input, B) bitset_clear(self._input2) self.__move_current_basis(self._input, self._input2) self.__fundamental_circuit(self._output, self._idx[e]) @@ -787,7 +787,7 @@ cdef class BasisExchangeMatroid(Matroid): :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__closure(self._output, self._input) return self.__unpack(self._output) @@ -818,7 +818,7 @@ cdef class BasisExchangeMatroid(Matroid): see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__max_coindependent(self._output, self._input) return self.__unpack(self._output) @@ -848,7 +848,7 @@ cdef class BasisExchangeMatroid(Matroid): input is indeed a subset of the ground set, see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__max_coindependent(self._output, self._input) return bitset_len(self._output) @@ -885,7 +885,7 @@ cdef class BasisExchangeMatroid(Matroid): input is indeed a subset of the ground set, see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self.__cocircuit(self._output, self._input) return self.__unpack(self._output) @@ -910,7 +910,7 @@ cdef class BasisExchangeMatroid(Matroid): sage: sorted(M._fundamental_cocircuit('efgh', 'e')) ['b', 'c', 'd', 'e'] """ - self.__pack(self._input, B) + self._pack(self._input, B) bitset_clear(self._input2) self.__move_current_basis(self._input, self._input2) self.__fundamental_cocircuit(self._output, self._idx[e]) @@ -943,7 +943,7 @@ cdef class BasisExchangeMatroid(Matroid): see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) self._coclosure_internal(self._output, self._input) return self.__unpack(self._output) @@ -973,8 +973,8 @@ cdef class BasisExchangeMatroid(Matroid): ['e', 'f', 'g'] """ - self.__pack(self._input, X) - self.__pack(self._input2, Y) + self._pack(self._input, X) + self._pack(self._input2, Y) self.__augment(self._output, self._input, self._input2) return self.__unpack(self._output) @@ -1006,7 +1006,7 @@ cdef class BasisExchangeMatroid(Matroid): the input is indeed a subset of the ground set, see :meth:``. """ - self.__pack(self._input, F) + self._pack(self._input, F) return self.__is_independent(self._input) # connectivity @@ -1142,8 +1142,8 @@ cdef class BasisExchangeMatroid(Matroid): cdef bitset_t SS, TT bitset_init(SS, self._groundset_size) bitset_init(TT, self._groundset_size) - self.__pack(SS,S) - self.__pack(TT,T) + self._pack(SS,S) + self._pack(TT,T) #F = set(self.groundset()) - (S | T) cdef bitset_t F, I bitset_init(F, self._groundset_size) diff --git a/src/sage/matroids/basis_matroid.pyx b/src/sage/matroids/basis_matroid.pyx index c553c302989..1cb721af21f 100644 --- a/src/sage/matroids/basis_matroid.pyx +++ b/src/sage/matroids/basis_matroid.pyx @@ -219,7 +219,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): raise ValueError("basis has wrong cardinality.") if not b.issubset(self._groundset): raise ValueError("basis is not a subset of the groundset") - self.__pack(self._b, b) + self._pack(self._b, b) i = set_to_index(self._b) if not bitset_in(self._bb, i): self._bcount += 1 @@ -234,7 +234,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): raise ValueError("nonbasis has wrong cardinality") if not b.issubset(self._groundset): raise ValueError("nonbasis is not a subset of the groundset") - self.__pack(self._b, b) + self._pack(self._b, b) i = set_to_index(self._b) if bitset_in(self._bb, i): self._bcount -= 1 @@ -326,7 +326,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): sage: M._is_basis(set(['a', 'b', 'c', 'd'])) False """ - self.__pack(self._b, X) + self._pack(self._b, X) return bitset_in(self._bb, set_to_index(self._b)) # dual and minors From 573d08573cbb384000cfbe6d15d4260a8857f5c4 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 15:41:02 +0800 Subject: [PATCH 14/54] rename __move -> _move --- src/sage/matroids/basis_exchange_matroid.pxd | 2 +- src/sage/matroids/basis_exchange_matroid.pyx | 24 ++++++++++---------- src/sage/matroids/linear_matroid.pyx | 6 ++--- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/sage/matroids/basis_exchange_matroid.pxd b/src/sage/matroids/basis_exchange_matroid.pxd index cde20c4e20a..d2d8e91aab7 100644 --- a/src/sage/matroids/basis_exchange_matroid.pxd +++ b/src/sage/matroids/basis_exchange_matroid.pxd @@ -21,7 +21,7 @@ cdef class BasisExchangeMatroid(Matroid): cdef __unpack(self, bitset_t) cdef bint _is_exchange_pair(self, long x, long y) except -1 cdef int _exchange(self, long x, long y) except -1 - cdef int __move(self, bitset_t X, bitset_t Y) except -1 + cdef int _move(self, bitset_t X, bitset_t Y) except -1 cdef __fundamental_cocircuit(self, bitset_t, long x) cdef __fundamental_circuit(self, bitset_t, long y) diff --git a/src/sage/matroids/basis_exchange_matroid.pyx b/src/sage/matroids/basis_exchange_matroid.pyx index 6f1c6feb749..26b8eedefb5 100644 --- a/src/sage/matroids/basis_exchange_matroid.pyx +++ b/src/sage/matroids/basis_exchange_matroid.pyx @@ -266,7 +266,7 @@ cdef class BasisExchangeMatroid(Matroid): bitset_discard(self._current_basis, x) bitset_add(self._current_basis, y) - cdef int __move(self, bitset_t X, bitset_t Y) except -1: + cdef int _move(self, bitset_t X, bitset_t Y) except -1: """ Change current_basis to minimize intersection with ``X``, maximize intersection with ``Y``. """ @@ -319,7 +319,7 @@ cdef class BasisExchangeMatroid(Matroid): """ bitset_difference(self._inside, self._current_basis, F) bitset_difference(self._outside, F, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_intersection(R, self._current_basis, F) cdef __circuit(self, bitset_t R, bitset_t F): @@ -355,7 +355,7 @@ cdef class BasisExchangeMatroid(Matroid): """ bitset_difference(self._inside, self._current_basis, F) bitset_difference(self._outside, F, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_set_first_n(R, self._groundset_size) cdef long x = bitset_first(self._inside) while x >= 0: @@ -370,7 +370,7 @@ cdef class BasisExchangeMatroid(Matroid): bitset_complement(R, F) bitset_difference(self._inside, self._current_basis, R) bitset_difference(self._outside, R, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_difference(R, F, self._current_basis) cdef __cocircuit(self, bitset_t R, bitset_t F): @@ -408,7 +408,7 @@ cdef class BasisExchangeMatroid(Matroid): bitset_complement(R, F) bitset_difference(self._inside, self._current_basis, R) bitset_difference(self._outside, R, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_set_first_n(R, self._groundset_size) cdef long y = bitset_first(self._outside) while y >= 0: @@ -422,10 +422,10 @@ cdef class BasisExchangeMatroid(Matroid): """ bitset_difference(self._inside, self._current_basis, X) bitset_difference(self._outside, X, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_difference(self._inside, self._inside, Y) bitset_difference(self._outside, Y, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_intersection(R, self._current_basis, Y) cdef bint __is_independent(self, bitset_t F) except -1: @@ -434,7 +434,7 @@ cdef class BasisExchangeMatroid(Matroid): """ bitset_difference(self._inside, self._current_basis, F) bitset_difference(self._outside, F, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) return bitset_isempty(self._outside) cdef __move_current_basis(self, bitset_t X, bitset_t Y): @@ -443,11 +443,11 @@ cdef class BasisExchangeMatroid(Matroid): """ bitset_difference(self._inside, self._current_basis, X) bitset_difference(self._outside, X, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_intersection(self._inside, self._current_basis, Y) bitset_complement(self._outside, self._current_basis) bitset_difference(self._outside, self._outside, Y) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) # functions for derived classes and for parent class cdef bint _set_current_basis(self, F): @@ -457,7 +457,7 @@ cdef class BasisExchangeMatroid(Matroid): self._pack(self._input, F) bitset_difference(self._inside, self._current_basis, self._input) bitset_difference(self._outside, self._input, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) return bitset_isempty(self._outside) and bitset_isempty(self._inside) # groundset and full_rank @@ -2397,7 +2397,7 @@ cdef class BasisExchangeMatroid(Matroid): # Set current basis to Y bitset_difference(self._inside, self._current_basis, BB._subsets[pointerY]) bitset_difference(self._outside, BB._subsets[pointerY], self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) if not bitset_eq(self._current_basis, BB._subsets[pointerY]): # We failed to set the current basis to Y through basis exchanges. # Therefore, the exchange axioms are violated! diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index 08f48484ff1..31df805813d 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -3184,7 +3184,7 @@ cdef class BinaryMatroid(LinearMatroid): bitset_complement(R, F) bitset_difference(self._inside, self._current_basis, R) bitset_difference(self._outside, R, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_copy(R, F) bitset_difference(self._inside, self._current_basis, F) @@ -4252,7 +4252,7 @@ cdef class TernaryMatroid(LinearMatroid): bitset_complement(R, F) bitset_difference(self._inside, self._current_basis, R) bitset_difference(self._outside, R, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_copy(R, F) bitset_difference(self._inside, self._current_basis, F) @@ -5154,7 +5154,7 @@ cdef class QuaternaryMatroid(LinearMatroid): bitset_complement(R, F) bitset_difference(self._inside, self._current_basis, R) bitset_difference(self._outside, R, self._current_basis) - self.__move(self._inside, self._outside) + self._move(self._inside, self._outside) bitset_copy(R, F) bitset_difference(self._inside, self._current_basis, F) From 7c56ec56897f50c7fefa9a7d9071eab7cc9f05f5 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:34:59 +0800 Subject: [PATCH 15/54] rename __modulus -> _modulus --- src/sage/libs/ntl/ntl_lzz_p.pyx | 6 +- src/sage/libs/ntl/ntl_lzz_pX.pyx | 6 +- src/sage/rings/finite_rings/integer_mod.pxd | 2 +- src/sage/rings/finite_rings/integer_mod.pyx | 208 ++++++++++---------- src/sage/rings/fraction_field_FpT.pyx | 2 +- 5 files changed, 112 insertions(+), 112 deletions(-) diff --git a/src/sage/libs/ntl/ntl_lzz_p.pyx b/src/sage/libs/ntl/ntl_lzz_p.pyx index 161d0782bc2..af86b9bcf69 100644 --- a/src/sage/libs/ntl/ntl_lzz_p.pyx +++ b/src/sage/libs/ntl/ntl_lzz_p.pyx @@ -89,19 +89,19 @@ cdef class ntl_zz_p(): #self.c.restore_c() ## This was done in __new__ if isinstance(a, IntegerMod_int): - if (self.c.p == (a).__modulus.int32): ## this is slow + if (self.c.p == (a)._modulus.int32): ## this is slow self.x = (a).ivalue else: raise ValueError("Mismatched modulus for converting to zz_p.") elif isinstance(a, IntegerMod_int64): - if (self.c.p == (a).__modulus.int64): ## this is slow + if (self.c.p == (a)._modulus.int64): ## this is slow self.x = (a).ivalue else: raise ValueError("Mismatched modulus for converting to zz_p.") elif isinstance(a, IntegerMod_gmp): - if (p_sage == (a).__modulus.sageInteger): ## this is slow + if (p_sage == (a)._modulus.sageInteger): ## this is slow self.x = mpz_get_si((a).value) else: raise ValueError("Mismatched modulus for converting to zz_p.") diff --git a/src/sage/libs/ntl/ntl_lzz_pX.pyx b/src/sage/libs/ntl/ntl_lzz_pX.pyx index 24b503a9a62..7d19cc55e37 100644 --- a/src/sage/libs/ntl/ntl_lzz_pX.pyx +++ b/src/sage/libs/ntl/ntl_lzz_pX.pyx @@ -108,17 +108,17 @@ cdef class ntl_zz_pX(): a = ls[i] if isinstance(a, IntegerMod_int): - if (self.c.p == (a).__modulus.int32): ## this is slow + if (self.c.p == (a)._modulus.int32): ## this is slow zz_pX_SetCoeff_long(self.x, i, (a).ivalue) else: raise ValueError("Mismatched modulus for converting to zz_pX.") elif isinstance(a, IntegerMod_int64): - if (self.c.p == (a).__modulus.int64): ## this is slow + if (self.c.p == (a)._modulus.int64): ## this is slow zz_pX_SetCoeff_long(self.x, i, (a).ivalue) else: raise ValueError("Mismatched modulus for converting to zz_pX.") elif isinstance(a, IntegerMod_gmp): - if (p_sage == (a).__modulus.sageInteger): ## this is slow + if (p_sage == (a)._modulus.sageInteger): ## this is slow zz_pX_SetCoeff_long(self.x, i, mpz_get_si((a).value)) else: raise ValueError("Mismatched modulus for converting to zz_pX.") diff --git a/src/sage/rings/finite_rings/integer_mod.pxd b/src/sage/rings/finite_rings/integer_mod.pxd index 1e3cb81c148..351ffa25e1b 100644 --- a/src/sage/rings/finite_rings/integer_mod.pxd +++ b/src/sage/rings/finite_rings/integer_mod.pxd @@ -20,7 +20,7 @@ cdef class NativeIntStruct: cdef class IntegerMod_abstract(FiniteRingElement): - cdef NativeIntStruct __modulus + cdef NativeIntStruct _modulus cdef _new_c_from_long(self, long value) cdef IntegerMod_abstract _new_c_fast(self, unsigned long value) cdef void set_from_mpz(self, mpz_t value) diff --git a/src/sage/rings/finite_rings/integer_mod.pyx b/src/sage/rings/finite_rings/integer_mod.pyx index b9461bd362e..9dba0a06c71 100644 --- a/src/sage/rings/finite_rings/integer_mod.pyx +++ b/src/sage/rings/finite_rings/integer_mod.pyx @@ -361,7 +361,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): ZeroDivisionError: inverse of Mod(4, 30) does not exist """ self._parent = parent - self.__modulus = parent._pyx_order + self._modulus = parent._pyx_order if value is None: return @@ -373,7 +373,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): if isinstance(value, Integer): z = value elif isinstance(value, rational.Rational): - z = value % self.__modulus.sageInteger + z = value % self._modulus.sageInteger elif integer_check_long_py(value, &longval, &err) and not err: self.set_from_long(longval) return @@ -388,7 +388,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): value = py_scalar_to_element(value) if isinstance(value, Element) and value.parent().is_exact(): value = sage.rings.rational_field.QQ(value) - z = value % self.__modulus.sageInteger + z = value % self._modulus.sageInteger else: raise self.set_from_mpz(z.value) @@ -397,7 +397,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): cdef type t = type(self) x = t.__new__(t) x._parent = self._parent - x.__modulus = self.__modulus + x._modulus = self._modulus x.set_from_ulong_fast(value) return x @@ -405,7 +405,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): cdef type t = type(self) cdef IntegerMod_abstract x = t.__new__(t) x._parent = self._parent - x.__modulus = self.__modulus + x._modulus = self._modulus x.set_from_long(value) return x @@ -529,17 +529,17 @@ cdef class IntegerMod_abstract(FiniteRingElement): """ if self.is_zero(): return True - m = self.__modulus.sageInteger.exact_log(2) + 1 + m = self._modulus.sageInteger.exact_log(2) + 1 return (self**m).is_zero() ################################################################# # Interfaces ################################################################# def _pari_init_(self): - return 'Mod(%s,%s)'%(str(self), self.__modulus.sageInteger) + return 'Mod(%s,%s)'%(str(self), self._modulus.sageInteger) def __pari__(self): - return self.lift().__pari__().Mod(self.__modulus.sageInteger) + return self.lift().__pari__().Mod(self._modulus.sageInteger) def _gap_init_(self): r""" @@ -558,7 +558,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): sage: gap(Mod(4, 48)) ZmodnZObj( 4, 48 ) """ - return '%s*One(ZmodnZ(%s))' % (self, self.__modulus.sageInteger) + return '%s*One(ZmodnZ(%s))' % (self, self._modulus.sageInteger) def _magma_init_(self, magma): """ @@ -869,7 +869,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): sage: Mod(3,17).modulus() 17 """ - return self.__modulus.sageInteger + return self._modulus.sageInteger def charpoly(self, var='x'): """ @@ -1229,7 +1229,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): modulus = R.gen()**2 - R(self) if self._parent.is_field(): from .finite_field_constructor import FiniteField - Q = FiniteField(self.__modulus.sageInteger**2, y, modulus) + Q = FiniteField(self._modulus.sageInteger**2, y, modulus) else: R = self.parent()['x'] Q = R.quotient(modulus, names=(y,)) @@ -1250,7 +1250,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): if all and e > 1 and not self.is_unit(): if self.is_zero(): # All multiples of p^ciel(e/2) vanish - return [self._parent(x) for x in range(0, self.__modulus.sageInteger, p**((e+1)/2))] + return [self._parent(x) for x in range(0, self._modulus.sageInteger, p**((e+1)/2))] else: z = self.lift() val = z.valuation(p)/2 # square => valuation is even @@ -1272,7 +1272,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): p_exp = p**exp w = [self._parent(a.lift() * p_val + b) for a in u.sqrt(all=True) - for b in range(0, self.__modulus.sageInteger, p_exp)] + for b in range(0, self._modulus.sageInteger, p_exp)] if p == 2: w = list(set(w)) w.sort() @@ -1624,7 +1624,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): despite the possibly probabilistic nature of the underlying algorithm. """ - if self.lift() > self.__modulus.sageInteger >> 1: + if self.lift() > self._modulus.sageInteger >> 1: return -self return self @@ -1705,8 +1705,8 @@ cdef class IntegerMod_abstract(FiniteRingElement): cdef int_fast64_t new_modulus if not isinstance(self, IntegerMod_gmp) and not isinstance(other, IntegerMod_gmp): - if other.__modulus.int64 == 1: return self - new_modulus = self.__modulus.int64 * other.__modulus.int64 + if other._modulus.int64 == 1: return self + new_modulus = self._modulus.int64 * other._modulus.int64 if new_modulus < INTEGER_MOD_INT32_LIMIT: return self.__crt(other) @@ -1718,11 +1718,11 @@ cdef class IntegerMod_abstract(FiniteRingElement): return self.__crt(other) if not isinstance(self, IntegerMod_gmp): - if self.__modulus.int64 == 1: return other + if self._modulus.int64 == 1: return other self = IntegerMod_gmp(self._parent, self.lift()) if not isinstance(other, IntegerMod_gmp): - if other.__modulus.int64 == 1: return self + if other._modulus.int64 == 1: return self other = IntegerMod_gmp(other._parent, other.lift()) return self.__crt(other) @@ -1742,7 +1742,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): sage: Integers(90308402384902)(2).additive_order() 45154201192451 """ - n = self.__modulus.sageInteger + n = self._modulus.sageInteger return sage.rings.integer.Integer(n // self.lift().gcd(n)) def is_primitive_root(self): @@ -1856,7 +1856,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): return sage.rings.integer.Integer(self.__pari__().znorder()) except PariError: raise ArithmeticError("multiplicative order of %s not defined since it is not a unit modulo %s"%( - self, self.__modulus.sageInteger)) + self, self._modulus.sageInteger)) def valuation(self, p): """ @@ -1905,7 +1905,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): 2 """ - p=self.__modulus.sageInteger.gcd(p) + p=self._modulus.sageInteger.gcd(p) if p==1: raise ValueError("Valuation with respect to a unit is not defined.") r = 0 @@ -1913,7 +1913,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): while not (self % power): # self % power == 0 r += 1 power *= p - if not power.divides(self.__modulus.sageInteger): + if not power.divides(self._modulus.sageInteger): from sage.rings.infinity import infinity return infinity return r @@ -1980,7 +1980,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): cdef IntegerMod_gmp _new_c(self): cdef IntegerMod_gmp x x = IntegerMod_gmp.__new__(IntegerMod_gmp) - x.__modulus = self.__modulus + x._modulus = self._modulus x._parent = self._parent return x @@ -1989,7 +1989,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): cdef void set_from_mpz(self, mpz_t value): cdef sage.rings.integer.Integer modulus - modulus = self.__modulus.sageInteger + modulus = self._modulus.sageInteger mpz_mod(self.value, value, modulus.value) cdef void set_from_long(self, long value): @@ -2001,7 +2001,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): 1 """ mpz_set_si(self.value, value) - mpz_mod(self.value, self.value, self.__modulus.sageInteger.value) + mpz_mod(self.value, self.value, self._modulus.sageInteger.value) cdef void set_from_ulong_fast(self, unsigned long value): mpz_set_ui(self.value, value) @@ -2071,7 +2071,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): x = self._new_c() if k > 0: mpz_mul_2exp(x.value, self.value, k) - mpz_fdiv_r(x.value, x.value, self.__modulus.sageInteger.value) + mpz_fdiv_r(x.value, x.value, self._modulus.sageInteger.value) else: mpz_fdiv_q_2exp(x.value, self.value, -k) return x @@ -2136,8 +2136,8 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): cdef IntegerMod_gmp lift, x cdef sage.rings.integer.Integer modulus, other_modulus - modulus = self.__modulus.sageInteger - other_modulus = other.__modulus.sageInteger + modulus = self._modulus.sageInteger + other_modulus = other._modulus.sageInteger from .integer_mod_ring import IntegerModRing lift = IntegerMod_gmp(IntegerModRing(modulus*other_modulus)) try: @@ -2188,8 +2188,8 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): cdef IntegerMod_gmp x x = self._new_c() mpz_add(x.value, self.value, (right).value) - if mpz_cmp(x.value, self.__modulus.sageInteger.value) >= 0: - mpz_sub(x.value, x.value, self.__modulus.sageInteger.value) + if mpz_cmp(x.value, self._modulus.sageInteger.value) >= 0: + mpz_sub(x.value, x.value, self._modulus.sageInteger.value) return x cpdef _sub_(self, right): @@ -2204,7 +2204,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): x = self._new_c() mpz_sub(x.value, self.value, (right).value) if mpz_sgn(x.value) == -1: - mpz_add(x.value, x.value, self.__modulus.sageInteger.value) + mpz_add(x.value, x.value, self._modulus.sageInteger.value) return x cpdef _neg_(self): @@ -2220,7 +2220,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): return self cdef IntegerMod_gmp x x = self._new_c() - mpz_sub(x.value, self.__modulus.sageInteger.value, self.value) + mpz_sub(x.value, self._modulus.sageInteger.value, self.value) return x cpdef _mul_(self, right): @@ -2234,7 +2234,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): cdef IntegerMod_gmp x x = self._new_c() mpz_mul(x.value, self.value, (right).value) - mpz_fdiv_r(x.value, x.value, self.__modulus.sageInteger.value) + mpz_fdiv_r(x.value, x.value, self._modulus.sageInteger.value) return x cpdef _div_(self, right): @@ -2310,7 +2310,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): cdef IntegerMod_gmp x = self._new_c() sig_on() try: - mpz_pow_helper(x.value, self.value, exp, self.__modulus.sageInteger.value) + mpz_pow_helper(x.value, self.value, exp, self._modulus.sageInteger.value) finally: sig_off() return x @@ -2331,12 +2331,12 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): ZeroDivisionError: inverse of Mod(2, 10000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000) does not exist """ if self.is_zero(): - raise ZeroDivisionError(f"inverse of Mod(0, {self.__modulus.sageInteger}) does not exist") + raise ZeroDivisionError(f"inverse of Mod(0, {self._modulus.sageInteger}) does not exist") cdef IntegerMod_gmp x x = self._new_c() - if not mpz_invert(x.value, self.value, self.__modulus.sageInteger.value): - raise ZeroDivisionError(f"inverse of Mod({self}, {self.__modulus.sageInteger}) does not exist") + if not mpz_invert(x.value, self.value, self._modulus.sageInteger.value): + raise ZeroDivisionError(f"inverse of Mod({self}, {self._modulus.sageInteger}) does not exist") return x def lift(IntegerMod_gmp self): @@ -2391,10 +2391,10 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): """ cdef IntegerMod_gmp ans = self._new_c() sig_on() - mpz_gcd(ans.value, self.value, self.__modulus.sageInteger.value) + mpz_gcd(ans.value, self.value, self._modulus.sageInteger.value) mpz_gcd(ans.value, ans.value, other.value) sig_off() - if mpz_cmp(ans.value, self.__modulus.sageInteger.value) == 0: + if mpz_cmp(ans.value, self._modulus.sageInteger.value) == 0: # self = other = 0 mpz_set_ui(ans.value, 0) return ans @@ -2422,30 +2422,30 @@ cdef class IntegerMod_int(IntegerMod_abstract): """ cdef IntegerMod_int _new_c(self, int_fast32_t value): - if self.__modulus.table is not None: - return self.__modulus.table[value] + if self._modulus.table is not None: + return self._modulus.table[value] cdef IntegerMod_int x = IntegerMod_int.__new__(IntegerMod_int) x._parent = self._parent - x.__modulus = self.__modulus + x._modulus = self._modulus x.ivalue = value return x cdef void set_from_mpz(self, mpz_t value): - self.ivalue = mpz_fdiv_ui(value, self.__modulus.int32) + self.ivalue = mpz_fdiv_ui(value, self._modulus.int32) cdef void set_from_long(self, long value): - self.ivalue = value % self.__modulus.int32 + self.ivalue = value % self._modulus.int32 if self.ivalue < 0: - self.ivalue += self.__modulus.int32 + self.ivalue += self._modulus.int32 cdef void set_from_ulong_fast(self, unsigned long value): self.ivalue = value cdef void set_from_int(IntegerMod_int self, int_fast32_t ivalue): if ivalue < 0: - self.ivalue = self.__modulus.int32 + (ivalue % self.__modulus.int32) - elif ivalue >= self.__modulus.int32: - self.ivalue = ivalue % self.__modulus.int32 + self.ivalue = self._modulus.int32 + (ivalue % self._modulus.int32) + elif ivalue >= self._modulus.int32: + self.ivalue = ivalue % self._modulus.int32 else: self.ivalue = ivalue @@ -2490,7 +2490,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: Zmod(1).one().is_one() True """ - return self.ivalue == 1 or self.__modulus.int32 == 1 + return self.ivalue == 1 or self._modulus.int32 == 1 def __bool__(IntegerMod_int self): """ @@ -2519,7 +2519,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: a.is_unit() False """ - return gcd_int(self.ivalue, self.__modulus.int32) == 1 + return gcd_int(self.ivalue, self._modulus.int32) == 1 def __crt(IntegerMod_int self, IntegerMod_int other): """ @@ -2543,11 +2543,11 @@ cdef class IntegerMod_int(IntegerMod_abstract): cdef int_fast32_t x from .integer_mod_ring import IntegerModRing - lift = IntegerMod_int(IntegerModRing(self.__modulus.int32 * other.__modulus.int32)) + lift = IntegerMod_int(IntegerModRing(self._modulus.int32 * other._modulus.int32)) try: - x = (other.ivalue - self.ivalue % other.__modulus.int32) * mod_inverse_int(self.__modulus.int32, other.__modulus.int32) - lift.set_from_int( x * self.__modulus.int32 + self.ivalue ) + x = (other.ivalue - self.ivalue % other._modulus.int32) * mod_inverse_int(self._modulus.int32, other._modulus.int32) + lift.set_from_int( x * self._modulus.int32 + self.ivalue ) return lift except ZeroDivisionError: raise ZeroDivisionError("moduli must be coprime") @@ -2586,8 +2586,8 @@ cdef class IntegerMod_int(IntegerMod_abstract): """ cdef int_fast32_t x x = self.ivalue + (right).ivalue - if x >= self.__modulus.int32: - x = x - self.__modulus.int32 + if x >= self._modulus.int32: + x = x - self._modulus.int32 return self._new_c(x) cpdef _sub_(self, right): @@ -2601,7 +2601,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): cdef int_fast32_t x x = self.ivalue - (right).ivalue if x < 0: - x = x + self.__modulus.int32 + x = x + self._modulus.int32 return self._new_c(x) cpdef _neg_(self): @@ -2615,7 +2615,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): """ if self.ivalue == 0: return self - return self._new_c(self.__modulus.int32 - self.ivalue) + return self._new_c(self._modulus.int32 - self.ivalue) cpdef _mul_(self, right): """ @@ -2625,7 +2625,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: R(7) * R(8) 6 """ - return self._new_c((self.ivalue * (right).ivalue) % self.__modulus.int32) + return self._new_c((self.ivalue * (right).ivalue) % self._modulus.int32) cpdef _div_(self, right): """ @@ -2635,16 +2635,16 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: R(2)/3 4 """ - if self.__modulus.inverses is not None: - right_inverse = self.__modulus.inverses[(right).ivalue] + if self._modulus.inverses is not None: + right_inverse = self._modulus.inverses[(right).ivalue] if right_inverse is None: - raise ZeroDivisionError(f"inverse of Mod({right}, {self.__modulus.sageInteger}) does not exist") + raise ZeroDivisionError(f"inverse of Mod({right}, {self._modulus.sageInteger}) does not exist") else: - return self._new_c((self.ivalue * (right_inverse).ivalue) % self.__modulus.int32) + return self._new_c((self.ivalue * (right_inverse).ivalue) % self._modulus.int32) cdef int_fast32_t x - x = self.ivalue * mod_inverse_int((right).ivalue, self.__modulus.int32) - return self._new_c(x% self.__modulus.int32) + x = self.ivalue * mod_inverse_int((right).ivalue, self._modulus.int32) + return self._new_c(x% self._modulus.int32) def __int__(IntegerMod_int self): """ @@ -2739,7 +2739,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): if k == 0: return self elif k > 0: - return self._new_c((self.ivalue << k) % self.__modulus.int32) + return self._new_c((self.ivalue << k) % self._modulus.int32) else: return self._new_c(self.ivalue >> (-k)) @@ -2802,7 +2802,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): sig_on() try: mpz_init(res_mpz) - mpz_pow_helper(res_mpz, (base).value, exp, self.__modulus.sageInteger.value) + mpz_pow_helper(res_mpz, (base).value, exp, self._modulus.sageInteger.value) res = mpz_get_ui(res_mpz) mpz_clear(res_mpz) finally: @@ -2811,12 +2811,12 @@ cdef class IntegerMod_int(IntegerMod_abstract): if long_exp == 0 and self.ivalue == 0: # Return 0 if the modulus is 1, otherwise return 1. - return self._new_c(self.__modulus.int32 != 1) + return self._new_c(self._modulus.int32 != 1) cdef bint invert = False if long_exp < 0: invert = True long_exp = -long_exp - res = mod_pow_int(self.ivalue, long_exp, self.__modulus.int32) + res = mod_pow_int(self.ivalue, long_exp, self._modulus.int32) if invert: return ~self._new_c(res) else: @@ -2833,14 +2833,14 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: Mod(0,1)^-1 0 """ - if self.__modulus.inverses is not None: - x = self.__modulus.inverses[self.ivalue] + if self._modulus.inverses is not None: + x = self._modulus.inverses[self.ivalue] if x is None: - raise ZeroDivisionError(f"inverse of Mod({self}, {self.__modulus.sageInteger}) does not exist") + raise ZeroDivisionError(f"inverse of Mod({self}, {self._modulus.sageInteger}) does not exist") else: return x else: - return self._new_c(mod_inverse_int(self.ivalue, self.__modulus.int32)) + return self._new_c(mod_inverse_int(self.ivalue, self._modulus.int32)) def lift(IntegerMod_int self): """ @@ -3006,15 +3006,15 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: GF(103)(-1).sqrt(extend=False, all=True) [] """ - cdef int_fast32_t i, n = self.__modulus.int32 + cdef int_fast32_t i, n = self._modulus.int32 if n > 100: moduli = self._parent.factored_order() # Unless the modulus is tiny, test to see if we're in the really # easy case of n prime, n = 3 mod 4. if n > 100 and n % 4 == 3 and len(moduli) == 1 and moduli[0][1] == 1: - if jacobi_int(self.ivalue, self.__modulus.int32) == 1: + if jacobi_int(self.ivalue, self._modulus.int32) == 1: # it's a non-zero square, sqrt(a) = a^(p+1)/4 - i = mod_pow_int(self.ivalue, (self.__modulus.int32+1)/4, n) + i = mod_pow_int(self.ivalue, (self._modulus.int32+1)/4, n) if i > n / 2: i = n - i if all: @@ -3049,7 +3049,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): This function returns `x` or `-x`, whichever has a positive representative in `-n/2 < x \leq n/2`. """ - if self.ivalue > self.__modulus.int32 / 2: + if self.ivalue > self._modulus.int32 / 2: return -self return self @@ -3082,9 +3082,9 @@ cdef class IntegerMod_int(IntegerMod_abstract): sage: mod(0,1).gcd(mod(0,1)) 0 """ - cdef int_fast32_t g = gcd_int(self.ivalue, self.__modulus.int32) + cdef int_fast32_t g = gcd_int(self.ivalue, self._modulus.int32) g = gcd_int(g, other.ivalue) - if g == self.__modulus.int32: # self = other = 0 + if g == self._modulus.int32: # self = other = 0 g = 0 return self._new_c(g) @@ -3256,27 +3256,27 @@ cdef class IntegerMod_int64(IntegerMod_abstract): cdef IntegerMod_int64 _new_c(self, int_fast64_t value): cdef IntegerMod_int64 x x = IntegerMod_int64.__new__(IntegerMod_int64) - x.__modulus = self.__modulus + x._modulus = self._modulus x._parent = self._parent x.ivalue = value return x cdef void set_from_mpz(self, mpz_t value): - self.ivalue = mpz_fdiv_ui(value, self.__modulus.int64) + self.ivalue = mpz_fdiv_ui(value, self._modulus.int64) cdef void set_from_long(self, long value): - self.ivalue = value % self.__modulus.int64 + self.ivalue = value % self._modulus.int64 if self.ivalue < 0: - self.ivalue += self.__modulus.int64 + self.ivalue += self._modulus.int64 cdef void set_from_ulong_fast(self, unsigned long value): self.ivalue = value cdef void set_from_int(IntegerMod_int64 self, int_fast64_t ivalue): if ivalue < 0: - self.ivalue = self.__modulus.int64 + (ivalue % self.__modulus.int64) # Is ivalue % self.__modulus.int64 actually negative? - elif ivalue >= self.__modulus.int64: - self.ivalue = ivalue % self.__modulus.int64 + self.ivalue = self._modulus.int64 + (ivalue % self._modulus.int64) # Is ivalue % self._modulus.int64 actually negative? + elif ivalue >= self._modulus.int64: + self.ivalue = ivalue % self._modulus.int64 else: self.ivalue = ivalue @@ -3344,7 +3344,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): sage: mod(25, 5^10).is_unit() False """ - return gcd_int64(self.ivalue, self.__modulus.int64) == 1 + return gcd_int64(self.ivalue, self._modulus.int64) == 1 def __crt(IntegerMod_int64 self, IntegerMod_int64 other): """ @@ -3379,11 +3379,11 @@ cdef class IntegerMod_int64(IntegerMod_abstract): cdef int_fast64_t x from .integer_mod_ring import IntegerModRing - lift = IntegerMod_int64(IntegerModRing(self.__modulus.int64 * other.__modulus.int64)) + lift = IntegerMod_int64(IntegerModRing(self._modulus.int64 * other._modulus.int64)) try: - x = (other.ivalue - self.ivalue % other.__modulus.int64) * mod_inverse_int64(self.__modulus.int64, other.__modulus.int64) - lift.set_from_int( x * self.__modulus.int64 + self.ivalue ) + x = (other.ivalue - self.ivalue % other._modulus.int64) * mod_inverse_int64(self._modulus.int64, other._modulus.int64) + lift.set_from_int( x * self._modulus.int64 + self.ivalue ) return lift except ZeroDivisionError: raise ZeroDivisionError("moduli must be coprime") @@ -3422,8 +3422,8 @@ cdef class IntegerMod_int64(IntegerMod_abstract): """ cdef int_fast64_t x x = self.ivalue + (right).ivalue - if x >= self.__modulus.int64: - x = x - self.__modulus.int64 + if x >= self._modulus.int64: + x = x - self._modulus.int64 return self._new_c(x) cpdef _sub_(self, right): @@ -3437,7 +3437,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): cdef int_fast64_t x x = self.ivalue - (right).ivalue if x < 0: - x = x + self.__modulus.int64 + x = x + self._modulus.int64 return self._new_c(x) cpdef _neg_(self): @@ -3451,7 +3451,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): """ if self.ivalue == 0: return self - return self._new_c(self.__modulus.int64 - self.ivalue) + return self._new_c(self._modulus.int64 - self.ivalue) cpdef _mul_(self, right): """ @@ -3461,7 +3461,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): sage: R(700) * R(800) 60000 """ - return self._new_c((self.ivalue * (right).ivalue) % self.__modulus.int64) + return self._new_c((self.ivalue * (right).ivalue) % self._modulus.int64) cpdef _div_(self, right): @@ -3473,7 +3473,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): 33334 """ return self._new_c((self.ivalue * mod_inverse_int64((right).ivalue, - self.__modulus.int64) ) % self.__modulus.int64) + self._modulus.int64) ) % self._modulus.int64) def __int__(IntegerMod_int64 self): return self.ivalue @@ -3559,7 +3559,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): if k == 0: return self elif k > 0: - return self._new_c((self.ivalue << k) % self.__modulus.int64) + return self._new_c((self.ivalue << k) % self._modulus.int64) else: return self._new_c(self.ivalue >> (-k)) @@ -3633,7 +3633,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): sig_on() try: mpz_init(res_mpz) - mpz_pow_helper(res_mpz, (base).value, exp, self.__modulus.sageInteger.value) + mpz_pow_helper(res_mpz, (base).value, exp, self._modulus.sageInteger.value) res = mpz_get_ui(res_mpz) mpz_clear(res_mpz) finally: @@ -3642,14 +3642,14 @@ cdef class IntegerMod_int64(IntegerMod_abstract): if long_exp == 0 and self.ivalue == 0: # Return 0 if the modulus is 1, otherwise return 1. - return self._new_c(self.__modulus.int64 != 1) + return self._new_c(self._modulus.int64 != 1) cdef bint invert = False if long_exp < 0: invert = True long_exp = -long_exp - res = mod_pow_int64(self.ivalue, long_exp, self.__modulus.int64) + res = mod_pow_int64(self.ivalue, long_exp, self._modulus.int64) if invert: - return self._new_c(mod_inverse_int64(res, self.__modulus.int64)) + return self._new_c(mod_inverse_int64(res, self._modulus.int64)) else: return self._new_c(res) @@ -3666,7 +3666,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): sage: a 7 """ - return self._new_c(mod_inverse_int64(self.ivalue, self.__modulus.int64)) + return self._new_c(mod_inverse_int64(self.ivalue, self._modulus.int64)) def lift(IntegerMod_int64 self): """ @@ -3715,7 +3715,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): This function returns `x` or `-x`, whichever has a positive representative in `-n/2 < x \leq n/2`. """ - if self.ivalue > self.__modulus.int64 / 2: + if self.ivalue > self._modulus.int64 / 2: return -self return self @@ -3738,9 +3738,9 @@ cdef class IntegerMod_int64(IntegerMod_abstract): sage: mod(0,17^5).gcd(mod(0,17^5)) 0 """ - cdef int_fast64_t g = gcd_int64(self.ivalue, self.__modulus.int64) + cdef int_fast64_t g = gcd_int64(self.ivalue, self._modulus.int64) g = gcd_int64(g, other.ivalue) - if g == self.__modulus.int64: # self = other = 0 + if g == self._modulus.int64: # self = other = 0 g = 0 return self._new_c(g) diff --git a/src/sage/rings/fraction_field_FpT.pyx b/src/sage/rings/fraction_field_FpT.pyx index 0a25191a11c..c9bb5d5a384 100644 --- a/src/sage/rings/fraction_field_FpT.pyx +++ b/src/sage/rings/fraction_field_FpT.pyx @@ -1650,7 +1650,7 @@ cdef class FpT_Fp_section(Section): raise ValueError("not constant") ans = IntegerMod_int.__new__(IntegerMod_int) ans._parent = self.codomain() - ans.__modulus = ans._parent._pyx_order + ans._modulus = ans._parent._pyx_order if nmod_poly_get_coeff_ui(x._denom, 0) != 1: normalize(x._numer, x._denom, self.p) ans.ivalue = nmod_poly_get_coeff_ui(x._numer, 0) From 03e6b0b37d3c77a53aaa9186a9ea866086040eca Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:36:18 +0800 Subject: [PATCH 16/54] rename __normalize -> _normalize --- .../libs/linkages/padics/Polynomial_ram.pxi | 2 +- src/sage/modular/modsym/p1list.pxd | 2 +- src/sage/modular/modsym/p1list.pyx | 14 +++---- .../rings/laurent_series_ring_element.pxd | 2 +- .../rings/laurent_series_ring_element.pyx | 4 +- .../rings/polynomial/laurent_polynomial.pxd | 2 +- .../rings/polynomial/laurent_polynomial.pyx | 40 +++++++++---------- .../polynomial/ore_polynomial_element.pxd | 2 +- .../polynomial/ore_polynomial_element.pyx | 10 ++--- .../rings/polynomial/polynomial_element.pxd | 2 +- .../rings/polynomial/polynomial_element.pyx | 24 +++++------ 11 files changed, 52 insertions(+), 52 deletions(-) diff --git a/src/sage/libs/linkages/padics/Polynomial_ram.pxi b/src/sage/libs/linkages/padics/Polynomial_ram.pxi index 1ac51f1211f..4a8e0b11d83 100644 --- a/src/sage/libs/linkages/padics/Polynomial_ram.pxi +++ b/src/sage/libs/linkages/padics/Polynomial_ram.pxi @@ -64,7 +64,7 @@ cdef inline bint creduce(celement out, celement a, long prec, PowComputer_ prime if i == break_pt: coeff_prec -= 1 out.__coeffs[i] = out.__coeffs[i].add_bigoh(coeff_prec) - out.__normalize() + out._normalize() return out == 0 cdef inline bint creduce_small(celement out, celement a, long prec, PowComputer_ prime_pow) except -1: diff --git a/src/sage/modular/modsym/p1list.pxd b/src/sage/modular/modsym/p1list.pxd index cc24a33139b..b66f28b8ad6 100644 --- a/src/sage/modular/modsym/p1list.pxd +++ b/src/sage/modular/modsym/p1list.pxd @@ -21,7 +21,7 @@ cdef class P1List: # Here we use a pointer to a function, so the if logic # for normalizing an element does not need to be used # every time the user calls the normalize function. - cdef int (*__normalize)(int N, int u, int v, + cdef int (*_normalize)(int N, int u, int v, int* uu, int* vv, int* ss, int compute_s) except -1 cpdef index(self, int u, int v) diff --git a/src/sage/modular/modsym/p1list.pyx b/src/sage/modular/modsym/p1list.pyx index 111d408cee4..30a8f7471dd 100644 --- a/src/sage/modular/modsym/p1list.pyx +++ b/src/sage/modular/modsym/p1list.pyx @@ -723,10 +723,10 @@ cdef class P1List(): self.__N = N if N <= 46340: self.__list = p1list_int(N) - self.__normalize = c_p1_normalize_int + self._normalize = c_p1_normalize_int elif N <= 2147483647: self.__list = p1list_llong(N) - self.__normalize = c_p1_normalize_llong + self._normalize = c_p1_normalize_llong else: raise OverflowError("p1list not defined for such large N.") self.__list.sort() @@ -921,7 +921,7 @@ cdef class P1List(): """ cdef int u, v, uu, vv, ss u,v = self.__list[i] - self.__normalize(self.__N, -u, v, &uu, &vv, &ss, 0) + self._normalize(self.__N, -u, v, &uu, &vv, &ss, 0) _, j = search(self.__list, (uu,vv)) return j @@ -954,7 +954,7 @@ cdef class P1List(): """ cdef int u, v, uu, vv, ss u,v = self.__list[i] - self.__normalize(self.__N, -v, u, &uu, &vv, &ss, 0) + self._normalize(self.__N, -v, u, &uu, &vv, &ss, 0) _, j = search(self.__list, (uu,vv)) return j @@ -987,7 +987,7 @@ cdef class P1List(): """ cdef int u, v, uu, vv, ss u,v = self.__list[i] - self.__normalize(self.__N, v, -u-v, &uu, &vv, &ss, 0) + self._normalize(self.__N, v, -u-v, &uu, &vv, &ss, 0) _, j = search(self.__list, (uu,vv)) return j @@ -1153,7 +1153,7 @@ cdef class P1List(): True """ cdef int uu, vv, ss - self.__normalize(self.__N, u, v, &uu, &vv, &ss, 0) + self._normalize(self.__N, u, v, &uu, &vv, &ss, 0) return (uu,vv) def normalize_with_scalar(self, int u, int v): @@ -1186,7 +1186,7 @@ cdef class P1List(): True """ cdef int uu, vv, ss - self.__normalize(self.__N, u, v, &uu, &vv, &ss, 1) + self._normalize(self.__N, u, v, &uu, &vv, &ss, 1) return (uu, vv, ss) def N(self): diff --git a/src/sage/rings/laurent_series_ring_element.pxd b/src/sage/rings/laurent_series_ring_element.pxd index d190645ce52..8df5a92c9e7 100644 --- a/src/sage/rings/laurent_series_ring_element.pxd +++ b/src/sage/rings/laurent_series_ring_element.pxd @@ -4,7 +4,7 @@ cdef class LaurentSeries(AlgebraElement): cdef ModuleElement __u cdef long __n - cdef __normalize(self) + cdef _normalize(self) cpdef _add_(self, other) cpdef _mul_(self, other) diff --git a/src/sage/rings/laurent_series_ring_element.pyx b/src/sage/rings/laurent_series_ring_element.pyx index 8e950478045..9bef72396b7 100644 --- a/src/sage/rings/laurent_series_ring_element.pyx +++ b/src/sage/rings/laurent_series_ring_element.pyx @@ -302,7 +302,7 @@ cdef class LaurentSeries(AlgebraElement): x = im_gens[0] return codomain(self.__u._im_gens_(codomain, im_gens, base_map=base_map) * x**self.__n) - cdef __normalize(self): + cdef _normalize(self): r""" A Laurent series is a pair (u(t), n), where either u=0 (to some precision) or u is a unit. This pair corresponds to @@ -725,7 +725,7 @@ cdef class LaurentSeries(AlgebraElement): R = self._parent.base_ring() coeffs = [value] + [R(0) for _ in range(1,-j)] + self.__u.list() self.__u = self.__u._parent(coeffs) - self.__normalize() + self._normalize() cpdef _add_(self, right_m): """ diff --git a/src/sage/rings/polynomial/laurent_polynomial.pxd b/src/sage/rings/polynomial/laurent_polynomial.pxd index 3648d6d1ed1..8e9107aeb47 100644 --- a/src/sage/rings/polynomial/laurent_polynomial.pxd +++ b/src/sage/rings/polynomial/laurent_polynomial.pxd @@ -12,6 +12,6 @@ cdef class LaurentPolynomial(CommutativeAlgebraElement): cdef class LaurentPolynomial_univariate(LaurentPolynomial): cdef ModuleElement __u cdef long __n - cpdef __normalize(self) + cpdef _normalize(self) cpdef _unsafe_mutate(self, i, value) diff --git a/src/sage/rings/polynomial/laurent_polynomial.pyx b/src/sage/rings/polynomial/laurent_polynomial.pyx index 4be246c6688..cd79996eed7 100644 --- a/src/sage/rings/polynomial/laurent_polynomial.pyx +++ b/src/sage/rings/polynomial/laurent_polynomial.pyx @@ -366,7 +366,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): # self is that t^n * u: self.__u = f self.__n = n - self.__normalize() + self._normalize() def __reduce__(self): """ @@ -531,7 +531,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): u = u.map_coefficients(base_map) return codomain(u(x) * x**self.__n) - cpdef __normalize(self): + cpdef _normalize(self): r""" A Laurent series is a pair `(u(t), n)`, where either `u = 0` (to some precision) or `u` is a unit. This pair corresponds to @@ -763,7 +763,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = f ret.__n = self.__n - ret.__normalize() + ret._normalize() return ret return self.__u[i - self.__n] @@ -919,7 +919,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): R = self._parent.base_ring() coeffs = [value] + [R.zero() for _ in range(1,-j)] + self.__u.list() self.__u = self.__u._parent(coeffs) - self.__normalize() + self._normalize() cpdef _add_(self, right_m): """ @@ -972,7 +972,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = (f1 + f2) ret.__n = m - ret.__normalize() + ret._normalize() return ret cpdef _sub_(self, right_m): @@ -1012,7 +1012,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = (f1 - f2) ret.__n = m - ret.__normalize() + ret._normalize() return ret def degree(self): @@ -1063,7 +1063,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = (self.__u * right.__u) ret.__n = self.__n + right.__n - ret.__normalize() + ret._normalize() return ret cpdef _rmul_(self, Element c): @@ -1079,7 +1079,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = self.__u._rmul_(c) ret.__n = self.__n - ret.__normalize() + ret._normalize() return ret cpdef _lmul_(self, Element c): @@ -1095,7 +1095,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = self.__u._lmul_(c) ret.__n = self.__n - ret.__normalize() + ret._normalize() return ret def is_monomial(self): @@ -1175,7 +1175,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = (self.__u // right.__u) ret.__n = self.__n - right.__n - ret.__normalize() + ret._normalize() return ret def shift(self, k): @@ -1287,7 +1287,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): if self.__u.is_unit(): ret.__u = self.__u.inverse_of_unit() ret.__n = -self.__n - ret.__normalize() + ret._normalize() return ret # Enlarge the ring so we can divide by the coefficient R = self._parent.base_ring().fraction_field() @@ -1362,7 +1362,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = self.__u.gcd(b.__u) ret.__n = min(self.__n, b.__n) - ret.__normalize() + ret._normalize() return ret @coerce_binop @@ -1408,11 +1408,11 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ql = self._new_c() ql.__u = q ql.__n = self.__n - right.__n - ql.__normalize() + ql._normalize() qr = self._new_c() qr.__u = r qr.__n = self.__n - qr.__normalize() + qr._normalize() return ql, qr cpdef _richcmp_(self, right_r, int op): @@ -1519,7 +1519,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = self.__u.truncate(n - self.__n) ret.__n = self.__n - ret.__normalize() + ret._normalize() return ret def variable_name(self): @@ -1777,7 +1777,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = self._parent._R(u) ret.__n = self.__n - ret.__normalize() + ret._normalize() return ret except AttributeError: raise ValueError('cannot differentiate with respect to {}'.format(var)) @@ -1792,7 +1792,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = self._parent._R(a) ret.__n = self.__n - 1 - ret.__normalize() + ret._normalize() return ret def integral(self): @@ -1857,7 +1857,7 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): ret = self._new_c() ret.__u = u ret.__n = n + 1 - ret.__normalize() + ret._normalize() return ret def __call__(self, *x, **kwds): @@ -1919,14 +1919,14 @@ cdef class LaurentPolynomial_univariate(LaurentPolynomial): u = self._new_c() u.__u = pf.unit() u.__n = self.__n - u.__normalize() + u._normalize() f = [] for t in pf: d = self._new_c() d.__u = t[0] d.__n = 0 - d.__normalize() + d._normalize() if d.is_unit(): u *= d ** t[1] else: diff --git a/src/sage/rings/polynomial/ore_polynomial_element.pxd b/src/sage/rings/polynomial/ore_polynomial_element.pxd index 3a3fe0a0d54..aa36112ab90 100644 --- a/src/sage/rings/polynomial/ore_polynomial_element.pxd +++ b/src/sage/rings/polynomial/ore_polynomial_element.pxd @@ -33,7 +33,7 @@ cdef void lmul_gen(list A, Morphism m, d) cdef class OrePolynomial_generic_dense(OrePolynomial): cdef list _coeffs - cdef void __normalize(self) + cdef void _normalize(self) cpdef _add_(self, other) cdef list _mul_list(self, list A) cpdef _mul_(self, other) diff --git a/src/sage/rings/polynomial/ore_polynomial_element.pyx b/src/sage/rings/polynomial/ore_polynomial_element.pyx index d67c63b6be8..be154ba8b1a 100644 --- a/src/sage/rings/polynomial/ore_polynomial_element.pyx +++ b/src/sage/rings/polynomial/ore_polynomial_element.pyx @@ -2269,7 +2269,7 @@ cdef class OrePolynomial_generic_dense(OrePolynomial): if isinstance(x, list): if check: self._coeffs = [R(t) for t in x] - self.__normalize() + self._normalize() else: self._coeffs = x return @@ -2288,7 +2288,7 @@ cdef class OrePolynomial_generic_dense(OrePolynomial): else: self._coeffs = [R(a, **kwds) for a in x.list()] if check: - self.__normalize() + self._normalize() return elif isinstance(x, int) and x == 0: @@ -2302,7 +2302,7 @@ cdef class OrePolynomial_generic_dense(OrePolynomial): x = [x] if check: self._coeffs = [R(z, **kwds) for z in x] - self.__normalize() + self._normalize() else: self._coeffs = x @@ -2377,10 +2377,10 @@ cdef class OrePolynomial_generic_dense(OrePolynomial): f._parent = P f._coeffs = coeffs if check: - f.__normalize() + f._normalize() return f - cdef void __normalize(self): + cdef void _normalize(self): r""" Remove higher order `0`-coefficients from the representation of ``self``. diff --git a/src/sage/rings/polynomial/polynomial_element.pxd b/src/sage/rings/polynomial/polynomial_element.pxd index e6d935d28fe..f439aef123c 100644 --- a/src/sage/rings/polynomial/polynomial_element.pxd +++ b/src/sage/rings/polynomial/polynomial_element.pxd @@ -50,7 +50,7 @@ cdef class Polynomial(CommutativePolynomial): cdef class Polynomial_generic_dense(Polynomial): cdef Polynomial_generic_dense _new_c(self, list coeffs, Parent P) cdef list __coeffs - cdef int __normalize(self) except -1 + cdef int _normalize(self) except -1 cpdef list list(self, bint copy=*) cdef class Polynomial_generic_dense_inexact(Polynomial_generic_dense): diff --git a/src/sage/rings/polynomial/polynomial_element.pyx b/src/sage/rings/polynomial/polynomial_element.pyx index 4d4b9dd10f5..1653e0ec395 100644 --- a/src/sage/rings/polynomial/polynomial_element.pyx +++ b/src/sage/rings/polynomial/polynomial_element.pyx @@ -11548,7 +11548,7 @@ cdef class Polynomial_generic_dense(Polynomial): if isinstance(x, (list, tuple)): if check: self.__coeffs = [R(t) for t in x] - self.__normalize() + self._normalize() else: self.__coeffs = x return @@ -11573,7 +11573,7 @@ cdef class Polynomial_generic_dense(Polynomial): else: self.__coeffs = [R(a, **kwds) for a in x.list(copy=False)] if check: - self.__normalize() + self._normalize() return elif isinstance(x, int) and x == 0: @@ -11594,7 +11594,7 @@ cdef class Polynomial_generic_dense(Polynomial): # x = [] # zero polynomial if check: self.__coeffs = [R(z, **kwds) for z in x] - self.__normalize() + self._normalize() else: self.__coeffs = x @@ -11697,10 +11697,10 @@ cdef class Polynomial_generic_dense(Polynomial): cdef Polynomial_generic_dense res = self._new_c(v, self._parent) #if not v[len(v)-1]: # "normalize" checks this anyway... - res.__normalize() + res._normalize() return res - cdef int __normalize(self) except -1: + cdef int _normalize(self) except -1: """ TESTS: @@ -11773,7 +11773,7 @@ cdef class Polynomial_generic_dense(Polynomial): if n >= 0 and n < len(self.__coeffs): self.__coeffs[n] = value if n == len(self.__coeffs) and value == 0: - self.__normalize() + self._normalize() elif n < 0: raise IndexError("polynomial coefficient index must be nonnegative") elif value != 0: @@ -11823,7 +11823,7 @@ cdef class Polynomial_generic_dense(Polynomial): P = parent(self) d = P.base_ring()(right) cdef Polynomial_generic_dense res = (self)._new_c([c // d for c in (self).__coeffs], P) - res.__normalize() + res._normalize() return res cpdef _add_(self, right): @@ -11852,7 +11852,7 @@ cdef class Polynomial_generic_dense(Polynomial): cdef list low = [x[i] + y[i] for i from 0 <= i < min] if len(x) == len(y): res = self._new_c(low, self._parent) - res.__normalize() + res._normalize() return res else: return self._new_c(low + high, self._parent) @@ -11873,7 +11873,7 @@ cdef class Polynomial_generic_dense(Polynomial): low = [x[i] - y[i] for i from 0 <= i < min] if len(x) == len(y): res = self._new_c(low, self._parent) - res.__normalize() + res._normalize() return res else: return self._new_c(low + high, self._parent) @@ -11887,7 +11887,7 @@ cdef class Polynomial_generic_dense(Polynomial): cdef Polynomial_generic_dense res = self._new_c(v, self._parent) #if not v[len(v)-1]: # "normalize" checks this anyway... - res.__normalize() + res._normalize() return res cpdef _lmul_(self, Element c): @@ -11899,7 +11899,7 @@ cdef class Polynomial_generic_dense(Polynomial): cdef Polynomial_generic_dense res = self._new_c(v, self._parent) #if not v[len(v)-1]: # "normalize" checks this anyway... - res.__normalize() + res._normalize() return res cpdef constant_coefficient(self): @@ -12305,7 +12305,7 @@ cdef class Polynomial_generic_dense_inexact(Polynomial_generic_dense): - Xavier Caruso (2013-03) """ - cdef int __normalize(self) except -1: + cdef int _normalize(self) except -1: r""" TESTS:: From bb94714e1c9b9fced93850c9724fc5be632f8918 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:36:58 +0800 Subject: [PATCH 17/54] rename __coeffs -> _coeffs --- .../libs/linkages/padics/Polynomial_ram.pxi | 30 ++--- .../linkages/padics/Polynomial_shared.pxi | 50 ++++---- src/sage/rings/padics/CA_template.pxi | 8 +- src/sage/rings/padics/CR_template.pxi | 8 +- src/sage/rings/padics/FM_template.pxi | 8 +- src/sage/rings/padics/FP_template.pxi | 8 +- .../rings/polynomial/polynomial_element.pxd | 2 +- .../rings/polynomial/polynomial_element.pyx | 112 +++++++++--------- 8 files changed, 113 insertions(+), 113 deletions(-) diff --git a/src/sage/libs/linkages/padics/Polynomial_ram.pxi b/src/sage/libs/linkages/padics/Polynomial_ram.pxi index 4a8e0b11d83..e0584ecb8ad 100644 --- a/src/sage/libs/linkages/padics/Polynomial_ram.pxi +++ b/src/sage/libs/linkages/padics/Polynomial_ram.pxi @@ -55,15 +55,15 @@ cdef inline bint creduce(celement out, celement a, long prec, PowComputer_ prime """ cdef celement ared = a % prime_pow.modulus if ared is a and out is not a: - out.__coeffs = ared.__coeffs[:] + out._coeffs = ared._coeffs[:] else: - out.__coeffs = ared.__coeffs + out._coeffs = ared._coeffs cdef long coeff_prec = prec / prime_pow.e + 1 cdef long break_pt = prec % prime_pow.e - for i in range(len(out.__coeffs)): + for i in range(len(out._coeffs)): if i == break_pt: coeff_prec -= 1 - out.__coeffs[i] = out.__coeffs[i].add_bigoh(coeff_prec) + out._coeffs[i] = out._coeffs[i].add_bigoh(coeff_prec) out._normalize() return out == 0 @@ -116,7 +116,7 @@ cdef inline long cvaluation(celement a, long prec, PowComputer_ prime_pow) excep higher. """ - C = a.__coeffs + C = a._coeffs if not C: return prec cdef long ret = maxordp @@ -161,7 +161,7 @@ cdef inline int cshift(celement shifted, celement rem, celement a, long n, long v = cvaluation(a, prec, prime_pow) notrunc = (v >= -n) if notrunc: - rem.__coeffs = [] + rem._coeffs = [] return cshift_notrunc(shifted, a, n, prec, prime_pow, reduce_afterward) if v > 0: b = prime_pow.poly_ring(0) @@ -185,7 +185,7 @@ cdef inline int cshift(celement shifted, celement rem, celement a, long n, long if reduce_afterward: creduce(shifted, a, prec, prime_pow) else: - shifted.__coeffs = a.__coeffs[:] + shifted._coeffs = a._coeffs[:] cdef inline int cshift_notrunc(celement out, celement a, long n, long prec, PowComputer_ prime_pow, bint reduce_afterward) except -1: r""" @@ -236,7 +236,7 @@ cdef inline int cshift_notrunc(celement out, celement a, long n, long prec, PowC if reduce_afterward: creduce(out, a, prec, prime_pow) else: - out.__coeffs = a.__coeffs[:] + out._coeffs = a._coeffs[:] cdef inline int cinvert(celement out, celement a, long prec, PowComputer_ prime_pow) except -1: r""" @@ -253,7 +253,7 @@ cdef inline int cinvert(celement out, celement a, long prec, PowComputer_ prime_ - ``prime_pow`` -- the ``PowComputer`` for the ring """ - out.__coeffs = prime_pow.invert(a, prec).__coeffs + out._coeffs = prime_pow.invert(a, prec)._coeffs creduce(out, out, prec, prime_pow) cdef inline int cdivunit(celement out, celement a, celement b, long prec, PowComputer_ prime_pow) except -1: @@ -335,7 +335,7 @@ cdef inline cexpansion_next(celement value, expansion_mode mode, long curpower, # the following is specific to the ramified over unramified case. modp_rep, term = value[0]._modp_rep(mode == smallest_mode) if term: - value.__coeffs[0] -= modp_rep + value._coeffs[0] -= modp_rep cshift_notrunc(value, value, -1, curpower, prime_pow, False) return term @@ -354,10 +354,10 @@ cdef inline cexpansion_getitem(celement value, long m, PowComputer_ prime_pow): while m >= 0: modp_rep, term = value[0]._modp_rep() if m: - if len(value.__coeffs): - value.__coeffs[0] -= modp_rep + if len(value._coeffs): + value._coeffs[0] -= modp_rep else: - value.__coeffs.append(-modp_rep) + value._coeffs.append(-modp_rep) cshift_notrunc(value, value, -1, 1, prime_pow, False) m -= 1 return term @@ -379,9 +379,9 @@ cdef int cteichmuller(celement out, celement value, long prec, PowComputer_ prim """ if value[0].valuation() > 0: - out.__coeffs = [] + out._coeffs = [] else: - out.__coeffs = [value[0].parent().teichmuller(value[0])] + out._coeffs = [value[0].parent().teichmuller(value[0])] cdef list ccoefficients(celement x, long valshift, long prec, PowComputer_ prime_pow): """ diff --git a/src/sage/libs/linkages/padics/Polynomial_shared.pxi b/src/sage/libs/linkages/padics/Polynomial_shared.pxi index 495dc6b0848..367bbc2f33d 100644 --- a/src/sage/libs/linkages/padics/Polynomial_shared.pxi +++ b/src/sage/libs/linkages/padics/Polynomial_shared.pxi @@ -106,7 +106,7 @@ cdef inline int ccmp(celement a, celement b, long prec, bint reduce_a, bint redu if not (reduce_a or reduce_b): return 0 if a == b else 1 csub(prime_pow.tmp_ccmp_a, a, b, prec, prime_pow) - coeffs = prime_pow.tmp_ccmp_a.__coeffs + coeffs = prime_pow.tmp_ccmp_a._coeffs cdef long i, coeff_prec, break_pt if prime_pow.e == 1: for i in range(prime_pow.tmp_ccmp_a.degree()+1): @@ -186,9 +186,9 @@ cdef inline int cneg(celement out, celement a, long prec, PowComputer_ prime_pow """ cdef celement ma = -a if ma is a: - out.__coeffs = ma.__coeffs[:] + out._coeffs = ma._coeffs[:] else: - out.__coeffs = ma.__coeffs + out._coeffs = ma._coeffs cdef inline int cadd(celement out, celement a, celement b, long prec, PowComputer_ prime_pow) except -1: r""" @@ -211,9 +211,9 @@ cdef inline int cadd(celement out, celement a, celement b, long prec, PowCompute """ cdef celement sm = a + b if sm is a or sm is b: - out.__coeffs = sm.__coeffs[:] + out._coeffs = sm._coeffs[:] else: - out.__coeffs = sm.__coeffs + out._coeffs = sm._coeffs cdef inline int csub(celement out, celement a, celement b, long prec, PowComputer_ prime_pow) except -1: r""" @@ -236,9 +236,9 @@ cdef inline int csub(celement out, celement a, celement b, long prec, PowCompute """ cdef celement df = a - b if df is a or df is b: - out.__coeffs = df.__coeffs[:] + out._coeffs = df._coeffs[:] else: - out.__coeffs = df.__coeffs + out._coeffs = df._coeffs cdef inline int cmul(celement out, celement a, celement b, long prec, PowComputer_ prime_pow) except -1: r""" @@ -261,9 +261,9 @@ cdef inline int cmul(celement out, celement a, celement b, long prec, PowCompute """ cdef celement pd = a*b if pd is a or pd is b: - out.__coeffs = pd.__coeffs[:] + out._coeffs = pd._coeffs[:] else: - out.__coeffs = pd.__coeffs + out._coeffs = pd._coeffs cdef inline int csetone(celement out, PowComputer_ prime_pow) except -1: r""" @@ -276,7 +276,7 @@ cdef inline int csetone(celement out, PowComputer_ prime_pow) except -1: - ``prime_pow`` -- the ``PowComputer`` for the ring """ - out.__coeffs = [prime_pow.base_ring(1)] + out._coeffs = [prime_pow.base_ring(1)] cdef inline int csetzero(celement out, PowComputer_ prime_pow) except -1: r""" @@ -289,7 +289,7 @@ cdef inline int csetzero(celement out, PowComputer_ prime_pow) except -1: - ``prime_pow`` -- the ``PowComputer`` for the ring """ - out.__coeffs = [] + out._coeffs = [] cdef inline bint cisone(celement a, PowComputer_ prime_pow) except -1: r""" @@ -330,7 +330,7 @@ cdef inline int ccopy(celement out, celement a, PowComputer_ prime_pow) except - - ``prime_pow`` -- the ``PowComputer`` for the ring """ - out.__coeffs = a.__coeffs[:] + out._coeffs = a._coeffs[:] cdef inline cpickle(celement a, PowComputer_ prime_pow): r""" @@ -343,7 +343,7 @@ cdef inline cpickle(celement a, PowComputer_ prime_pow): - ``prime_pow`` the ``PowComputer`` for the ring """ - return a.__coeffs + return a._coeffs cdef inline int cunpickle(celement out, x, PowComputer_ prime_pow) except -1: r""" @@ -358,7 +358,7 @@ cdef inline int cunpickle(celement out, x, PowComputer_ prime_pow) except -1: - ``prime_pow`` -- the ``PowComputer`` for the ring """ - out.__coeffs = x + out._coeffs = x cdef inline long chash(celement a, long ordp, long prec, PowComputer_ prime_pow) except -1: r""" @@ -413,9 +413,9 @@ cdef int cconv(celement out, x, long prec, long valshift, PowComputer_ prime_pow else: xx = prime_pow.poly_ring(x) if xx is x: - out.__coeffs = xx.__coeffs[:] + out._coeffs = xx._coeffs[:] else: - out.__coeffs = xx.__coeffs + out._coeffs = xx._coeffs if valshift > 0: cshift_notrunc(out, out, -valshift, prec, prime_pow, True) elif valshift == 0: @@ -458,12 +458,12 @@ cdef inline long cconv_mpz_t(celement out, mpz_t x, long prec, bint absolute, Po mpz_set(n.value, x) if n: - out.__coeffs = [prime_pow.base_ring(n)] + out._coeffs = [prime_pow.base_ring(n)] if not absolute: valuation = cremove(out, out, prec, prime_pow) creduce(out, out, prec, prime_pow) else: - out.__coeffs = [] + out._coeffs = [] return valuation @@ -492,12 +492,12 @@ cdef inline int cconv_mpz_t_out(mpz_t out, celement x, long valshift, long prec, else: prime_pow.powhelper_cconv_out = x - if len(prime_pow.powhelper_cconv_out.__coeffs) == 0: + if len(prime_pow.powhelper_cconv_out._coeffs) == 0: mpz_set_ui(out, 0) - elif len(prime_pow.powhelper_cconv_out.__coeffs) == 1: + elif len(prime_pow.powhelper_cconv_out._coeffs) == 1: # recursively let the underlying polynomial convert the constant # coefficient to an integer (if possible) - n = ZZ(prime_pow.powhelper_cconv_out.__coeffs[0]) + n = ZZ(prime_pow.powhelper_cconv_out._coeffs[0]) mpz_set(out, n.value) else: raise ValueError("cannot convert to integer") @@ -532,7 +532,7 @@ cdef inline long cconv_mpq_t(celement out, mpq_t x, long prec, bint absolute, Po """ cdef Rational r = PY_NEW(Rational) mpq_set(r.value, x) - out.__coeffs = [prime_pow.base_ring(r)] + out._coeffs = [prime_pow.base_ring(r)] if not absolute: return cremove(out, out, prec, prime_pow) @@ -565,12 +565,12 @@ cdef inline int cconv_mpq_t_out(mpq_t out, celement x, long valshift, long prec, else: prime_pow.powhelper_cconv_out = x - if len(prime_pow.powhelper_cconv_out.__coeffs) == 0: + if len(prime_pow.powhelper_cconv_out._coeffs) == 0: mpq_set_ui(out, 0, 1) - elif len(prime_pow.powhelper_cconv_out.__coeffs) == 1: + elif len(prime_pow.powhelper_cconv_out._coeffs) == 1: # recursively let the underlying polynomial convert the constant # coefficient to a rational (if possible) - c = QQ(prime_pow.powhelper_cconv_out.__coeffs[0]) + c = QQ(prime_pow.powhelper_cconv_out._coeffs[0]) mpq_set(out, c.value) else: raise ValueError("cannot convert to rational") diff --git a/src/sage/rings/padics/CA_template.pxi b/src/sage/rings/padics/CA_template.pxi index a0a66c19621..d821b5c1576 100644 --- a/src/sage/rings/padics/CA_template.pxi +++ b/src/sage/rings/padics/CA_template.pxi @@ -1463,7 +1463,7 @@ cdef class pAdicCoercion_CA_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] ans._normalize() return ans @@ -1516,7 +1516,7 @@ cdef class pAdicCoercion_CA_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] pass return ans @@ -1686,7 +1686,7 @@ cdef class pAdicConvert_CA_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. R = ans.value.base_ring() - ans.value.__coeffs = [R(c) for c in ans.value.__coeffs] + ans.value._coeffs = [R(c) for c in ans.value._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -1741,7 +1741,7 @@ cdef class pAdicConvert_CA_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. R = ans.value.base_ring() - ans.value.__coeffs = [R(c) for c in ans.value.__coeffs] + ans.value._coeffs = [R(c) for c in ans.value._coeffs] return ans cdef dict _extra_slots(self): diff --git a/src/sage/rings/padics/CR_template.pxi b/src/sage/rings/padics/CR_template.pxi index cb57bb2cb48..863c612587c 100644 --- a/src/sage/rings/padics/CR_template.pxi +++ b/src/sage/rings/padics/CR_template.pxi @@ -2184,7 +2184,7 @@ cdef class pAdicCoercion_CR_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -2241,7 +2241,7 @@ cdef class pAdicCoercion_CR_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans def section(self): @@ -2404,7 +2404,7 @@ cdef class pAdicConvert_CR_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -2463,7 +2463,7 @@ cdef class pAdicConvert_CR_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cdef dict _extra_slots(self): diff --git a/src/sage/rings/padics/FM_template.pxi b/src/sage/rings/padics/FM_template.pxi index ea7d4055660..f47200074ea 100644 --- a/src/sage/rings/padics/FM_template.pxi +++ b/src/sage/rings/padics/FM_template.pxi @@ -1227,7 +1227,7 @@ cdef class pAdicCoercion_FM_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -1277,7 +1277,7 @@ cdef class pAdicCoercion_FM_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans def section(self): @@ -1435,7 +1435,7 @@ cdef class pAdicConvert_FM_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. R = ans.value.base_ring() - ans.value.__coeffs = [R(c) for c in ans.value.__coeffs] + ans.value._coeffs = [R(c) for c in ans.value._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -1483,7 +1483,7 @@ cdef class pAdicConvert_FM_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. R = ans.value.base_ring() - ans.value.__coeffs = [R(c) for c in ans.value.__coeffs] + ans.value._coeffs = [R(c) for c in ans.value._coeffs] return ans cdef dict _extra_slots(self): diff --git a/src/sage/rings/padics/FP_template.pxi b/src/sage/rings/padics/FP_template.pxi index 57ec619b278..c718c0a5f8d 100644 --- a/src/sage/rings/padics/FP_template.pxi +++ b/src/sage/rings/padics/FP_template.pxi @@ -1849,7 +1849,7 @@ cdef class pAdicCoercion_FP_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -1903,7 +1903,7 @@ cdef class pAdicCoercion_FP_frac_field(RingHomomorphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans def section(self): @@ -2025,7 +2025,7 @@ cdef class pAdicConvert_FP_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cpdef Element _call_with_args(self, _x, args=(), kwds={}): @@ -2081,7 +2081,7 @@ cdef class pAdicConvert_FP_frac_field(Morphism): IF CELEMENT_IS_PY_OBJECT: # The base ring is wrong, so we fix it. K = ans.unit.base_ring() - ans.unit.__coeffs = [K(c) for c in ans.unit.__coeffs] + ans.unit._coeffs = [K(c) for c in ans.unit._coeffs] return ans cdef dict _extra_slots(self): diff --git a/src/sage/rings/polynomial/polynomial_element.pxd b/src/sage/rings/polynomial/polynomial_element.pxd index f439aef123c..5dcbf4597d0 100644 --- a/src/sage/rings/polynomial/polynomial_element.pxd +++ b/src/sage/rings/polynomial/polynomial_element.pxd @@ -49,7 +49,7 @@ cdef class Polynomial(CommutativePolynomial): cdef class Polynomial_generic_dense(Polynomial): cdef Polynomial_generic_dense _new_c(self, list coeffs, Parent P) - cdef list __coeffs + cdef list _coeffs cdef int _normalize(self) except -1 cpdef list list(self, bint copy=*) diff --git a/src/sage/rings/polynomial/polynomial_element.pyx b/src/sage/rings/polynomial/polynomial_element.pyx index 1653e0ec395..d1c802835ae 100644 --- a/src/sage/rings/polynomial/polynomial_element.pyx +++ b/src/sage/rings/polynomial/polynomial_element.pyx @@ -9800,7 +9800,7 @@ cdef class Polynomial(CommutativePolynomial): 0 """ # __getitem__ already returns a polynomial!! - # We must not have check=False, since 0 must not have __coeffs = [0]. + # We must not have check=False, since 0 must not have _coeffs = [0]. return self._parent(self[:n])#, check=False) cdef _inplace_truncate(self, long prec): @@ -11541,16 +11541,16 @@ cdef class Polynomial_generic_dense(Polynomial): def __init__(self, parent, x=None, int check=1, is_gen=False, int construct=0, **kwds): Polynomial.__init__(self, parent, is_gen=is_gen) if x is None: - self.__coeffs = [] + self._coeffs = [] return R = parent.base_ring() if isinstance(x, (list, tuple)): if check: - self.__coeffs = [R(t) for t in x] + self._coeffs = [R(t) for t in x] self._normalize() else: - self.__coeffs = x + self._coeffs = x return if sage.rings.fraction_field_element.is_FractionFieldElement(x): @@ -11565,19 +11565,19 @@ cdef class Polynomial_generic_dense(Polynomial): elif R.has_coerce_map_from((x)._parent):# is R or (x)._parent == R: try: if x.is_zero(): - self.__coeffs = [] + self._coeffs = [] return except (AttributeError, TypeError): pass x = [x] else: - self.__coeffs = [R(a, **kwds) for a in x.list(copy=False)] + self._coeffs = [R(a, **kwds) for a in x.list(copy=False)] if check: self._normalize() return elif isinstance(x, int) and x == 0: - self.__coeffs = [] + self._coeffs = [] return elif isinstance(x, dict): @@ -11593,16 +11593,16 @@ cdef class Polynomial_generic_dense(Polynomial): # else: # x = [] # zero polynomial if check: - self.__coeffs = [R(z, **kwds) for z in x] + self._coeffs = [R(z, **kwds) for z in x] self._normalize() else: - self.__coeffs = x + self._coeffs = x cdef Polynomial_generic_dense _new_c(self, list coeffs, Parent P): cdef type t = type(self) cdef Polynomial_generic_dense f = t.__new__(t) f._parent = P - f.__coeffs = coeffs + f._coeffs = coeffs return f cpdef Polynomial _new_constant_poly(self, a, Parent P): @@ -11644,10 +11644,10 @@ cdef class Polynomial_generic_dense(Polynomial): sage: type(f) """ - return make_generic_polynomial, (self._parent, self.__coeffs) + return make_generic_polynomial, (self._parent, self._coeffs) def __bool__(self): - return bool(self.__coeffs) + return bool(self._coeffs) cpdef bint is_term(self) except -1: """ @@ -11667,10 +11667,10 @@ cdef class Polynomial_generic_dense(Polynomial): sage: (1 + 3*x^5).is_term() False """ - if not self.__coeffs: + if not self._coeffs: return False - for c in self.__coeffs[:-1]: + for c in self._coeffs[:-1]: if c: return False return True @@ -11682,9 +11682,9 @@ cdef class Polynomial_generic_dense(Polynomial): Return the product ``self * term``, where ``term`` is a polynomial with a single term. """ - cdef Py_ssize_t d = len( ( term).__coeffs ) - 1 + cdef Py_ssize_t d = len( ( term)._coeffs ) - 1 cdef Py_ssize_t i - cdef list x = self.__coeffs + cdef list x = self._coeffs cdef Py_ssize_t ell = len(x) c = term.get_unsafe(d) cdef list v = [self.base_ring().zero()] * (d + ell) @@ -11718,7 +11718,7 @@ cdef class Polynomial_generic_dense(Polynomial): ... NotImplementedError: cannot check whether number is non-zero """ - cdef list x = self.__coeffs + cdef list x = self._coeffs cdef Py_ssize_t n = len(x) - 1 while n >= 0 and not x[n]: del x[n] @@ -11747,7 +11747,7 @@ cdef class Polynomial_generic_dense(Polynomial): sage: f[:3] 40.0*x^2 + 10.0*x + 1.0 """ - return self.__coeffs[n] + return self._coeffs[n] def _unsafe_mutate(self, n, value): """ @@ -11770,17 +11770,17 @@ cdef class Polynomial_generic_dense(Polynomial): """ n = int(n) value = self.base_ring()(value) - if n >= 0 and n < len(self.__coeffs): - self.__coeffs[n] = value - if n == len(self.__coeffs) and value == 0: + if n >= 0 and n < len(self._coeffs): + self._coeffs[n] = value + if n == len(self._coeffs) and value == 0: self._normalize() elif n < 0: raise IndexError("polynomial coefficient index must be nonnegative") elif value != 0: zero = self.base_ring().zero() - for _ in range(len(self.__coeffs), n): - self.__coeffs.append(zero) - self.__coeffs.append(value) + for _ in range(len(self._coeffs), n): + self._coeffs.append(zero) + self._coeffs.append(value) def __floordiv__(self, right): """ @@ -11822,7 +11822,7 @@ cdef class Polynomial_generic_dense(Polynomial): return (self)._floordiv_(right) P = parent(self) d = P.base_ring()(right) - cdef Polynomial_generic_dense res = (self)._new_c([c // d for c in (self).__coeffs], P) + cdef Polynomial_generic_dense res = (self)._new_c([c // d for c in (self)._coeffs], P) res._normalize() return res @@ -11839,8 +11839,8 @@ cdef class Polynomial_generic_dense(Polynomial): """ cdef Polynomial_generic_dense res cdef Py_ssize_t check=0, i, min - x = (self).__coeffs - y = (right).__coeffs + x = (self)._coeffs + y = (right)._coeffs if len(x) > len(y): min = len(y) high = x[min:] @@ -11860,8 +11860,8 @@ cdef class Polynomial_generic_dense(Polynomial): cpdef _sub_(self, right): cdef Polynomial_generic_dense res cdef Py_ssize_t check=0, i, min - x = (self).__coeffs - y = (right).__coeffs + x = (self)._coeffs + y = (right)._coeffs if len(x) > len(y): min = len(y) high = x[min:] @@ -11879,11 +11879,11 @@ cdef class Polynomial_generic_dense(Polynomial): return self._new_c(low + high, self._parent) cpdef _rmul_(self, Element c): - if not self.__coeffs: + if not self._coeffs: return self - if c._parent is not (self.__coeffs[0])._parent: - c = (self.__coeffs[0])._parent.coerce(c) - v = [c * a for a in self.__coeffs] + if c._parent is not (self._coeffs[0])._parent: + c = (self._coeffs[0])._parent.coerce(c) + v = [c * a for a in self._coeffs] cdef Polynomial_generic_dense res = self._new_c(v, self._parent) #if not v[len(v)-1]: # "normalize" checks this anyway... @@ -11891,11 +11891,11 @@ cdef class Polynomial_generic_dense(Polynomial): return res cpdef _lmul_(self, Element c): - if not self.__coeffs: + if not self._coeffs: return self - if c._parent is not (self.__coeffs[0])._parent: - c = (self.__coeffs[0])._parent.coerce(c) - v = [a * c for a in self.__coeffs] + if c._parent is not (self._coeffs[0])._parent: + c = (self._coeffs[0])._parent.coerce(c) + v = [a * c for a in self._coeffs] cdef Polynomial_generic_dense res = self._new_c(v, self._parent) #if not v[len(v)-1]: # "normalize" checks this anyway... @@ -11916,10 +11916,10 @@ cdef class Polynomial_generic_dense(Polynomial): sage: f.constant_coefficient() t """ - if not self.__coeffs: + if not self._coeffs: return self.base_ring().zero() else: - return self.__coeffs[0] + return self._coeffs[0] cpdef list list(self, bint copy=True): """ @@ -11934,9 +11934,9 @@ cdef class Polynomial_generic_dense(Polynomial): [1, 9, 12, 8] """ if copy: - return list(self.__coeffs) + return list(self._coeffs) else: - return self.__coeffs + return self._coeffs def degree(self, gen=None): """ @@ -11955,7 +11955,7 @@ cdef class Polynomial_generic_dense(Polynomial): """ - return smallInteger(len(self.__coeffs) - 1) + return smallInteger(len(self._coeffs) - 1) def shift(self, Py_ssize_t n): r""" @@ -11993,13 +11993,13 @@ cdef class Polynomial_generic_dense(Polynomial): return self if n > 0: output = [self.base_ring().zero()] * n - output.extend(self.__coeffs) + output.extend(self._coeffs) return self._new_c(output, self._parent) if n < 0: - if n > len(self.__coeffs) - 1: + if n > len(self._coeffs) - 1: return self._parent([]) else: - return self._new_c(self.__coeffs[-int(n):], self._parent) + return self._new_c(self._coeffs[-int(n):], self._parent) @coerce_binop def quo_rem(self, other): @@ -12073,8 +12073,8 @@ cdef class Polynomial_generic_dense(Polynomial): return self, self R = self._parent.base_ring() - cdef list x = list((self).__coeffs) # make a copy - cdef list y = (other).__coeffs + cdef list x = list((self)._coeffs) # make a copy + cdef list y = (other)._coeffs cdef Py_ssize_t m = len(x) # deg(self)=m-1 cdef Py_ssize_t n = len(y) # deg(other)=n-1 if m < n: @@ -12135,18 +12135,18 @@ cdef class Polynomial_generic_dense(Polynomial): sage: type(f) """ - l = len(self.__coeffs) + l = len(self._coeffs) if n > l: n = l - while n > 0 and not self.__coeffs[n-1]: + while n > 0 and not self._coeffs[n-1]: n -= 1 - return self._new_c(self.__coeffs[:n], self._parent) + return self._new_c(self._coeffs[:n], self._parent) cdef _inplace_truncate(self, long n): - if n < len(self.__coeffs): - while n > 0 and not self.__coeffs[n-1]: + if n < len(self._coeffs): + while n > 0 and not self._coeffs[n-1]: n -= 1 - self.__coeffs = self.__coeffs[:n] + self._coeffs = self._coeffs[:n] return self def make_generic_polynomial(parent, coeffs): @@ -12316,7 +12316,7 @@ cdef class Polynomial_generic_dense_inexact(Polynomial_generic_dense): sage: S([1, R(0, 20)]) # needs sage.rings.padics O(5^20)*x + 1 + O(5^20) """ - cdef list x = self.__coeffs + cdef list x = self._coeffs cdef Py_ssize_t n = len(x) - 1 cdef RingElement c while n >= 0: @@ -12376,7 +12376,7 @@ cdef class Polynomial_generic_dense_inexact(Polynomial_generic_dense): - Xavier Caruso (2013-03) """ - coeffs = self.__coeffs + coeffs = self._coeffs d = len(coeffs) - 1 while d >= 0: c = coeffs[d] @@ -12420,7 +12420,7 @@ cdef class Polynomial_generic_dense_inexact(Polynomial_generic_dense): - Xavier Caruso (2013-03) """ - return len(self.__coeffs) - 1 + return len(self._coeffs) - 1 cdef class ConstantPolynomialSection(Map): From a59885c45dbf052cd02847754a74ed656eaa9c92 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:38:21 +0800 Subject: [PATCH 18/54] rename __ngens -> _ngens --- .../letterplace/free_algebra_letterplace.pxd | 4 +-- .../letterplace/free_algebra_letterplace.pyx | 34 +++++++++---------- .../multi_polynomial_libsingular.pyx | 8 ++--- .../polynomial/multi_polynomial_ring_base.pxd | 2 +- .../polynomial/multi_polynomial_ring_base.pyx | 10 +++--- src/sage/rings/polynomial/pbori/pbori.pyx | 2 +- src/sage/rings/polynomial/plural.pxd | 2 +- src/sage/rings/polynomial/plural.pyx | 14 ++++---- 8 files changed, 38 insertions(+), 38 deletions(-) diff --git a/src/sage/algebras/letterplace/free_algebra_letterplace.pxd b/src/sage/algebras/letterplace/free_algebra_letterplace.pxd index d1d162c3b40..5623a1bb6d4 100644 --- a/src/sage/algebras/letterplace/free_algebra_letterplace.pxd +++ b/src/sage/algebras/letterplace/free_algebra_letterplace.pxd @@ -20,13 +20,13 @@ cdef class FreeAlgebra_letterplace_libsingular(): cdef ring* _lp_ring cdef MPolynomialRing_libsingular _commutative_ring cdef MPolynomialRing_libsingular _lp_ring_internal - cdef object __ngens + cdef object _ngens cdef class FreeAlgebra_letterplace(Algebra): cdef MPolynomialRing_libsingular _commutative_ring cdef MPolynomialRing_libsingular _current_ring cdef int _degbound - cdef int __ngens + cdef int _ngens cdef int _nb_slackvars cdef object __monoid cdef public object __custom_name diff --git a/src/sage/algebras/letterplace/free_algebra_letterplace.pyx b/src/sage/algebras/letterplace/free_algebra_letterplace.pyx index e9c70c9de29..53f0dfdea6d 100644 --- a/src/sage/algebras/letterplace/free_algebra_letterplace.pyx +++ b/src/sage/algebras/letterplace/free_algebra_letterplace.pyx @@ -255,7 +255,7 @@ cdef class FreeAlgebra_letterplace(Algebra): """ if not isinstance(R, MPolynomialRing_libsingular): raise TypeError("a letterplace algebra must be provided by a polynomial ring of type %s" % MPolynomialRing_libsingular) - self.__ngens = R.ngens() + self._ngens = R.ngens() if degrees is None: varnames = R.variable_names() self._nb_slackvars = 0 @@ -269,12 +269,12 @@ cdef class FreeAlgebra_letterplace(Algebra): self._current_ring = make_letterplace_ring(R, 1) self._degbound = 1 if degrees is None: - self._degrees = tuple([int(1)] * self.__ngens) + self._degrees = tuple([int(1)] * self._ngens) else: if (not isinstance(degrees, (tuple, list))) \ - or len(degrees) != self.__ngens - self._nb_slackvars \ + or len(degrees) != self._ngens - self._nb_slackvars \ or any(i <= 0 for i in degrees): - raise TypeError("the generator degrees must be given by a list or tuple of %d positive integers" % (self.__ngens - 1)) + raise TypeError("the generator degrees must be given by a list or tuple of %d positive integers" % (self._ngens - 1)) self._degrees = tuple([int(i) for i in degrees]) self.set_degbound(max(self._degrees)) self._populate_coercion_lists_(coerce_list=[base_ring]) @@ -305,7 +305,7 @@ cdef class FreeAlgebra_letterplace(Algebra): sage: F.ngens() 3 """ - return self.__ngens - self._nb_slackvars + return self._ngens - self._nb_slackvars def gen(self, i): """ @@ -327,17 +327,17 @@ cdef class FreeAlgebra_letterplace(Algebra): sage: F.gen(2) c """ - if i >= self.__ngens - self._nb_slackvars: - raise ValueError("this free algebra only has %d generators" % (self.__ngens - self._nb_slackvars)) + if i >= self._ngens - self._nb_slackvars: + raise ValueError("this free algebra only has %d generators" % (self._ngens - self._nb_slackvars)) if self._gens is not None: return self._gens[i] deg = self._degrees[i] # self.set_degbound(deg) p = self._current_ring.gen(i) cdef int n - cdef int j = self.__ngens - 1 + cdef int j = self._ngens - 1 for n in range(1, deg): - j += self.__ngens + j += self._ngens p *= self._current_ring.gen(j) return FreeAlgebraElement_letterplace(self, p) @@ -413,7 +413,7 @@ cdef class FreeAlgebra_letterplace(Algebra): sage: FreeAlgebra(QQ, implementation='letterplace', names=['x']).is_commutative() True """ - return self.__ngens - self._nb_slackvars <= 1 + return self._ngens - self._nb_slackvars <= 1 def is_field(self, proof=True): """ @@ -430,7 +430,7 @@ cdef class FreeAlgebra_letterplace(Algebra): sage: F.is_field() False """ - return (not (self.__ngens - self._nb_slackvars)) and self._base.is_field(proof=proof) + return (not (self._ngens - self._nb_slackvars)) and self._base.is_field(proof=proof) def _repr_(self): """ @@ -446,7 +446,7 @@ cdef class FreeAlgebra_letterplace(Algebra): sage: F Free Associative Unital Algebra on 3 generators (x, y, z) over Rational Field """ - return "Free Associative Unital Algebra on %d generators %s over %s" % (self.__ngens - self._nb_slackvars, self.gens(), self._base) + return "Free Associative Unital Algebra on %d generators %s over %s" % (self._ngens - self._nb_slackvars, self.gens(), self._base) def _latex_(self): r""" @@ -586,7 +586,7 @@ cdef class FreeAlgebra_letterplace(Algebra): generated free abelian monoid. In principle, this is correct, but it is not implemented, yet.> """ - cdef int ngens = self.__ngens + cdef int ngens = self._ngens cdef int nblocks = len(E) // ngens cdef int i, j, base, exp, var_ind cdef list out = [] @@ -618,7 +618,7 @@ cdef class FreeAlgebra_letterplace(Algebra): sage: latex(-(a*b*(z+1)-c)^2) # indirect doctest \left(2 z + 1\right) a b a b + \left(z + 1\right) a b c + \left(z + 1\right) c a b - c c """ - cdef int ngens = self.__ngens + cdef int ngens = self._ngens cdef int nblocks = len(E) // ngens cdef int i, j, base, exp, var_ind cdef list out = [] @@ -678,7 +678,7 @@ cdef class FreeAlgebra_letterplace(Algebra): cdef list out = [] C = self.current_ring() cdef FreeAlgebraElement_letterplace x - ngens = self.__ngens + ngens = self._ngens cdef list G = [C(x._poly) for x in g] from sage.groups.perm_gps.permgroup_named import CyclicPermutationGroup CG = CyclicPermutationGroup(C.ngens()) @@ -811,7 +811,7 @@ cdef class FreeAlgebra_letterplace(Algebra): l = len(e) break cdef dict out = {} - self.set_degbound(l // self.__ngens) + self.set_degbound(l // self._ngens) cdef Py_ssize_t n = self._current_ring.ngens() for e, c in D.iteritems(): out[tuple(e) + (0,) * (n - l)] = c @@ -896,7 +896,7 @@ cdef class FreeAlgebra_letterplace_libsingular(): self._commutative_ring = commutative_ring def __init__(self, commutative_ring, degbound): - self.__ngens = commutative_ring.ngens() * degbound + self._ngens = commutative_ring.ngens() * degbound def __dealloc__(self): r""" diff --git a/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx b/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx index d796b7f8169..52a81dbf846 100644 --- a/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx +++ b/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx @@ -375,7 +375,7 @@ cdef class MPolynomialRing_libsingular(MPolynomialRing_base): ... NotImplementedError: polynomials in -1 variables are not supported in Singular """ - self.__ngens = n + self._ngens = n self._ring = singular_ring_new(base_ring, n, names, order) self._zero_element = new_MP(self, NULL) cdef MPolynomial_libsingular one = new_MP(self, p_ISet(1, self._ring)) @@ -1019,7 +1019,7 @@ cdef class MPolynomialRing_libsingular(MPolynomialRing_base): Multivariate Polynomial Ring in x, y over Rational Field """ varstr = ", ".join(char_to_str(rRingVar(i,self._ring)) - for i in range(self.__ngens)) + for i in range(self._ngens)) return "Multivariate Polynomial Ring in %s over %s" % (varstr, self.base_ring()) def ngens(self): @@ -1037,7 +1037,7 @@ cdef class MPolynomialRing_libsingular(MPolynomialRing_base): sage: P.ngens() # needs sage.rings.finite_rings 1000 """ - return int(self.__ngens) + return int(self._ngens) def gen(self, int n=0): """ @@ -1065,7 +1065,7 @@ cdef class MPolynomialRing_libsingular(MPolynomialRing_base): cdef poly *_p cdef ring *_ring = self._ring - if n < 0 or n >= self.__ngens: + if n < 0 or n >= self._ngens: raise ValueError("Generator not defined.") rChangeCurrRing(_ring) diff --git a/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd b/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd index fc81cf6d298..e54dd1e9ce6 100644 --- a/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd +++ b/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd @@ -2,7 +2,7 @@ cimport sage.rings.ring from sage.structure.parent cimport Parent cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): - cdef object __ngens + cdef object _ngens cdef object __term_order cdef public object _has_singular cdef public object _magma_gens diff --git a/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx b/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx index 1d3fbc60944..d5388ba7342 100644 --- a/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx +++ b/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx @@ -80,7 +80,7 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): raise ValueError("Multivariate Polynomial Rings must " "have more than 0 variables.") order = TermOrder(order, n) - self.__ngens = n + self._ngens = n self.__term_order = order self._has_singular = False # cannot convert to Singular by default self._magma_cache = {} @@ -639,10 +639,10 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): lft = left other = right - lx = (lft.base_ring(), lft.__ngens, + lx = (lft.base_ring(), lft._ngens, lft.variable_names(), lft.__term_order) - rx = (other.base_ring(), other.__ngens, + rx = (other.base_ring(), other._ngens, other.variable_names(), other.__term_order) return richcmp(lx, rx, op) @@ -867,7 +867,7 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): return self.base_ring().characteristic() def gen(self, n=0): - if n < 0 or n >= self.__ngens: + if n < 0 or n >= self._ngens: raise ValueError("Generator not defined.") return self._gens[int(n)] @@ -927,7 +927,7 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): return self.base_ring().krull_dimension() + self.ngens() def ngens(self): - return self.__ngens + return self._ngens def _monomial_order_function(self): raise NotImplementedError diff --git a/src/sage/rings/polynomial/pbori/pbori.pyx b/src/sage/rings/polynomial/pbori/pbori.pyx index 07cc696477a..314196faa14 100644 --- a/src/sage/rings/polynomial/pbori/pbori.pyx +++ b/src/sage/rings/polynomial/pbori/pbori.pyx @@ -547,7 +547,7 @@ cdef class BooleanPolynomialRing(BooleanPolynomialRing_base): """ return tuple(new_BP_from_PBVar(self, self._pbring.variable(self.pbind[i])) - for i in range(self.__ngens)) + for i in range(self._ngens)) def change_ring(self, base_ring=None, names=None, order=None): """ diff --git a/src/sage/rings/polynomial/plural.pxd b/src/sage/rings/polynomial/plural.pxd index 41db2a144e7..5d05e4d0e25 100644 --- a/src/sage/rings/polynomial/plural.pxd +++ b/src/sage/rings/polynomial/plural.pxd @@ -13,7 +13,7 @@ cdef extern from *: ctypedef long Py_hash_t cdef class NCPolynomialRing_plural(Ring): - cdef object __ngens + cdef object _ngens cdef object _c cdef object _d cdef object __term_order diff --git a/src/sage/rings/polynomial/plural.pyx b/src/sage/rings/polynomial/plural.pyx index a647d68e08d..a98a04b2ef5 100644 --- a/src/sage/rings/polynomial/plural.pyx +++ b/src/sage/rings/polynomial/plural.pyx @@ -336,7 +336,7 @@ cdef class NCPolynomialRing_plural(Ring): self._ring = singular_ring_reference(rw._ring) self._ring.ShortOut = 0 - self.__ngens = n + self._ngens = n self.__term_order = order Ring.__init__(self, base_ring, names, category=category) @@ -727,7 +727,7 @@ cdef class NCPolynomialRing_plural(Ring): from sage.repl.rich_output.backend_base import BackendBase from sage.repl.display.pretty_print import SagePrettyPrinter varstr = ", ".join(char_to_str(rRingVar(i, self._ring)) - for i in range(self.__ngens)) + for i in range(self._ngens)) backend = BackendBase() relations = backend._apply_pretty_printer(SagePrettyPrinter, self.relations()) @@ -830,7 +830,7 @@ cdef class NCPolynomialRing_plural(Ring): sage: P.ngens() 3 """ - return int(self.__ngens) + return int(self._ngens) def gen(self, int n=0): """ @@ -857,7 +857,7 @@ cdef class NCPolynomialRing_plural(Ring): cdef poly *_p cdef ring *_ring = self._ring - if n < 0 or n >= self.__ngens: + if n < 0 or n >= self._ngens: raise ValueError("Generator not defined.") rChangeCurrRing(_ring) @@ -2352,7 +2352,7 @@ cdef class NCPolynomial_plural(RingElement): except TypeError: x = (x,) - if len(x) != (self._parent).__ngens: + if len(x) != (self._parent)._ngens: raise TypeError("x must have length self.ngens()") m = p_ISet(1,r) @@ -2890,7 +2890,7 @@ cpdef MPolynomialRing_libsingular new_CRing(RingWrap rw, base_ring): self._ring.ShortOut = 0 - self.__ngens = rw.ngens() + self._ngens = rw.ngens() self.__term_order = TermOrder(rw.ordering_string(), force=True) ParentWithGens.__init__(self, base_ring, tuple(rw.var_names()), @@ -2962,7 +2962,7 @@ cpdef NCPolynomialRing_plural new_NRing(RingWrap rw, base_ring): self._ring.ShortOut = 0 - self.__ngens = rw.ngens() + self._ngens = rw.ngens() self.__term_order = TermOrder(rw.ordering_string(), force=True) ParentWithGens.__init__(self, base_ring, rw.var_names()) From 5caf2caf197126c403da1da6a94063db92cec9fa Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 15:42:50 +0800 Subject: [PATCH 19/54] rename __ideal_monoid -> _ideal_monoid --- src/sage/rings/ring.pxd | 2 +- src/sage/rings/ring.pyx | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/sage/rings/ring.pxd b/src/sage/rings/ring.pxd index 9384f39f258..1322697688f 100644 --- a/src/sage/rings/ring.pxd +++ b/src/sage/rings/ring.pxd @@ -7,7 +7,7 @@ cdef class Ring(ParentWithGens): cdef public object _one_element cdef public object _zero_ideal cdef public object _unit_ideal - cdef public object __ideal_monoid + cdef public object _ideal_monoid cdef class CommutativeRing(Ring): diff --git a/src/sage/rings/ring.pyx b/src/sage/rings/ring.pyx index 4cba2c9ba7f..8acf4383270 100644 --- a/src/sage/rings/ring.pyx +++ b/src/sage/rings/ring.pyx @@ -325,12 +325,12 @@ cdef class Ring(ParentWithGens): by the ideal (x*y + y*z, x*x + x*y - y*x - y*y) """ - if self.__ideal_monoid is not None: - return self.__ideal_monoid + if self._ideal_monoid is not None: + return self._ideal_monoid else: from sage.rings.noncommutative_ideals import IdealMonoid_nc M = IdealMonoid_nc(self) - self.__ideal_monoid = M + self._ideal_monoid = M return M def ideal(self, *args, **kwds): @@ -1106,12 +1106,12 @@ cdef class Ring(ParentWithGens): sage: R.=QQ[]; R.ideal_monoid() Monoid of ideals of Univariate Polynomial Ring in x over Rational Field """ - if self.__ideal_monoid is not None: - return self.__ideal_monoid + if self._ideal_monoid is not None: + return self._ideal_monoid else: from sage.rings.ideal_monoid import IdealMonoid M = IdealMonoid(self) - self.__ideal_monoid = M + self._ideal_monoid = M return M @cached_method @@ -1345,12 +1345,12 @@ cdef class CommutativeRing(Ring): sage: R.=QQ[]; R.ideal_monoid() Monoid of ideals of Univariate Polynomial Ring in x over Rational Field """ - if self.__ideal_monoid is not None: - return self.__ideal_monoid + if self._ideal_monoid is not None: + return self._ideal_monoid else: from sage.rings.ideal_monoid import IdealMonoid M = IdealMonoid(self) - self.__ideal_monoid = M + self._ideal_monoid = M return M def extension(self, poly, name=None, names=None, **kwds): From 230ebf857d846df755414bc80e6554033e69a08a Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:39:44 +0800 Subject: [PATCH 20/54] rename __allocated -> _allocated --- src/sage/rings/padics/pow_computer.pxd | 2 +- src/sage/rings/padics/pow_computer.pyx | 6 +++--- src/sage/rings/padics/pow_computer_flint.pyx | 12 ++++++------ src/sage/rings/padics/pow_computer_relative.pyx | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/sage/rings/padics/pow_computer.pxd b/src/sage/rings/padics/pow_computer.pxd index 2a93e42254e..8766725882e 100644 --- a/src/sage/rings/padics/pow_computer.pxd +++ b/src/sage/rings/padics/pow_computer.pxd @@ -6,7 +6,7 @@ cdef class PowComputer_class(SageObject): cdef Integer prime cdef Integer p2 # floor(p/2) cdef bint in_field - cdef int __allocated + cdef int _allocated cdef public object _prec_type cdef long ram_prec_cap # = prec_cap * e diff --git a/src/sage/rings/padics/pow_computer.pyx b/src/sage/rings/padics/pow_computer.pyx index c2fa8031086..1c5bdf86897 100644 --- a/src/sage/rings/padics/pow_computer.pyx +++ b/src/sage/rings/padics/pow_computer.pyx @@ -65,7 +65,7 @@ cdef class PowComputer_class(SageObject): sig_on() mpz_init(self.temp_m) sig_off() - self.__allocated = 1 + self._allocated = 1 def __init__(self, Integer prime, long cache_limit, long prec_cap, long ram_prec_cap, bint in_field, poly=None, shift_seed=None): """ @@ -485,7 +485,7 @@ cdef class PowComputer_base(PowComputer_class): finally: sig_off() - self.__allocated = 2 + self._allocated = 2 def __init__(self, Integer prime, long cache_limit, long prec_cap, long ram_prec_cap, bint in_field, poly=None, shift_seed=None): """ @@ -529,7 +529,7 @@ cdef class PowComputer_base(PowComputer_class): """ cdef Py_ssize_t i - if self.__allocated >= 2: + if self._allocated >= 2: for i in range(self.cache_limit + 1): mpz_clear(self.small_powers[i]) mpz_clear(self.top_power) diff --git a/src/sage/rings/padics/pow_computer_flint.pyx b/src/sage/rings/padics/pow_computer_flint.pyx index 9f914defcc6..ae9e9f954a2 100644 --- a/src/sage/rings/padics/pow_computer_flint.pyx +++ b/src/sage/rings/padics/pow_computer_flint.pyx @@ -59,7 +59,7 @@ cdef class PowComputer_flint(PowComputer_class): finally: sig_off() - self.__allocated = 4 + self._allocated = 4 def __init__(self, Integer prime, long cache_limit, long prec_cap, long ram_prec_cap, bint in_field, poly=None, shift_seed=None): """ @@ -87,7 +87,7 @@ cdef class PowComputer_flint(PowComputer_class): sage: A = PowComputer_flint(5, 20, 20, 20, False) sage: del A """ - if self.__allocated >= 4: + if self._allocated >= 4: fmpz_clear(self.fprime) fmpz_clear(self.half_prime) fmpz_clear(self._fpow_variable) @@ -251,7 +251,7 @@ cdef class PowComputer_flint_1step(PowComputer_flint): finally: sig_off() - self.__allocated = 8 + self._allocated = 8 def __init__(self, Integer prime, long cache_limit, long prec_cap, long ram_prec_cap, bint in_field, _poly, shift_seed=None): """ @@ -296,7 +296,7 @@ cdef class PowComputer_flint_1step(PowComputer_flint): """ cdef Py_ssize_t i - if self.__allocated >= 8: + if self._allocated >= 8: fmpz_clear(self.q) fmpz_poly_clear(self.modulus) fmpz_poly_clear(self.powhelper_oneunit) @@ -501,7 +501,7 @@ cdef class PowComputer_flint_unram(PowComputer_flint_1step): mpz_init(self.mpz_matmod) sig_off() - self.__allocated = 16 + self._allocated = 16 def __dealloc__(self): """ @@ -515,7 +515,7 @@ cdef class PowComputer_flint_unram(PowComputer_flint_1step): sage: del A """ - if self.__allocated >= 16: + if self._allocated >= 16: fmpz_clear(self.fmpz_ccmp) fmpz_clear(self.fmpz_cval) fmpz_clear(self.fmpz_cinv) diff --git a/src/sage/rings/padics/pow_computer_relative.pyx b/src/sage/rings/padics/pow_computer_relative.pyx index 39051a681de..2253281bd35 100644 --- a/src/sage/rings/padics/pow_computer_relative.pyx +++ b/src/sage/rings/padics/pow_computer_relative.pyx @@ -69,7 +69,7 @@ cdef class PowComputer_relative(PowComputer_class): sage: PC = PowComputer_relative_maker(3, 20, 20, 60, False, f, shift_seed, 'fixed-mod') """ - self.__allocated = 4 + self._allocated = 4 def __init__(self, Integer prime, long cache_limit, long prec_cap, long ram_prec_cap, bint in_field, poly, shift_seed): r""" From 6c39b64158bdef1165fde0550208d56fa8b26ece Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:40:17 +0800 Subject: [PATCH 21/54] rename __denominator -> _denominator --- .../quatalg/quaternion_algebra_element.pyx | 10 +- src/sage/matrix/matrix_cyclo_dense.pyx | 2 +- src/sage/rings/fraction_field_element.pyx | 100 +++++++++--------- .../number_field/number_field_element.pxd | 2 +- .../number_field/number_field_element.pyx | 84 +++++++-------- .../number_field_element_quadratic.pyx | 4 +- 6 files changed, 101 insertions(+), 101 deletions(-) diff --git a/src/sage/algebras/quatalg/quaternion_algebra_element.pyx b/src/sage/algebras/quatalg/quaternion_algebra_element.pyx index f6e87440fe9..0e93d2f3f55 100644 --- a/src/sage/algebras/quatalg/quaternion_algebra_element.pyx +++ b/src/sage/algebras/quatalg/quaternion_algebra_element.pyx @@ -1705,10 +1705,10 @@ cdef class QuaternionAlgebraElement_number_field(QuaternionAlgebraElement_abstra fmpz_poly_set_ZZX(self.z, (z).__numerator) fmpz_poly_set_ZZX(self.w, (w).__numerator) - ZZ_to_mpz(T1, &(x).__denominator) - ZZ_to_mpz(T2, &(y).__denominator) - ZZ_to_mpz(t3, &(z).__denominator) - ZZ_to_mpz(t4, &(w).__denominator) + ZZ_to_mpz(T1, &(x)._denominator) + ZZ_to_mpz(T2, &(y)._denominator) + ZZ_to_mpz(t3, &(z)._denominator) + ZZ_to_mpz(t4, &(w)._denominator) mpz_lcm(self.d, T1, T2) mpz_lcm(self.d, self.d, t3) @@ -1766,7 +1766,7 @@ cdef class QuaternionAlgebraElement_number_field(QuaternionAlgebraElement_abstra else: raise IndexError("quaternion element index out of range") - mpz_to_ZZ(&item.__denominator, self.d) + mpz_to_ZZ(&item._denominator, self.d) return item diff --git a/src/sage/matrix/matrix_cyclo_dense.pyx b/src/sage/matrix/matrix_cyclo_dense.pyx index 15ff6394951..36513526259 100644 --- a/src/sage/matrix/matrix_cyclo_dense.pyx +++ b/src/sage/matrix/matrix_cyclo_dense.pyx @@ -400,7 +400,7 @@ cdef class Matrix_cyclo_dense(Matrix_dense): # Set the denominator of x to denom. fmpz_get_mpz(tmp, denom) - mpz_to_ZZ(&x.__denominator, tmp) + mpz_to_ZZ(&x._denominator, tmp) fmpz_clear(denom) mpz_clear(tmp) fmpz_clear(ftmp) diff --git a/src/sage/rings/fraction_field_element.pyx b/src/sage/rings/fraction_field_element.pyx index 11a2b646d35..0ed690cb28e 100644 --- a/src/sage/rings/fraction_field_element.pyx +++ b/src/sage/rings/fraction_field_element.pyx @@ -79,7 +79,7 @@ cdef class FractionFieldElement(FieldElement): (1, 0) """ cdef object __numerator - cdef object __denominator + cdef object _denominator cdef bint _is_reduced def __init__(self, parent, numerator, denominator=1, @@ -109,16 +109,16 @@ cdef class FractionFieldElement(FieldElement): FieldElement.__init__(self, parent) if coerce: self.__numerator = parent.ring()(numerator) - self.__denominator = parent.ring()(denominator) + self._denominator = parent.ring()(denominator) else: self.__numerator = numerator - self.__denominator = denominator + self._denominator = denominator if reduce and parent.is_exact(): try: self.reduce() except ArithmeticError: pass - if self.__denominator.is_zero(): + if self._denominator.is_zero(): raise ZeroDivisionError("fraction field element division by zero") def _im_gens_(self, codomain, im_gens, base_map=None): @@ -155,7 +155,7 @@ cdef class FractionFieldElement(FieldElement): ((-i))/b """ nnum = codomain.coerce(self.__numerator._im_gens_(codomain, im_gens, base_map=base_map)) - nden = codomain.coerce(self.__denominator._im_gens_(codomain, im_gens, base_map=base_map)) + nden = codomain.coerce(self._denominator._im_gens_(codomain, im_gens, base_map=base_map)) return codomain.coerce(nnum/nden) cpdef reduce(self): @@ -191,10 +191,10 @@ cdef class FractionFieldElement(FieldElement): if self._is_reduced: return try: - g = self.__numerator.gcd(self.__denominator) + g = self.__numerator.gcd(self._denominator) if not g.is_unit(): self.__numerator //= g - self.__denominator //= g + self._denominator //= g self._is_reduced = True except AttributeError: raise ArithmeticError("unable to reduce because lack of gcd or quo_rem algorithm") @@ -202,14 +202,14 @@ cdef class FractionFieldElement(FieldElement): raise ArithmeticError("unable to reduce because gcd algorithm doesn't work on input") except NotImplementedError: raise ArithmeticError("unable to reduce because gcd algorithm not implemented on input") - if not self.__denominator.is_one() and self.__denominator.is_unit(): + if not self._denominator.is_one() and self._denominator.is_unit(): try: - inv = self.__denominator.inverse_of_unit() + inv = self._denominator.inverse_of_unit() except Exception: pass else: self.__numerator *= inv - self.__denominator = self.__denominator.parent().one() + self._denominator = self._denominator.parent().one() def __copy__(self): """ @@ -224,7 +224,7 @@ cdef class FractionFieldElement(FieldElement): (x + y)/y """ return self.__class__(self._parent, self.__numerator, - self.__denominator, coerce=False, reduce=False) + self._denominator, coerce=False, reduce=False) def numerator(self): """ @@ -252,7 +252,7 @@ cdef class FractionFieldElement(FieldElement): sage: f.denominator() y """ - return self.__denominator + return self._denominator def is_square(self,root=False): @@ -399,7 +399,7 @@ cdef class FractionFieldElement(FieldElement): sage: ((x+1)/(x^2+1)).subs({x: 1}) # optional - sage.rings.number_field 1 """ - if self.__denominator.is_one(): + if self._denominator.is_one(): # Handle this case even over rings that don't support reduction, to # avoid breaking existing code that carelessly mixes p and p/1 return hash(self.__numerator) @@ -414,7 +414,7 @@ cdef class FractionFieldElement(FieldElement): self.reduce() # Same algorithm as for elements of QQ n = hash(self.__numerator) - d = hash(self.__denominator) + d = hash(self._denominator) if d == 1: return n else: @@ -443,7 +443,7 @@ cdef class FractionFieldElement(FieldElement): sage: h(x0=1) (-2*x1*x2 + x1 + 1)/(x1 + x2) """ - return self.__numerator(*x, **kwds) / self.__denominator(*x, **kwds) + return self.__numerator(*x, **kwds) / self._denominator(*x, **kwds) def _is_atomic(self): """ @@ -456,7 +456,7 @@ cdef class FractionFieldElement(FieldElement): sage: f._is_atomic() False """ - return self.__numerator._is_atomic() and self.__denominator._is_atomic() + return self.__numerator._is_atomic() and self._denominator._is_atomic() def _repr_(self): """ @@ -477,9 +477,9 @@ cdef class FractionFieldElement(FieldElement): if self.is_zero(): return "0" s = "%s" % self.__numerator - if self.__denominator != 1: - denom_string = str( self.__denominator ) - if self.__denominator._is_atomic() and not ('*' in denom_string or '/' in denom_string): + if self._denominator != 1: + denom_string = str( self._denominator ) + if self._denominator._is_atomic() and not ('*' in denom_string or '/' in denom_string): s = "%s/%s"%(self.__numerator._coeff_repr(no_space=False),denom_string) else: s = "%s/(%s)"%(self.__numerator._coeff_repr(no_space=False),denom_string) @@ -518,10 +518,10 @@ cdef class FractionFieldElement(FieldElement): """ if self.is_zero(): return "0" - if self.__denominator == 1: + if self._denominator == 1: return latex.latex(self.__numerator) return "\\frac{%s}{%s}"%(latex.latex(self.__numerator), - latex.latex(self.__denominator)) + latex.latex(self._denominator)) def _magma_init_(self, magma): """ @@ -578,9 +578,9 @@ cdef class FractionFieldElement(FieldElement): (t^2 + 6)/t """ rnum = self.__numerator - rden = self.__denominator + rden = self._denominator snum = ( right).__numerator - sden = ( right).__denominator + sden = ( right)._denominator if (rnum.is_zero()): return right @@ -602,7 +602,7 @@ cdef class FractionFieldElement(FieldElement): self._parent.ring().one(), coerce=False, reduce=False) else: - tden = self.__denominator * sden + tden = self._denominator * sden e = tnum.gcd(d) if not e.is_unit(): tnum = tnum // e @@ -625,9 +625,9 @@ cdef class FractionFieldElement(FieldElement): pass rnum = self.__numerator - rden = self.__denominator + rden = self._denominator snum = ( right).__numerator - sden = ( right).__denominator + sden = ( right)._denominator return self.__class__(self._parent, rnum*sden + rden*snum, rden*sden, coerce=False, reduce=False) @@ -653,9 +653,9 @@ cdef class FractionFieldElement(FieldElement): 3/(t + 1) """ rnum = self.__numerator - rden = self.__denominator + rden = self._denominator snum = ( right).__numerator - sden = ( right).__denominator + sden = ( right)._denominator if (rnum.is_zero() or snum.is_zero()): return self._parent.zero() @@ -690,9 +690,9 @@ cdef class FractionFieldElement(FieldElement): pass rnum = self.__numerator - rden = self.__denominator + rden = self._denominator snum = ( right).__numerator - sden = ( right).__denominator + sden = ( right)._denominator return self.__class__(self._parent, rnum * snum, rden * sden, coerce=False, reduce=False) @@ -718,7 +718,7 @@ cdef class FractionFieldElement(FieldElement): (x*z - x + z - 1)/(z - 3) """ snum = ( right).__numerator - sden = ( right).__denominator + sden = ( right)._denominator if snum.is_zero(): raise ZeroDivisionError("fraction field element division by zero") @@ -743,9 +743,9 @@ cdef class FractionFieldElement(FieldElement): sage: int(K(.5)) 0 """ - if self.__denominator != 1: + if self._denominator != 1: self.reduce() - if self.__denominator == 1: + if self._denominator == 1: return int(self.__numerator) else: raise TypeError("denominator must equal 1") @@ -758,7 +758,7 @@ cdef class FractionFieldElement(FieldElement): sage: float(x/x + y/y) 2.0 """ - return float(self.__numerator) / float(self.__denominator) + return float(self.__numerator) / float(self._denominator) def __complex__(self): """ @@ -768,7 +768,7 @@ cdef class FractionFieldElement(FieldElement): sage: complex(x/(I*x) + (I*y)/y) 0j """ - return complex(self.__numerator) / complex(self.__denominator) + return complex(self.__numerator) / complex(self._denominator) def _rational_(self): r""" @@ -822,12 +822,12 @@ cdef class FractionFieldElement(FieldElement): sage: A(C(u)) # optional - sage.rings.number_field u """ - if self.__denominator.is_one(): + if self._denominator.is_one(): return R(self.__numerator) else: self.reduce() num = R(self.__numerator) - inv_den = R(self.__denominator).inverse_of_unit() + inv_den = R(self._denominator).inverse_of_unit() return num * inv_den _real_double_ = _conversion @@ -847,7 +847,7 @@ cdef class FractionFieldElement(FieldElement): Returns self raised to the `right^{th}` power. Note that we need to check whether or not right is negative so we - don't set ``__numerator`` or ``__denominator`` to an element of the + don't set ``__numerator`` or ``_denominator`` to an element of the fraction field instead of the underlying ring. EXAMPLES:: @@ -877,7 +877,7 @@ cdef class FractionFieldElement(FieldElement): 1 """ snum = ( self).__numerator - sden = ( self).__denominator + sden = ( self)._denominator if right == 0: R = self.parent().ring() return self.__class__(self.parent(), @@ -904,7 +904,7 @@ cdef class FractionFieldElement(FieldElement): (4*t^2 + 4*t)/(t + 2) """ return self.__class__(self._parent, - -self.__numerator, self.__denominator, + -self.__numerator, self._denominator, coerce=False, reduce=False) def __abs__(self): @@ -915,7 +915,7 @@ cdef class FractionFieldElement(FieldElement): sage: abs(FractionFieldElement(QQ, -2, 3, coerce=False)) 2/3 """ - return abs(self.__numerator) / abs(self.__denominator) + return abs(self.__numerator) / abs(self._denominator) def __invert__(self): """ @@ -929,7 +929,7 @@ cdef class FractionFieldElement(FieldElement): if self.is_zero(): raise ZeroDivisionError("Cannot invert 0") return self.__class__(self._parent, - self.__denominator, self.__numerator, coerce=False, reduce=False) + self._denominator, self.__numerator, coerce=False, reduce=False) cpdef _richcmp_(self, other, int op): """ @@ -952,8 +952,8 @@ cdef class FractionFieldElement(FieldElement): False """ return richcmp(self.__numerator * - (other).__denominator, - self.__denominator * + (other)._denominator, + self._denominator * (other).__numerator, op) def valuation(self, v=None): @@ -972,7 +972,7 @@ cdef class FractionFieldElement(FieldElement): sage: f.valuation(x^2 + 1) 1 """ - return self.__numerator.valuation(v) - self.__denominator.valuation(v) + return self.__numerator.valuation(v) - self._denominator.valuation(v) def __bool__(self): """ @@ -1025,7 +1025,7 @@ cdef class FractionFieldElement(FieldElement): sage: (x/y).is_one() False """ - return self.__numerator == self.__denominator + return self.__numerator == self._denominator def _symbolic_(self, ring): """ @@ -1044,7 +1044,7 @@ cdef class FractionFieldElement(FieldElement): sage: symbolic_expression(elt) # optional - sage.symbolic 2/3*(x + y)/(x - y) """ - return ring(self.__numerator)/ring(self.__denominator) + return ring(self.__numerator)/ring(self._denominator) def __reduce__(self): """ @@ -1058,7 +1058,7 @@ cdef class FractionFieldElement(FieldElement): True """ return (make_element, - (self._parent, self.__numerator, self.__denominator)) + (self._parent, self.__numerator, self._denominator)) def _evaluate_polynomial(self, pol): """ @@ -1170,8 +1170,8 @@ cdef class FractionFieldElement_1poly_field(FractionFieldElement): """ See :meth:`reduce`. """ - invlc = ~self.__denominator.leading_coefficient() - self.__denominator = self.__denominator.monic() + invlc = ~self._denominator.leading_coefficient() + self._denominator = self._denominator.monic() self.__numerator *= invlc def is_integral(self): diff --git a/src/sage/rings/number_field/number_field_element.pxd b/src/sage/rings/number_field/number_field_element.pxd index 9b6917223a0..dd2530caf45 100644 --- a/src/sage/rings/number_field/number_field_element.pxd +++ b/src/sage/rings/number_field/number_field_element.pxd @@ -12,7 +12,7 @@ from sage.libs.ntl.ntl_ZZ cimport ntl_ZZ cdef class NumberFieldElement(NumberFieldElement_base): cdef ZZX_c __numerator - cdef ZZ_c __denominator + cdef ZZ_c _denominator # Pointers to the defining polynomial (with numerator) for the field. # I keep these as pointers for arithmetic speed. cdef ntl_ZZX __fld_numerator diff --git a/src/sage/rings/number_field/number_field_element.pyx b/src/sage/rings/number_field/number_field_element.pyx index 27e33ad5be0..ed75c8539b7 100644 --- a/src/sage/rings/number_field/number_field_element.pyx +++ b/src/sage/rings/number_field/number_field_element.pyx @@ -325,12 +325,12 @@ cdef class NumberFieldElement(NumberFieldElement_base): # fast pathway mpz_to_ZZ(&coeff, (ZZ(f)).value) ZZX_SetCoeff( self.__numerator, 0, coeff ) - ZZ_conv_from_int( self.__denominator, 1 ) + ZZ_conv_from_int( self._denominator, 1 ) return elif isinstance(f, NumberFieldElement): if type(self) is type(f): self.__numerator = (f).__numerator - self.__denominator = (f).__denominator + self._denominator = (f)._denominator return else: f = f.polynomial() @@ -342,7 +342,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef long i den = f.denominator() - mpz_to_ZZ(&self.__denominator, (ZZ(den)).value) + mpz_to_ZZ(&self._denominator, (ZZ(den)).value) num = f * den for i from 0 <= i <= num.degree(): mpz_to_ZZ(&coeff, (ZZ(num[i])).value) @@ -418,7 +418,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef NumberFieldElement x = t.__new__(t) x._parent = new_parent x.__fld_numerator, x.__fld_denominator = new_parent.polynomial_ntl() - x.__denominator = self.__denominator + x._denominator = self._denominator cdef ZZX_c result cdef ZZ_c tmp cdef int i @@ -858,7 +858,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef int res # fast equality check - res = left.__numerator == _right.__numerator and left.__denominator == _right.__denominator + res = left.__numerator == _right.__numerator and left._denominator == _right._denominator if res: if op == Py_EQ or op == Py_GE or op == Py_LE: return True @@ -883,8 +883,8 @@ cdef class NumberFieldElement(NumberFieldElement_base): if P._embedded_real: mpz_init(ld) mpz_init(rd) - ZZ_to_mpz(ld, &left.__denominator) - ZZ_to_mpz(rd, &_right.__denominator) + ZZ_to_mpz(ld, &left._denominator) + ZZ_to_mpz(rd, &_right._denominator) v = P._get_embedding_approx(0) mpfi_init2(la, mpfi_get_prec(v.value)) @@ -951,7 +951,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # It seems like a simpler approach would be to simply generate # random integers for each coefficient of self.__numerator - # and an integer for self.__denominator. However, this would + # and an integer for self._denominator. However, this would # generate things with a fairly fixed shape: in particular, # we'd be very unlikely to get elements like 1/3*a^3 + 1/7, # or anything where the denominators are actually unrelated @@ -965,7 +965,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # set the denominator mpz_set_si(denom_temp.value, 1) - mpz_to_ZZ(&self.__denominator, (denom_temp).value) + mpz_to_ZZ(&self._denominator, (denom_temp).value) for i from 0 <= i < ZZX_deg(self.__fld_numerator.x): tmp_integer = (ZZ.random_element(x=num_bound, distribution=distribution)) @@ -989,7 +989,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # scale the numerators and set everything appropriately # first, the denominator (easy) - mpz_to_ZZ(&self.__denominator, (denom_temp).value) + mpz_to_ZZ(&self._denominator, (denom_temp).value) # now the coefficients themselves. for i from 0 <= i < ZZX_deg(self.__fld_numerator.x): @@ -1158,7 +1158,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): mpz_init(den) ZZX_getitem_as_mpz(num, &self.__numerator, 0) - ZZ_to_mpz(den, &self.__denominator) + ZZ_to_mpz(den, &self._denominator) ans = PY_NEW(Integer) mpz_fdiv_q(ans.value, num, den) @@ -1183,7 +1183,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): mpz_init(den) mpfi_init2(a, mpfi_get_prec(v.value)) - ZZ_to_mpz(den, &self.__denominator) + ZZ_to_mpz(den, &self._denominator) ZZX_evaluation_mpfi(a, self.__numerator, v.value) mpfi_div_z(a, a, den) @@ -2483,17 +2483,17 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef ZZ_c gcd cdef ZZ_c t1 cdef ZZX_c t2 - if ZZ_IsOne(self.__denominator): + if ZZ_IsOne(self._denominator): return ZZX_content(t1, self.__numerator) - ZZ_GCD(gcd, t1, self.__denominator) - if ZZ_sign(gcd) != ZZ_sign(self.__denominator): + ZZ_GCD(gcd, t1, self._denominator) + if ZZ_sign(gcd) != ZZ_sign(self._denominator): ZZ_negate(t1, gcd) gcd = t1 ZZX_div_ZZ(t2, self.__numerator, gcd) - ZZ_div(t1, self.__denominator, gcd) + ZZ_div(t1, self._denominator, gcd) self.__numerator = t2 - self.__denominator = t1 + self._denominator = t1 cpdef _add_(self, right): r""" @@ -2509,11 +2509,11 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef NumberFieldElement _right = right cdef ZZ_c g, q1, q2 x = self._new() - ZZ_GCD(g, self.__denominator, _right.__denominator) - ZZ_div(q1, self.__denominator, g) - ZZ_div(q2, _right.__denominator, g) - ZZ_mul(x.__denominator, q1, q2) - ZZ_mul(x.__denominator, x.__denominator, g) + ZZ_GCD(g, self._denominator, _right._denominator) + ZZ_div(q1, self._denominator, g) + ZZ_div(q2, _right._denominator, g) + ZZ_mul(x._denominator, q1, q2) + ZZ_mul(x._denominator, x._denominator, g) cdef ZZX_c t1, t2 ZZX_mul_ZZ(t1, self.__numerator, q2) ZZX_mul_ZZ(t2, _right.__numerator, q1) @@ -2534,11 +2534,11 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef NumberFieldElement _right = right cdef ZZ_c g, q1, q2 x = self._new() - ZZ_GCD(g, self.__denominator, _right.__denominator) - ZZ_div(q1, self.__denominator, g) - ZZ_div(q2, _right.__denominator, g) - ZZ_mul(x.__denominator, q1, q2) - ZZ_mul(x.__denominator, x.__denominator, g) + ZZ_GCD(g, self._denominator, _right._denominator) + ZZ_div(q1, self._denominator, g) + ZZ_div(q2, _right._denominator, g) + ZZ_mul(x._denominator, q1, q2) + ZZ_mul(x._denominator, x._denominator, g) cdef ZZX_c t1, t2 ZZX_mul_ZZ(t1, self.__numerator, q2) ZZX_mul_ZZ(t2, _right.__numerator, q1) @@ -2571,18 +2571,18 @@ cdef class NumberFieldElement(NumberFieldElement_base): sig_on() # MulMod doesn't handle non-monic polynomials. # Therefore, we handle the non-monic case entirely separately. - ZZ_mul(x.__denominator, self.__denominator, _right.__denominator) + ZZ_mul(x._denominator, self._denominator, _right._denominator) if ZZ_IsOne(ZZX_LeadCoeff(self.__fld_numerator.x)): ZZX_MulMod(x.__numerator, self.__numerator, _right.__numerator, self.__fld_numerator.x) else: ZZX_mul(x.__numerator, self.__numerator, _right.__numerator) if ZZX_deg(x.__numerator) >= ZZX_deg(self.__fld_numerator.x): ZZX_mul_ZZ( x.__numerator, x.__numerator, self.__fld_denominator.x ) - ZZX_mul_ZZ( temp, self.__fld_numerator.x, x.__denominator ) + ZZX_mul_ZZ( temp, self.__fld_numerator.x, x._denominator ) ZZ_power(temp1,ZZX_LeadCoeff(temp),ZZX_deg(x.__numerator)-ZZX_deg(self.__fld_numerator.x)+1) ZZX_PseudoRem(x.__numerator, x.__numerator, temp) - ZZ_mul(x.__denominator, x.__denominator, self.__fld_denominator.x) - ZZ_mul(x.__denominator, x.__denominator, temp1) + ZZ_mul(x._denominator, x._denominator, self.__fld_denominator.x) + ZZ_mul(x._denominator, x._denominator, temp1) sig_off() x._reduce_c_() return x @@ -2718,7 +2718,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef NumberFieldElement x x = self._new() ZZX_mul_long(x.__numerator, self.__numerator, -1) - x.__denominator = self.__denominator + x._denominator = self._denominator return x cpdef _copy_for_parent(self, Parent parent): @@ -2739,7 +2739,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef NumberFieldElement x x = self._new() x.__numerator = self.__numerator - x.__denominator = self.__denominator + x._denominator = self._denominator x._set_parent(parent) return x @@ -2835,8 +2835,8 @@ cdef class NumberFieldElement(NumberFieldElement_base): # but may fail if NTL runs out of FFT primes. x = self._new() sig_on() - ZZX_XGCD(x.__denominator, x.__numerator, temp, self.__numerator, self.__fld_numerator.x, 1) - ZZX_mul_ZZ(x.__numerator, x.__numerator, self.__denominator) + ZZX_XGCD(x._denominator, x.__numerator, temp, self.__numerator, self.__fld_numerator.x, 1) + ZZX_mul_ZZ(x.__numerator, x.__numerator, self._denominator) x._reduce_c_() sig_off() except NTLError: @@ -2882,7 +2882,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef Integer num = Integer.__new__(Integer) ZZX_getitem_as_mpz(num.value, &self.__numerator, 0) cdef Integer den = Integer.__new__(Integer) - ZZ_to_mpz(den.value, &self.__denominator) + ZZ_to_mpz(den.value, &self._denominator) return num / den def _algebraic_(self, parent): @@ -3276,7 +3276,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # magic number below is floor(2^63 / (2+sqrt(2))) h ^= mpz_pythonhash(z) + ( 2701463124188384701) + (h << 16) + (h >> 2) - ZZ_to_mpz(z, &self.__denominator) + ZZ_to_mpz(z, &self._denominator) # magic number below is floor((1+sqrt(5)) * 2^61) h += (mpz_pythonhash(z) - 1) * ( 7461864723258187525) @@ -3305,7 +3305,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef int i cdef mpz_t den mpz_init(den) - ZZ_to_mpz(den, &self.__denominator) + ZZ_to_mpz(den, &self._denominator) cdef int size = ZZX_deg(self.__numerator) + 1 cdef list coeffs = [None]*size for i in range(size): @@ -3325,7 +3325,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef void _ntl_denom_as_mpz(self, mpz_t z): cdef Integer denom = Integer.__new__(Integer) - ZZ_to_mpz(denom.value, &self.__denominator) + ZZ_to_mpz(denom.value, &self._denominator) mpz_set(z, denom.value) def denominator(self): @@ -3344,7 +3344,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): 15 """ cdef Integer ans = Integer.__new__(Integer) - ZZ_to_mpz(ans.value, &self.__denominator) + ZZ_to_mpz(ans.value, &self._denominator) return ans def _set_multiplicative_order(self, n): @@ -3475,7 +3475,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): False """ return ZZX_IsOne(self.__numerator) == 1 and \ - ZZ_IsOne(self.__denominator) == 1 + ZZ_IsOne(self._denominator) == 1 cpdef bint is_rational(self): r""" @@ -3527,7 +3527,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: K(1/2).is_integer() False """ - return ZZX_deg(self.__numerator) <= 0 and ZZ_IsOne(self.__denominator) == 1 + return ZZX_deg(self.__numerator) <= 0 and ZZ_IsOne(self._denominator) == 1 def trace(self, K=None): r""" diff --git a/src/sage/rings/number_field/number_field_element_quadratic.pyx b/src/sage/rings/number_field/number_field_element_quadratic.pyx index 0992e7cd527..a40edf7a867 100644 --- a/src/sage/rings/number_field/number_field_element_quadratic.pyx +++ b/src/sage/rings/number_field/number_field_element_quadratic.pyx @@ -611,7 +611,7 @@ cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute): x._parent = new_parent x.__fld_numerator, x.__fld_denominator = new_parent.polynomial_ntl() - x.__denominator = elt_den + x._denominator = elt_den cdef ZZX_c result cdef ZZ_c tmp cdef int i @@ -1643,7 +1643,7 @@ cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute): return res ################################################################################# -# We must override everything that makes uses of self.__numerator/__denominator +# We must override everything that makes uses of self.__numerator/_denominator ################################################################################# def __hash__(self): From 10b7918aea49d911ea0542dafb4615fb6182c8f4 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:40:31 +0800 Subject: [PATCH 22/54] rename __numerator -> _numerator --- .../quatalg/quaternion_algebra_element.pyx | 20 +-- src/sage/matrix/matrix_cyclo_dense.pyx | 2 +- src/sage/rings/fraction_field_element.pyx | 92 +++++++------- .../number_field/number_field_element.pxd | 2 +- .../number_field/number_field_element.pyx | 114 +++++++++--------- .../number_field_element_quadratic.pyx | 4 +- 6 files changed, 117 insertions(+), 117 deletions(-) diff --git a/src/sage/algebras/quatalg/quaternion_algebra_element.pyx b/src/sage/algebras/quatalg/quaternion_algebra_element.pyx index 0e93d2f3f55..b42182851fa 100644 --- a/src/sage/algebras/quatalg/quaternion_algebra_element.pyx +++ b/src/sage/algebras/quatalg/quaternion_algebra_element.pyx @@ -1700,10 +1700,10 @@ cdef class QuaternionAlgebraElement_number_field(QuaternionAlgebraElement_abstra x, y, z, w = v cdef NumberFieldElement a = (parent._base(parent._a)) cdef NumberFieldElement b = (parent._base(parent._b)) - fmpz_poly_set_ZZX(self.x, (x).__numerator) - fmpz_poly_set_ZZX(self.y, (y).__numerator) - fmpz_poly_set_ZZX(self.z, (z).__numerator) - fmpz_poly_set_ZZX(self.w, (w).__numerator) + fmpz_poly_set_ZZX(self.x, (x)._numerator) + fmpz_poly_set_ZZX(self.y, (y)._numerator) + fmpz_poly_set_ZZX(self.z, (z)._numerator) + fmpz_poly_set_ZZX(self.w, (w)._numerator) ZZ_to_mpz(T1, &(x)._denominator) ZZ_to_mpz(T2, &(y)._denominator) @@ -1724,8 +1724,8 @@ cdef class QuaternionAlgebraElement_number_field(QuaternionAlgebraElement_abstra fmpz_poly_scalar_mul_mpz(self.z, self.z, t3) fmpz_poly_scalar_mul_mpz(self.w, self.w, t4) - fmpz_poly_set_ZZX(self.a, a.__numerator) # we will assume that the denominator of a and b are 1 - fmpz_poly_set_ZZX(self.b, b.__numerator) + fmpz_poly_set_ZZX(self.a, a._numerator) # we will assume that the denominator of a and b are 1 + fmpz_poly_set_ZZX(self.b, b._numerator) fmpz_poly_set_ZZX(self.modulus, (x).__fld_numerator.x) # and same for the modulus @@ -1756,13 +1756,13 @@ cdef class QuaternionAlgebraElement_number_field(QuaternionAlgebraElement_abstra cdef NumberFieldElement item = el._new() if i == 0: - fmpz_poly_get_ZZX(item.__numerator, self.x) + fmpz_poly_get_ZZX(item._numerator, self.x) elif i == 1: - fmpz_poly_get_ZZX(item.__numerator, self.y) + fmpz_poly_get_ZZX(item._numerator, self.y) elif i == 2: - fmpz_poly_get_ZZX(item.__numerator, self.z) + fmpz_poly_get_ZZX(item._numerator, self.z) elif i == 3: - fmpz_poly_get_ZZX(item.__numerator, self.w) + fmpz_poly_get_ZZX(item._numerator, self.w) else: raise IndexError("quaternion element index out of range") diff --git a/src/sage/matrix/matrix_cyclo_dense.pyx b/src/sage/matrix/matrix_cyclo_dense.pyx index 36513526259..f1ed9af8403 100644 --- a/src/sage/matrix/matrix_cyclo_dense.pyx +++ b/src/sage/matrix/matrix_cyclo_dense.pyx @@ -396,7 +396,7 @@ cdef class Matrix_cyclo_dense(Matrix_dense): # Now set k-th entry of x's numerator to tmp fmpz_get_mpz(tmp, ftmp) mpz_to_ZZ(&coeff, tmp) - ZZX_SetCoeff(x.__numerator, k, coeff) + ZZX_SetCoeff(x._numerator, k, coeff) # Set the denominator of x to denom. fmpz_get_mpz(tmp, denom) diff --git a/src/sage/rings/fraction_field_element.pyx b/src/sage/rings/fraction_field_element.pyx index 0ed690cb28e..75e47af1299 100644 --- a/src/sage/rings/fraction_field_element.pyx +++ b/src/sage/rings/fraction_field_element.pyx @@ -78,7 +78,7 @@ cdef class FractionFieldElement(FieldElement): sage: F.one().quo_rem(F.one()) (1, 0) """ - cdef object __numerator + cdef object _numerator cdef object _denominator cdef bint _is_reduced @@ -108,10 +108,10 @@ cdef class FractionFieldElement(FieldElement): """ FieldElement.__init__(self, parent) if coerce: - self.__numerator = parent.ring()(numerator) + self._numerator = parent.ring()(numerator) self._denominator = parent.ring()(denominator) else: - self.__numerator = numerator + self._numerator = numerator self._denominator = denominator if reduce and parent.is_exact(): try: @@ -154,7 +154,7 @@ cdef class FractionFieldElement(FieldElement): sage: phi(i/a) # optional - sage.rings.number_field ((-i))/b """ - nnum = codomain.coerce(self.__numerator._im_gens_(codomain, im_gens, base_map=base_map)) + nnum = codomain.coerce(self._numerator._im_gens_(codomain, im_gens, base_map=base_map)) nden = codomain.coerce(self._denominator._im_gens_(codomain, im_gens, base_map=base_map)) return codomain.coerce(nnum/nden) @@ -191,9 +191,9 @@ cdef class FractionFieldElement(FieldElement): if self._is_reduced: return try: - g = self.__numerator.gcd(self._denominator) + g = self._numerator.gcd(self._denominator) if not g.is_unit(): - self.__numerator //= g + self._numerator //= g self._denominator //= g self._is_reduced = True except AttributeError: @@ -208,7 +208,7 @@ cdef class FractionFieldElement(FieldElement): except Exception: pass else: - self.__numerator *= inv + self._numerator *= inv self._denominator = self._denominator.parent().one() def __copy__(self): @@ -223,7 +223,7 @@ cdef class FractionFieldElement(FieldElement): sage: copy(f) (x + y)/y """ - return self.__class__(self._parent, self.__numerator, + return self.__class__(self._parent, self._numerator, self._denominator, coerce=False, reduce=False) def numerator(self): @@ -238,7 +238,7 @@ cdef class FractionFieldElement(FieldElement): sage: f.numerator() x + y """ - return self.__numerator + return self._numerator def denominator(self): """ @@ -402,7 +402,7 @@ cdef class FractionFieldElement(FieldElement): if self._denominator.is_one(): # Handle this case even over rings that don't support reduction, to # avoid breaking existing code that carelessly mixes p and p/1 - return hash(self.__numerator) + return hash(self._numerator) if self._parent.is_exact(): # May fail; let the exception propagate then. # (In contrast, over inexact rings, we hash unreduced fractions @@ -413,7 +413,7 @@ cdef class FractionFieldElement(FieldElement): # issues even if we didn't...) self.reduce() # Same algorithm as for elements of QQ - n = hash(self.__numerator) + n = hash(self._numerator) d = hash(self._denominator) if d == 1: return n @@ -443,7 +443,7 @@ cdef class FractionFieldElement(FieldElement): sage: h(x0=1) (-2*x1*x2 + x1 + 1)/(x1 + x2) """ - return self.__numerator(*x, **kwds) / self._denominator(*x, **kwds) + return self._numerator(*x, **kwds) / self._denominator(*x, **kwds) def _is_atomic(self): """ @@ -456,7 +456,7 @@ cdef class FractionFieldElement(FieldElement): sage: f._is_atomic() False """ - return self.__numerator._is_atomic() and self._denominator._is_atomic() + return self._numerator._is_atomic() and self._denominator._is_atomic() def _repr_(self): """ @@ -476,13 +476,13 @@ cdef class FractionFieldElement(FieldElement): """ if self.is_zero(): return "0" - s = "%s" % self.__numerator + s = "%s" % self._numerator if self._denominator != 1: denom_string = str( self._denominator ) if self._denominator._is_atomic() and not ('*' in denom_string or '/' in denom_string): - s = "%s/%s"%(self.__numerator._coeff_repr(no_space=False),denom_string) + s = "%s/%s"%(self._numerator._coeff_repr(no_space=False),denom_string) else: - s = "%s/(%s)"%(self.__numerator._coeff_repr(no_space=False),denom_string) + s = "%s/(%s)"%(self._numerator._coeff_repr(no_space=False),denom_string) return s def _latex_(self): @@ -519,8 +519,8 @@ cdef class FractionFieldElement(FieldElement): if self.is_zero(): return "0" if self._denominator == 1: - return latex.latex(self.__numerator) - return "\\frac{%s}{%s}"%(latex.latex(self.__numerator), + return latex.latex(self._numerator) + return "\\frac{%s}{%s}"%(latex.latex(self._numerator), latex.latex(self._denominator)) def _magma_init_(self, magma): @@ -577,9 +577,9 @@ cdef class FractionFieldElement(FieldElement): sage: t - 1/t # indirect doctest # optional - sage.rings.finite_rings (t^2 + 6)/t """ - rnum = self.__numerator + rnum = self._numerator rden = self._denominator - snum = ( right).__numerator + snum = ( right)._numerator sden = ( right)._denominator if (rnum.is_zero()): @@ -624,9 +624,9 @@ cdef class FractionFieldElement(FieldElement): except TypeError: pass - rnum = self.__numerator + rnum = self._numerator rden = self._denominator - snum = ( right).__numerator + snum = ( right)._numerator sden = ( right)._denominator return self.__class__(self._parent, rnum*sden + rden*snum, rden*sden, @@ -652,9 +652,9 @@ cdef class FractionFieldElement(FieldElement): sage: a * b # indirect doctest # optional - sage.rings.finite_rings 3/(t + 1) """ - rnum = self.__numerator + rnum = self._numerator rden = self._denominator - snum = ( right).__numerator + snum = ( right)._numerator sden = ( right)._denominator if (rnum.is_zero() or snum.is_zero()): @@ -689,9 +689,9 @@ cdef class FractionFieldElement(FieldElement): except TypeError: pass - rnum = self.__numerator + rnum = self._numerator rden = self._denominator - snum = ( right).__numerator + snum = ( right)._numerator sden = ( right)._denominator return self.__class__(self._parent, rnum * snum, rden * sden, @@ -717,7 +717,7 @@ cdef class FractionFieldElement(FieldElement): sage: a/b (x*z - x + z - 1)/(z - 3) """ - snum = ( right).__numerator + snum = ( right)._numerator sden = ( right)._denominator if snum.is_zero(): @@ -746,7 +746,7 @@ cdef class FractionFieldElement(FieldElement): if self._denominator != 1: self.reduce() if self._denominator == 1: - return int(self.__numerator) + return int(self._numerator) else: raise TypeError("denominator must equal 1") @@ -758,7 +758,7 @@ cdef class FractionFieldElement(FieldElement): sage: float(x/x + y/y) 2.0 """ - return float(self.__numerator) / float(self._denominator) + return float(self._numerator) / float(self._denominator) def __complex__(self): """ @@ -768,7 +768,7 @@ cdef class FractionFieldElement(FieldElement): sage: complex(x/(I*x) + (I*y)/y) 0j """ - return complex(self.__numerator) / complex(self._denominator) + return complex(self._numerator) / complex(self._denominator) def _rational_(self): r""" @@ -823,10 +823,10 @@ cdef class FractionFieldElement(FieldElement): u """ if self._denominator.is_one(): - return R(self.__numerator) + return R(self._numerator) else: self.reduce() - num = R(self.__numerator) + num = R(self._numerator) inv_den = R(self._denominator).inverse_of_unit() return num * inv_den @@ -847,7 +847,7 @@ cdef class FractionFieldElement(FieldElement): Returns self raised to the `right^{th}` power. Note that we need to check whether or not right is negative so we - don't set ``__numerator`` or ``_denominator`` to an element of the + don't set ``_numerator`` or ``_denominator`` to an element of the fraction field instead of the underlying ring. EXAMPLES:: @@ -876,7 +876,7 @@ cdef class FractionFieldElement(FieldElement): sage: ((x+y)/(x-y))^0 1 """ - snum = ( self).__numerator + snum = ( self)._numerator sden = ( self)._denominator if right == 0: R = self.parent().ring() @@ -904,7 +904,7 @@ cdef class FractionFieldElement(FieldElement): (4*t^2 + 4*t)/(t + 2) """ return self.__class__(self._parent, - -self.__numerator, self._denominator, + -self._numerator, self._denominator, coerce=False, reduce=False) def __abs__(self): @@ -915,7 +915,7 @@ cdef class FractionFieldElement(FieldElement): sage: abs(FractionFieldElement(QQ, -2, 3, coerce=False)) 2/3 """ - return abs(self.__numerator) / abs(self._denominator) + return abs(self._numerator) / abs(self._denominator) def __invert__(self): """ @@ -929,7 +929,7 @@ cdef class FractionFieldElement(FieldElement): if self.is_zero(): raise ZeroDivisionError("Cannot invert 0") return self.__class__(self._parent, - self._denominator, self.__numerator, coerce=False, reduce=False) + self._denominator, self._numerator, coerce=False, reduce=False) cpdef _richcmp_(self, other, int op): """ @@ -951,10 +951,10 @@ cdef class FractionFieldElement(FieldElement): sage: 1 > y False """ - return richcmp(self.__numerator * + return richcmp(self._numerator * (other)._denominator, self._denominator * - (other).__numerator, op) + (other)._numerator, op) def valuation(self, v=None): """ @@ -972,7 +972,7 @@ cdef class FractionFieldElement(FieldElement): sage: f.valuation(x^2 + 1) 1 """ - return self.__numerator.valuation(v) - self._denominator.valuation(v) + return self._numerator.valuation(v) - self._denominator.valuation(v) def __bool__(self): """ @@ -991,7 +991,7 @@ cdef class FractionFieldElement(FieldElement): sage: bool(1/x) True """ - return not self.__numerator.is_zero() + return not self._numerator.is_zero() def is_zero(self): """ @@ -1010,7 +1010,7 @@ cdef class FractionFieldElement(FieldElement): sage: u.parent() is F True """ - return self.__numerator.is_zero() + return self._numerator.is_zero() def is_one(self): """ @@ -1025,7 +1025,7 @@ cdef class FractionFieldElement(FieldElement): sage: (x/y).is_one() False """ - return self.__numerator == self._denominator + return self._numerator == self._denominator def _symbolic_(self, ring): """ @@ -1044,7 +1044,7 @@ cdef class FractionFieldElement(FieldElement): sage: symbolic_expression(elt) # optional - sage.symbolic 2/3*(x + y)/(x - y) """ - return ring(self.__numerator)/ring(self._denominator) + return ring(self._numerator)/ring(self._denominator) def __reduce__(self): """ @@ -1058,7 +1058,7 @@ cdef class FractionFieldElement(FieldElement): True """ return (make_element, - (self._parent, self.__numerator, self._denominator)) + (self._parent, self._numerator, self._denominator)) def _evaluate_polynomial(self, pol): """ @@ -1172,7 +1172,7 @@ cdef class FractionFieldElement_1poly_field(FractionFieldElement): """ invlc = ~self._denominator.leading_coefficient() self._denominator = self._denominator.monic() - self.__numerator *= invlc + self._numerator *= invlc def is_integral(self): """ diff --git a/src/sage/rings/number_field/number_field_element.pxd b/src/sage/rings/number_field/number_field_element.pxd index dd2530caf45..418e54aba8c 100644 --- a/src/sage/rings/number_field/number_field_element.pxd +++ b/src/sage/rings/number_field/number_field_element.pxd @@ -11,7 +11,7 @@ from sage.libs.ntl.ntl_ZZ cimport ntl_ZZ cdef class NumberFieldElement(NumberFieldElement_base): - cdef ZZX_c __numerator + cdef ZZX_c _numerator cdef ZZ_c _denominator # Pointers to the defining polynomial (with numerator) for the field. # I keep these as pointers for arithmetic speed. diff --git a/src/sage/rings/number_field/number_field_element.pyx b/src/sage/rings/number_field/number_field_element.pyx index ed75c8539b7..6a0041d2e8e 100644 --- a/src/sage/rings/number_field/number_field_element.pyx +++ b/src/sage/rings/number_field/number_field_element.pyx @@ -324,12 +324,12 @@ cdef class NumberFieldElement(NumberFieldElement_base): # set it up and exit immediately # fast pathway mpz_to_ZZ(&coeff, (ZZ(f)).value) - ZZX_SetCoeff( self.__numerator, 0, coeff ) + ZZX_SetCoeff( self._numerator, 0, coeff ) ZZ_conv_from_int( self._denominator, 1 ) return elif isinstance(f, NumberFieldElement): if type(self) is type(f): - self.__numerator = (f).__numerator + self._numerator = (f)._numerator self._denominator = (f)._denominator return else: @@ -346,7 +346,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): num = f * den for i from 0 <= i <= num.degree(): mpz_to_ZZ(&coeff, (ZZ(num[i])).value) - ZZX_SetCoeff( self.__numerator, i, coeff ) + ZZX_SetCoeff( self._numerator, i, coeff ) def _lift_cyclotomic_element(self, new_parent, bint check=True, int rel=0): """ @@ -424,10 +424,10 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef int i cdef ntl_ZZX _num cdef ntl_ZZ _den - for i from 0 <= i <= ZZX_deg(self.__numerator): - tmp = ZZX_coeff(self.__numerator, i) + for i from 0 <= i <= ZZX_deg(self._numerator): + tmp = ZZX_coeff(self._numerator, i) ZZX_SetCoeff(result, i*rel, tmp) - ZZX_rem(x.__numerator, result, x.__fld_numerator.x) + ZZX_rem(x._numerator, result, x.__fld_numerator.x) return x def __reduce__(self): @@ -858,7 +858,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef int res # fast equality check - res = left.__numerator == _right.__numerator and left._denominator == _right._denominator + res = left._numerator == _right._numerator and left._denominator == _right._denominator if res: if op == Py_EQ or op == Py_GE or op == Py_LE: return True @@ -889,9 +889,9 @@ cdef class NumberFieldElement(NumberFieldElement_base): v = P._get_embedding_approx(0) mpfi_init2(la, mpfi_get_prec(v.value)) mpfi_init2(ra, mpfi_get_prec(v.value)) - ZZX_evaluation_mpfi(la, left.__numerator, v.value) + ZZX_evaluation_mpfi(la, left._numerator, v.value) mpfi_div_z(la, la, ld) - ZZX_evaluation_mpfi(ra, _right.__numerator, v.value) + ZZX_evaluation_mpfi(ra, _right._numerator, v.value) mpfi_div_z(ra, ra, rd) while mpfr_greaterequal_p(&la.right, &ra.left) \ and mpfr_greaterequal_p(&ra.right, &la.left): @@ -899,9 +899,9 @@ cdef class NumberFieldElement(NumberFieldElement_base): v = P._get_embedding_approx(i) mpfi_set_prec(la, mpfi_get_prec(v.value)) mpfi_set_prec(ra, mpfi_get_prec(v.value)) - ZZX_evaluation_mpfi(la, left.__numerator, v.value) + ZZX_evaluation_mpfi(la, left._numerator, v.value) mpfi_div_z(la, la, ld) - ZZX_evaluation_mpfi(ra, _right.__numerator, v.value) + ZZX_evaluation_mpfi(ra, _right._numerator, v.value) mpfi_div_z(ra, ra, rd) if op == Py_LT or op == Py_LE: res = mpfr_less_p(&la.right, &ra.left) @@ -950,7 +950,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef Rational tmp_rational # It seems like a simpler approach would be to simply generate - # random integers for each coefficient of self.__numerator + # random integers for each coefficient of self._numerator # and an integer for self._denominator. However, this would # generate things with a fairly fixed shape: in particular, # we'd be very unlikely to get elements like 1/3*a^3 + 1/7, @@ -970,7 +970,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): tmp_integer = (ZZ.random_element(x=num_bound, distribution=distribution)) mpz_to_ZZ(&ntl_temp, (tmp_integer).value) - ZZX_SetCoeff(self.__numerator, i, ntl_temp) + ZZX_SetCoeff(self._numerator, i, ntl_temp) else: coeff_list = [] @@ -1006,7 +1006,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # now set the coefficient of self mpz_to_ZZ(&ntl_temp, (tmp_integer).value) - ZZX_SetCoeff(self.__numerator, i, ntl_temp) + ZZX_SetCoeff(self._numerator, i, ntl_temp) return 0 # No error @@ -1089,10 +1089,10 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: L.zero().sign() 0 """ - if ZZX_deg(self.__numerator) == -1: + if ZZX_deg(self._numerator) == -1: return 0 - if ZZX_deg(self.__numerator) == 0: - return ZZ_sign(ZZX_coeff(self.__numerator, 0)) + if ZZX_deg(self._numerator) == 0: + return ZZ_sign(ZZX_coeff(self._numerator, 0)) if not ( self._parent)._embedded_real: raise TypeError("sign not well defined since no real embedding is specified") @@ -1153,11 +1153,11 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef RealIntervalFieldElement v - if ZZX_deg(self.__numerator) <= 0: + if ZZX_deg(self._numerator) <= 0: mpz_init(num) mpz_init(den) - ZZX_getitem_as_mpz(num, &self.__numerator, 0) + ZZX_getitem_as_mpz(num, &self._numerator, 0) ZZ_to_mpz(den, &self._denominator) ans = PY_NEW(Integer) @@ -1185,7 +1185,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): ZZ_to_mpz(den, &self._denominator) - ZZX_evaluation_mpfi(a, self.__numerator, v.value) + ZZX_evaluation_mpfi(a, self._numerator, v.value) mpfi_div_z(a, a, den) mpfr_floor(&a.left, &a.left) @@ -1197,7 +1197,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): v = P._get_embedding_approx(i) mpfi_set_prec(a, mpfi_get_prec(v.value)) - ZZX_evaluation_mpfi(a, self.__numerator, v.value) + ZZX_evaluation_mpfi(a, self._numerator, v.value) mpfi_div_z(a, a, den) mpfr_floor(&a.left ,&a.left) mpfr_floor(&a.right, &a.right) @@ -1248,7 +1248,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): ... TypeError: ceil not uniquely defined since no real embedding is specified """ - if ZZX_deg(self.__numerator) <= 0: + if ZZX_deg(self._numerator) <= 0: return self._rational_().ceil() if not ( self._parent)._embedded_real: @@ -1311,7 +1311,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): ... TypeError: floor not uniquely defined since no real embedding is specified """ - if ZZX_deg(self.__numerator) <= 0: + if ZZX_deg(self._numerator) <= 0: return self._rational_().round() return (self + QQ((1,2))).floor() @@ -2485,14 +2485,14 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef ZZX_c t2 if ZZ_IsOne(self._denominator): return - ZZX_content(t1, self.__numerator) + ZZX_content(t1, self._numerator) ZZ_GCD(gcd, t1, self._denominator) if ZZ_sign(gcd) != ZZ_sign(self._denominator): ZZ_negate(t1, gcd) gcd = t1 - ZZX_div_ZZ(t2, self.__numerator, gcd) + ZZX_div_ZZ(t2, self._numerator, gcd) ZZ_div(t1, self._denominator, gcd) - self.__numerator = t2 + self._numerator = t2 self._denominator = t1 cpdef _add_(self, right): @@ -2515,9 +2515,9 @@ cdef class NumberFieldElement(NumberFieldElement_base): ZZ_mul(x._denominator, q1, q2) ZZ_mul(x._denominator, x._denominator, g) cdef ZZX_c t1, t2 - ZZX_mul_ZZ(t1, self.__numerator, q2) - ZZX_mul_ZZ(t2, _right.__numerator, q1) - ZZX_add(x.__numerator, t1, t2) + ZZX_mul_ZZ(t1, self._numerator, q2) + ZZX_mul_ZZ(t2, _right._numerator, q1) + ZZX_add(x._numerator, t1, t2) x._reduce_c_() return x @@ -2540,9 +2540,9 @@ cdef class NumberFieldElement(NumberFieldElement_base): ZZ_mul(x._denominator, q1, q2) ZZ_mul(x._denominator, x._denominator, g) cdef ZZX_c t1, t2 - ZZX_mul_ZZ(t1, self.__numerator, q2) - ZZX_mul_ZZ(t2, _right.__numerator, q1) - ZZX_sub(x.__numerator, t1, t2) + ZZX_mul_ZZ(t1, self._numerator, q2) + ZZX_mul_ZZ(t2, _right._numerator, q1) + ZZX_sub(x._numerator, t1, t2) x._reduce_c_() return x @@ -2573,14 +2573,14 @@ cdef class NumberFieldElement(NumberFieldElement_base): # Therefore, we handle the non-monic case entirely separately. ZZ_mul(x._denominator, self._denominator, _right._denominator) if ZZ_IsOne(ZZX_LeadCoeff(self.__fld_numerator.x)): - ZZX_MulMod(x.__numerator, self.__numerator, _right.__numerator, self.__fld_numerator.x) + ZZX_MulMod(x._numerator, self._numerator, _right._numerator, self.__fld_numerator.x) else: - ZZX_mul(x.__numerator, self.__numerator, _right.__numerator) - if ZZX_deg(x.__numerator) >= ZZX_deg(self.__fld_numerator.x): - ZZX_mul_ZZ( x.__numerator, x.__numerator, self.__fld_denominator.x ) + ZZX_mul(x._numerator, self._numerator, _right._numerator) + if ZZX_deg(x._numerator) >= ZZX_deg(self.__fld_numerator.x): + ZZX_mul_ZZ( x._numerator, x._numerator, self.__fld_denominator.x ) ZZX_mul_ZZ( temp, self.__fld_numerator.x, x._denominator ) - ZZ_power(temp1,ZZX_LeadCoeff(temp),ZZX_deg(x.__numerator)-ZZX_deg(self.__fld_numerator.x)+1) - ZZX_PseudoRem(x.__numerator, x.__numerator, temp) + ZZ_power(temp1,ZZX_LeadCoeff(temp),ZZX_deg(x._numerator)-ZZX_deg(self.__fld_numerator.x)+1) + ZZX_PseudoRem(x._numerator, x._numerator, temp) ZZ_mul(x._denominator, x._denominator, self.__fld_denominator.x) ZZ_mul(x._denominator, x._denominator, temp1) sig_off() @@ -2704,7 +2704,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: bool(b + 1) True """ - return not IsZero_ZZX(self.__numerator) + return not IsZero_ZZX(self._numerator) cpdef _neg_(self): r""" @@ -2717,7 +2717,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): """ cdef NumberFieldElement x x = self._new() - ZZX_mul_long(x.__numerator, self.__numerator, -1) + ZZX_mul_long(x._numerator, self._numerator, -1) x._denominator = self._denominator return x @@ -2738,7 +2738,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): """ cdef NumberFieldElement x x = self._new() - x.__numerator = self.__numerator + x._numerator = self._numerator x._denominator = self._denominator x._set_parent(parent) return x @@ -2826,7 +2826,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: L. = K.extension(f) sage: alpha = (a^8 + (zeta22^9 - zeta22^6 + 2*zeta22^4 + 33)*a^7)/(10**2555) #long time """ - if IsZero_ZZX(self.__numerator): + if IsZero_ZZX(self._numerator): raise ZeroDivisionError("number field element division by zero") cdef NumberFieldElement x cdef ZZX_c temp @@ -2835,8 +2835,8 @@ cdef class NumberFieldElement(NumberFieldElement_base): # but may fail if NTL runs out of FFT primes. x = self._new() sig_on() - ZZX_XGCD(x._denominator, x.__numerator, temp, self.__numerator, self.__fld_numerator.x, 1) - ZZX_mul_ZZ(x.__numerator, x.__numerator, self._denominator) + ZZX_XGCD(x._denominator, x._numerator, temp, self._numerator, self.__fld_numerator.x, 1) + ZZX_mul_ZZ(x._numerator, x._numerator, self._denominator) x._reduce_c_() sig_off() except NTLError: @@ -2858,7 +2858,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: (2*I*I)._integer_() -2 """ - if ZZX_deg(self.__numerator) >= 1: + if ZZX_deg(self._numerator) >= 1: raise TypeError("Unable to coerce %s to an integer" % self) return ZZ(self._rational_()) @@ -2877,10 +2877,10 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: (I*I/2)._rational_() -1/2 """ - if ZZX_deg(self.__numerator) >= 1: + if ZZX_deg(self._numerator) >= 1: raise TypeError("Unable to coerce %s to a rational"%self) cdef Integer num = Integer.__new__(Integer) - ZZX_getitem_as_mpz(num.value, &self.__numerator, 0) + ZZX_getitem_as_mpz(num.value, &self._numerator, 0) cdef Integer den = Integer.__new__(Integer) ZZ_to_mpz(den.value, &self._denominator) return num / den @@ -3268,11 +3268,11 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef mpz_t z mpz_init(z) - ZZX_getitem_as_mpz(z, &self.__numerator, 0) + ZZX_getitem_as_mpz(z, &self._numerator, 0) h = mpz_pythonhash(z) - for i from 1 <= i <= ZZX_deg(self.__numerator): - ZZX_getitem_as_mpz(z, &self.__numerator, i) + for i from 1 <= i <= ZZX_deg(self._numerator): + ZZX_getitem_as_mpz(z, &self._numerator, i) # magic number below is floor(2^63 / (2+sqrt(2))) h ^= mpz_pythonhash(z) + ( 2701463124188384701) + (h << 16) + (h >> 2) @@ -3306,11 +3306,11 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef mpz_t den mpz_init(den) ZZ_to_mpz(den, &self._denominator) - cdef int size = ZZX_deg(self.__numerator) + 1 + cdef int size = ZZX_deg(self._numerator) + 1 cdef list coeffs = [None]*size for i in range(size): coeff = Rational.__new__(Rational) - ZZX_getitem_as_mpz(mpq_numref(coeff.value), &self.__numerator, i) + ZZX_getitem_as_mpz(mpq_numref(coeff.value), &self._numerator, i) mpz_set(mpq_denref(coeff.value), den) mpq_canonicalize(coeff.value) coeffs[i] = coeff @@ -3318,10 +3318,10 @@ cdef class NumberFieldElement(NumberFieldElement_base): return coeffs cdef void _ntl_coeff_as_mpz(self, mpz_t z, long i): - if i > ZZX_deg(self.__numerator): + if i > ZZX_deg(self._numerator): mpz_set_ui(z, 0) else: - ZZX_getitem_as_mpz(z, &self.__numerator, i) + ZZX_getitem_as_mpz(z, &self._numerator, i) cdef void _ntl_denom_as_mpz(self, mpz_t z): cdef Integer denom = Integer.__new__(Integer) @@ -3474,7 +3474,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: a.is_one() False """ - return ZZX_IsOne(self.__numerator) == 1 and \ + return ZZX_IsOne(self._numerator) == 1 and \ ZZ_IsOne(self._denominator) == 1 cpdef bint is_rational(self): @@ -3501,7 +3501,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: K(1/2).is_rational() True """ - return ZZX_deg(self.__numerator) <= 0 + return ZZX_deg(self._numerator) <= 0 def is_integer(self): r""" @@ -3527,7 +3527,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): sage: K(1/2).is_integer() False """ - return ZZX_deg(self.__numerator) <= 0 and ZZ_IsOne(self._denominator) == 1 + return ZZX_deg(self._numerator) <= 0 and ZZ_IsOne(self._denominator) == 1 def trace(self, K=None): r""" diff --git a/src/sage/rings/number_field/number_field_element_quadratic.pyx b/src/sage/rings/number_field/number_field_element_quadratic.pyx index a40edf7a867..88f4c92ce8b 100644 --- a/src/sage/rings/number_field/number_field_element_quadratic.pyx +++ b/src/sage/rings/number_field/number_field_element_quadratic.pyx @@ -621,7 +621,7 @@ cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute): for i from 0 <= i <= ZZX_deg(elt_num): tmp = ZZX_coeff(elt_num, i) ZZX_SetCoeff(result, i*rel, tmp) - ZZX_rem(x.__numerator, result, _num.x) + ZZX_rem(x._numerator, result, _num.x) (x)._reduce_c_() return x @@ -1643,7 +1643,7 @@ cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute): return res ################################################################################# -# We must override everything that makes uses of self.__numerator/_denominator +# We must override everything that makes uses of self._numerator/_denominator ################################################################################# def __hash__(self): From 3517ddebd8795d22c52f8fd873ddb8874a8d8dc4 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:41:11 +0800 Subject: [PATCH 23/54] rename __temporarily_change_names -> _temporarily_change_names --- src/sage/rings/polynomial/multi_polynomial_libsingular.pyx | 2 +- src/sage/structure/category_object.pyx | 2 +- src/sage/structure/parent_gens.pyx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx b/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx index 52a81dbf846..83c79c39843 100644 --- a/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx +++ b/src/sage/rings/polynomial/multi_polynomial_libsingular.pyx @@ -1494,7 +1494,7 @@ cdef class MPolynomialRing_libsingular(MPolynomialRing_base): return unpickle_MPolynomialRing_libsingular, \ (self.base_ring(), self.variable_names(), self.term_order()) - def __temporarily_change_names(self, names, latex_names): + def _temporarily_change_names(self, names, latex_names): """ This is used by the variable names context manager. diff --git a/src/sage/structure/category_object.pyx b/src/sage/structure/category_object.pyx index 7f84eabd7f1..b6a7eaecb5b 100644 --- a/src/sage/structure/category_object.pyx +++ b/src/sage/structure/category_object.pyx @@ -491,7 +491,7 @@ cdef class CategoryObject(SageObject): """ return self.variable_names()[0] - def __temporarily_change_names(self, names, latex_names): + def _temporarily_change_names(self, names, latex_names): """ This is used by the variable names context manager. diff --git a/src/sage/structure/parent_gens.pyx b/src/sage/structure/parent_gens.pyx index ab531314458..cc6ffaace21 100644 --- a/src/sage/structure/parent_gens.pyx +++ b/src/sage/structure/parent_gens.pyx @@ -371,7 +371,7 @@ cdef class localvars: self._latex_names = latex_names def __enter__(self): - self._orig = self._obj.__temporarily_change_names(self._names, self._latex_names) + self._orig = self._obj._temporarily_change_names(self._names, self._latex_names) def __exit__(self, type, value, traceback): - self._obj.__temporarily_change_names(self._orig[0], self._orig[1]) + self._obj._temporarily_change_names(self._orig[0], self._orig[1]) From 826c4304cddc1ca5b3132675d26f94ffb0049d12 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:41:30 +0800 Subject: [PATCH 24/54] rename __term_order -> _term_order --- src/sage/rings/polynomial/multi_polynomial_ring_base.pxd | 2 +- src/sage/rings/polynomial/multi_polynomial_ring_base.pyx | 8 ++++---- src/sage/rings/polynomial/plural.pxd | 2 +- src/sage/rings/polynomial/plural.pyx | 8 ++++---- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd b/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd index e54dd1e9ce6..eb6f8b70917 100644 --- a/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd +++ b/src/sage/rings/polynomial/multi_polynomial_ring_base.pxd @@ -3,7 +3,7 @@ from sage.structure.parent cimport Parent cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): cdef object _ngens - cdef object __term_order + cdef object _term_order cdef public object _has_singular cdef public object _magma_gens cdef public dict _magma_cache diff --git a/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx b/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx index d5388ba7342..c8f66508cc2 100644 --- a/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx +++ b/src/sage/rings/polynomial/multi_polynomial_ring_base.pyx @@ -81,7 +81,7 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): "have more than 0 variables.") order = TermOrder(order, n) self._ngens = n - self.__term_order = order + self._term_order = order self._has_singular = False # cannot convert to Singular by default self._magma_cache = {} # Ring.__init__ already does assign the names. @@ -641,10 +641,10 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): lx = (lft.base_ring(), lft._ngens, lft.variable_names(), - lft.__term_order) + lft._term_order) rx = (other.base_ring(), other._ngens, other.variable_names(), - other.__term_order) + other._term_order) return richcmp(lx, rx, op) def _repr_(self): @@ -849,7 +849,7 @@ cdef class MPolynomialRing_base(sage.rings.ring.CommutativeRing): return False def term_order(self): - return self.__term_order + return self._term_order def characteristic(self): """ diff --git a/src/sage/rings/polynomial/plural.pxd b/src/sage/rings/polynomial/plural.pxd index 5d05e4d0e25..d3a46f6aa0d 100644 --- a/src/sage/rings/polynomial/plural.pxd +++ b/src/sage/rings/polynomial/plural.pxd @@ -16,7 +16,7 @@ cdef class NCPolynomialRing_plural(Ring): cdef object _ngens cdef object _c cdef object _d - cdef object __term_order + cdef object _term_order cdef public object _has_singular cdef public object _magma_gens, _magma_cache diff --git a/src/sage/rings/polynomial/plural.pyx b/src/sage/rings/polynomial/plural.pyx index a98a04b2ef5..bc432611c89 100644 --- a/src/sage/rings/polynomial/plural.pyx +++ b/src/sage/rings/polynomial/plural.pyx @@ -337,7 +337,7 @@ cdef class NCPolynomialRing_plural(Ring): self._ring.ShortOut = 0 self._ngens = n - self.__term_order = order + self._term_order = order Ring.__init__(self, base_ring, names, category=category) self._populate_coercion_lists_() @@ -673,7 +673,7 @@ cdef class NCPolynomialRing_plural(Ring): sage: P.term_order() Degree reverse lexicographic term order """ - return self.__term_order + return self._term_order def is_commutative(self): """ @@ -2891,7 +2891,7 @@ cpdef MPolynomialRing_libsingular new_CRing(RingWrap rw, base_ring): self._ring.ShortOut = 0 self._ngens = rw.ngens() - self.__term_order = TermOrder(rw.ordering_string(), force=True) + self._term_order = TermOrder(rw.ordering_string(), force=True) ParentWithGens.__init__(self, base_ring, tuple(rw.var_names()), normalize=False) @@ -2963,7 +2963,7 @@ cpdef NCPolynomialRing_plural new_NRing(RingWrap rw, base_ring): self._ring.ShortOut = 0 self._ngens = rw.ngens() - self.__term_order = TermOrder(rw.ordering_string(), force=True) + self._term_order = TermOrder(rw.ordering_string(), force=True) ParentWithGens.__init__(self, base_ring, rw.var_names()) # self._populate_coercion_lists_() # ??? From 251d36b7a2fffe81257c6d54e42ec51aeb8adb99 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:42:08 +0800 Subject: [PATCH 25/54] rename __custom_name -> _custom_name --- .../letterplace/free_algebra_letterplace.pxd | 2 +- .../categories/hopf_algebras_with_basis.py | 2 +- src/sage/categories/modules_with_basis.py | 4 +-- src/sage/combinat/cluster_complex.py | 6 ++-- src/sage/combinat/subword_complex.py | 2 +- .../groups/perm_gps/permgroup_element.pxd | 2 +- src/sage/interfaces/interface.py | 2 +- src/sage/interfaces/singular.py | 2 +- src/sage/libs/gap/element.pyx | 2 +- src/sage/matroids/basis_matroid.pyx | 6 ++-- .../matroids/circuit_closures_matroid.pyx | 10 +++---- src/sage/matroids/dual_matroid.py | 10 +++---- src/sage/matroids/graphic_matroid.py | 10 +++---- src/sage/matroids/linear_matroid.pyx | 30 +++++++++---------- src/sage/matroids/matroid.pxd | 1 - src/sage/matroids/minor_matroid.py | 10 +++---- src/sage/matroids/rank_matroid.py | 8 ++--- src/sage/quivers/representation.py | 4 +-- .../drinfeld_modules/drinfeld_module.py | 4 +-- src/sage/sets/set_from_iterator.py | 2 +- src/sage/structure/sage_object.pyx | 12 ++++---- src/sage/topology/simplicial_set.py | 16 +++++----- .../topology/simplicial_set_constructions.py | 2 +- 23 files changed, 74 insertions(+), 75 deletions(-) diff --git a/src/sage/algebras/letterplace/free_algebra_letterplace.pxd b/src/sage/algebras/letterplace/free_algebra_letterplace.pxd index 5623a1bb6d4..9bce00e2755 100644 --- a/src/sage/algebras/letterplace/free_algebra_letterplace.pxd +++ b/src/sage/algebras/letterplace/free_algebra_letterplace.pxd @@ -29,7 +29,7 @@ cdef class FreeAlgebra_letterplace(Algebra): cdef int _ngens cdef int _nb_slackvars cdef object __monoid - cdef public object __custom_name + cdef public object _custom_name cdef str exponents_to_string(self, E) cdef str exponents_to_latex(self, E) cdef tuple _degrees diff --git a/src/sage/categories/hopf_algebras_with_basis.py b/src/sage/categories/hopf_algebras_with_basis.py index 1be964cb6c9..d2c22fb4331 100644 --- a/src/sage/categories/hopf_algebras_with_basis.py +++ b/src/sage/categories/hopf_algebras_with_basis.py @@ -36,7 +36,7 @@ class HopfAlgebrasWithBasis(CategoryWithAxiom_over_base_ring): sage: A = C.example(); A # needs sage.groups An example of Hopf algebra with basis: the group algebra of the Dihedral group of order 6 as a permutation group over Rational Field - sage: A.__custom_name = "A" # needs sage.groups + sage: A._custom_name = "A" # needs sage.groups sage: A.category() # needs sage.groups Category of finite dimensional hopf algebras with basis over Rational Field diff --git a/src/sage/categories/modules_with_basis.py b/src/sage/categories/modules_with_basis.py index 65fd47cb890..7a307987651 100644 --- a/src/sage/categories/modules_with_basis.py +++ b/src/sage/categories/modules_with_basis.py @@ -66,8 +66,8 @@ class ModulesWithBasis(CategoryWithAxiom_over_base_ring): Let `X` and `Y` be two modules with basis. We can build `Hom(X,Y)`:: - sage: X = CombinatorialFreeModule(QQ, [1,2]); X.__custom_name = "X" # needs sage.modules - sage: Y = CombinatorialFreeModule(QQ, [3,4]); Y.__custom_name = "Y" # needs sage.modules + sage: X = CombinatorialFreeModule(QQ, [1,2]); X._custom_name = "X" # needs sage.modules + sage: Y = CombinatorialFreeModule(QQ, [3,4]); Y._custom_name = "Y" # needs sage.modules sage: H = Hom(X, Y); H # needs sage.modules Set of Morphisms from X to Y in Category of finite dimensional vector spaces with basis over Rational Field diff --git a/src/sage/combinat/cluster_complex.py b/src/sage/combinat/cluster_complex.py index edc4f235aeb..fccf3877480 100644 --- a/src/sage/combinat/cluster_complex.py +++ b/src/sage/combinat/cluster_complex.py @@ -223,9 +223,9 @@ def __init__(self, W, k, coxeter_element, algorithm): self._w0 = w self._k = k if k == 1: - self.__custom_name = 'Cluster complex' + self._custom_name = 'Cluster complex' else: - self.__custom_name = 'Multi-cluster complex' + self._custom_name = 'Multi-cluster complex' self.set_immutable() @@ -271,7 +271,7 @@ def _repr_(self): sage: ClusterComplex(['A', 2])._repr_() "Cluster complex of type ['A', 2] with 5 vertices and 5 facets" """ - name = self.__custom_name + name = self._custom_name name += (' of type %s with %s vertices and %s facets' % (self.cartan_type(), len(self.vertices()), len(self._facets))) diff --git a/src/sage/combinat/subword_complex.py b/src/sage/combinat/subword_complex.py index b7489bdf754..c4cf1dac47c 100644 --- a/src/sage/combinat/subword_complex.py +++ b/src/sage/combinat/subword_complex.py @@ -1131,7 +1131,7 @@ def __init__(self, Q, w, algorithm="inductive"): SimplicialComplex.__init__(self, maximal_faces=Fs, maximality_check=False, category=cat) - self.__custom_name = 'Subword complex' + self._custom_name = 'Subword complex' self._W = W try: T = W.coxeter_matrix().coxeter_type() diff --git a/src/sage/groups/perm_gps/permgroup_element.pxd b/src/sage/groups/perm_gps/permgroup_element.pxd index a2ac8f20eaa..b1ec2b09a19 100644 --- a/src/sage/groups/perm_gps/permgroup_element.pxd +++ b/src/sage/groups/perm_gps/permgroup_element.pxd @@ -22,7 +22,7 @@ cdef class PermutationGroupElement(MultiplicativeGroupElement): cpdef PermutationGroupElement _generate_new_GAP(self, old) cpdef _gap_list(self) cpdef domain(self) - cdef public __custom_name + cdef public _custom_name cpdef list _act_on_list_on_position(self, list x) cpdef ClonableIntArray _act_on_array_on_position(self, ClonableIntArray x) cpdef ETuple _act_on_etuple_on_position(self, ETuple x) diff --git a/src/sage/interfaces/interface.py b/src/sage/interfaces/interface.py index f8237d3ad94..9679c34ab5b 100644 --- a/src/sage/interfaces/interface.py +++ b/src/sage/interfaces/interface.py @@ -1171,7 +1171,7 @@ def __repr__(self): s = self._repr_() if self._name in s: try: - s = s.replace(self._name, getattr(self, '__custom_name')) + s = s.replace(self._name, getattr(self, '_custom_name')) except AttributeError: pass if cr: diff --git a/src/sage/interfaces/singular.py b/src/sage/interfaces/singular.py index 4b5c76e2bfa..1ba45f6605d 100644 --- a/src/sage/interfaces/singular.py +++ b/src/sage/interfaces/singular.py @@ -1400,7 +1400,7 @@ def _repr_(self): """ s = super(SingularElement, self)._repr_() if self._name in s: - if (not hasattr(self, "__custom_name")) and self.type() == 'matrix': + if (not hasattr(self, "_custom_name")) and self.type() == 'matrix': s = self.parent().eval('pmat(%s,20)'%(self.name())) return s diff --git a/src/sage/libs/gap/element.pyx b/src/sage/libs/gap/element.pyx index 1dc53c81f67..964cd18e646 100644 --- a/src/sage/libs/gap/element.pyx +++ b/src/sage/libs/gap/element.pyx @@ -720,7 +720,7 @@ cdef class GapElement(RingElement): ... AttributeError: 'some_name' does not define a GAP function """ - if name in ('__dict__', '_getAttributeNames', '__custom_name', 'keys'): + if name in ('__dict__', '_getAttributeNames', '_custom_name', 'keys'): raise AttributeError('Python special name, not a GAP function.') try: proxy = make_GapElement_MethodProxy\ diff --git a/src/sage/matroids/basis_matroid.pyx b/src/sage/matroids/basis_matroid.pyx index 1cb721af21f..56357ca7878 100644 --- a/src/sage/matroids/basis_matroid.pyx +++ b/src/sage/matroids/basis_matroid.pyx @@ -1177,7 +1177,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): """ N = BasisMatroid(M=self) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo=None): @@ -1201,7 +1201,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): if memo is None: memo = {} N = BasisMatroid(M=self) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __reduce__(self): @@ -1230,7 +1230,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): """ import sage.matroids.unpickling BB = bitset_pickle(self._bb) - data = (self._E, self._matroid_rank, getattr(self, '__custom_name'), BB) + data = (self._E, self._matroid_rank, getattr(self, '_custom_name'), BB) version = 0 return sage.matroids.unpickling.unpickle_basis_matroid, (version, data) diff --git a/src/sage/matroids/circuit_closures_matroid.pyx b/src/sage/matroids/circuit_closures_matroid.pyx index 402822b2dc6..72a95068504 100644 --- a/src/sage/matroids/circuit_closures_matroid.pyx +++ b/src/sage/matroids/circuit_closures_matroid.pyx @@ -513,8 +513,8 @@ cdef class CircuitClosuresMatroid(Matroid): N._groundset = self._groundset N._circuit_closures = self._circuit_closures N._matroid_rank = self._matroid_rank - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '__custom_name')) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo=None): @@ -539,8 +539,8 @@ cdef class CircuitClosuresMatroid(Matroid): from copy import deepcopy # Since matroids are immutable, N cannot reference itself in correct code, so no need to worry about the recursion. N = CircuitClosuresMatroid(groundset=deepcopy(self._groundset, memo), circuit_closures=deepcopy(self._circuit_closures, memo)) - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -570,7 +570,7 @@ cdef class CircuitClosuresMatroid(Matroid): 4: {{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'}}} """ import sage.matroids.unpickling - data = (self._groundset, self._circuit_closures, getattr(self, '__custom_name')) + data = (self._groundset, self._circuit_closures, getattr(self, '_custom_name')) version = 0 return sage.matroids.unpickling.unpickle_circuit_closures_matroid, (version, data) diff --git a/src/sage/matroids/dual_matroid.py b/src/sage/matroids/dual_matroid.py index 804e43f035b..445a78bc43d 100644 --- a/src/sage/matroids/dual_matroid.py +++ b/src/sage/matroids/dual_matroid.py @@ -519,9 +519,9 @@ def __copy__(self): """ N = DualMatroid(self._matroid) - if getattr(self, '__custom_name') is not None: + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo={}): @@ -543,10 +543,10 @@ def __deepcopy__(self, memo={}): """ from copy import deepcopy N = DualMatroid(deepcopy(self._matroid, memo)) - if getattr(self, '__custom_name') is not None: + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the # default deepcopy - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -575,6 +575,6 @@ def __reduce__(self): 4: {{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'}}}' """ import sage.matroids.unpickling - data = (self._matroid, getattr(self, '__custom_name')) + data = (self._matroid, getattr(self, '_custom_name')) version = 0 return sage.matroids.unpickling.unpickle_dual_matroid, (version, data) diff --git a/src/sage/matroids/graphic_matroid.py b/src/sage/matroids/graphic_matroid.py index 5216ef11517..106cd68bf71 100644 --- a/src/sage/matroids/graphic_matroid.py +++ b/src/sage/matroids/graphic_matroid.py @@ -481,8 +481,8 @@ def __copy__(self): False """ N = GraphicMatroid(self._G) - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '__custom_name')) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo={}): @@ -502,8 +502,8 @@ def __deepcopy__(self, memo={}): """ # The only real difference between this and __copy__() is the memo N = GraphicMatroid(deepcopy(self._G, memo)) - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -519,7 +519,7 @@ def __reduce__(self): Graphic matroid of rank 9 on 15 elements """ from .unpickling import unpickle_graphic_matroid - data = (self._G, getattr(self, '__custom_name')) + data = (self._G, getattr(self, '_custom_name')) version = 0 return unpickle_graphic_matroid, (version, data) diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index 31df805813d..402c5bbed86 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -2909,7 +2909,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): else: rows, cols = self._current_rows_cols() N = LinearMatroid(groundset=rows + cols, reduced_matrix=self._A) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo): @@ -2930,7 +2930,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): else: rows, cols = self._current_rows_cols() N = LinearMatroid(groundset=deepcopy(rows + cols, memo), reduced_matrix=deepcopy(self._A, memo)) - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -2979,7 +2979,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): rows, cols = self._current_rows_cols() gs = rows + cols reduced = True - data = (A, gs, reduced, getattr(self, '__custom_name')) + data = (A, gs, reduced, getattr(self, '_custom_name')) return sage.matroids.unpickling.unpickle_linear_matroid, (version, data) # Binary matroid @@ -3964,7 +3964,7 @@ cdef class BinaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = BinaryMatroid(groundset=self._E, matrix=self._A, basis=basis) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo): @@ -3989,7 +3989,7 @@ cdef class BinaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = BinaryMatroid(groundset=deepcopy(self._E, memo), matrix=deepcopy(self._A, memo), basis=deepcopy(basis, memo)) - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -4047,7 +4047,7 @@ cdef class BinaryMatroid(LinearMatroid): A = self._A # current basis ordered so matrix cols form identity matrix: basis = self._current_rows_cols()[0] - data = (A, gs, basis, getattr(self, '__custom_name')) + data = (A, gs, basis, getattr(self, '_custom_name')) return sage.matroids.unpickling.unpickle_binary_matroid, (version, data) cdef class TernaryMatroid(LinearMatroid): @@ -4858,7 +4858,7 @@ cdef class TernaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = TernaryMatroid(groundset=self._E, matrix=self._A, basis=basis) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo): @@ -4883,7 +4883,7 @@ cdef class TernaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = TernaryMatroid(groundset=deepcopy(self._E, memo), matrix=deepcopy(self._A, memo), basis=deepcopy(basis, memo)) - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -4945,7 +4945,7 @@ cdef class TernaryMatroid(LinearMatroid): A = self._A # current basis ordered so matrix cols form identity matrix: basis = self._current_rows_cols()[0] - data = (A, gs, basis, getattr(self, '__custom_name')) + data = (A, gs, basis, getattr(self, '_custom_name')) return sage.matroids.unpickling.unpickle_ternary_matroid, (version, data) # Quaternary Matroids @@ -5589,7 +5589,7 @@ cdef class QuaternaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = QuaternaryMatroid(groundset=self._E, matrix=self._A, basis=basis) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo): @@ -5614,7 +5614,7 @@ cdef class QuaternaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = QuaternaryMatroid(groundset=deepcopy(self._E, memo), matrix=deepcopy(self._A, memo), basis=deepcopy(basis, memo)) - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -5672,7 +5672,7 @@ cdef class QuaternaryMatroid(LinearMatroid): A = self._A # current basis ordered so matrix cols form identity matrix: basis = self._current_rows_cols()[0] - data = (A, gs, basis, getattr(self, '__custom_name')) + data = (A, gs, basis, getattr(self, '_custom_name')) return sage.matroids.unpickling.unpickle_quaternary_matroid, (version, data) # Regular Matroids @@ -6524,7 +6524,7 @@ cdef class RegularMatroid(LinearMatroid): else: rows, cols = self._current_rows_cols() N = RegularMatroid(groundset=rows + cols, reduced_matrix=self._A) - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo): @@ -6544,7 +6544,7 @@ cdef class RegularMatroid(LinearMatroid): else: rows, cols = self._current_rows_cols() N = RegularMatroid(groundset=deepcopy(rows + cols, memo), reduced_matrix=deepcopy(self._A, memo)) - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -6593,5 +6593,5 @@ cdef class RegularMatroid(LinearMatroid): rows, cols = self._current_rows_cols() gs = rows + cols reduced = True - data = (A, gs, reduced, getattr(self, '__custom_name')) + data = (A, gs, reduced, getattr(self, '_custom_name')) return sage.matroids.unpickling.unpickle_regular_matroid, (version, data) diff --git a/src/sage/matroids/matroid.pxd b/src/sage/matroids/matroid.pxd index fe6c07e3b71..54af72317ba 100644 --- a/src/sage/matroids/matroid.pxd +++ b/src/sage/matroids/matroid.pxd @@ -1,7 +1,6 @@ from sage.structure.sage_object cimport SageObject cdef class Matroid(SageObject): - cdef public __custom_name cdef public _custom_name cdef public _cached_info cdef int _stored_full_rank diff --git a/src/sage/matroids/minor_matroid.py b/src/sage/matroids/minor_matroid.py index c0e756917f5..24dc60d11d0 100644 --- a/src/sage/matroids/minor_matroid.py +++ b/src/sage/matroids/minor_matroid.py @@ -486,8 +486,8 @@ def __copy__(self): True """ N = MinorMatroid(self._matroid, self._contractions, self._deletions) - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '__custom_name')) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo={}): @@ -512,8 +512,8 @@ def __deepcopy__(self, memo={}): from copy import deepcopy # Since matroids are immutable, N cannot reference itself in correct code, so no need to worry about the recursion. N = MinorMatroid(deepcopy(self._matroid, memo), deepcopy(self._contractions, memo), deepcopy(self._deletions, memo)) - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): @@ -534,6 +534,6 @@ def __reduce__(self): 4: {{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'}}} """ import sage.matroids.unpickling - data = (self._matroid, self._contractions, self._deletions, getattr(self, '__custom_name')) + data = (self._matroid, self._contractions, self._deletions, getattr(self, '_custom_name')) version = 0 return sage.matroids.unpickling.unpickle_minor_matroid, (version, data) diff --git a/src/sage/matroids/rank_matroid.py b/src/sage/matroids/rank_matroid.py index 4633ff0a792..dd443eb6390 100644 --- a/src/sage/matroids/rank_matroid.py +++ b/src/sage/matroids/rank_matroid.py @@ -267,9 +267,9 @@ def __copy__(self): N = RankMatroid(groundset=[], rank_function=None) N._groundset = self._groundset N._rank_function = self._rank_function - if getattr(self, '__custom_name') is not None: + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '__custom_name')) + N.rename(getattr(self, '_custom_name')) return N def __deepcopy__(self, memo={}): @@ -293,8 +293,8 @@ def __deepcopy__(self, memo={}): from copy import deepcopy # Since matroids are immutable, N cannot reference itself in correct code, so no need to worry about the recursion. N = RankMatroid(groundset=deepcopy(self._groundset), rank_function=deepcopy(self._rank_function)) - if getattr(self, '__custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '__custom_name'), memo)) + if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy + N.rename(deepcopy(getattr(self, '_custom_name'), memo)) return N def __reduce__(self): diff --git a/src/sage/quivers/representation.py b/src/sage/quivers/representation.py index 9c11eb8ad0e..47d113778a6 100644 --- a/src/sage/quivers/representation.py +++ b/src/sage/quivers/representation.py @@ -1297,8 +1297,8 @@ def copy(self): sage: v.get_element(1) (1, 0) """ - if hasattr(self, '__custom_name'): - name = self.__custom_name + if hasattr(self, '_custom_name'): + name = self._custom_name else: name = None return self.parent()(self._elems.copy(), name) diff --git a/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py b/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py index a27e75f5fce..6c70b55a7bb 100644 --- a/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py +++ b/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py @@ -804,8 +804,8 @@ def _latex_(self): \phi sage: phi.reset_name() """ - if hasattr(self, '__custom_name'): - return latex_variable_name(getattr(self, '__custom_name')) + if hasattr(self, '_custom_name'): + return latex_variable_name(getattr(self, '_custom_name')) else: return f'\\phi: {latex(self._function_ring.gen())} \\mapsto ' \ f'{latex(self._gen)}' diff --git a/src/sage/sets/set_from_iterator.py b/src/sage/sets/set_from_iterator.py index c47bb76920b..d0e3de48f5c 100644 --- a/src/sage/sets/set_from_iterator.py +++ b/src/sage/sets/set_from_iterator.py @@ -217,7 +217,7 @@ def __reduce__(self): (self._func, # func getattr(self, '_args', None), # args getattr(self, '_kwds', None), # kwds - getattr(self, '__custom_name', None), # name + getattr(self, '_custom_name', None), # name self.category(), # category hasattr(self, '_cache')) # cache ) diff --git a/src/sage/structure/sage_object.pyx b/src/sage/structure/sage_object.pyx index 8474142eaa1..9f1a4ece91a 100644 --- a/src/sage/structure/sage_object.pyx +++ b/src/sage/structure/sage_object.pyx @@ -110,15 +110,15 @@ cdef class SageObject: a lot of memory. To support them for a specific class, add a - ``cdef public __custom_name`` attribute. + ``cdef public _custom_name`` attribute. """ if x is None: - #if hasattr(self, '__custom_name'): + #if hasattr(self, '_custom_name'): # that's tested in reset_name anyway... self.reset_name() else: try: - self.__custom_name = str(x) + self._custom_name = str(x) except AttributeError: raise NotImplementedError("object does not support renaming: %s" % self) @@ -138,8 +138,8 @@ cdef class SageObject: sage: P Univariate Polynomial Ring in x over Rational Field """ - if hasattr(self, '__custom_name'): - del self.__custom_name + if hasattr(self, '_custom_name'): + del self._custom_name def __repr__(self): """ @@ -181,7 +181,7 @@ cdef class SageObject: """ try: - name = self.__custom_name + name = self._custom_name if name is not None: return name except AttributeError: diff --git a/src/sage/topology/simplicial_set.py b/src/sage/topology/simplicial_set.py index 42cc3f77780..5792c6d0f91 100644 --- a/src/sage/topology/simplicial_set.py +++ b/src/sage/topology/simplicial_set.py @@ -570,13 +570,13 @@ def __lt__(self, other): return True if self.degeneracies() and other.degeneracies() and self.degeneracies() != other.degeneracies(): return self.degeneracies() < other.degeneracies() - if hasattr(self.nondegenerate(), '__custom_name'): - if hasattr(other.nondegenerate(), '__custom_name'): + if hasattr(self.nondegenerate(), '_custom_name'): + if hasattr(other.nondegenerate(), '_custom_name'): return str(self) < str(other) return True - if (hasattr(other, '__custom_name') - or hasattr(other.nondegenerate(), '__custom_name')): + if (hasattr(other, '_custom_name') + or hasattr(other.nondegenerate(), '_custom_name')): return False return id(self) < id(other) @@ -793,7 +793,7 @@ def __copy__(self): # dimension, the degeneracies, and the name (with a prime # added). sigma = AbstractSimplex(self._dim, degeneracies=self.degeneracies()) - if hasattr(self, '__custom_name'): + if hasattr(self, '_custom_name'): sigma.rename(str(self) + "'") return sigma @@ -839,7 +839,7 @@ def __deepcopy__(self, memo): return memo[underlying].apply_degeneracies(*degens) except KeyError: sigma = AbstractSimplex(underlying._dim) - if hasattr(underlying, '__custom_name'): + if hasattr(underlying, '_custom_name'): sigma.rename(str(self) + "'") memo[underlying] = sigma return sigma.apply_degeneracies(*degens) @@ -896,11 +896,11 @@ def _latex_(self): """ if self._latex_name is not None: return self._latex_name - if hasattr(self, '__custom_name'): + if hasattr(self, '_custom_name'): return str(self) if self.nondegenerate()._latex_name is not None: simplex = self.nondegenerate()._latex_name - elif hasattr(self.nondegenerate(), '__custom_name'): + elif hasattr(self.nondegenerate(), '_custom_name'): simplex = str(self.nondegenerate()) else: simplex = "\\Delta^{{{}}}".format(self._dim) diff --git a/src/sage/topology/simplicial_set_constructions.py b/src/sage/topology/simplicial_set_constructions.py index ae98821df8a..f887443abeb 100644 --- a/src/sage/topology/simplicial_set_constructions.py +++ b/src/sage/topology/simplicial_set_constructions.py @@ -176,7 +176,7 @@ def __init__(self, data, ambient=None): else: SimplicialSet_finite.__init__(self, data) if self == ambient: - if hasattr(ambient, '__custom_name'): + if hasattr(ambient, '_custom_name'): self.rename(str(ambient)) self._latex_name = latex(ambient) # When constructing the inclusion map, we do not need to check From 252f0bbbd5886277ffefea38888461f36d0b8240 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:42:36 +0800 Subject: [PATCH 26/54] rename __crt -> _crt --- src/sage/rings/finite_rings/integer_mod.pyx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/sage/rings/finite_rings/integer_mod.pyx b/src/sage/rings/finite_rings/integer_mod.pyx index 9dba0a06c71..d64ba5af84f 100644 --- a/src/sage/rings/finite_rings/integer_mod.pyx +++ b/src/sage/rings/finite_rings/integer_mod.pyx @@ -1708,14 +1708,14 @@ cdef class IntegerMod_abstract(FiniteRingElement): if other._modulus.int64 == 1: return self new_modulus = self._modulus.int64 * other._modulus.int64 if new_modulus < INTEGER_MOD_INT32_LIMIT: - return self.__crt(other) + return self._crt(other) elif new_modulus < INTEGER_MOD_INT64_LIMIT: if not isinstance(self, IntegerMod_int64): self = IntegerMod_int64(self._parent, self.lift()) if not isinstance(other, IntegerMod_int64): other = IntegerMod_int64(other._parent, other.lift()) - return self.__crt(other) + return self._crt(other) if not isinstance(self, IntegerMod_gmp): if self._modulus.int64 == 1: return other @@ -1725,7 +1725,7 @@ cdef class IntegerMod_abstract(FiniteRingElement): if other._modulus.int64 == 1: return self other = IntegerMod_gmp(other._parent, other.lift()) - return self.__crt(other) + return self._crt(other) def additive_order(self): r""" @@ -2132,7 +2132,7 @@ cdef class IntegerMod_gmp(IntegerMod_abstract): """ return self.lift().gcd(self.modulus()) == 1 - def __crt(IntegerMod_gmp self, IntegerMod_gmp other): + def _crt(IntegerMod_gmp self, IntegerMod_gmp other): cdef IntegerMod_gmp lift, x cdef sage.rings.integer.Integer modulus, other_modulus @@ -2521,7 +2521,7 @@ cdef class IntegerMod_int(IntegerMod_abstract): """ return gcd_int(self.ivalue, self._modulus.int32) == 1 - def __crt(IntegerMod_int self, IntegerMod_int other): + def _crt(IntegerMod_int self, IntegerMod_int other): """ Use the Chinese Remainder Theorem to find an element of the integers modulo the product of the moduli that reduces to self and @@ -3346,7 +3346,7 @@ cdef class IntegerMod_int64(IntegerMod_abstract): """ return gcd_int64(self.ivalue, self._modulus.int64) == 1 - def __crt(IntegerMod_int64 self, IntegerMod_int64 other): + def _crt(IntegerMod_int64 self, IntegerMod_int64 other): """ Use the Chinese Remainder Theorem to find an element of the integers modulo the product of the moduli that reduces to self and From 75f522d74ff0a0fcac4861671ece5cbc1dde1c12 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 15:44:09 +0800 Subject: [PATCH 27/54] rename __is_gen -> _is_gen --- src/sage/rings/power_series_mpoly.pyx | 2 +- src/sage/rings/power_series_poly.pyx | 2 +- src/sage/rings/power_series_ring_element.pxd | 2 +- src/sage/rings/power_series_ring_element.pyx | 4 ++-- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/sage/rings/power_series_mpoly.pyx b/src/sage/rings/power_series_mpoly.pyx index 0c901a3557b..b8a68c33a25 100644 --- a/src/sage/rings/power_series_mpoly.pyx +++ b/src/sage/rings/power_series_mpoly.pyx @@ -65,7 +65,7 @@ cdef class PowerSeries_mpoly(PowerSeries): def __reduce__(self): # do *not* delete old versions. - return make_powerseries_mpoly_v0, (self._parent, self.__f, self._prec, self.__is_gen) + return make_powerseries_mpoly_v0, (self._parent, self.__f, self._prec, self._is_gen) def __call__(self, *args, **kwds): if len(kwds) == 0 and len(args) == 1: diff --git a/src/sage/rings/power_series_poly.pyx b/src/sage/rings/power_series_poly.pyx index 7c93168d4b1..6cacab1f0c8 100644 --- a/src/sage/rings/power_series_poly.pyx +++ b/src/sage/rings/power_series_poly.pyx @@ -97,7 +97,7 @@ cdef class PowerSeries_poly(PowerSeries): sage: f == loads(dumps(f)) # indirect doctest True """ - return self.__class__, (self._parent, self.__f, self._prec, self.__is_gen) + return self.__class__, (self._parent, self.__f, self._prec, self._is_gen) def polynomial(self): """ diff --git a/src/sage/rings/power_series_ring_element.pxd b/src/sage/rings/power_series_ring_element.pxd index 067c4f3c6d4..e5c031ee147 100644 --- a/src/sage/rings/power_series_ring_element.pxd +++ b/src/sage/rings/power_series_ring_element.pxd @@ -1,7 +1,7 @@ from sage.structure.element cimport AlgebraElement, RingElement cdef class PowerSeries(AlgebraElement): - cdef char __is_gen + cdef char _is_gen cdef _prec cdef common_prec_c(self, PowerSeries other) #_prec(self, RingElement right_r) diff --git a/src/sage/rings/power_series_ring_element.pyx b/src/sage/rings/power_series_ring_element.pyx index 54314d538ed..e5e2df79e1b 100644 --- a/src/sage/rings/power_series_ring_element.pyx +++ b/src/sage/rings/power_series_ring_element.pyx @@ -159,7 +159,7 @@ cdef class PowerSeries(AlgebraElement): over Finite Field of size 3 """ AlgebraElement.__init__(self, parent) - self.__is_gen = is_gen + self._is_gen = is_gen self._prec = prec def __hash__(self): @@ -234,7 +234,7 @@ cdef class PowerSeries(AlgebraElement): sage: 1*t == t True """ - return bool(self.__is_gen) + return bool(self._is_gen) def _im_gens_(self, codomain, im_gens, base_map=None): """ From 2ee4332fdb746ca2ec6c3f6e4e2344c5ecd86dd8 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 15:49:33 +0800 Subject: [PATCH 28/54] rename __subset -> _subset_internal --- src/sage/matroids/linear_matroid.pyx | 4 +-- src/sage/matroids/matroid.pxd | 2 +- src/sage/matroids/matroid.pyx | 44 ++++++++++++++-------------- 3 files changed, 25 insertions(+), 25 deletions(-) diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index 402c5bbed86..a648d281ab5 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -605,7 +605,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): self._representation = self._basic_representation(B) A = self._representation else: - B = self.__subset(B) + B = self._subset_internal(B) A = self._basic_representation(B) A = A.matrix_from_rows_and_columns(range(A.nrows()), order_idx) if lift_map is None: @@ -622,7 +622,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): if B is None: B = frozenset(self.basis()) else: - B = self.__subset(B) + B = self._subset_internal(B) A = self._reduced_representation(B) R, C = self._current_rows_cols() Ri = [] diff --git a/src/sage/matroids/matroid.pxd b/src/sage/matroids/matroid.pxd index 54af72317ba..a0bb7be9f4c 100644 --- a/src/sage/matroids/matroid.pxd +++ b/src/sage/matroids/matroid.pxd @@ -36,7 +36,7 @@ cdef class Matroid(SageObject): cpdef _line_length(self, F) cpdef _extension(self, element, hyperplanes) - cdef inline __subset(self, X): + cdef inline _subset_internal(self, X): """ Convert ``X`` to a ``frozenset`` and check that it is a subset of the groundset. diff --git a/src/sage/matroids/matroid.pyx b/src/sage/matroids/matroid.pyx index dcee87ea49c..8ac5ec3f678 100644 --- a/src/sage/matroids/matroid.pyx +++ b/src/sage/matroids/matroid.pyx @@ -1307,7 +1307,7 @@ cdef class Matroid(SageObject): TypeError: 'sage.rings.integer.Integer' object is not iterable """ # Call corresponding Cython method - return self.__subset(X) + return self._subset_internal(X) def _subset_all(self, X): """ @@ -1374,7 +1374,7 @@ cdef class Matroid(SageObject): """ if X is None: return self.full_rank() - return self._rank(self.__subset(X)) + return self._rank(self._subset_internal(X)) cpdef full_rank(self): r""" @@ -1453,7 +1453,7 @@ cdef class Matroid(SageObject): ... ValueError: ['x'] is not a subset of the groundset """ - return self._max_independent(self.__subset(X)) + return self._max_independent(self._subset_internal(X)) cpdef circuit(self, X=None): """ @@ -1558,7 +1558,7 @@ cdef class Matroid(SageObject): ... ValueError: ['x'] is not a subset of the groundset """ - return self._closure(self.__subset(X)) + return self._closure(self._subset_internal(X)) cpdef k_closure(self, X, k): r""" @@ -1597,7 +1597,7 @@ cdef class Matroid(SageObject): sage: sorted(M.k_closure({0,1}, 4)) [0, 1, 4] """ - X = self.__subset(X) + X = self._subset_internal(X) cdef int cur cdef frozenset S, cl cur = 0 @@ -1644,7 +1644,7 @@ cdef class Matroid(SageObject): ... ValueError: ['x'] is not a subset of the groundset """ - X = self.__subset(X) + X = self._subset_internal(X) Y = self.__subset_all(Y) return self._augment(X, Y.difference(X)) @@ -1781,7 +1781,7 @@ cdef class Matroid(SageObject): ... ValueError: ['x'] is not a subset of the groundset """ - return self._max_coindependent(self.__subset(X)) + return self._max_coindependent(self._subset_internal(X)) cpdef coclosure(self, X): """ @@ -1813,7 +1813,7 @@ cdef class Matroid(SageObject): ... ValueError: ['x'] is not a subset of the groundset """ - return self._coclosure(self.__subset(X)) + return self._coclosure(self._subset_internal(X)) cpdef cocircuit(self, X=None): """ @@ -1947,7 +1947,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return self._is_independent(self.__subset(X)) + return self._is_independent(self._subset_internal(X)) cpdef is_dependent(self, X): r""" @@ -1973,7 +1973,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return not self._is_independent(self.__subset(X)) + return not self._is_independent(self._subset_internal(X)) cpdef is_basis(self, X): r""" @@ -1999,7 +1999,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - X = self.__subset(X) + X = self._subset_internal(X) if len(X) != self.full_rank(): return False return self._is_basis(X) @@ -2035,7 +2035,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return self._is_closed(self.__subset(X)) + return self._is_closed(self._subset_internal(X)) cpdef is_subset_k_closed(self, X, int k): r""" @@ -2118,7 +2118,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return self._is_circuit(self.__subset(X)) + return self._is_circuit(self._subset_internal(X)) cpdef coloops(self): r""" @@ -2178,7 +2178,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return self._is_coindependent(self.__subset(X)) + return self._is_coindependent(self._subset_internal(X)) cpdef is_codependent(self, X): r""" @@ -2211,7 +2211,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return not self._is_coindependent(self.__subset(X)) + return not self._is_coindependent(self._subset_internal(X)) cpdef is_cobasis(self, X): r""" @@ -2245,7 +2245,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - X = self.__subset(X) + X = self._subset_internal(X) if len(X) != self.full_corank(): return False return self._is_cobasis(X) @@ -2282,7 +2282,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return self._is_cocircuit(self.__subset(X)) + return self._is_cocircuit(self._subset_internal(X)) cpdef is_coclosed(self, X): r""" @@ -2315,7 +2315,7 @@ cdef class Matroid(SageObject): ... ValueError: 'abcx' is not a subset of the groundset """ - return self._is_coclosed(self.__subset(X)) + return self._is_coclosed(self._subset_internal(X)) # verification @@ -4868,10 +4868,10 @@ cdef class Matroid(SageObject): sage: M.connectivity('ab', 'cd') 2 """ - S = self.__subset(S) + S = self._subset_internal(S) if T is None: return self._rank(S) + self._rank(self.groundset()-S) - self.full_rank() - T = self.__subset(T) + T = self._subset_internal(T) if S.intersection(T): raise ValueError("S and T are not disjoint") return len(self._link(S, T)[0]) - self.full_rank() + self._rank(S) + self._rank(T) @@ -4956,8 +4956,8 @@ cdef class Matroid(SageObject): sage: N.connectivity(S) 2 """ - S = self.__subset(S) - T = self.__subset(T) + S = self._subset_internal(S) + T = self._subset_internal(T) if not S.isdisjoint(T): raise ValueError("S and T are not disjoint") return self._link(S, T) From 8386b4ef1592e3ae65071874f8e7bf2fb6ce3806 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 15:53:42 +0800 Subject: [PATCH 29/54] rename __relabel -> _relabel --- src/sage/matroids/basis_exchange_matroid.pxd | 2 +- src/sage/matroids/basis_exchange_matroid.pyx | 2 +- src/sage/matroids/basis_matroid.pyx | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/sage/matroids/basis_exchange_matroid.pxd b/src/sage/matroids/basis_exchange_matroid.pxd index d2d8e91aab7..28cc7ad868c 100644 --- a/src/sage/matroids/basis_exchange_matroid.pxd +++ b/src/sage/matroids/basis_exchange_matroid.pxd @@ -15,7 +15,7 @@ cdef class BasisExchangeMatroid(Matroid): cdef _weak_invariant_var, _strong_invariant_var, _heuristic_invariant_var cdef SetSystem _weak_partition_var, _strong_partition_var, _heuristic_partition_var - cdef __relabel(self, l) + cdef _relabel(self, l) cdef _pack(self, bitset_t, X) cdef __unpack(self, bitset_t) diff --git a/src/sage/matroids/basis_exchange_matroid.pyx b/src/sage/matroids/basis_exchange_matroid.pyx index 26b8eedefb5..015fa8b8df3 100644 --- a/src/sage/matroids/basis_exchange_matroid.pyx +++ b/src/sage/matroids/basis_exchange_matroid.pyx @@ -191,7 +191,7 @@ cdef class BasisExchangeMatroid(Matroid): bitset_free(self._output) bitset_free(self._temp) - cdef __relabel(self, l): + cdef _relabel(self, l): """ Relabel each element `e` as `l[e]`, where `l` is a given injective map. diff --git a/src/sage/matroids/basis_matroid.pyx b/src/sage/matroids/basis_matroid.pyx index 56357ca7878..da66df5bd73 100644 --- a/src/sage/matroids/basis_matroid.pyx +++ b/src/sage/matroids/basis_matroid.pyx @@ -557,7 +557,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): """ M = BasisMatroid(M=self) - M.__relabel(l) + M._relabel(l) return M # enumeration From d7999944fcdd3df896d06e7241a69352ee788285 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:44:46 +0800 Subject: [PATCH 30/54] rename __fld_denominator -> _fld_denominator --- .../rings/number_field/number_field_element.pxd | 2 +- .../rings/number_field/number_field_element.pyx | 14 +++++++------- .../number_field_element_quadratic.pyx | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/sage/rings/number_field/number_field_element.pxd b/src/sage/rings/number_field/number_field_element.pxd index 418e54aba8c..fe77101f6cc 100644 --- a/src/sage/rings/number_field/number_field_element.pxd +++ b/src/sage/rings/number_field/number_field_element.pxd @@ -16,7 +16,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # Pointers to the defining polynomial (with numerator) for the field. # I keep these as pointers for arithmetic speed. cdef ntl_ZZX __fld_numerator - cdef ntl_ZZ __fld_denominator + cdef ntl_ZZ _fld_denominator cdef object __multiplicative_order cdef object __pari cdef object __matrix diff --git a/src/sage/rings/number_field/number_field_element.pyx b/src/sage/rings/number_field/number_field_element.pyx index 6a0041d2e8e..be9dcda3b1d 100644 --- a/src/sage/rings/number_field/number_field_element.pyx +++ b/src/sage/rings/number_field/number_field_element.pyx @@ -219,7 +219,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef NumberFieldElement x = t.__new__(t) x._parent = self._parent x.__fld_numerator = self.__fld_numerator - x.__fld_denominator = self.__fld_denominator + x._fld_denominator = self._fld_denominator return x cdef number_field(self): @@ -317,7 +317,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): True """ FieldElement.__init__(self, parent) - self.__fld_numerator, self.__fld_denominator = parent.absolute_polynomial_ntl() + self.__fld_numerator, self._fld_denominator = parent.absolute_polynomial_ntl() cdef ZZ_c coeff if isinstance(f, (int, Integer_sage)): @@ -417,7 +417,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef type t = type(self) cdef NumberFieldElement x = t.__new__(t) x._parent = new_parent - x.__fld_numerator, x.__fld_denominator = new_parent.polynomial_ntl() + x.__fld_numerator, x._fld_denominator = new_parent.polynomial_ntl() x._denominator = self._denominator cdef ZZX_c result cdef ZZ_c tmp @@ -2577,11 +2577,11 @@ cdef class NumberFieldElement(NumberFieldElement_base): else: ZZX_mul(x._numerator, self._numerator, _right._numerator) if ZZX_deg(x._numerator) >= ZZX_deg(self.__fld_numerator.x): - ZZX_mul_ZZ( x._numerator, x._numerator, self.__fld_denominator.x ) + ZZX_mul_ZZ( x._numerator, x._numerator, self._fld_denominator.x ) ZZX_mul_ZZ( temp, self.__fld_numerator.x, x._denominator ) ZZ_power(temp1,ZZX_LeadCoeff(temp),ZZX_deg(x._numerator)-ZZX_deg(self.__fld_numerator.x)+1) ZZX_PseudoRem(x._numerator, x._numerator, temp) - ZZ_mul(x._denominator, x._denominator, self.__fld_denominator.x) + ZZ_mul(x._denominator, x._denominator, self._fld_denominator.x) ZZ_mul(x._denominator, x._denominator, temp1) sig_off() x._reduce_c_() @@ -5323,7 +5323,7 @@ cdef class OrderElement_absolute(NumberFieldElement_absolute): x._parent = self._parent x._number_field = self._parent.number_field() x.__fld_numerator = self.__fld_numerator - x.__fld_denominator = self.__fld_denominator + x._fld_denominator = self._fld_denominator return x cdef number_field(self): @@ -5444,7 +5444,7 @@ cdef class OrderElement_relative(NumberFieldElement_relative): x._parent = self._parent x._number_field = self._parent.number_field() x.__fld_numerator = self.__fld_numerator - x.__fld_denominator = self.__fld_denominator + x._fld_denominator = self._fld_denominator return x def __invert__(self): diff --git a/src/sage/rings/number_field/number_field_element_quadratic.pyx b/src/sage/rings/number_field/number_field_element_quadratic.pyx index 88f4c92ce8b..0a41607d124 100644 --- a/src/sage/rings/number_field/number_field_element_quadratic.pyx +++ b/src/sage/rings/number_field/number_field_element_quadratic.pyx @@ -610,7 +610,7 @@ cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute): mpz_clear(tmp_mpz) x._parent = new_parent - x.__fld_numerator, x.__fld_denominator = new_parent.polynomial_ntl() + x.__fld_numerator, x._fld_denominator = new_parent.polynomial_ntl() x._denominator = elt_den cdef ZZX_c result cdef ZZ_c tmp From dedfbf71fd4d0fd6c96c0b0ab0a1fca5705a5192 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:45:03 +0800 Subject: [PATCH 31/54] rename __fld_numerator -> _fld_numerator --- .../quatalg/quaternion_algebra_element.pyx | 2 +- .../number_field/number_field_element.pxd | 2 +- .../number_field/number_field_element.pyx | 30 +++++++++---------- .../number_field_element_quadratic.pyx | 2 +- 4 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/sage/algebras/quatalg/quaternion_algebra_element.pyx b/src/sage/algebras/quatalg/quaternion_algebra_element.pyx index b42182851fa..8cb7e848fd0 100644 --- a/src/sage/algebras/quatalg/quaternion_algebra_element.pyx +++ b/src/sage/algebras/quatalg/quaternion_algebra_element.pyx @@ -1727,7 +1727,7 @@ cdef class QuaternionAlgebraElement_number_field(QuaternionAlgebraElement_abstra fmpz_poly_set_ZZX(self.a, a._numerator) # we will assume that the denominator of a and b are 1 fmpz_poly_set_ZZX(self.b, b._numerator) - fmpz_poly_set_ZZX(self.modulus, (x).__fld_numerator.x) # and same for the modulus + fmpz_poly_set_ZZX(self.modulus, (x)._fld_numerator.x) # and same for the modulus def __getitem__(self, int i): """ diff --git a/src/sage/rings/number_field/number_field_element.pxd b/src/sage/rings/number_field/number_field_element.pxd index fe77101f6cc..c3d8a8b4a4b 100644 --- a/src/sage/rings/number_field/number_field_element.pxd +++ b/src/sage/rings/number_field/number_field_element.pxd @@ -15,7 +15,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef ZZ_c _denominator # Pointers to the defining polynomial (with numerator) for the field. # I keep these as pointers for arithmetic speed. - cdef ntl_ZZX __fld_numerator + cdef ntl_ZZX _fld_numerator cdef ntl_ZZ _fld_denominator cdef object __multiplicative_order cdef object __pari diff --git a/src/sage/rings/number_field/number_field_element.pyx b/src/sage/rings/number_field/number_field_element.pyx index be9dcda3b1d..d44fc55b70c 100644 --- a/src/sage/rings/number_field/number_field_element.pyx +++ b/src/sage/rings/number_field/number_field_element.pyx @@ -218,7 +218,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef type t = type(self) cdef NumberFieldElement x = t.__new__(t) x._parent = self._parent - x.__fld_numerator = self.__fld_numerator + x._fld_numerator = self._fld_numerator x._fld_denominator = self._fld_denominator return x @@ -317,7 +317,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): True """ FieldElement.__init__(self, parent) - self.__fld_numerator, self._fld_denominator = parent.absolute_polynomial_ntl() + self._fld_numerator, self._fld_denominator = parent.absolute_polynomial_ntl() cdef ZZ_c coeff if isinstance(f, (int, Integer_sage)): @@ -417,7 +417,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): cdef type t = type(self) cdef NumberFieldElement x = t.__new__(t) x._parent = new_parent - x.__fld_numerator, x._fld_denominator = new_parent.polynomial_ntl() + x._fld_numerator, x._fld_denominator = new_parent.polynomial_ntl() x._denominator = self._denominator cdef ZZX_c result cdef ZZ_c tmp @@ -427,7 +427,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): for i from 0 <= i <= ZZX_deg(self._numerator): tmp = ZZX_coeff(self._numerator, i) ZZX_SetCoeff(result, i*rel, tmp) - ZZX_rem(x._numerator, result, x.__fld_numerator.x) + ZZX_rem(x._numerator, result, x._fld_numerator.x) return x def __reduce__(self): @@ -966,7 +966,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # set the denominator mpz_set_si(denom_temp.value, 1) mpz_to_ZZ(&self._denominator, (denom_temp).value) - for i from 0 <= i < ZZX_deg(self.__fld_numerator.x): + for i from 0 <= i < ZZX_deg(self._fld_numerator.x): tmp_integer = (ZZ.random_element(x=num_bound, distribution=distribution)) mpz_to_ZZ(&ntl_temp, (tmp_integer).value) @@ -977,7 +977,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): mpz_set_si(denom_temp.value, 1) tmp_integer = Integer.__new__(Integer) - for i from 0 <= i < ZZX_deg(self.__fld_numerator.x): + for i from 0 <= i < ZZX_deg(self._fld_numerator.x): tmp_rational = (QQ.random_element(num_bound=num_bound, den_bound=den_bound, distribution=distribution)) @@ -992,7 +992,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): mpz_to_ZZ(&self._denominator, (denom_temp).value) # now the coefficients themselves. - for i from 0 <= i < ZZX_deg(self.__fld_numerator.x): + for i from 0 <= i < ZZX_deg(self._fld_numerator.x): # calculate the new numerator. if our old entry is # p/q, and the lcm is k, it's just pk/q, which we # also know is integral -- so we can use mpz_divexact @@ -2572,14 +2572,14 @@ cdef class NumberFieldElement(NumberFieldElement_base): # MulMod doesn't handle non-monic polynomials. # Therefore, we handle the non-monic case entirely separately. ZZ_mul(x._denominator, self._denominator, _right._denominator) - if ZZ_IsOne(ZZX_LeadCoeff(self.__fld_numerator.x)): - ZZX_MulMod(x._numerator, self._numerator, _right._numerator, self.__fld_numerator.x) + if ZZ_IsOne(ZZX_LeadCoeff(self._fld_numerator.x)): + ZZX_MulMod(x._numerator, self._numerator, _right._numerator, self._fld_numerator.x) else: ZZX_mul(x._numerator, self._numerator, _right._numerator) - if ZZX_deg(x._numerator) >= ZZX_deg(self.__fld_numerator.x): + if ZZX_deg(x._numerator) >= ZZX_deg(self._fld_numerator.x): ZZX_mul_ZZ( x._numerator, x._numerator, self._fld_denominator.x ) - ZZX_mul_ZZ( temp, self.__fld_numerator.x, x._denominator ) - ZZ_power(temp1,ZZX_LeadCoeff(temp),ZZX_deg(x._numerator)-ZZX_deg(self.__fld_numerator.x)+1) + ZZX_mul_ZZ( temp, self._fld_numerator.x, x._denominator ) + ZZ_power(temp1,ZZX_LeadCoeff(temp),ZZX_deg(x._numerator)-ZZX_deg(self._fld_numerator.x)+1) ZZX_PseudoRem(x._numerator, x._numerator, temp) ZZ_mul(x._denominator, x._denominator, self._fld_denominator.x) ZZ_mul(x._denominator, x._denominator, temp1) @@ -2835,7 +2835,7 @@ cdef class NumberFieldElement(NumberFieldElement_base): # but may fail if NTL runs out of FFT primes. x = self._new() sig_on() - ZZX_XGCD(x._denominator, x._numerator, temp, self._numerator, self.__fld_numerator.x, 1) + ZZX_XGCD(x._denominator, x._numerator, temp, self._numerator, self._fld_numerator.x, 1) ZZX_mul_ZZ(x._numerator, x._numerator, self._denominator) x._reduce_c_() sig_off() @@ -5322,7 +5322,7 @@ cdef class OrderElement_absolute(NumberFieldElement_absolute): cdef OrderElement_absolute x = t.__new__(t) x._parent = self._parent x._number_field = self._parent.number_field() - x.__fld_numerator = self.__fld_numerator + x._fld_numerator = self._fld_numerator x._fld_denominator = self._fld_denominator return x @@ -5443,7 +5443,7 @@ cdef class OrderElement_relative(NumberFieldElement_relative): cdef OrderElement_relative x = t.__new__(t) x._parent = self._parent x._number_field = self._parent.number_field() - x.__fld_numerator = self.__fld_numerator + x._fld_numerator = self._fld_numerator x._fld_denominator = self._fld_denominator return x diff --git a/src/sage/rings/number_field/number_field_element_quadratic.pyx b/src/sage/rings/number_field/number_field_element_quadratic.pyx index 0a41607d124..c32f6aadd10 100644 --- a/src/sage/rings/number_field/number_field_element_quadratic.pyx +++ b/src/sage/rings/number_field/number_field_element_quadratic.pyx @@ -610,7 +610,7 @@ cdef class NumberFieldElement_quadratic(NumberFieldElement_absolute): mpz_clear(tmp_mpz) x._parent = new_parent - x.__fld_numerator, x._fld_denominator = new_parent.polynomial_ntl() + x._fld_numerator, x._fld_denominator = new_parent.polynomial_ntl() x._denominator = elt_den cdef ZZX_c result cdef ZZ_c tmp From 117880c98bed5a284e24d055dad65019042dde41 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:45:39 +0800 Subject: [PATCH 32/54] rename __prec -> _prec --- src/sage/numerical/gauss_legendre.pyx | 4 +- src/sage/rings/complex_mpc.pxd | 2 +- src/sage/rings/complex_mpc.pyx | 26 ++--- .../polynomial/polynomial_real_mpfr_dense.pyx | 10 +- src/sage/rings/real_mpfi.pxd | 2 +- src/sage/rings/real_mpfi.pyx | 24 ++-- src/sage/rings/real_mpfr.pxd | 2 +- src/sage/rings/real_mpfr.pyx | 104 +++++++++--------- 8 files changed, 87 insertions(+), 87 deletions(-) diff --git a/src/sage/numerical/gauss_legendre.pyx b/src/sage/numerical/gauss_legendre.pyx index 5325797c7aa..96708c5b1ac 100644 --- a/src/sage/numerical/gauss_legendre.pyx +++ b/src/sage/numerical/gauss_legendre.pyx @@ -117,8 +117,8 @@ def nodes_uncached(degree, prec): raise ValueError("degree=%s not supported (degree must be 3 or even)" % degree) R = RealField(int(prec*3/2)) Rout = RealField(prec) - mpfr_init2(u,R.__prec) - mpfr_init2(v,R.__prec) + mpfr_init2(u,R._prec) + mpfr_init2(v,R._prec) ZERO = R.zero() ONE = R.one() HALF = ONE/2 diff --git a/src/sage/rings/complex_mpc.pxd b/src/sage/rings/complex_mpc.pxd index 762c38afbdc..f7d8cb9492c 100644 --- a/src/sage/rings/complex_mpc.pxd +++ b/src/sage/rings/complex_mpc.pxd @@ -11,7 +11,7 @@ cdef class MPComplexNumber(sage.structure.element.FieldElement): cpdef _mul_(self, other) cdef class MPComplexField_class(sage.rings.ring.Field): - cdef readonly int __prec + cdef readonly int _prec cdef mpc_rnd_t __rnd cdef object __rnd_str cdef object __real_field diff --git a/src/sage/rings/complex_mpc.pyx b/src/sage/rings/complex_mpc.pyx index b3681ff724f..bdd5c4e4fe6 100644 --- a/src/sage/rings/complex_mpc.pyx +++ b/src/sage/rings/complex_mpc.pyx @@ -307,7 +307,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): if prec < mpfr_prec_min() or prec > mpfr_prec_max(): raise ValueError("prec (=%s) must be >= %s and <= %s." % ( prec, mpfr_prec_min(), mpfr_prec_max())) - self.__prec = prec + self._prec = prec if not isinstance(rnd, str): raise TypeError("rnd must be a string") try: @@ -331,7 +331,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): cdef MPComplexNumber z z = MPComplexNumber.__new__(MPComplexNumber) z._parent = self - mpc_init2(z.value, self.__prec) + mpc_init2(z.value, self._prec) z.init = 1 return z @@ -344,7 +344,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): sage: MPComplexField(200, 'RNDDU') # indirect doctest Complex Field with 200 bits of precision and rounding RNDDU """ - s = "Complex Field with %s bits of precision"%self.__prec + s = "Complex Field with %s bits of precision"%self._prec if self.__rnd != MPC_RNDNN: s = s + " and rounding %s"%(self.__rnd_str) return s @@ -465,13 +465,13 @@ cdef class MPComplexField_class(sage.rings.ring.Field): if RR.has_coerce_map_from(S): return self._coerce_map_via([RR], S) - if isinstance(S, MPComplexField_class) and S.prec() >= self.__prec: + if isinstance(S, MPComplexField_class) and S.prec() >= self._prec: #FIXME: What map when rounding modes differ but prec is the same ? # How to provide commutativity of morphisms ? # Change _cmp_ when done return MPCtoMPC(S, self) - if isinstance(S, ComplexField_class) and S.prec() >= self.__prec: + if isinstance(S, ComplexField_class) and S.prec() >= self._prec: return CCtoMPC(S, self) late_import() @@ -490,7 +490,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): sage: loads(dumps(C)) == C True """ - return __create__MPComplexField_version0, (self.__prec, self.__rnd_str) + return __create__MPComplexField_version0, (self._prec, self.__rnd_str) def __richcmp__(left, right, int op): """ @@ -513,7 +513,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): cdef MPComplexField_class s = left cdef MPComplexField_class o = right - return richcmp(s.__prec, o.__prec, op) + return richcmp(s._prec, o._prec, op) def gen(self, n=0): """ @@ -604,7 +604,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): sage: C = MPComplexField(10, 'RNDNZ'); C.name() 'MPComplexField10_RNDNZ' """ - return "MPComplexField%s_%s"%(self.__prec, self.__rnd_str) + return "MPComplexField%s_%s"%(self._prec, self.__rnd_str) def __hash__(self): """ @@ -629,7 +629,7 @@ cdef class MPComplexField_class(sage.rings.ring.Field): sage: MPComplexField(22).prec() 22 """ - return self.__prec + return self._prec def rounding_mode(self): """ @@ -707,7 +707,7 @@ cdef class MPComplexNumber(sage.structure.element.FieldElement): cdef MPComplexNumber z z = MPComplexNumber.__new__(MPComplexNumber) z._parent = self._parent - mpc_init2(z.value, (self._parent).__prec) + mpc_init2(z.value, (self._parent)._prec) z.init = 1 return z @@ -760,7 +760,7 @@ cdef class MPComplexNumber(sage.structure.element.FieldElement): if parent is None: raise TypeError self._parent = parent - mpc_init2(self.value, parent.__prec) + mpc_init2(self.value, parent._prec) self.init = 1 if x is None: return self._set(x, y, base) @@ -1010,7 +1010,7 @@ cdef class MPComplexNumber(sage.structure.element.FieldElement): sage: i.prec() 2000 """ - return (self._parent).__prec + return (self._parent)._prec def real(self): """ @@ -2347,7 +2347,7 @@ cdef class MPComplexNumber(sage.structure.element.FieldElement): cdef mpc_rnd_t rnd = ((self._parent)).__rnd - cdef int prec = self._parent.__prec + cdef int prec = self._parent._prec if optimal or algorithm == "principal": if not isinstance(right, MPComplexNumber) or (right)._parent is not self._parent: diff --git a/src/sage/rings/polynomial/polynomial_real_mpfr_dense.pyx b/src/sage/rings/polynomial/polynomial_real_mpfr_dense.pyx index fbe96d186c5..955f83468e4 100644 --- a/src/sage/rings/polynomial/polynomial_real_mpfr_dense.pyx +++ b/src/sage/rings/polynomial/polynomial_real_mpfr_dense.pyx @@ -116,7 +116,7 @@ cdef class PolynomialRealDense(Polynomial): Polynomial.__init__(self, parent, is_gen=is_gen) self._base_ring = parent._base cdef Py_ssize_t i, degree - cdef int prec = self._base_ring.__prec + cdef int prec = self._base_ring._prec cdef mpfr_rnd_t rnd = self._base_ring.rnd if x is None: self._coeffs = check_allocarray(1, sizeof(mpfr_t)) # degree zero @@ -227,7 +227,7 @@ cdef class PolynomialRealDense(Polynomial): cdef PolynomialRealDense _new(self, Py_ssize_t degree): cdef Py_ssize_t i - cdef int prec = self._base_ring.__prec + cdef int prec = self._base_ring._prec cdef PolynomialRealDense f = PolynomialRealDense.__new__(PolynomialRealDense) f._parent = self._parent f._base_ring = self._base_ring @@ -501,7 +501,7 @@ cdef class PolynomialRealDense(Polynomial): else: f = left._new(left._degree + right._degree) sig_on() - mpfr_init2(tmp, left._base_ring.__prec) + mpfr_init2(tmp, left._base_ring._prec) for i from 0 <= i <= f._degree: # Yes, we could make this more efficient by initializing with # a multiple of left rather than all zeros... @@ -661,7 +661,7 @@ cdef class PolynomialRealDense(Polynomial): q = self._new(self._degree - other._degree) # This is the standard division algorithm sig_on() - mpfr_init2(tmp, self._base_ring.__prec) + mpfr_init2(tmp, self._base_ring._prec) for i from self._degree >= i >= other._degree: mpfr_set(q._coeffs[i-other._degree], r._coeffs[i], rnd) for j from 0 <= j < other._degree: @@ -725,7 +725,7 @@ cdef class PolynomialRealDense(Polynomial): cdef RealNumber x = xx cdef RealNumber res - if (x._parent).__prec < self._base_ring.__prec: + if (x._parent)._prec < self._base_ring._prec: res = RealNumber(x._parent) else: res = RealNumber(self._base_ring) diff --git a/src/sage/rings/real_mpfi.pxd b/src/sage/rings/real_mpfi.pxd index 959a650aafc..4201788d198 100644 --- a/src/sage/rings/real_mpfi.pxd +++ b/src/sage/rings/real_mpfi.pxd @@ -11,7 +11,7 @@ from .real_mpfr cimport RealField_class cdef class RealIntervalFieldElement(RingElement) # forward decl cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): - cdef mpfr_prec_t __prec + cdef mpfr_prec_t _prec cdef bint sci_not # Cache RealField instances for the lower, upper, and middle bounds. # These have the same precision as the interval field; diff --git a/src/sage/rings/real_mpfi.pyx b/src/sage/rings/real_mpfi.pyx index 1193a14baff..509f6f63da0 100644 --- a/src/sage/rings/real_mpfi.pyx +++ b/src/sage/rings/real_mpfi.pyx @@ -526,7 +526,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): if prec < MPFR_PREC_MIN or prec > MPFR_PREC_MAX: raise ValueError("prec (=%s) must be >= %s and <= %s." % ( prec, MPFR_PREC_MIN, MPFR_PREC_MAX)) - self.__prec = prec + self._prec = prec self.sci_not = sci_not self.__lower_field = RealField(prec, sci_not, "RNDD") self.__middle_field = RealField(prec, sci_not, "RNDN") @@ -598,7 +598,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): elif rnd == "RNDU": return self.upper_field() else: - return RealField(self.__prec, self.sci_not, rnd) + return RealField(self._prec, self.sci_not, rnd) def _repr_(self): """ @@ -611,7 +611,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): sage: RealIntervalField(200) # indirect doctest Real Interval Field with 200 bits of precision """ - s = "Real Interval Field with %s bits of precision"%self.__prec + s = "Real Interval Field with %s bits of precision"%self._prec return s def _latex_(self): @@ -802,7 +802,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): sage: RIF.has_coerce_map_from(float) False """ - prec = self.__prec + prec = self._prec # Direct and efficient conversions if S is ZZ or S is QQ: @@ -810,7 +810,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): if S is int or S is long: return True if isinstance(S, RealIntervalField_class): - return (S).__prec >= prec + return (S)._prec >= prec if isinstance(S, sage.rings.abc.NumberField_quadratic): return S.discriminant() > 0 @@ -844,7 +844,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): cdef RealIntervalField_class right left = self right = other # to access C structure - return richcmp(left.__prec, right.__prec, op) + return richcmp(left._prec, right._prec, op) def __reduce__(self): """ @@ -856,7 +856,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): sage: loads(dumps(R)) == R True """ - return __create__RealIntervalField_version0, (self.__prec, self.sci_not) + return __create__RealIntervalField_version0, (self._prec, self.sci_not) def random_element(self, *args, **kwds): """ @@ -997,7 +997,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): sage: RealIntervalField(200).name() 'IntervalRealIntervalField200' """ - return "IntervalRealIntervalField%s"%(self.__prec) + return "IntervalRealIntervalField%s"%(self._prec) def __hash__(self): """ @@ -1023,7 +1023,7 @@ cdef class RealIntervalField_class(sage.rings.abc.RealIntervalField): sage: RealIntervalField(200).precision() 200 """ - return self.__prec + return self._prec prec = precision @@ -1187,7 +1187,7 @@ cdef class RealIntervalFieldElement(RingElement): sage: TestSuite(x).run(skip=["_test_eq", "_test_pickling"]) """ cdef RealIntervalField_class p = parent - mpfi_init2(self.value, p.__prec) + mpfi_init2(self.value, p._prec) self._parent = p def __init__(self, parent, x, int base=10): @@ -1864,7 +1864,7 @@ cdef class RealIntervalFieldElement(RingElement): cdef mp_exp_t self_exp cdef mpz_t self_zz - cdef mpfr_prec_t prec = (self._parent).__prec + cdef mpfr_prec_t prec = (self._parent)._prec cdef char *zz_str cdef size_t zz_str_maxlen @@ -2977,7 +2977,7 @@ cdef class RealIntervalFieldElement(RingElement): sage: RealIntervalField(200)(2.1).precision() 200 """ - return (self._parent).__prec + return (self._parent)._prec prec = precision diff --git a/src/sage/rings/real_mpfr.pxd b/src/sage/rings/real_mpfr.pxd index 3549eccfd03..dd18e87715b 100644 --- a/src/sage/rings/real_mpfr.pxd +++ b/src/sage/rings/real_mpfr.pxd @@ -9,7 +9,7 @@ from sage.libs.mpfr.types cimport mpfr_prec_t cdef class RealNumber(sage.structure.element.RingElement) # forward decl cdef class RealField_class(sage.rings.abc.RealField): - cdef mpfr_prec_t __prec + cdef mpfr_prec_t _prec cdef bint sci_not cdef mpfr_rnd_t rnd cdef object rnd_str diff --git a/src/sage/rings/real_mpfr.pyx b/src/sage/rings/real_mpfr.pyx index ea7ff07a216..11e21af5e98 100644 --- a/src/sage/rings/real_mpfr.pyx +++ b/src/sage/rings/real_mpfr.pyx @@ -524,7 +524,7 @@ cdef class RealField_class(sage.rings.abc.RealField): if prec < MPFR_PREC_MIN or prec > MPFR_PREC_MAX: raise ValueError("prec (=%s) must be >= %s and <= %s" % ( prec, MPFR_PREC_MIN, MPFR_PREC_MAX)) - self.__prec = prec + self._prec = prec self.sci_not = sci_not self.rnd = rnd @@ -561,7 +561,7 @@ cdef class RealField_class(sage.rings.abc.RealField): sage: RealField(17,rnd='RNDD') # indirect doctest Real Field with 17 bits of precision and rounding RNDD """ - s = "Real Field with %s bits of precision"%self.__prec + s = "Real Field with %s bits of precision"%self._prec if self.rnd != MPFR_RNDN: s = s + " and rounding %s"%(self.rnd_str) return s @@ -733,13 +733,13 @@ cdef class RealField_class(sage.rings.abc.RealField): return ZZtoRR(ZZ, self) elif S is QQ: return QQtoRR(QQ, self) - elif (S is RDF or S is float) and self.__prec <= 53: + elif (S is RDF or S is float) and self._prec <= 53: return double_toRR(S, self) elif S is long: return int_toRR(long, self) elif S is int: return int_toRR(int, self) - elif isinstance(S, RealField_class) and S.prec() >= self.__prec: + elif isinstance(S, RealField_class) and S.prec() >= self._prec: return RRtoRR(S, self) elif QQ.has_coerce_map_from(S): return QQtoRR(QQ, self) * QQ._internal_coerce_map_from(S) @@ -786,7 +786,7 @@ cdef class RealField_class(sage.rings.abc.RealField): return NotImplemented _other = other # to access C structure - return (self.__prec == _other.__prec and + return (self._prec == _other._prec and self.rnd == _other.rnd) == (op == Py_EQ) def __reduce__(self): @@ -799,7 +799,7 @@ cdef class RealField_class(sage.rings.abc.RealField): sage: loads(dumps(R)) == R True """ - return __create__RealField_version0, (self.__prec, self.sci_not, self.rnd_str) + return __create__RealField_version0, (self._prec, self.sci_not, self.rnd_str) def construction(self): r""" @@ -968,7 +968,7 @@ cdef class RealField_class(sage.rings.abc.RealField): sage: RealField(100,rnd='RNDU').name() 'RealField100_2' """ - return "RealField%s_%s"%(self.__prec,self.rnd) + return "RealField%s_%s"%(self._prec,self.rnd) def __hash__(self): """ @@ -995,7 +995,7 @@ cdef class RealField_class(sage.rings.abc.RealField): sage: RealField(20).precision() 20 """ - return Integer(self.__prec) + return Integer(self._prec) prec=precision # an alias @@ -1031,7 +1031,7 @@ cdef class RealField_class(sage.rings.abc.RealField): sage: R.to_prec(300) Real Field with 300 bits of precision and rounding RNDZ """ - if prec == self.__prec: + if prec == self._prec: return self else: return RealField(prec, self.sci_not, self.rnd) @@ -1052,7 +1052,7 @@ cdef class RealField_class(sage.rings.abc.RealField): 0.88622692545275801364908374167057259139877473 """ cdef RealNumber x = self._new() - if self.__prec > SIG_PREC_THRESHOLD: sig_on() + if self._prec > SIG_PREC_THRESHOLD: sig_on() # The docs for mpfr_free_cache say "Free the cache used by # the functions computing constants if needed (currently # mpfr_const_log2, mpfr_const_pi and mpfr_const_euler)", so @@ -1062,7 +1062,7 @@ cdef class RealField_class(sage.rings.abc.RealField): # functions, but this free is needed for them too! mpfr_free_cache() mpfr_const_pi(x.value, self.rnd) - if self.__prec > SIG_PREC_THRESHOLD: sig_off() + if self._prec > SIG_PREC_THRESHOLD: sig_off() return x def euler_constant(self): @@ -1091,10 +1091,10 @@ cdef class RealField_class(sage.rings.abc.RealField): 0.91596559417721901505460351493 """ cdef RealNumber x = self._new() - if self.__prec > SIG_PREC_THRESHOLD: sig_on() + if self._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_free_cache() mpfr_const_catalan(x.value, self.rnd) - if self.__prec > SIG_PREC_THRESHOLD: sig_off() + if self._prec > SIG_PREC_THRESHOLD: sig_off() return x def log2(self): @@ -1111,10 +1111,10 @@ cdef class RealField_class(sage.rings.abc.RealField): 0.69314718055994530941723212146 """ cdef RealNumber x = self._new() - if self.__prec > SIG_PREC_THRESHOLD: sig_on() + if self._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_free_cache() mpfr_const_log2(x.value, self.rnd) - if self.__prec > SIG_PREC_THRESHOLD: sig_off() + if self._prec > SIG_PREC_THRESHOLD: sig_off() return x def random_element(self, min=-1, max=1, distribution=None): @@ -1181,9 +1181,9 @@ cdef class RealField_class(sage.rings.abc.RealField): if n < 0: raise ArithmeticError("n must be nonnegative") x = self._new() - if self.__prec > SIG_PREC_THRESHOLD and n < SIG_PREC_THRESHOLD: sig_on() + if self._prec > SIG_PREC_THRESHOLD and n < SIG_PREC_THRESHOLD: sig_on() mpfr_fac_ui(x.value, n, self.rnd) - if self.__prec > SIG_PREC_THRESHOLD and n < SIG_PREC_THRESHOLD: sig_off() + if self._prec > SIG_PREC_THRESHOLD and n < SIG_PREC_THRESHOLD: sig_off() return x def rounding_mode(self): @@ -1346,7 +1346,7 @@ cdef class RealNumber(sage.structure.element.RingElement): NaN """ cdef RealField_class p = parent - mpfr_init2(self.value, p.__prec) + mpfr_init2(self.value, p._prec) self._parent = p def __init__(self, parent, x=0, int base=10): @@ -1446,7 +1446,7 @@ cdef class RealNumber(sage.structure.element.RingElement): sage: numpy.array([1.000000000000000000000000000000000000]).dtype # optional - numpy dtype('O') """ - if (self._parent).__prec <= 53: + if (self._parent)._prec <= 53: return numpy_double_interface else: return numpy_object_interface @@ -2075,7 +2075,7 @@ cdef class RealNumber(sage.structure.element.RingElement): # This avoids the confusion a lot of people have with the last # 1-2 binary digits being wrong due to rounding coming from # representing numbers in binary. - digits = (((self._parent).__prec - 1) * M_LN2_LN10) + digits = (((self._parent)._prec - 1) * M_LN2_LN10) if digits < 2: digits = 2 @@ -2303,7 +2303,7 @@ cdef class RealNumber(sage.structure.element.RingElement): if sgn == 0: return z - cdef mpfr_prec_t prec = (self._parent).__prec + cdef mpfr_prec_t prec = (self._parent)._prec if mpfr_inf_p(self.value): mpz_set_ui(z.value, EXP_MAX+1-EXP_MIN) @@ -2757,7 +2757,7 @@ cdef class RealNumber(sage.structure.element.RingElement): sage: RealField(101)(-1).precision() 101 """ - return Integer((self._parent).__prec) + return Integer((self._parent)._prec) prec = precision # alias @@ -3364,7 +3364,7 @@ cdef class RealNumber(sage.structure.element.RingElement): cdef unsigned long wordsize = sizeof(long)*8 cdef mpfr_prec_t prec - prec = (self._parent).__prec + prec = (self._parent)._prec # We round up the precision to the nearest multiple of wordsize. cdef int rounded_prec @@ -3699,7 +3699,7 @@ cdef class RealNumber(sage.structure.element.RingElement): from .real_mpfi import RealIntervalField cdef mpfr_rnd_t rnd = (self._parent).rnd - cdef mpfr_prec_t prec = (self._parent).__prec + cdef mpfr_prec_t prec = (self._parent)._prec cdef RealNumber low, high cdef int odd @@ -4249,9 +4249,9 @@ cdef class RealNumber(sage.structure.element.RingElement): cdef RealNumber x if mpfr_cmp_ui(self.value, 0) >= 0: x = self._new() - if (self._parent).__prec > 10*SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > 10*SIG_PREC_THRESHOLD: sig_on() mpfr_sqrt(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > 10*SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > 10*SIG_PREC_THRESHOLD: sig_off() if all: if x.is_zero(): return [x] @@ -4295,9 +4295,9 @@ cdef class RealNumber(sage.structure.element.RingElement): -1.42108547152020e-14 """ cdef RealNumber x = self._new() - if (self._parent).__prec > 10*SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > 10*SIG_PREC_THRESHOLD: sig_on() mpfr_cbrt(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > 10*SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > 10*SIG_PREC_THRESHOLD: sig_off() return x def __pow(self, RealNumber exponent): @@ -4435,9 +4435,9 @@ cdef class RealNumber(sage.structure.element.RingElement): return self._complex_number_().log(base) if base is None or base == 'e': x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_log(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x elif base == 10: return self.log10() @@ -4476,9 +4476,9 @@ cdef class RealNumber(sage.structure.element.RingElement): if self < 0: return self._complex_number_().log(2) x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_log2(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def log10(self): @@ -4513,9 +4513,9 @@ cdef class RealNumber(sage.structure.element.RingElement): if self < 0: return self._complex_number_().log(10) x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_log10(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def log1p(self): @@ -4562,9 +4562,9 @@ cdef class RealNumber(sage.structure.element.RingElement): if self < -1: return (self+1.0)._complex_number_().log() x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_log1p(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def exp(self): @@ -4620,9 +4620,9 @@ cdef class RealNumber(sage.structure.element.RingElement): 1.89117248253021e-10 """ cdef RealNumber x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_exp2(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def exp10(self): @@ -4648,9 +4648,9 @@ cdef class RealNumber(sage.structure.element.RingElement): 5.01187233627276e-33 """ cdef RealNumber x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_exp10(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def expm1(self): @@ -4672,9 +4672,9 @@ cdef class RealNumber(sage.structure.element.RingElement): 1.00000000000000e-16 """ cdef RealNumber x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_expm1(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def eint(self): @@ -4694,9 +4694,9 @@ cdef class RealNumber(sage.structure.element.RingElement): -0.219383934395520 """ cdef RealNumber x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_eint(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() return x def cos(self): @@ -5125,9 +5125,9 @@ cdef class RealNumber(sage.structure.element.RingElement): _other = self._parent(other) x = self._new() - if (self._parent).__prec > 10000: sig_on() + if (self._parent)._prec > 10000: sig_on() mpfr_agm(x.value, self.value, _other.value, (self._parent).rnd) - if (self._parent).__prec > 10000: sig_off() + if (self._parent)._prec > 10000: sig_off() return x def erf(self): @@ -5280,9 +5280,9 @@ cdef class RealNumber(sage.structure.element.RingElement): 0.886226925452758 """ cdef RealNumber x = self._new() - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_on() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_gamma(x.value, self.value, (self._parent).rnd) - if (self._parent).__prec > SIG_PREC_THRESHOLD: sig_off() + if (self._parent)._prec > SIG_PREC_THRESHOLD: sig_off() return x def log_gamma(self): @@ -5306,10 +5306,10 @@ cdef class RealNumber(sage.structure.element.RingElement): cdef RealNumber x = self._new() parent = (self._parent) if not mpfr_sgn(self.value) < 0: - if parent.__prec > SIG_PREC_THRESHOLD: + if parent._prec > SIG_PREC_THRESHOLD: sig_on() mpfr_lngamma(x.value, self.value, parent.rnd) - if parent.__prec > SIG_PREC_THRESHOLD: + if parent._prec > SIG_PREC_THRESHOLD: sig_off() return x from sage.libs.mpmath.utils import call @@ -5534,7 +5534,7 @@ cdef class RealNumber(sage.structure.element.RingElement): cdef RealField_class fld = self._parent - if algorithm == 0 and n <= 10000 / fld.__prec: + if algorithm == 0 and n <= 10000 / fld._prec: # This is a rough estimate for when it is probably # faster to call mpfr directly. (This is a pretty # good estimate on one particular machine, a @@ -5639,7 +5639,7 @@ cdef class RealNumber(sage.structure.element.RingElement): from .real_mpfi import RealIntervalField - cdef mpfr_prec_t prec = fld.__prec + 10 + cdef mpfr_prec_t prec = fld._prec + 10 cdef RealNumber lower cdef RealNumber upper From fddd81b99a952ff189fed147586e7e1faf80228e Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:46:02 +0800 Subject: [PATCH 33/54] rename __poly -> _poly --- src/sage/libs/arb/arith.pyx | 2 +- src/sage/matrix/matrix_complex_ball_dense.pyx | 2 +- src/sage/matrix/matrix_integer_dense.pyx | 6 +- src/sage/matrix/matrix_integer_sparse.pyx | 12 +- src/sage/misc/cython.py | 6 +- src/sage/rings/complex_arb.pyx | 4 +- src/sage/rings/padics/pow_computer_flint.pyx | 12 +- src/sage/rings/polynomial/hilbert.pyx | 28 +- .../polynomial/polynomial_complex_arb.pxd | 2 +- .../polynomial/polynomial_complex_arb.pyx | 122 ++++---- .../polynomial_integer_dense_flint.pxd | 2 +- .../polynomial_integer_dense_flint.pyx | 160 +++++------ .../polynomial_integer_dense_ntl.pxd | 2 +- .../polynomial_integer_dense_ntl.pyx | 102 +++---- .../polynomial/polynomial_modn_dense_ntl.pxd | 2 +- .../polynomial/polynomial_modn_dense_ntl.pyx | 52 ++-- .../polynomial/polynomial_rational_flint.pxd | 2 +- .../polynomial/polynomial_rational_flint.pyx | 266 +++++++++--------- .../polynomial/polynomial_zmod_flint.pyx | 2 +- src/sage/rings/power_series_mpoly.pxd | 2 +- src/sage/rings/power_series_mpoly.pyx | 6 +- 21 files changed, 397 insertions(+), 397 deletions(-) diff --git a/src/sage/libs/arb/arith.pyx b/src/sage/libs/arb/arith.pyx index d885f97b238..3b32fe7e8ed 100644 --- a/src/sage/libs/arb/arith.pyx +++ b/src/sage/libs/arb/arith.pyx @@ -81,5 +81,5 @@ def hilbert_class_polynomial(D): cdef long n = D cdef Polynomial_integer_dense_flint poly poly = PolynomialRing(ZZ, "x", implementation="FLINT")() - acb_modular_hilbert_class_poly(poly.__poly, n) + acb_modular_hilbert_class_poly(poly._poly, n) return poly diff --git a/src/sage/matrix/matrix_complex_ball_dense.pyx b/src/sage/matrix/matrix_complex_ball_dense.pyx index 9e14079c6d4..47ca41070fa 100644 --- a/src/sage/matrix/matrix_complex_ball_dense.pyx +++ b/src/sage/matrix/matrix_complex_ball_dense.pyx @@ -664,7 +664,7 @@ cdef class Matrix_complex_ball_dense(Matrix_dense): Pol = polynomial_ring_constructor._single_variate(self.base_ring(), var) cdef Polynomial_complex_arb res = Polynomial_complex_arb(Pol) sig_on() - acb_mat_charpoly(res.__poly, self.value, prec(self)) + acb_mat_charpoly(res._poly, self.value, prec(self)) sig_off() return res diff --git a/src/sage/matrix/matrix_integer_dense.pyx b/src/sage/matrix/matrix_integer_dense.pyx index 9c509104967..8088350577c 100644 --- a/src/sage/matrix/matrix_integer_dense.pyx +++ b/src/sage/matrix/matrix_integer_dense.pyx @@ -1371,12 +1371,12 @@ cdef class Matrix_integer_dense(Matrix_dense): if algorithm == 'flint': g = ( PolynomialRing(ZZ, names=var).gen())._new() sig_on() - fmpz_mat_charpoly(g.__poly, self._matrix) + fmpz_mat_charpoly(g._poly, self._matrix) sig_off() elif algorithm == 'linbox': g = ( PolynomialRing(ZZ, names=var).gen())._new() sig_on() - linbox_fmpz_mat_charpoly(g.__poly, self._matrix) + linbox_fmpz_mat_charpoly(g._poly, self._matrix) sig_off() elif algorithm == 'generic': g = Matrix_dense.charpoly(self, var) @@ -1460,7 +1460,7 @@ cdef class Matrix_integer_dense(Matrix_dense): if algorithm == 'linbox': g = ( PolynomialRing(ZZ, names=var).gen())._new() sig_on() - linbox_fmpz_mat_minpoly(g.__poly, self._matrix) + linbox_fmpz_mat_minpoly(g._poly, self._matrix) sig_off() elif algorithm == 'generic': g = Matrix_dense.minpoly(self, var) diff --git a/src/sage/matrix/matrix_integer_sparse.pyx b/src/sage/matrix/matrix_integer_sparse.pyx index a41677c7b6a..83d5ee42fbe 100644 --- a/src/sage/matrix/matrix_integer_sparse.pyx +++ b/src/sage/matrix/matrix_integer_sparse.pyx @@ -869,10 +869,10 @@ cdef class Matrix_integer_sparse(Matrix_sparse): sig_off() cdef size_t i - fmpz_poly_fit_length(g.__poly, p.size()) + fmpz_poly_fit_length(g._poly, p.size()) for i in range(p.size()): - fmpz_poly_set_coeff_mpz(g.__poly, i, p[0][i].get_mpz_const()) - _fmpz_poly_set_length(g.__poly, p.size()) + fmpz_poly_set_coeff_mpz(g._poly, i, p[0][i].get_mpz_const()) + _fmpz_poly_set_length(g._poly, p.size()) del M del p @@ -968,10 +968,10 @@ cdef class Matrix_integer_sparse(Matrix_sparse): sig_off() cdef size_t i - fmpz_poly_fit_length(g.__poly, p.size()) + fmpz_poly_fit_length(g._poly, p.size()) for i in range(p.size()): - fmpz_poly_set_coeff_mpz(g.__poly, i, p[0][i].get_mpz_const()) - _fmpz_poly_set_length(g.__poly, p.size()) + fmpz_poly_set_coeff_mpz(g._poly, i, p[0][i].get_mpz_const()) + _fmpz_poly_set_length(g._poly, p.size()) del M del p diff --git a/src/sage/misc/cython.py b/src/sage/misc/cython.py index f4083f3909b..5f83f585c3a 100644 --- a/src/sage/misc/cython.py +++ b/src/sage/misc/cython.py @@ -646,9 +646,9 @@ def compile_and_load(code, **kwds): ....: cdef Polynomial_rational_flint res = f._new() ....: cdef unsigned long k ....: cdef Rational z = Rational(0) - ....: for k in range(fmpq_poly_length(f.__poly)): - ....: fmpq_poly_get_coeff_mpq(z.value, f.__poly, k) - ....: fmpq_poly_set_coeff_mpq(res.__poly, n*k, z.value) + ....: for k in range(fmpq_poly_length(f._poly)): + ....: fmpq_poly_get_coeff_mpq(z.value, f._poly, k) + ....: fmpq_poly_set_coeff_mpq(res._poly, n*k, z.value) ....: return res ....: ''' sage: module = compile_and_load(code) # long time diff --git a/src/sage/rings/complex_arb.pyx b/src/sage/rings/complex_arb.pyx index ef432c1e945..95e615f3ee6 100644 --- a/src/sage/rings/complex_arb.pyx +++ b/src/sage/rings/complex_arb.pyx @@ -874,7 +874,7 @@ class ComplexBallField(UniqueRepresentation, sage.rings.abc.ComplexBallField): cdef RealBall rb cdef ComplexBall cb acb_poly_init(rounded_poly) - cdef long deg = acb_poly_degree(poly.__poly) + cdef long deg = acb_poly_degree(poly._poly) if deg < 0: raise ArithmeticError("taking the roots of the zero polynomial") cdef acb_ptr roots = _acb_vec_init(deg) @@ -883,7 +883,7 @@ class ComplexBallField(UniqueRepresentation, sage.rings.abc.ComplexBallField): while ((isolated < deg or any(acb_rel_accuracy_bits(&roots[i]) < tgtprec for i in range(deg))) and prec < maxprec): - acb_poly_set_round(rounded_poly, poly.__poly, prec) + acb_poly_set_round(rounded_poly, poly._poly, prec) maxiter = min(max(deg, 32), prec) if (prec == initial_prec): isolated = acb_poly_find_roots(roots, rounded_poly, NULL, maxiter, prec) diff --git a/src/sage/rings/padics/pow_computer_flint.pyx b/src/sage/rings/padics/pow_computer_flint.pyx index ae9e9f954a2..e521ea6e078 100644 --- a/src/sage/rings/padics/pow_computer_flint.pyx +++ b/src/sage/rings/padics/pow_computer_flint.pyx @@ -208,7 +208,7 @@ cdef class PowComputer_flint_1step(PowComputer_flint): """ cdef Polynomial_integer_dense_flint poly = _poly - cdef long length = fmpz_poly_length(poly.__poly) + cdef long length = fmpz_poly_length(poly._poly) cdef Py_ssize_t i @@ -268,10 +268,10 @@ cdef class PowComputer_flint_1step(PowComputer_flint): PowComputer_flint.__init__(self, prime, cache_limit, prec_cap, ram_prec_cap, in_field, _poly, shift_seed) cdef Polynomial_integer_dense_flint poly = _poly - cdef long length = fmpz_poly_length(poly.__poly) + cdef long length = fmpz_poly_length(poly._poly) self.deg = length - 1 - fmpz_poly_set(self.modulus, poly.__poly) + fmpz_poly_set(self.modulus, poly._poly) cdef Py_ssize_t i cdef fmpz* coeffs = self.modulus.coeffs @@ -427,9 +427,9 @@ cdef class PowComputer_flint_1step(PowComputer_flint): x = R.gen() cdef Polynomial_integer_dense_flint ans = (x)._new() if _n is None: - fmpz_poly_set(ans.__poly, self.modulus) + fmpz_poly_set(ans._poly, self.modulus) else: - fmpz_poly_set(ans.__poly, self.get_modulus(_n)[0]) + fmpz_poly_set(ans._poly, self.get_modulus(_n)[0]) return ans cdef _new_fmpz_poly(self, fmpz_poly_t value, var='x'): @@ -440,7 +440,7 @@ cdef class PowComputer_flint_1step(PowComputer_flint): R = ZZ[var] x = R.gen() cdef Polynomial_integer_dense_flint ans = (x)._new() - fmpz_poly_set(ans.__poly, value) + fmpz_poly_set(ans._poly, value) return ans cdef class PowComputer_flint_unram(PowComputer_flint_1step): diff --git a/src/sage/rings/polynomial/hilbert.pyx b/src/sage/rings/polynomial/hilbert.pyx index a1f70e0c983..d2abf325fd8 100644 --- a/src/sage/rings/polynomial/hilbert.pyx +++ b/src/sage/rings/polynomial/hilbert.pyx @@ -170,7 +170,7 @@ cdef bint HilbertBaseCase(Polynomial_integer_dense_flint fhs, Node D, tuple w): cdef int e # First, the easiest cases: if not D.Id: # The zero ideal - fmpz_poly_set_coeff_si(fhs.__poly, 0, 1) # = PR(1) + fmpz_poly_set_coeff_si(fhs._poly, 0, 1) # = PR(1) return True cdef ETuple m = PyList_GET_ITEM(D.Id, len(D.Id)-1) if m._nonzero == 0: # The one ideal @@ -183,18 +183,18 @@ cdef bint HilbertBaseCase(Polynomial_integer_dense_flint fhs, Node D, tuple w): if m._nonzero == 1 and m._data[1] == 1: fmpz_poly_init(poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, 0, 1) - fmpz_poly_set_coeff_si(fhs.__poly, 0, 1) # = PR(1) + fmpz_poly_set_coeff_si(fhs._poly, 0, 1) # = PR(1) if w is None: for i in range(len(D.Id)): exp = (PyList_GET_ITEM(D.Id, i)).unweighted_degree() fmpz_poly_set_coeff_si(poly_tmp, exp, -1) - fmpz_poly_mul(fhs.__poly, fhs.__poly, poly_tmp) + fmpz_poly_mul(fhs._poly, fhs._poly, poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, exp, 0) else: for i in range(len(D.Id)): exp = (PyList_GET_ITEM(D.Id, i)).weighted_degree(w) fmpz_poly_set_coeff_si(poly_tmp, exp, -1) - fmpz_poly_mul(fhs.__poly, fhs.__poly, poly_tmp) + fmpz_poly_mul(fhs._poly, fhs._poly, poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, exp, 0) fmpz_poly_clear(poly_tmp) return True # PR.prod([(1-t**degree(m,w)) for m in D.Id]) @@ -210,18 +210,18 @@ cdef bint HilbertBaseCase(Polynomial_integer_dense_flint fhs, Node D, tuple w): # The ideal is generated by some powers of single variables, i.e., it splits. fmpz_poly_init(poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, 0, 1) - fmpz_poly_set_coeff_si(fhs.__poly, 0, 1) # = PR(1) + fmpz_poly_set_coeff_si(fhs._poly, 0, 1) # = PR(1) if w is None: for i in range(len(D.Id)): exp = (PyList_GET_ITEM(D.Id, i)).unweighted_degree() fmpz_poly_set_coeff_si(poly_tmp, exp, -1) - fmpz_poly_mul(fhs.__poly, fhs.__poly, poly_tmp) + fmpz_poly_mul(fhs._poly, fhs._poly, poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, exp, 0) else: for i in range(len(D.Id)): exp = (PyList_GET_ITEM(D.Id, i)).weighted_degree(w) fmpz_poly_set_coeff_si(poly_tmp, exp, -1) - fmpz_poly_mul(fhs.__poly, fhs.__poly, poly_tmp) + fmpz_poly_mul(fhs._poly, fhs._poly, poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, exp, 0) fmpz_poly_clear(poly_tmp) return True # PR.prod([(1-t**degree(m,w)) for m in D.Id]) @@ -278,8 +278,8 @@ cdef bint HilbertBaseCase(Polynomial_integer_dense_flint fhs, Node D, tuple w): fmpz_poly_mul(SecondSummand, SecondSummand, poly_tmp) fmpz_poly_set_coeff_si(poly_tmp, exp, 0) fmpz_poly_clear(poly_tmp) - fmpz_poly_add(fhs.__poly, fhs.__poly, FirstSummand) - fmpz_poly_add(fhs.__poly, fhs.__poly, SecondSummand) + fmpz_poly_add(fhs._poly, fhs._poly, FirstSummand) + fmpz_poly_add(fhs._poly, fhs._poly, SecondSummand) fmpz_poly_clear(FirstSummand) fmpz_poly_clear(SecondSummand) return True @@ -532,11 +532,11 @@ def first_hilbert_series(I, grading=None, return_grading=False): if AN.Back.Right is None: AN = AN.Back #~ fhs *= AN.LMult - fmpz_poly_mul(fhs.__poly, fhs.__poly, AN.LMult) + fmpz_poly_mul(fhs._poly, fhs._poly, AN.LMult) got_result = True else: - fmpz_poly_set(AN.Back.LeftFHS, fhs.__poly) - fmpz_poly_set_si(fhs.__poly, 0) + fmpz_poly_set(AN.Back.LeftFHS, fhs._poly) + fmpz_poly_set_si(fhs._poly, 0) AN = AN.Back.Right AN.Back.Left = None got_result = HilbertBaseCase(fhs, AN, w) @@ -545,8 +545,8 @@ def first_hilbert_series(I, grading=None, return_grading=False): AN.Right = None #~ fhs = AN.LMult*AN.LeftFHS + AN.RMult*fhs fmpz_poly_mul(AN.LMult, AN.LMult, AN.LeftFHS) - fmpz_poly_mul(AN.RMult, AN.RMult, fhs.__poly) - fmpz_poly_add(fhs.__poly, AN.LMult, AN.RMult) + fmpz_poly_mul(AN.RMult, AN.RMult, fhs._poly) + fmpz_poly_add(fhs._poly, AN.LMult, AN.RMult) got_result = True def hilbert_poincare_series(I, grading=None): diff --git a/src/sage/rings/polynomial/polynomial_complex_arb.pxd b/src/sage/rings/polynomial/polynomial_complex_arb.pxd index aa4e2a1c0dc..e54d85e961b 100644 --- a/src/sage/rings/polynomial/polynomial_complex_arb.pxd +++ b/src/sage/rings/polynomial/polynomial_complex_arb.pxd @@ -2,5 +2,5 @@ from sage.libs.arb.acb_poly cimport * from sage.rings.polynomial.polynomial_element cimport Polynomial cdef class Polynomial_complex_arb(Polynomial): - cdef acb_poly_struct[1] __poly # https://github.com/cython/cython/issues/1984 + cdef acb_poly_struct[1] _poly # https://github.com/cython/cython/issues/1984 cdef Polynomial_complex_arb _new(self) diff --git a/src/sage/rings/polynomial/polynomial_complex_arb.pyx b/src/sage/rings/polynomial/polynomial_complex_arb.pyx index e51268b4b54..57c1a52ede4 100644 --- a/src/sage/rings/polynomial/polynomial_complex_arb.pyx +++ b/src/sage/rings/polynomial/polynomial_complex_arb.pyx @@ -75,7 +75,7 @@ cdef class Polynomial_complex_arb(Polynomial): sage: ComplexBallField(2)['y']() 0 """ - acb_poly_init(self.__poly) + acb_poly_init(self._poly) def __dealloc__(self): r""" @@ -84,7 +84,7 @@ cdef class Polynomial_complex_arb(Polynomial): sage: pol = CBF['x']() sage: del pol """ - acb_poly_clear(self.__poly) + acb_poly_clear(self._poly) cdef Polynomial_complex_arb _new(self): r""" @@ -140,49 +140,49 @@ cdef class Polynomial_complex_arb(Polynomial): Polynomial.__init__(self, parent, is_gen=is_gen) if is_gen: - acb_poly_set_coeff_si(self.__poly, 1, 1) + acb_poly_set_coeff_si(self._poly, 1, 1) elif x is None: - acb_poly_zero(self.__poly) + acb_poly_zero(self._poly) elif isinstance(x, Polynomial_complex_arb): - acb_poly_set(self.__poly, ( x).__poly) + acb_poly_set(self._poly, ( x)._poly) elif isinstance(x, ComplexBall): - acb_poly_set_coeff_acb(self.__poly, 0, ( x).value) + acb_poly_set_coeff_acb(self._poly, 0, ( x).value) else: Coeff = parent.base_ring() if isinstance(x, list): lst = x length = len(lst) - sig_on(); acb_poly_fit_length(self.__poly, length); sig_off() + sig_on(); acb_poly_fit_length(self._poly, length); sig_off() for i in range(length): ball = Coeff(lst[i]) - acb_poly_set_coeff_acb(self.__poly, i, ball.value) + acb_poly_set_coeff_acb(self._poly, i, ball.value) elif isinstance(x, tuple): tpl = x length = len(tpl) - sig_on(); acb_poly_fit_length(self.__poly, length); sig_off() + sig_on(); acb_poly_fit_length(self._poly, length); sig_off() for i in range(length): ball = Coeff(tpl[i]) - acb_poly_set_coeff_acb(self.__poly, i, ball.value) + acb_poly_set_coeff_acb(self._poly, i, ball.value) elif isinstance(x, Polynomial): pol = x length = pol.degree() + 1 - sig_on(); acb_poly_fit_length(self.__poly, length); sig_off() + sig_on(); acb_poly_fit_length(self._poly, length); sig_off() for i in range(length): ball = Coeff(pol.get_unsafe(i)) - acb_poly_set_coeff_acb(self.__poly, i, ball.value) + acb_poly_set_coeff_acb(self._poly, i, ball.value) elif isinstance(x, dict): dct = x if len(dct) == 0: - acb_poly_zero(self.__poly) + acb_poly_zero(self._poly) else: length = max(int(i) for i in dct) + 1 - sig_on(); acb_poly_fit_length(self.__poly, length); sig_off() + sig_on(); acb_poly_fit_length(self._poly, length); sig_off() for i, c in dct.iteritems(): ball = Coeff(c) - acb_poly_set_coeff_acb(self.__poly, i, ball.value) + acb_poly_set_coeff_acb(self._poly, i, ball.value) else: ball = Coeff(x) - acb_poly_set_coeff_acb(self.__poly, 0, ball.value) + acb_poly_set_coeff_acb(self._poly, 0, ball.value) def __reduce__(self): r""" @@ -219,12 +219,12 @@ cdef class Polynomial_complex_arb(Polynomial): sage: Pol([1, 0, 0, 0]).degree() 0 """ - return smallInteger(acb_poly_degree(self.__poly)) + return smallInteger(acb_poly_degree(self._poly)) cdef get_unsafe(self, Py_ssize_t n): cdef ComplexBall res = ComplexBall.__new__(ComplexBall) res._parent = self._parent._base - acb_poly_get_coeff_acb(res.value, self.__poly, n) + acb_poly_get_coeff_acb(res.value, self._poly, n) return res cpdef list list(self, bint copy=True): @@ -241,7 +241,7 @@ cdef class Polynomial_complex_arb(Polynomial): sage: Pol([0, 1, RBF(0, rad=.1), 0]).list() [0, 1.000000000000000, [+/- 0.101]] """ - cdef unsigned long length = acb_poly_length(self.__poly) + cdef unsigned long length = acb_poly_length(self._poly) return [self.get_unsafe(n) for n in range(length)] def __bool__(self): @@ -257,7 +257,7 @@ cdef class Polynomial_complex_arb(Polynomial): sage: bool(z) True """ - return acb_poly_length(self.__poly) + return acb_poly_length(self._poly) # Ring and Euclidean arithmetic @@ -274,9 +274,9 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb res = self._new() sig_on() acb_poly_add( - res.__poly, - self.__poly, - ( other).__poly, + res._poly, + self._poly, + ( other)._poly, prec(self)) sig_off() return res @@ -293,7 +293,7 @@ cdef class Polynomial_complex_arb(Polynomial): """ cdef Polynomial_complex_arb res = self._new() sig_on() - acb_poly_neg(res.__poly, self.__poly) + acb_poly_neg(res._poly, self._poly) sig_off() return res @@ -310,9 +310,9 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb res = self._new() sig_on() acb_poly_sub( - res.__poly, - self.__poly, - ( other).__poly, + res._poly, + self._poly, + ( other)._poly, prec(self)) sig_off() return res @@ -331,9 +331,9 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb res = self._new() sig_on() acb_poly_mul( - res.__poly, - self.__poly, - ( other).__poly, + res._poly, + self._poly, + ( other)._poly, prec(self)) sig_off() return res @@ -354,7 +354,7 @@ cdef class Polynomial_complex_arb(Polynomial): """ cdef Polynomial_complex_arb res = self._new() sig_on() - acb_poly_scalar_mul(res.__poly, self.__poly, ( a).value, prec(self)) + acb_poly_scalar_mul(res._poly, self._poly, ( a).value, prec(self)) sig_off() return res @@ -409,8 +409,8 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb quo = self._new() cdef Polynomial_complex_arb rem = self._new() sig_on() - cdef bint success = acb_poly_divrem(quo.__poly, rem.__poly, self.__poly, - div.__poly, prec(self)) + cdef bint success = acb_poly_divrem(quo._poly, rem._poly, self._poly, + div._poly, prec(self)) sig_off() if success: return quo, rem @@ -445,15 +445,15 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_set(res.__poly, self.__poly) - acb_poly_truncate(res.__poly, n) + acb_poly_set(res._poly, self._poly) + acb_poly_truncate(res._poly, n) sig_off() return res cdef _inplace_truncate(self, long n): if n < 0: n = 0 - acb_poly_truncate(self.__poly, n) + acb_poly_truncate(self._poly, n) return self def __lshift__(val, n): @@ -485,7 +485,7 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb self = ( val) cdef Polynomial_complex_arb res = self._new() sig_on() - acb_poly_shift_left(res.__poly, self.__poly, n) + acb_poly_shift_left(res._poly, self._poly, n) sig_off() return res @@ -518,7 +518,7 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb self = ( val) cdef Polynomial_complex_arb res = self._new() sig_on() - acb_poly_shift_right(res.__poly, self.__poly, n) + acb_poly_shift_right(res._poly, self._poly, n) sig_off() return res @@ -548,7 +548,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_mullow(res.__poly, self.__poly, my_other.__poly, n, prec(self)) + acb_poly_mullow(res._poly, self._poly, my_other._poly, n, prec(self)) sig_off() return res @@ -576,7 +576,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_inv_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_inv_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -612,7 +612,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_pow_ui_trunc_binexp(res.__poly, self.__poly, expo, n, prec(self)) + acb_poly_pow_ui_trunc_binexp(res._poly, self._poly, expo, n, prec(self)) sig_off() return res @@ -648,7 +648,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_log_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_log_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -672,7 +672,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_exp_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_exp_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -697,7 +697,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_sqrt_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_sqrt_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -716,7 +716,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_gamma_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_gamma_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -735,7 +735,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_lgamma_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_lgamma_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -754,7 +754,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_rgamma_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_rgamma_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -784,7 +784,7 @@ cdef class Polynomial_complex_arb(Polynomial): if n < 0: n = 0 sig_on() - acb_poly_lambertw_series(res.__poly, self.__poly, _branch, 0, n, prec(self)) + acb_poly_lambertw_series(res._poly, self._poly, _branch, 0, n, prec(self)) sig_off() fmpz_clear(_branch) return res @@ -814,7 +814,7 @@ cdef class Polynomial_complex_arb(Polynomial): cdef ComplexBall _a = (self._parent._base.coerce(a)) cdef Polynomial_complex_arb res = self._new() sig_on() - acb_poly_zeta_series(res.__poly, self.__poly, _a.value, deflate, n, prec(self)) + acb_poly_zeta_series(res._poly, self._poly, _a.value, deflate, n, prec(self)) sig_off() return res @@ -846,24 +846,24 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb res = self._new() cdef acb_poly_t self_ts, other_ts cdef acb_ptr cc - if acb_poly_length(other1.__poly) > 0: - cc = acb_poly_get_coeff_ptr(other1.__poly, 0) + if acb_poly_length(other1._poly) > 0: + cc = acb_poly_get_coeff_ptr(other1._poly, 0) if not acb_is_zero(cc): sig_on() try: acb_poly_init(self_ts) acb_poly_init(other_ts) - acb_poly_taylor_shift(self_ts, self.__poly, cc, prec(self)) - acb_poly_set(other_ts, other1.__poly) + acb_poly_taylor_shift(self_ts, self._poly, cc, prec(self)) + acb_poly_set(other_ts, other1._poly) acb_zero(acb_poly_get_coeff_ptr(other_ts, 0)) - acb_poly_compose_series(res.__poly, self_ts, other_ts, n, prec(self)) + acb_poly_compose_series(res._poly, self_ts, other_ts, n, prec(self)) finally: acb_poly_clear(other_ts) acb_poly_clear(self_ts) sig_off() return res sig_on() - acb_poly_compose_series(res.__poly, self.__poly, other1.__poly, n, prec(self)) + acb_poly_compose_series(res._poly, self._poly, other1._poly, n, prec(self)) sig_off() return res @@ -895,12 +895,12 @@ cdef class Polynomial_complex_arb(Polynomial): cdef Polynomial_complex_arb res = self._new() if n < 0: n = 0 - if not acb_is_zero(acb_poly_get_coeff_ptr(self.__poly, 0)): + if not acb_is_zero(acb_poly_get_coeff_ptr(self._poly, 0)): raise ValueError("the constant coefficient must be zero") - if acb_contains_zero(acb_poly_get_coeff_ptr(self.__poly, 1)): + if acb_contains_zero(acb_poly_get_coeff_ptr(self._poly, 1)): raise ValueError("the linear term must be nonzero") sig_on() - acb_poly_revert_series(res.__poly, self.__poly, n, prec(self)) + acb_poly_revert_series(res._poly, self._poly, n, prec(self)) sig_off() return res @@ -938,15 +938,15 @@ cdef class Polynomial_complex_arb(Polynomial): ball = ComplexBall.__new__(ComplexBall) ball._parent = self._parent._base sig_on() - acb_poly_evaluate(ball.value, self.__poly, + acb_poly_evaluate(ball.value, self._poly, ( point).value, prec(self)) sig_off() return ball elif isinstance(point, Polynomial_complex_arb): poly = ( point)._new() sig_on() - acb_poly_compose(poly.__poly, self.__poly, - ( point).__poly, prec(self)) + acb_poly_compose(poly._poly, self._poly, + ( point)._poly, prec(self)) sig_off() return poly # TODO: perhaps add more special cases, e.g. for real ball, diff --git a/src/sage/rings/polynomial/polynomial_integer_dense_flint.pxd b/src/sage/rings/polynomial/polynomial_integer_dense_flint.pxd index 03c5cebbf09..b1b593d6a26 100644 --- a/src/sage/rings/polynomial/polynomial_integer_dense_flint.pxd +++ b/src/sage/rings/polynomial/polynomial_integer_dense_flint.pxd @@ -5,7 +5,7 @@ from sage.rings.integer cimport Integer from sage.structure.parent cimport Parent cdef class Polynomial_integer_dense_flint(Polynomial): - cdef fmpz_poly_t __poly + cdef fmpz_poly_t _poly cdef Polynomial_integer_dense_flint _new(self) cpdef _unsafe_mutate(self, long n, value) diff --git a/src/sage/rings/polynomial/polynomial_integer_dense_flint.pyx b/src/sage/rings/polynomial/polynomial_integer_dense_flint.pyx index e201ac843ad..194eb9263b2 100644 --- a/src/sage/rings/polynomial/polynomial_integer_dense_flint.pyx +++ b/src/sage/rings/polynomial/polynomial_integer_dense_flint.pyx @@ -99,14 +99,14 @@ cdef class Polynomial_integer_dense_flint(Polynomial): r""" This calls the underlying FLINT fmpz_poly constructor """ - fmpz_poly_init(self.__poly) + fmpz_poly_init(self._poly) def __dealloc__(self): r""" calls the underlying FLINT fmpz_poly destructor """ - fmpz_poly_clear(self.__poly) + fmpz_poly_clear(self._poly) cdef Polynomial_integer_dense_flint _new(self): r""" @@ -139,7 +139,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): x._is_gen = 0 if not isinstance(a, Integer): a = ZZ(a) - fmpz_poly_set_coeff_mpz(x.__poly, 0, (a).value) + fmpz_poly_set_coeff_mpz(x._poly, 0, (a).value) return x def __init__(self, parent, x=None, check=True, is_gen=False, @@ -224,8 +224,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if isinstance(x, Polynomial): if x.parent() is self.parent(): sig_on() - fmpz_poly_set(self.__poly, - (x).__poly) + fmpz_poly_set(self._poly, + (x)._poly) sig_off() return else: @@ -246,7 +246,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): degree = i try: sig_on() - fmpz_poly_realloc(self.__poly, degree + 1) + fmpz_poly_realloc(self._poly, degree + 1) sig_off() except RuntimeError: raise OverflowError("Cannot allocate memory!") @@ -255,13 +255,13 @@ cdef class Polynomial_integer_dense_flint(Polynomial): i = ii[0] if type(ii) is tuple else ii if is_small_python_int(a): sig_on() - fmpz_poly_set_coeff_si(self.__poly, i, a) + fmpz_poly_set_coeff_si(self._poly, i, a) sig_off() else: if not isinstance(a, Integer): a = ZZ(a) sig_on() - fmpz_poly_set_coeff_mpz(self.__poly, i, (a).value) + fmpz_poly_set_coeff_mpz(self._poly, i, (a).value) sig_off() return @@ -270,7 +270,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): check = False elif isinstance(x, ntl_ZZX): # coercion from ntl.pyx object - fmpz_poly_set_ZZX(self.__poly, (x).x) + fmpz_poly_set_ZZX(self._poly, (x).x) return elif isinstance(x, FractionFieldElement) and \ @@ -278,8 +278,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if x.denominator() == 1: # fraction of the form f(x)/1 sig_on() - fmpz_poly_set(self.__poly, - (x.numerator()).__poly) + fmpz_poly_set(self._poly, + (x.numerator())._poly) sig_off() return @@ -287,19 +287,19 @@ cdef class Polynomial_integer_dense_flint(Polynomial): x = [x] # constant polynomials sig_on() - fmpz_poly_realloc(self.__poly, len(x)) + fmpz_poly_realloc(self._poly, len(x)) sig_off() for i from 0 <= i < len(x): a = x[i] if is_small_python_int(a): sig_on() - fmpz_poly_set_coeff_si(self.__poly, i, a) + fmpz_poly_set_coeff_si(self._poly, i, a) sig_off() else: if not isinstance(a, Integer): a = ZZ(a) sig_on() - fmpz_poly_set_coeff_mpz(self.__poly, i, (a).value) + fmpz_poly_set_coeff_mpz(self._poly, i, (a).value) sig_off() def _eval_mpfr_(self, RealNumber a): @@ -327,7 +327,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef RealNumber res = a._new() sig_on() - fmpz_poly_evaluation_mpfr(res.value, self.__poly, a.value) + fmpz_poly_evaluation_mpfr(res.value, self._poly, a.value) sig_off() return res @@ -357,7 +357,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef RealIntervalFieldElement res = a._new() sig_on() - fmpz_poly_evaluation_mpfi(res.value, self.__poly, a.value) + fmpz_poly_evaluation_mpfi(res.value, self._poly, a.value) sig_off() return res @@ -412,8 +412,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if isinstance(x, Polynomial_integer_dense_flint): f = self._new() sig_on() - fmpz_poly_compose(f.__poly, self.__poly, - ( x0).__poly) + fmpz_poly_compose(f._poly, self._poly, + ( x0)._poly) sig_off() return f if is_small_python_int(x0): @@ -422,7 +422,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): fmpz_init(a_fmpz) fmpz_init(z_fmpz) fmpz_set_si(a_fmpz, PyInt_AS_LONG(x0)) - fmpz_poly_evaluate_fmpz(z_fmpz, self.__poly, a_fmpz) + fmpz_poly_evaluate_fmpz(z_fmpz, self._poly, a_fmpz) fmpz_get_mpz(z.value, z_fmpz) fmpz_clear(a_fmpz) fmpz_clear(z_fmpz) @@ -433,7 +433,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if isinstance(x0, Integer): a = x0 - if fmpz_poly_length(self.__poly) == 0: + if fmpz_poly_length(self._poly) == 0: return ZZ.zero() if mpz_sgn(a.value) == 0: return self[0] @@ -444,7 +444,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): fmpz_init(a_fmpz) fmpz_init(z_fmpz) fmpz_set_mpz(a_fmpz, a.value) - fmpz_poly_evaluate_fmpz(z_fmpz, self.__poly, a_fmpz) + fmpz_poly_evaluate_fmpz(z_fmpz, self._poly, a_fmpz) fmpz_get_mpz(z.value, z_fmpz) fmpz_clear(a_fmpz) fmpz_clear(z_fmpz) @@ -460,14 +460,14 @@ cdef class Polynomial_integer_dense_flint(Polynomial): arb_a = x0 arb_z = arb_a._new() sig_on() - arb_fmpz_poly_evaluate_arb(arb_z.value, self.__poly, arb_a.value, arb_a._parent._prec) + arb_fmpz_poly_evaluate_arb(arb_z.value, self._poly, arb_a.value, arb_a._parent._prec) sig_off() return arb_z if isinstance(x0, ComplexBall): acb_a = x0 acb_z = acb_a._new() sig_on() - arb_fmpz_poly_evaluate_acb(acb_z.value, self.__poly, acb_a.value, acb_a._parent._prec) + arb_fmpz_poly_evaluate_acb(acb_z.value, self._poly, acb_a.value, acb_a._parent._prec) sig_off() return acb_z @@ -510,10 +510,10 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef fmpz_t c fmpz_init(c) - fmpz_poly_get_coeff_fmpz(c, self.__poly, fmpz_poly_degree(self.__poly)) + fmpz_poly_get_coeff_fmpz(c, self._poly, fmpz_poly_degree(self._poly)) cdef int sign = fmpz_sgn(c) - fmpz_poly_content(c, self.__poly) + fmpz_poly_content(c, self._poly) cdef Integer z = Integer.__new__(Integer) fmpz_get_mpz(z.value, c) @@ -561,7 +561,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): 5*x^5 + 4*x^4 + 3*x^3 + 2*x^2 + x + 1 """ cdef Integer z = Integer.__new__(Integer) - fmpz_poly_get_coeff_mpz(z.value, self.__poly, n) + fmpz_poly_get_coeff_mpz(z.value, self._poly, n) return z def _repr(self, name=None, bint latex=False): @@ -583,8 +583,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef long i cdef Integer coef = Integer.__new__(Integer) cdef list all = [] - for i from fmpz_poly_degree(self.__poly) >= i >= 0: - fmpz_poly_get_coeff_mpz(coef.value, self.__poly, i) + for i from fmpz_poly_degree(self._poly) >= i >= 0: + fmpz_poly_get_coeff_mpz(coef.value, self._poly, i) if coef: if coef > 0: sign_str = '+' @@ -649,8 +649,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_add(x.__poly, self.__poly, - (right).__poly) + fmpz_poly_add(x._poly, self._poly, + (right)._poly) sig_off() return x @@ -669,8 +669,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_sub(x.__poly, self.__poly, - (right).__poly) + fmpz_poly_sub(x._poly, self._poly, + (right)._poly) sig_off() return x @@ -688,7 +688,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_neg(x.__poly, self.__poly) + fmpz_poly_neg(x._poly, self._poly) sig_off() return x @@ -758,7 +758,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef Polynomial_integer_dense_flint rr = self._new() sig_on() - fmpz_poly_divrem(qq.__poly, rr.__poly, self.__poly, right.__poly) + fmpz_poly_divrem(qq._poly, rr._poly, self._poly, right._poly) sig_off() return qq, rr @@ -776,7 +776,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): sage: x.is_zero() False """ - return (fmpz_poly_degree(self.__poly) == -1) + return (fmpz_poly_degree(self._poly) == -1) cpdef bint is_one(self) except -1: """ @@ -792,7 +792,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): sage: x.is_one() False """ - return fmpz_poly_is_one(self.__poly) + return fmpz_poly_is_one(self._poly) def __bool__(self): """ @@ -808,7 +808,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): sage: bool(x) True """ - return not (fmpz_poly_degree(self.__poly) == -1) + return not (fmpz_poly_degree(self._poly) == -1) @coerce_binop def gcd(self, right): @@ -831,8 +831,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): return self cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_gcd(x.__poly, self.__poly, - (right).__poly) + fmpz_poly_gcd(x._poly, self._poly, + (right)._poly) sig_off() return x @@ -941,8 +941,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): fmpz_init(r) sig_on() - fmpz_poly_xgcd(r, ss.__poly, tt.__poly, self.__poly, - (right).__poly) + fmpz_poly_xgcd(r, ss._poly, tt._poly, self._poly, + (right)._poly) sig_off() cdef Integer rr = Integer.__new__(Integer) fmpz_get_mpz(rr.value, r) @@ -970,8 +970,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_mul(x.__poly, self.__poly, - (right).__poly) + fmpz_poly_mul(x._poly, self._poly, + (right)._poly) sig_off() return x @@ -1000,8 +1000,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_mullow(x.__poly, self.__poly, - (right).__poly, + fmpz_poly_mullow(x._poly, self._poly, + (right)._poly, n) sig_off() return x @@ -1020,7 +1020,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_scalar_mul_mpz(x.__poly, self.__poly, (right).value) + fmpz_poly_scalar_mul_mpz(x._poly, self._poly, (right).value) sig_off() return x @@ -1038,7 +1038,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint x = self._new() sig_on() - fmpz_poly_scalar_mul_mpz(x.__poly, self.__poly, (right).value) + fmpz_poly_scalar_mul_mpz(x._poly, self._poly, (right).value) sig_off() return x @@ -1132,7 +1132,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): num = n.numerator() den = n.denominator() - if fmpz_poly_degree(self.__poly) == 0: + if fmpz_poly_degree(self._poly) == 0: return self.parent()(self[0].nth_root(den) ** num) return self.nth_root(den) ** num @@ -1142,7 +1142,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if self.is_zero(): if nn == 0: - fmpz_poly_set_coeff_si(res.__poly, 0, 1) + fmpz_poly_set_coeff_si(res._poly, 0, 1) return res elif nn < 0: raise ZeroDivisionError("negative exponent in power of zero") @@ -1150,17 +1150,17 @@ cdef class Polynomial_integer_dense_flint(Polynomial): return res if nn < 0: sig_on() - fmpz_poly_pow(res.__poly, self.__poly, -nn) + fmpz_poly_pow(res._poly, self._poly, -nn) sig_off() return ~res else: if self is self._parent.gen(): sig_on() - fmpz_poly_set_coeff_ui(res.__poly, nn, 1) + fmpz_poly_set_coeff_ui(res._poly, nn, 1) sig_off() else: sig_on() - fmpz_poly_pow(res.__poly, self.__poly, nn) + fmpz_poly_pow(res._poly, self._poly, nn) sig_off() return res @@ -1187,7 +1187,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef Polynomial_integer_dense_flint res res = self._new() - fmpz_poly_pow_trunc(res.__poly, self.__poly, n, prec) + fmpz_poly_pow_trunc(res._poly, self._poly, n, prec) return res def __floordiv__(Polynomial_integer_dense_flint self, right): @@ -1226,14 +1226,14 @@ cdef class Polynomial_integer_dense_flint(Polynomial): else: res = self._new() sig_on() - fmpz_poly_scalar_fdiv_mpz(res.__poly, self.__poly, + fmpz_poly_scalar_fdiv_mpz(res._poly, self._poly, ( right).value) sig_off() return res elif right in ZZ: res = self._new() sig_on() - fmpz_poly_scalar_fdiv_mpz(res.__poly, self.__poly, + fmpz_poly_scalar_fdiv_mpz(res._poly, self._poly, (ZZ(right)).value) sig_off() return res @@ -1248,7 +1248,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): else: res = self._new() sig_on() - fmpz_poly_div(res.__poly, self.__poly, _right.__poly) + fmpz_poly_div(res._poly, self._poly, _right._poly) sig_off() return res @@ -1293,9 +1293,9 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if prec <= 0: raise ValueError("the precision must be positive, got {}".format(prec)) - if fmpz_poly_degree(self.__poly) == -1: + if fmpz_poly_degree(self._poly) == -1: raise ValueError("constant term is zero") - cdef fmpz_t c = fmpz_poly_get_coeff_ptr(self.__poly, 0) + cdef fmpz_t c = fmpz_poly_get_coeff_ptr(self._poly, 0) if fmpz_cmp_si(c, 1) and fmpz_cmp_si(c, -1): raise ValueError("constant term {} is not a unit".format(self[0])) @@ -1303,7 +1303,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if prec <= 0: return res sig_on() - fmpz_poly_inv_series(res.__poly, self.__poly, prec) + fmpz_poly_inv_series(res._poly, self._poly, prec) sig_off() return res @@ -1331,16 +1331,16 @@ cdef class Polynomial_integer_dense_flint(Polynomial): raise IndexError("n must be >= 0") if isinstance(value, int): sig_on() - fmpz_poly_set_coeff_si(self.__poly, n, value) + fmpz_poly_set_coeff_si(self._poly, n, value) sig_off() elif isinstance(value, Integer): sig_on() - fmpz_poly_set_coeff_mpz(self.__poly, n, (value).value) + fmpz_poly_set_coeff_mpz(self._poly, n, (value).value) sig_off() else: value = Integer(value) sig_on() - fmpz_poly_set_coeff_mpz(self.__poly, n, (value).value) + fmpz_poly_set_coeff_mpz(self._poly, n, (value).value) sig_off() def real_root_intervals(self): @@ -1364,7 +1364,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): ## def __copy__(self): ## f = Polynomial_integer_dense(self.parent()) -## f.__poly = self.__poly.copy() +## f._poly = self._poly.copy() ## return f @@ -1391,7 +1391,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): sage: type(x.degree()) """ - return smallInteger(fmpz_poly_degree(self.__poly)) + return smallInteger(fmpz_poly_degree(self._poly)) def pseudo_divrem(self, B): r""" @@ -1426,7 +1426,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef Polynomial_integer_dense_flint Q = self._new(), R = self._new(), _B = B cdef ulong d - fmpz_poly_pseudo_divrem(Q.__poly, R.__poly, &d, self.__poly, _B.__poly) + fmpz_poly_pseudo_divrem(Q._poly, R._poly, &d, self._poly, _B._poly) return Q, R, Integer(d) def discriminant(self, proof=True): @@ -1460,7 +1460,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): """ cdef ZZX_c ntl_poly cdef ZZ_c* temp - fmpz_poly_get_ZZX(ntl_poly, self.__poly) + fmpz_poly_get_ZZX(ntl_poly, self._poly) temp = ZZX_discriminant(&ntl_poly, proof) cdef Integer x = Integer.__new__(Integer) @@ -1531,12 +1531,12 @@ cdef class Polynomial_integer_dense_flint(Polynomial): # the primitive part returned by FLINT has positive leading # coefficient - fmpz_poly_primitive_part(ppart, self.__poly) + fmpz_poly_primitive_part(ppart, self._poly) fmpz_poly_get_ZZX(ntl_poly, ppart) fmpz_poly_clear(ppart) else: - fmpz_poly_get_ZZX(ntl_poly, self.__poly) + fmpz_poly_get_ZZX(ntl_poly, self._poly) # input is primitive, with positive leading coefficient ZZX_squarefree_decomposition(&v, &e, &n, &ntl_poly) @@ -1544,7 +1544,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): F = [] for i from 0 <= i < n: fac = self._new() - fmpz_poly_set_ZZX(fac.__poly, v[i][0]) + fmpz_poly_set_ZZX(fac._poly, v[i][0]) F.append( (fac,e[i]) ) del v[i] sig_free(v) @@ -1582,9 +1582,9 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef ZZ_c content cdef vec_pair_ZZX_long_c factors cdef long i - cdef int sig_me = fmpz_poly_degree(self.__poly) + cdef int sig_me = fmpz_poly_degree(self._poly) - fmpz_poly_get_ZZX(ntl_poly, self.__poly) + fmpz_poly_get_ZZX(ntl_poly, self._poly) if sig_me > 10: sig_on() @@ -1603,13 +1603,13 @@ cdef class Polynomial_integer_dense_flint(Polynomial): fac_py = self._new() fmpz_init(tcontent) fmpz_set_ZZ(tcontent, content) - fmpz_poly_set_coeff_fmpz(fac_py.__poly, 0, tcontent) + fmpz_poly_set_coeff_fmpz(fac_py._poly, 0, tcontent) results.append( (fac_py,1) ) fmpz_clear(tcontent) for i from 0 <= i < factors.length(): fac_py = self._new() - fmpz_poly_set_ZZX(fac_py.__poly, factors.RawGet(i).a) + fmpz_poly_set_ZZX(fac_py._poly, factors.RawGet(i).a) results.append( (fac_py,factors.RawGet(i).b) ) return Factorization(results, unit = unit) @@ -1639,7 +1639,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): (-1) * 2 * 3 * 5 * x """ cdef int i - cdef long deg = fmpz_poly_degree(self.__poly) + cdef long deg = fmpz_poly_degree(self._poly) # it appears that pari has a window from about degrees 30 and 300 # in which it beats NTL. c = self.content() @@ -1783,8 +1783,8 @@ cdef class Polynomial_integer_dense_flint(Polynomial): cdef Integer x = Integer.__new__(Integer) sig_on() - fmpz_poly_resultant(res, self.__poly, - (other).__poly) + fmpz_poly_resultant(res, self._poly, + (other)._poly) sig_off() fmpz_get_mpz(x.value, res) fmpz_clear(res) @@ -1830,10 +1830,10 @@ cdef class Polynomial_integer_dense_flint(Polynomial): if d != degree: raise ValueError("degree argument must be a non-negative integer, got %s" % degree) # FLINT expects length - fmpz_poly_reverse(res.__poly, self.__poly, d+1) + fmpz_poly_reverse(res._poly, self._poly, d+1) else: - fmpz_poly_reverse(res.__poly, self.__poly, - fmpz_poly_length(self.__poly)) + fmpz_poly_reverse(res._poly, self._poly, + fmpz_poly_length(self._poly)) return res def revert_series(self, n): @@ -1867,7 +1867,7 @@ cdef class Polynomial_integer_dense_flint(Polynomial): raise ValueError("self must have constant coefficient 0 and a unit for coefficient {}^1".format(self.parent().gen())) sig_on() - fmpz_poly_revert_series(res.__poly, self.__poly, m) + fmpz_poly_revert_series(res._poly, self._poly, m) sig_off() return res diff --git a/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pxd b/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pxd index a7c380b49a2..fcd907e1abe 100644 --- a/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pxd +++ b/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pxd @@ -2,6 +2,6 @@ from sage.libs.ntl.types cimport ZZX_c from sage.rings.polynomial.polynomial_element cimport Polynomial cdef class Polynomial_integer_dense_ntl(Polynomial): - cdef ZZX_c __poly + cdef ZZX_c _poly cdef Polynomial_integer_dense_ntl _new(self) diff --git a/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pyx b/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pyx index e7b708bbc51..80a1726bb4e 100644 --- a/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pyx +++ b/src/sage/rings/polynomial/polynomial_integer_dense_ntl.pyx @@ -172,7 +172,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): if isinstance(x, Polynomial): if x.parent() is self.parent(): # copy with NTL assignment operator - self.__poly = (x).__poly + self._poly = (x)._poly return else: # coerce coefficients into Sage integers @@ -191,17 +191,17 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): degree = i if degree >= NTL_OVFBND: raise OverflowError("Dense NTL integer polynomials have a maximum degree of %s" % (NTL_OVFBND-1)) - ZZX_SetCoeff_long(self.__poly, degree, 1) + ZZX_SetCoeff_long(self._poly, degree, 1) # now fill them in for ii, a in x: i = ii[0] if type(ii) is tuple else ii if type(a) is int: - ZZX_SetCoeff_long(self.__poly, i, a) + ZZX_SetCoeff_long(self._poly, i, a) else: if not isinstance(a, Integer): a = ZZ(a) mpz_to_ZZ(&y, (a).value) - ZZX_SetCoeff(self.__poly, i, y) + ZZX_SetCoeff(self._poly, i, y) return elif isinstance(x, pari_gen): @@ -210,14 +210,14 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): elif isinstance(x, ntl_ZZX): # coercion from ntl.pyx object # copy with NTL assignment operator - self.__poly = (x).x + self._poly = (x).x return elif isinstance(x, FractionFieldElement) and \ isinstance(x.numerator(), Polynomial_integer_dense_ntl): if x.denominator() == 1: # fraction of the form f(x)/1 - self.__poly = (x.numerator()).__poly + self._poly = (x.numerator())._poly return elif not isinstance(x, (list, tuple)): @@ -229,12 +229,12 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): for i from 0 <= i < len(x): a = x[i] if type(a) is int: - ZZX_SetCoeff_long(self.__poly, i, a) + ZZX_SetCoeff_long(self._poly, i, a) else: if not isinstance(a, Integer): a = ZZ(a) mpz_to_ZZ(&y, (a).value) - ZZX_SetCoeff(self.__poly, i, y) + ZZX_SetCoeff(self._poly, i, y) def content(self): @@ -259,7 +259,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): """ cdef ZZ_c y cdef Integer z = Integer.__new__(Integer) - ZZX_content(y, self.__poly) + ZZX_content(y, self._poly) ZZ_to_mpz(z.value, &y) return z @@ -288,7 +288,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): """ cdef RealNumber res = a._new() sig_on() - ZZX_evaluation_mpfr(res.value, self.__poly, a.value) + ZZX_evaluation_mpfr(res.value, self._poly, a.value) sig_off() return res @@ -318,7 +318,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): """ cdef RealIntervalFieldElement res = a._new() sig_on() - ZZX_evaluation_mpfi(res.value, self.__poly, a.value) + ZZX_evaluation_mpfi(res.value, self._poly, a.value) sig_off() return res @@ -363,7 +363,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): 5*x^5 + 4*x^4 + 3*x^3 + 2*x^2 + x + 1 """ cdef Integer z = Integer.__new__(Integer) - ZZ_to_mpz(z.value, &self.__poly.rep.elts()[n]) + ZZ_to_mpz(z.value, &self._poly.rep.elts()[n]) return z def _repr(self, name=None, bint latex=False): @@ -380,15 +380,15 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): name = self.parent().variable_name() cdef long i cdef list all = [] - for i from ZZX_deg(self.__poly) >= i >= 0: - sign = ZZ_sign(ZZX_coeff(self.__poly, i)) + for i from ZZX_deg(self._poly) >= i >= 0: + sign = ZZ_sign(ZZX_coeff(self._poly, i)) if sign: if sign > 0: sign_str = '+' - coeff_str = ccrepr(self.__poly.rep.elts()[i]) + coeff_str = ccrepr(self._poly.rep.elts()[i]) else: sign_str = '-' - coeff_str = ccrepr(self.__poly.rep.elts()[i])[1:] + coeff_str = ccrepr(self._poly.rep.elts()[i])[1:] if i > 0: if coeff_str == '1': coeff_str = '' @@ -441,8 +441,8 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): -3*x^2 + 2*x + 7 """ cdef Polynomial_integer_dense_ntl x = self._new() - ZZX_add(x.__poly, self.__poly, - (right).__poly) + ZZX_add(x._poly, self._poly, + (right)._poly) return x @@ -459,8 +459,8 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): 3*x^2 + 2*x - 5 """ cdef Polynomial_integer_dense_ntl x = self._new() - ZZX_sub(x.__poly, self.__poly, - (right).__poly) + ZZX_sub(x._poly, self._poly, + (right)._poly) return x @@ -476,7 +476,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): -2*x + 1 """ cdef Polynomial_integer_dense_ntl x = self._new() - ZZX_negate(x.__poly, self.__poly) + ZZX_negate(x._poly, self._poly) return x @@ -533,10 +533,10 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): """ cdef Polynomial_integer_dense_ntl _right = right - if ZZX_IsZero(_right.__poly): + if ZZX_IsZero(_right._poly): raise ArithmeticError("division by zero polynomial") - if ZZX_IsZero(self.__poly): + if ZZX_IsZero(self._poly): return self, self cdef ZZX_c *q @@ -545,19 +545,19 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): cdef Polynomial_integer_dense_ntl rr = self._new() cdef int divisible - if ZZ_IsOne(ZZX_LeadCoeff(_right.__poly)): + if ZZ_IsOne(ZZX_LeadCoeff(_right._poly)): # divisor is monic. Just do the division and remainder - ZZX_quo_rem(&self.__poly, &_right.__poly, &r, &q) - ZZX_swap(qq.__poly, q[0]) - ZZX_swap(rr.__poly, r[0]) + ZZX_quo_rem(&self._poly, &_right._poly, &r, &q) + ZZX_swap(qq._poly, q[0]) + ZZX_swap(rr._poly, r[0]) del q del r else: # Non-monic divisor. Check whether it divides exactly. - q = ZZX_div(&self.__poly, &_right.__poly, &divisible) + q = ZZX_div(&self._poly, &_right._poly, &divisible) if divisible: # exactly divisible - ZZX_swap(q[0], qq.__poly) + ZZX_swap(q[0], qq._poly) del q else: # division failed: clean up and raise exception @@ -584,8 +584,8 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): """ # todo: we're doing an unnecessary copy here cdef Polynomial_integer_dense_ntl x = self._new() - cdef ZZX_c* temp = ZZX_gcd(&self.__poly, &(right).__poly) - x.__poly = temp[0] + cdef ZZX_c* temp = ZZX_gcd(&self._poly, &(right)._poly) + x._poly = temp[0] del temp return x @@ -658,13 +658,13 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): cdef ZZX_c *t cdef ZZ_c *r - ZZX_xgcd(&self.__poly, &(right).__poly, &r, &s, &t, 1) # proof = 1 + ZZX_xgcd(&self._poly, &(right)._poly, &r, &s, &t, 1) # proof = 1 cdef Integer rr = Integer.__new__(Integer) ZZ_to_mpz(rr.value, r) cdef Polynomial_integer_dense_ntl ss = self._new() cdef Polynomial_integer_dense_ntl tt = self._new() - ss.__poly = s[0] - tt.__poly = t[0] + ss._poly = s[0] + tt._poly = t[0] del r del s del t @@ -691,8 +691,8 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): x^3 - 10*x^2 + 32*x - 32 """ cdef Polynomial_integer_dense_ntl x = self._new() - ZZX_mul(x.__poly, self.__poly, - (right).__poly) + ZZX_mul(x._poly, self._poly, + (right)._poly) return x cpdef _lmul_(self, Element right): @@ -711,7 +711,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): cdef ZZ_c _right mpz_to_ZZ(&_right, (right).value) - ZZX_mul_ZZ(x.__poly, self.__poly, _right) + ZZX_mul_ZZ(x._poly, self._poly, _right) return x cpdef _rmul_(self, Element right): @@ -730,7 +730,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): cdef ZZ_c _right mpz_to_ZZ(&_right, (right).value) - ZZX_mul_ZZ(x.__poly, self.__poly, _right) + ZZX_mul_ZZ(x._poly, self._poly, _right) return x @@ -783,7 +783,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): value = Integer(value) cdef ZZ_c y mpz_to_ZZ(&y, (value).value) - ZZX_SetCoeff(self.__poly, n, y) + ZZX_SetCoeff(self._poly, n, y) def real_root_intervals(self): @@ -805,7 +805,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): ## def __copy__(self): ## f = Polynomial_integer_dense(self.parent()) -## f.__poly = self.__poly.copy() +## f._poly = self._poly.copy() ## return f @@ -826,7 +826,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): sage: R(0).degree() -1 """ - return ZZX_deg(self.__poly) + return ZZX_deg(self._poly) def discriminant(self, proof=True): r""" @@ -849,7 +849,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): sage: f.discriminant(proof=False) -339 """ - cdef ZZ_c* temp = ZZX_discriminant(&self.__poly, proof) + cdef ZZ_c* temp = ZZX_discriminant(&self._poly, proof) cdef Integer x = Integer.__new__(Integer) ZZ_to_mpz(x.value, temp) del temp @@ -904,11 +904,11 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): cdef long* e cdef long i, n cdef Polynomial_integer_dense_ntl z - ZZX_squarefree_decomposition(&v, &e, &n, &p.__poly) + ZZX_squarefree_decomposition(&v, &e, &n, &p._poly) F = [] for i from 0 <= i < n: z = self._new() - z.__poly = v[i][0] + z._poly = v[i][0] F.append((z, e[i])) del v[i] sig_free(v) @@ -950,24 +950,24 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): cdef ZZ_c content cdef vec_pair_ZZX_long_c factors cdef long i - cdef int sig_me = ZZX_deg(self.__poly) + cdef int sig_me = ZZX_deg(self._poly) if sig_me > 10: sig_on() - ZZX_factor(content, factors, self.__poly, 0, 0) + ZZX_factor(content, factors, self._poly, 0, 0) if sig_me > 10: sig_off() results = [] unit = None if not ZZ_IsOne(content): fac_py = self._new() - ZZX_SetCoeff(fac_py.__poly, 0, content) - if ZZX_deg(fac_py.__poly) == 0 and ZZ_to_int(fac_py.__poly.rep.elts())==-1: + ZZX_SetCoeff(fac_py._poly, 0, content) + if ZZX_deg(fac_py._poly) == 0 and ZZ_to_int(fac_py._poly.rep.elts())==-1: unit = fac_py else: results.append( (fac_py,1) ) for i from 0 <= i < factors.length(): fac_py = self._new() - fac_py.__poly = factors.RawGet(i).a + fac_py._poly = factors.RawGet(i).a results.append( (fac_py,factors.RawGet(i).b) ) return Factorization(results, unit = unit) @@ -996,7 +996,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): sage: f = -30*x; f.factor() (-1) * 2 * 3 * 5 * x """ - cdef int deg = ZZX_deg(self.__poly) + cdef int deg = ZZX_deg(self._poly) # it appears that pari has a window from about degrees 30 and 300 # in which it beats NTL. c = self.content() @@ -1131,7 +1131,7 @@ cdef class Polynomial_integer_dense_ntl(Polynomial): True """ cdef Polynomial_integer_dense_ntl _other = (self.parent().coerce(other)) - cdef ZZ_c* temp = ZZX_resultant(&self.__poly, &_other.__poly, proof) + cdef ZZ_c* temp = ZZX_resultant(&self._poly, &_other._poly, proof) cdef Integer x = Integer.__new__(Integer) ZZ_to_mpz(x.value, temp) del temp diff --git a/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pxd b/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pxd index 264f05f3c0d..6934acfee8d 100644 --- a/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pxd +++ b/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pxd @@ -16,7 +16,7 @@ from sage.libs.ntl.lzz_pX cimport * cdef class Polynomial_dense_mod_n(Polynomial): - cdef object __poly + cdef object _poly cdef object __singular cdef class Polynomial_dense_modn_ntl_zz(Polynomial_dense_mod_n): diff --git a/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx b/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx index 57468e3510f..d69d5e09018 100644 --- a/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx +++ b/src/sage/rings/polynomial/polynomial_modn_dense_ntl.pyx @@ -105,19 +105,19 @@ cdef class Polynomial_dense_mod_n(Polynomial): if construct: if isinstance(x, ZZ_pX): - self.__poly = x + self._poly = x return - self.__poly = ZZ_pX(x, parent.modulus()) + self._poly = ZZ_pX(x, parent.modulus()) return - self.__poly = ZZ_pX([], parent.modulus()) + self._poly = ZZ_pX([], parent.modulus()) if x is None: return # leave initialized to 0 polynomial. if isinstance(x, Polynomial): if x.parent() == self.parent(): - self.__poly = (x).__poly.__copy__() + self._poly = (x)._poly.__copy__() return else: R = parent.base_ring() @@ -130,7 +130,7 @@ cdef class Polynomial_dense_mod_n(Polynomial): elif isinstance(x, ZZX): - self.__poly = x.copy() + self._poly = x.copy() return elif isinstance(x, pari_gen): @@ -142,7 +142,7 @@ cdef class Polynomial_dense_mod_n(Polynomial): if x.denominator().is_unit(): numer = x.numerator() denom = x.denominator().inverse_of_unit() - x = numer.__poly * denom.__poly + x = numer._poly * denom._poly check = False else: raise TypeError("Denominator not a unit.") @@ -154,13 +154,13 @@ cdef class Polynomial_dense_mod_n(Polynomial): R = parent.base_ring() x = [ZZ(R(a)) for a in x] - self.__poly = ZZ_pX(x, parent.modulus()) + self._poly = ZZ_pX(x, parent.modulus()) def __reduce__(self): return make_element, (self.parent(), (self.list(), False, self.is_gen())) def int_list(self): - return eval(str(self.__poly).replace(' ',',')) + return eval(str(self._poly).replace(' ',',')) def __pari__(self, variable=None): """ @@ -186,7 +186,7 @@ cdef class Polynomial_dense_mod_n(Polynomial): You must call ``ntl.set_modulus(ntl.ZZ(n))`` before doing arithmetic with this object! """ - return self.__poly + return self._poly cdef get_unsafe(self, Py_ssize_t n): """ @@ -203,13 +203,13 @@ cdef class Polynomial_dense_mod_n(Polynomial): sage: f[:3] 13*x^2 + 10*x + 5 """ - return self._parent._base(( self.__poly)[n]._integer_()) + return self._parent._base(( self._poly)[n]._integer_()) def _unsafe_mutate(self, n, value): n = int(n) if n < 0: raise IndexError("n must be >= 0") - self.__poly[n] = int(value) + self._poly[n] = int(value) def _pow(self, n): n = int(n) @@ -218,10 +218,10 @@ cdef class Polynomial_dense_mod_n(Polynomial): return self.parent()(self[0]**n) if n < 0: return (~self)**(-n) - return self.parent()(self.__poly**n, construct=True) + return self.parent()(self._poly**n, construct=True) cpdef _add_(self, right): - return self.parent()(self.__poly + (right).__poly, construct=True) + return self.parent()(self._poly + (right)._poly, construct=True) cpdef _mul_(self, right): """ @@ -231,11 +231,11 @@ cdef class Polynomial_dense_mod_n(Polynomial): sage: (x - 2)*(x^2 - 8*x + 16) x^3 + 90*x^2 + 32*x + 68 """ - return self.parent()(self.__poly * (right).__poly, construct=True) + return self.parent()(self._poly * (right)._poly, construct=True) cpdef _lmul_(self, Element c): try: - return self.parent()(ZZ_pX([c], self.parent().modulus()) * self.__poly, construct=True) + return self.parent()(ZZ_pX([c], self.parent().modulus()) * self._poly, construct=True) except RuntimeError as msg: # should this really be a TypeError raise TypeError(msg) @@ -245,7 +245,7 @@ cdef class Polynomial_dense_mod_n(Polynomial): Return a tuple ``(quotient, remainder)`` where ``self = quotient*other + remainder``. """ - v = self.__poly.quo_rem((right).__poly) + v = self._poly.quo_rem((right)._poly) P = self.parent() return (P(v[0], construct=True), P(v[1], construct=True) ) @@ -281,11 +281,11 @@ cdef class Polynomial_dense_mod_n(Polynomial): """ if n == 0 or self.degree() < 0: return self - return self.parent()(self.__poly.left_shift(n), + return self.parent()(self._poly.left_shift(n), construct=True) cpdef _sub_(self, right): - return self.parent()(self.__poly - (right).__poly, construct=True) + return self.parent()(self._poly - (right)._poly, construct=True) def __floordiv__(self, right): q, _ = self.quo_rem(right) @@ -314,7 +314,7 @@ cdef class Polynomial_dense_mod_n(Polynomial): sage: isinstance(x.degree(), Integer) True """ - return smallInteger(max(self.__poly.degree(), -1)) + return smallInteger(max(self._poly.degree(), -1)) cpdef list list(self, bint copy=True): """ @@ -358,7 +358,7 @@ cdef class Polynomial_dense_mod_n(Polynomial): """ if self.is_gen(): raise TypeError("Cannot change the value of the generator.") - self.__poly = ZZ_pX(v, self.parent().modulus()) + self._poly = ZZ_pX(v, self.parent().modulus()) # Polynomial_singular_repr stuff, copied due to lack of multiple inheritance def _singular_(self, singular=singular_default, force=False): @@ -654,8 +654,8 @@ cdef class Polynomial_dense_modn_ntl_zz(Polynomial_dense_mod_n): return Polynomial_dense_mod_n.__init__(self, parent, v, check=check, is_gen=is_gen, construct=construct) - v = [a for a in self.__poly.list()] - self.__poly = None # this will eventually go away + v = [a for a in self._poly.list()] + self._poly = None # this will eventually go away cdef ntl_zz_pX ntl = ntl_zz_pX(v, parent.modulus()) # let it handle the hard work self.x = ntl.x self.c = ntl.c @@ -668,8 +668,8 @@ cdef class Polynomial_dense_modn_ntl_zz(Polynomial_dense_mod_n): # TODO: Get rid of this Polynomial_dense_mod_n.ntl_set_directly(self, v) # verbatim from __init__ - v = [int(a) for a in self.__poly.list()] - self.__poly = None # this will eventually go away + v = [int(a) for a in self._poly.list()] + self._poly = None # this will eventually go away cdef ntl_zz_pX ntl = ntl_zz_pX(v, self._parent.modulus()) # let it handle the hard work self.x = ntl.x self.c = ntl.c @@ -1241,8 +1241,8 @@ cdef class Polynomial_dense_modn_ntl_ZZ(Polynomial_dense_mod_n): return Polynomial_dense_mod_n.__init__(self, parent, v, check=check, is_gen=is_gen, construct=construct) - cdef ntl_ZZ_pX ntl = self.__poly - self.__poly = None # this will eventually go away + cdef ntl_ZZ_pX ntl = self._poly + self._poly = None # this will eventually go away self.x = ntl.x self.c = ntl.c diff --git a/src/sage/rings/polynomial/polynomial_rational_flint.pxd b/src/sage/rings/polynomial/polynomial_rational_flint.pxd index 055d7842668..f4644f19d04 100644 --- a/src/sage/rings/polynomial/polynomial_rational_flint.pxd +++ b/src/sage/rings/polynomial/polynomial_rational_flint.pxd @@ -11,7 +11,7 @@ from sage.libs.flint.types cimport fmpq_poly_t from sage.rings.polynomial.polynomial_element cimport Polynomial cdef class Polynomial_rational_flint(Polynomial): - cdef fmpq_poly_t __poly + cdef fmpq_poly_t _poly cdef Polynomial_rational_flint _new(self) cpdef _mod_(self, right) diff --git a/src/sage/rings/polynomial/polynomial_rational_flint.pyx b/src/sage/rings/polynomial/polynomial_rational_flint.pyx index d0dd15522e9..26d070ac77f 100644 --- a/src/sage/rings/polynomial/polynomial_rational_flint.pyx +++ b/src/sage/rings/polynomial/polynomial_rational_flint.pyx @@ -155,16 +155,16 @@ cdef class Polynomial_rational_flint(Polynomial): res._parent = P res._is_gen = 0 if isinstance(x, int): - fmpq_poly_set_si(res.__poly, x) + fmpq_poly_set_si(res._poly, x) elif isinstance(x, Integer): - fmpq_poly_set_mpz(res.__poly, ( x).value) + fmpq_poly_set_mpz(res._poly, ( x).value) elif isinstance(x, Rational): - fmpq_poly_set_mpq(res.__poly, ( x).value) + fmpq_poly_set_mpq(res._poly, ( x).value) else: - fmpq_poly_set_si(res.__poly, int(x)) + fmpq_poly_set_si(res._poly, int(x)) return res @@ -177,7 +177,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: R. = QQ[] sage: f = 2/3 * t - 7 #indirect doctest """ - fmpq_poly_init(self.__poly) + fmpq_poly_init(self._poly) def __dealloc__(self): """ @@ -189,7 +189,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: f = 1/3 * t sage: del f """ - fmpq_poly_clear(self.__poly) + fmpq_poly_clear(self._poly) def __init__(self, parent, x=None, check=True, is_gen=False, construct=False): """ @@ -227,19 +227,19 @@ cdef class Polynomial_rational_flint(Polynomial): Polynomial.__init__(self, parent, is_gen=is_gen) if is_gen: - fmpq_poly_set_coeff_si(self.__poly, 1, 1) + fmpq_poly_set_coeff_si(self._poly, 1, 1) elif isinstance(x, Polynomial_rational_flint): - fmpq_poly_set(self.__poly, ( x).__poly) + fmpq_poly_set(self._poly, ( x)._poly) elif isinstance(x, int): - fmpq_poly_set_si(self.__poly, x) + fmpq_poly_set_si(self._poly, x) elif isinstance(x, Integer): - fmpq_poly_set_mpz(self.__poly, ( x).value) + fmpq_poly_set_mpz(self._poly, ( x).value) elif isinstance(x, Rational): - fmpq_poly_set_mpq(self.__poly, ( x).value) + fmpq_poly_set_mpq(self._poly, ( x).value) elif isinstance(x, list) or isinstance(x, tuple): @@ -257,7 +257,7 @@ cdef class Polynomial_rational_flint(Polynomial): for deg from 0 <= deg < n: mpq_init(L2[deg]) mpq_set(L2[deg], ( L1[deg]).value) - fmpq_poly_set_array_mpq(self.__poly, L2, n) + fmpq_poly_set_array_mpq(self._poly, L2, n) for deg from 0 <= deg < n: mpq_clear(L2[deg]) sig_free(L2) @@ -266,13 +266,13 @@ cdef class Polynomial_rational_flint(Polynomial): # deg = 0 # for e in x: # c = Rational(e) -# fmpq_poly_set_coeff_mpq(self.__poly, deg, c.value) +# fmpq_poly_set_coeff_mpq(self._poly, deg, c.value) # deg += 1 elif isinstance(x, dict): for deg, e in x.iteritems(): c = Rational(e) - fmpq_poly_set_coeff_mpq(self.__poly, deg, c.value) + fmpq_poly_set_coeff_mpq(self._poly, deg, c.value) elif isinstance(x, pari_gen): k = self._parent.base_ring() @@ -281,7 +281,7 @@ cdef class Polynomial_rational_flint(Polynomial): is_gen=False, construct=construct) elif isinstance(x, Polynomial_integer_dense_flint): - fmpq_poly_set_fmpz_poly(self.__poly, (x).__poly) + fmpq_poly_set_fmpz_poly(self._poly, (x)._poly) elif isinstance(x, Polynomial): k = self._parent.base_ring() @@ -329,7 +329,7 @@ cdef class Polynomial_rational_flint(Polynomial): True """ cdef Polynomial_rational_flint res = self._new() - fmpq_poly_set(res.__poly, self.__poly) + fmpq_poly_set(res._poly, self._poly) return res def _singular_(self, singular=singular_default): @@ -364,7 +364,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: g.list() [] """ - cdef unsigned long length = fmpq_poly_length(self.__poly) + cdef unsigned long length = fmpq_poly_length(self._poly) return [self.get_unsafe(n) for n in range(length)] ########################################################################### @@ -392,7 +392,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: type(f.degree()) """ - return smallInteger(fmpq_poly_degree(self.__poly)) + return smallInteger(fmpq_poly_degree(self._poly)) cdef get_unsafe(self, Py_ssize_t n): """ @@ -413,7 +413,7 @@ cdef class Polynomial_rational_flint(Polynomial): 1/2*t^2 + t + 1 """ cdef Rational z = Rational.__new__(Rational) - fmpq_poly_get_coeff_mpq(z.value, self.__poly, n) + fmpq_poly_get_coeff_mpq(z.value, self._poly, n) return z cpdef _unsafe_mutate(self, unsigned long n, value): @@ -434,24 +434,24 @@ cdef class Polynomial_rational_flint(Polynomial): rely on this convention. This method should be used only with the utmost care. """ - cdef bint do_sig = _do_sig(self.__poly) + cdef bint do_sig = _do_sig(self._poly) if isinstance(value, int): if do_sig: sig_str("FLINT exception") - fmpq_poly_set_coeff_si(self.__poly, n, value) + fmpq_poly_set_coeff_si(self._poly, n, value) if do_sig: sig_off() elif isinstance(value, Integer): if do_sig: sig_str("FLINT exception") - fmpq_poly_set_coeff_mpz(self.__poly, n, ( value).value) + fmpq_poly_set_coeff_mpz(self._poly, n, ( value).value) if do_sig: sig_off() elif isinstance(value, Rational): if do_sig: sig_str("FLINT exception") - fmpq_poly_set_coeff_mpq(self.__poly, n, ( value).value) + fmpq_poly_set_coeff_mpq(self._poly, n, ( value).value) if do_sig: sig_off() else: value = Rational(value) if do_sig: sig_str("FLINT exception") - fmpq_poly_set_coeff_mpq(self.__poly, n, ( value).value) + fmpq_poly_set_coeff_mpq(self._poly, n, ( value).value) if do_sig: sig_off() def __call__(self, *x, **kwds): @@ -501,20 +501,20 @@ cdef class Polynomial_rational_flint(Polynomial): if isinstance(a, Polynomial_rational_flint): f = ( a)._new() sig_str("FLINT exception") - fmpq_poly_compose(f.__poly, self.__poly, - ( a).__poly) + fmpq_poly_compose(f._poly, self._poly, + ( a)._poly) sig_off() return f elif isinstance(a, Rational): r = Rational.__new__(Rational) sig_str("FLINT exception") - fmpq_poly_evaluate_mpq(r.value, self.__poly, ( a).value) + fmpq_poly_evaluate_mpq(r.value, self._poly, ( a).value) sig_off() return r elif isinstance(a, Integer): r = Rational.__new__(Rational) sig_str("FLINT exception") - fmpq_poly_evaluate_mpz(r.value, self.__poly, ( a).value) + fmpq_poly_evaluate_mpz(r.value, self._poly, ( a).value) sig_off() return r elif isinstance(a, int): @@ -523,7 +523,7 @@ cdef class Polynomial_rational_flint(Polynomial): fmpz_init(tmpfz) fmpq_init(tmpfq) fmpz_set_si(tmpfz, PyInt_AS_LONG(a)) - fmpq_poly_evaluate_fmpz(tmpfq, self.__poly, tmpfz) + fmpq_poly_evaluate_fmpz(tmpfq, self._poly, tmpfz) fmpq_get_mpq(r.value, tmpfq) fmpq_clear(tmpfq) fmpz_clear(tmpfz) @@ -533,18 +533,18 @@ cdef class Polynomial_rational_flint(Polynomial): arb_a = a arb_z = arb_a._new() sig_on() - _arb_fmpz_poly_evaluate_arb(arb_z.value, fmpq_poly_numref(self.__poly), - fmpq_poly_length(self.__poly), arb_a.value, arb_a._parent._prec) - arb_div_fmpz(arb_z.value, arb_z.value, fmpq_poly_denref(self.__poly), arb_a._parent._prec) + _arb_fmpz_poly_evaluate_arb(arb_z.value, fmpq_poly_numref(self._poly), + fmpq_poly_length(self._poly), arb_a.value, arb_a._parent._prec) + arb_div_fmpz(arb_z.value, arb_z.value, fmpq_poly_denref(self._poly), arb_a._parent._prec) sig_off() return arb_z if isinstance(a, ComplexBall): acb_a = a acb_z = acb_a._new() sig_on() - _arb_fmpz_poly_evaluate_acb(acb_z.value, fmpq_poly_numref(self.__poly), - fmpq_poly_length(self.__poly), acb_a.value, acb_a._parent._prec) - acb_div_fmpz(acb_z.value, acb_z.value, fmpq_poly_denref(self.__poly), acb_a._parent._prec) + _arb_fmpz_poly_evaluate_acb(acb_z.value, fmpq_poly_numref(self._poly), + fmpq_poly_length(self._poly), acb_a.value, acb_a._parent._prec) + acb_div_fmpz(acb_z.value, acb_z.value, fmpq_poly_denref(self._poly), acb_a._parent._prec) sig_off() return acb_z @@ -570,14 +570,14 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint res cdef bint do_sig - if (n >= fmpq_poly_length(self.__poly)): + if (n >= fmpq_poly_length(self._poly)): return self else: res = self._new() if n > 0: - do_sig = _do_sig(self.__poly) + do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_get_slice(res.__poly, self.__poly, 0, n) + fmpq_poly_get_slice(res._poly, self._poly, 0, n) if do_sig: sig_off() return res @@ -664,7 +664,7 @@ cdef class Polynomial_rational_flint(Polynomial): cdef bint do_sig if degree is None: - len = fmpq_poly_length(self.__poly) + len = fmpq_poly_length(self._poly) else: try: len = (degree + 1) @@ -672,9 +672,9 @@ cdef class Polynomial_rational_flint(Polynomial): raise ValueError('degree must be convertible to long') res = self._new() - do_sig = _do_sig(self.__poly) + do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_reverse(res.__poly, self.__poly, len) + fmpq_poly_reverse(res._poly, self._poly, len) if do_sig: sig_off() return res @@ -709,7 +709,7 @@ cdef class Polynomial_rational_flint(Polynomial): raise ValueError("self must have constant coefficient 0 and a unit for coefficient {}^1".format(self.parent().gen())) sig_str("FLINT exception") - fmpq_poly_revert_series(res.__poly, self.__poly, m) + fmpq_poly_revert_series(res._poly, self._poly, m) sig_off() return res @@ -731,7 +731,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: R(0).is_zero() True """ - return fmpq_poly_is_zero(self.__poly) + return fmpq_poly_is_zero(self._poly) cpdef bint is_one(self) except -1: r""" @@ -751,7 +751,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: R([1,1]).is_one() False """ - return fmpq_poly_is_one(self.__poly) + return fmpq_poly_is_one(self._poly) def __bool__(self): """ @@ -766,7 +766,7 @@ cdef class Polynomial_rational_flint(Polynomial): sage: bool(R(0)) False """ - return not fmpq_poly_is_zero(self.__poly) + return not fmpq_poly_is_zero(self._poly) ########################################################################### # Shifting # @@ -794,14 +794,14 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint res cdef bint do_sig - if k == 0 or fmpq_poly_is_zero(f.__poly): + if k == 0 or fmpq_poly_is_zero(f._poly): return self else: res = f._new() - do_sig = fmpq_poly_length(f.__poly) > 5000 or n > 5000 + do_sig = fmpq_poly_length(f._poly) > 5000 or n > 5000 if do_sig: sig_str("FLINT exception") - fmpq_poly_shift_left(res.__poly, f.__poly, k) + fmpq_poly_shift_left(res._poly, f._poly, k) if do_sig: sig_off() return res @@ -822,14 +822,14 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint res cdef bint do_sig - if k == 0 or fmpq_poly_is_zero(f.__poly): + if k == 0 or fmpq_poly_is_zero(f._poly): return self else: res = f._new() - do_sig = _do_sig(f.__poly) + do_sig = _do_sig(f._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_shift_right(res.__poly, f.__poly, k) + fmpq_poly_shift_right(res._poly, f._poly, k) if do_sig: sig_off() return res @@ -858,10 +858,10 @@ cdef class Polynomial_rational_flint(Polynomial): """ cdef Polynomial_rational_flint op2 = right cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) or _do_sig(op2.__poly) + cdef bint do_sig = _do_sig(self._poly) or _do_sig(op2._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_add(res.__poly, self.__poly, op2.__poly) + fmpq_poly_add(res._poly, self._poly, op2._poly) if do_sig: sig_off() return res @@ -886,10 +886,10 @@ cdef class Polynomial_rational_flint(Polynomial): """ cdef Polynomial_rational_flint op2 = right cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) or _do_sig(op2.__poly) + cdef bint do_sig = _do_sig(self._poly) or _do_sig(op2._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_sub(res.__poly, self.__poly, op2.__poly) + fmpq_poly_sub(res._poly, self._poly, op2._poly) if do_sig: sig_off() return res @@ -912,10 +912,10 @@ cdef class Polynomial_rational_flint(Polynomial): True """ cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) + cdef bint do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_neg(res.__poly, self.__poly) + fmpq_poly_neg(res._poly, self._poly) if do_sig: sig_off() return res @@ -945,8 +945,8 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint rr = self._new() sig_str("FLINT exception") - fmpq_poly_divrem(qq.__poly, rr.__poly, self.__poly, - ( right).__poly) + fmpq_poly_divrem(qq._poly, rr._poly, self._poly, + ( right)._poly) sig_off() return qq, rr @@ -974,8 +974,8 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint res = self._new() sig_str("FLINT exception") - fmpq_poly_gcd(res.__poly, self.__poly, - ( right).__poly) + fmpq_poly_gcd(res._poly, self._poly, + ( right)._poly) sig_off() return res @@ -1001,8 +1001,8 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint res = self._new() sig_str("FLINT exception") - fmpq_poly_lcm(res.__poly, self.__poly, - ( right).__poly) + fmpq_poly_lcm(res._poly, self._poly, + ( right)._poly) sig_off() return res @@ -1043,7 +1043,7 @@ cdef class Polynomial_rational_flint(Polynomial): cdef Polynomial_rational_flint t = self._new() sig_str("FLINT exception") - fmpq_poly_xgcd(d.__poly, s.__poly, t.__poly, self.__poly, (right).__poly) + fmpq_poly_xgcd(d._poly, s._poly, t._poly, self._poly, (right)._poly) sig_off() return d, s, t @@ -1069,10 +1069,10 @@ cdef class Polynomial_rational_flint(Polynomial): """ cdef Polynomial_rational_flint op2 = right cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) or _do_sig(op2.__poly) + cdef bint do_sig = _do_sig(self._poly) or _do_sig(op2._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_mul(res.__poly, self.__poly, op2.__poly) + fmpq_poly_mul(res._poly, self._poly, op2._poly) if do_sig: sig_off() return res @@ -1103,13 +1103,13 @@ cdef class Polynomial_rational_flint(Polynomial): """ cdef Polynomial_rational_flint op2 = right cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) or _do_sig(op2.__poly) + cdef bint do_sig = _do_sig(self._poly) or _do_sig(op2._poly) if n <= 0: raise ValueError("n must be > 0") if do_sig: sig_str("FLINT exception") - fmpq_poly_mullow(res.__poly, self.__poly, op2.__poly, n) + fmpq_poly_mullow(res._poly, self._poly, op2._poly, n) if do_sig: sig_off() return res @@ -1125,10 +1125,10 @@ cdef class Polynomial_rational_flint(Polynomial): 9*t^3 - 6*t + 2 """ cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) + cdef bint do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_scalar_mul_mpq(res.__poly, self.__poly, + fmpq_poly_scalar_mul_mpq(res._poly, self._poly, ( left).value) if do_sig: sig_off() return res @@ -1145,10 +1145,10 @@ cdef class Polynomial_rational_flint(Polynomial): 9*t^3 - 6*t + 2 """ cdef Polynomial_rational_flint res = self._new() - cdef bint do_sig = _do_sig(self.__poly) + cdef bint do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_scalar_mul_mpq(res.__poly, self.__poly, + fmpq_poly_scalar_mul_mpq(res._poly, self._poly, ( right).value) if do_sig: sig_off() return res @@ -1272,27 +1272,27 @@ cdef class Polynomial_rational_flint(Polynomial): num = r.numerator() den = r.denominator() - if fmpq_poly_degree(self.__poly) == 0: + if fmpq_poly_degree(self._poly) == 0: return self.parent()(self[0].nth_root(den) ** num) return self.nth_root(den) ** num else: if n < 0: - if fmpq_poly_is_zero(self.__poly): + if fmpq_poly_is_zero(self._poly): raise ZeroDivisionError("negative exponent in power of zero") res = self._new() sig_str("FLINT exception") - fmpq_poly_pow(res.__poly, self.__poly, -n) + fmpq_poly_pow(res._poly, self._poly, -n) sig_off() return ~res else: res = self._new() sig_str("FLINT exception") if self._is_gen: - fmpq_poly_set_coeff_si(res.__poly, n, 1) + fmpq_poly_set_coeff_si(res._poly, n, 1) else: - fmpq_poly_pow(res.__poly, self.__poly, n) + fmpq_poly_pow(res._poly, self._poly, n) sig_off() return res @@ -1328,10 +1328,10 @@ cdef class Polynomial_rational_flint(Polynomial): if not isinstance(right, Polynomial_rational_flint): if right in QQ: res = self._new() - do_sig = _do_sig(self.__poly) + do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_scalar_div_mpq(res.__poly, self.__poly, + fmpq_poly_scalar_div_mpq(res._poly, self._poly, ( QQ(right)).value) if do_sig: sig_off() return res @@ -1340,8 +1340,8 @@ cdef class Polynomial_rational_flint(Polynomial): res = self._new() sig_str("FLINT exception") - fmpq_poly_div(res.__poly, self.__poly, - (right).__poly) + fmpq_poly_div(res._poly, self._poly, + (right)._poly) sig_off() return res @@ -1381,15 +1381,15 @@ cdef class Polynomial_rational_flint(Polynomial): """ if prec <= 0: raise ValueError("the precision must be positive, got {}".format(prec)) - if fmpq_poly_degree(self.__poly) == -1 or \ - fmpz_is_zero(fmpq_poly_numref(self.__poly)): + if fmpq_poly_degree(self._poly) == -1 or \ + fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term is zero") cdef Polynomial_rational_flint res = self._new() if prec <= 0: return res sig_on() - fmpq_poly_inv_series(res.__poly, self.__poly, prec) + fmpq_poly_inv_series(res._poly, self._poly, prec) sig_off() return res @@ -1423,8 +1423,8 @@ cdef class Polynomial_rational_flint(Polynomial): res = self._new() sig_str("FLINT exception") - fmpq_poly_rem(res.__poly, self.__poly, - (right).__poly) + fmpq_poly_rem(res._poly, self._poly, + (right)._poly) sig_off() return res @@ -1453,7 +1453,7 @@ cdef class Polynomial_rational_flint(Polynomial): Polynomial_integer_dense_flint.__init__(num, parent, x=None, check=False, is_gen=False, construct=False) sig_str("FLINT exception") - fmpq_poly_get_numerator(num.__poly, self.__poly) + fmpq_poly_get_numerator(num._poly, self._poly) sig_off() return num @@ -1469,10 +1469,10 @@ cdef class Polynomial_rational_flint(Polynomial): 3 """ cdef Integer den = Integer.__new__(Integer) - if fmpq_poly_denref(self.__poly) is NULL: + if fmpq_poly_denref(self._poly) is NULL: mpz_set_ui(den.value, 1) else: - fmpz_get_mpz(den.value, fmpq_poly_denref(self.__poly)) + fmpz_get_mpz(den.value, fmpq_poly_denref(self._poly)) return den def _derivative(self, var = None): @@ -1517,10 +1517,10 @@ cdef class Polynomial_rational_flint(Polynomial): raise ValueError("cannot differentiate with respect to {}".format(var)) der = self._new() - do_sig = _do_sig(self.__poly) + do_sig = _do_sig(self._poly) if do_sig: sig_str("FLINT exception") - fmpq_poly_derivative(der.__poly, self.__poly) + fmpq_poly_derivative(der._poly, self._poly) if do_sig: sig_off() return der @@ -1574,8 +1574,8 @@ cdef class Polynomial_rational_flint(Polynomial): cdef fmpq_t t fmpq_init(t) sig_str("FLINT exception") - fmpq_poly_resultant(t, self.__poly, - (right).__poly) + fmpq_poly_resultant(t, self._poly, + (right)._poly) fmpq_get_mpq(res.value, t) sig_off() fmpq_clear(t) @@ -1623,7 +1623,7 @@ cdef class Polynomial_rational_flint(Polynomial): """ cdef Polynomial_integer_dense_flint primitive - cdef unsigned long length = fmpq_poly_length(self.__poly) + cdef unsigned long length = fmpq_poly_length(self._poly) if length < 2: return False @@ -1636,8 +1636,8 @@ cdef class Polynomial_rational_flint(Polynomial): x=None, check=True, is_gen=False, construct=False) sig_str("FLINT exception") - fmpq_poly_get_numerator(primitive.__poly, self.__poly) - fmpz_poly_primitive_part(primitive.__poly, primitive.__poly) + fmpq_poly_get_numerator(primitive._poly, self._poly) + fmpz_poly_primitive_part(primitive._poly, primitive._poly) sig_off() return primitive.is_irreducible() @@ -1669,14 +1669,14 @@ cdef class Polynomial_rational_flint(Polynomial): ... ValueError: constant term should be 1 in order to take logarithm """ - if fmpq_poly_degree(self.__poly) == -1 or \ - fmpz_cmp(fmpq_poly_numref(self.__poly), - fmpq_poly_denref(self.__poly)): + if fmpq_poly_degree(self._poly) == -1 or \ + fmpz_cmp(fmpq_poly_numref(self._poly), + fmpq_poly_denref(self._poly)): raise ValueError("constant term should be 1 in order to take logarithm") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_log_series(res.__poly, self.__poly, prec) + fmpq_poly_log_series(res._poly, self._poly, prec) sig_off() return res @@ -1703,14 +1703,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.one() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take exponential") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_exp_series(res.__poly, self.__poly, prec) + fmpq_poly_exp_series(res._poly, self._poly, prec) sig_off() return res @@ -1737,14 +1737,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take arctangent") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_atan_series(res.__poly, self.__poly, prec) + fmpq_poly_atan_series(res._poly, self._poly, prec) sig_off() return res @@ -1768,14 +1768,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take hyperbolic arctangent") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_atanh_series(res.__poly, self.__poly, prec) + fmpq_poly_atanh_series(res._poly, self._poly, prec) sig_off() return res @@ -1802,14 +1802,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take arcsine") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_asin_series(res.__poly, self.__poly, prec) + fmpq_poly_asin_series(res._poly, self._poly, prec) sig_off() return res @@ -1837,14 +1837,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take hyperbolic arcsine") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_asinh_series(res.__poly, self.__poly, prec) + fmpq_poly_asinh_series(res._poly, self._poly, prec) sig_off() return res @@ -1871,14 +1871,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take tangent") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_tan_series(res.__poly, self.__poly, prec) + fmpq_poly_tan_series(res._poly, self._poly, prec) sig_off() return res @@ -1905,14 +1905,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take sine") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_sin_series(res.__poly, self.__poly, prec) + fmpq_poly_sin_series(res._poly, self._poly, prec) sig_off() return res @@ -1937,14 +1937,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take cosine") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_cos_series(res.__poly, self.__poly, prec) + fmpq_poly_cos_series(res._poly, self._poly, prec) sig_off() return res @@ -1969,14 +1969,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take hyperbolic sine") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_sinh_series(res.__poly, self.__poly, prec) + fmpq_poly_sinh_series(res._poly, self._poly, prec) sig_off() return res @@ -2007,14 +2007,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.one() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take hyperbolic cosine") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_cosh_series(res.__poly, self.__poly, prec) + fmpq_poly_cosh_series(res._poly, self._poly, prec) sig_off() return res @@ -2040,14 +2040,14 @@ cdef class Polynomial_rational_flint(Polynomial): sage: _.parent() Univariate Polynomial Ring in x over Rational Field """ - if fmpq_poly_degree(self.__poly) == -1: + if fmpq_poly_degree(self._poly) == -1: return self._parent.zero() - elif not fmpz_is_zero(fmpq_poly_numref(self.__poly)): + elif not fmpz_is_zero(fmpq_poly_numref(self._poly)): raise ValueError("constant term should be 0 in order to take hyperbolic tangent") cdef Polynomial_rational_flint res = self._new() sig_on() - fmpq_poly_tanh_series(res.__poly, self.__poly, prec) + fmpq_poly_tanh_series(res._poly, self._poly, prec) sig_off() return res diff --git a/src/sage/rings/polynomial/polynomial_zmod_flint.pyx b/src/sage/rings/polynomial/polynomial_zmod_flint.pyx index 253ab949fcc..4c480673861 100644 --- a/src/sage/rings/polynomial/polynomial_zmod_flint.pyx +++ b/src/sage/rings/polynomial/polynomial_zmod_flint.pyx @@ -110,7 +110,7 @@ cdef class Polynomial_zmod_flint(Polynomial_template): return elif isinstance(x, Polynomial_integer_dense_flint): Polynomial_template.__init__(self, parent, 0, check, is_gen, construct) - self._set_fmpz_poly((x).__poly) + self._set_fmpz_poly((x)._poly) return else: if isinstance(x, ntl_zz_pX): diff --git a/src/sage/rings/power_series_mpoly.pxd b/src/sage/rings/power_series_mpoly.pxd index f822ecc1227..d358ada1356 100644 --- a/src/sage/rings/power_series_mpoly.pxd +++ b/src/sage/rings/power_series_mpoly.pxd @@ -3,6 +3,6 @@ from .power_series_ring_element cimport PowerSeries cdef class PowerSeries_mpoly(PowerSeries): cdef ModuleElement __f - cdef object __poly + cdef object _poly cdef object __list cdef bint _truncated diff --git a/src/sage/rings/power_series_mpoly.pyx b/src/sage/rings/power_series_mpoly.pyx index b8a68c33a25..be59294e75b 100644 --- a/src/sage/rings/power_series_mpoly.pyx +++ b/src/sage/rings/power_series_mpoly.pyx @@ -92,10 +92,10 @@ cdef class PowerSeries_mpoly(PowerSeries): return self.__list def polynomial(self): - if self.__poly is None: + if self._poly is None: S = self.parent()._mpoly_ring() - self.__poly = self.__f.polynomial(S.gens()[-1]) - return self.__poly + self._poly = self.__f.polynomial(S.gens()[-1]) + return self._poly def _mpoly(self): return self.__f From 66def0dd46a793a420f1c53c7f8fa51ed84f01d8 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:46:55 +0800 Subject: [PATCH 34/54] fix private methods used in doctests --- src/sage/libs/lcalc/lcalc_Lfunction.pyx | 4 ++-- src/sage/rings/real_mpfr.pyx | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sage/libs/lcalc/lcalc_Lfunction.pyx b/src/sage/libs/lcalc/lcalc_Lfunction.pyx index d8b7221fe55..7b871ed049f 100644 --- a/src/sage/libs/lcalc/lcalc_Lfunction.pyx +++ b/src/sage/libs/lcalc/lcalc_Lfunction.pyx @@ -251,7 +251,7 @@ cdef class Lfunction: """ return self._compute_rank() - def __N(self, T): + def _N(self, T): """ Compute the number of zeroes upto height `T` using the formula for `N(T)` with the error of `S(T)`. Please do not use this. It is only @@ -262,7 +262,7 @@ cdef class Lfunction: sage: from sage.libs.lcalc.lcalc_Lfunction import * sage: chi = DirichletGroup(5)[2] #This is a quadratic character sage: L=Lfunction_from_character(chi, type="complex") - sage: L.__N(10) # abs tol 1e-8 + sage: L._N(10) # abs tol 1e-8 4.0 """ cdef RealNumber real_T=RRR(T) diff --git a/src/sage/rings/real_mpfr.pyx b/src/sage/rings/real_mpfr.pyx index 11e21af5e98..7440fadd265 100644 --- a/src/sage/rings/real_mpfr.pyx +++ b/src/sage/rings/real_mpfr.pyx @@ -4300,7 +4300,7 @@ cdef class RealNumber(sage.structure.element.RingElement): if (self._parent)._prec > 10*SIG_PREC_THRESHOLD: sig_off() return x - def __pow(self, RealNumber exponent): + def _pow(self, RealNumber exponent): """ Compute ``self`` raised to the power of exponent, rounded in the direction specified by the parent of ``self``. @@ -4309,7 +4309,7 @@ cdef class RealNumber(sage.structure.element.RingElement): sage: R = RealField(30) sage: a = R('1.23456') - sage: a.__pow(20.0) + sage: a._pow(20.0) 67.646297 """ cdef RealNumber x From 297a1ecf644acec8d19d9653bfb9a20709e247f3 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 18:34:25 +0800 Subject: [PATCH 35/54] fix string representations of ClusterComplex and SubwordComplex --- src/sage/combinat/cluster_complex.py | 6 +++--- src/sage/combinat/subword_complex.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/sage/combinat/cluster_complex.py b/src/sage/combinat/cluster_complex.py index fccf3877480..7f0f4da66f7 100644 --- a/src/sage/combinat/cluster_complex.py +++ b/src/sage/combinat/cluster_complex.py @@ -223,9 +223,9 @@ def __init__(self, W, k, coxeter_element, algorithm): self._w0 = w self._k = k if k == 1: - self._custom_name = 'Cluster complex' + self._name = 'Cluster complex' else: - self._custom_name = 'Multi-cluster complex' + self._name = 'Multi-cluster complex' self.set_immutable() @@ -271,7 +271,7 @@ def _repr_(self): sage: ClusterComplex(['A', 2])._repr_() "Cluster complex of type ['A', 2] with 5 vertices and 5 facets" """ - name = self._custom_name + name = self._name name += (' of type %s with %s vertices and %s facets' % (self.cartan_type(), len(self.vertices()), len(self._facets))) diff --git a/src/sage/combinat/subword_complex.py b/src/sage/combinat/subword_complex.py index c4cf1dac47c..a2480451d23 100644 --- a/src/sage/combinat/subword_complex.py +++ b/src/sage/combinat/subword_complex.py @@ -1131,7 +1131,7 @@ def __init__(self, Q, w, algorithm="inductive"): SimplicialComplex.__init__(self, maximal_faces=Fs, maximality_check=False, category=cat) - self._custom_name = 'Subword complex' + self._name = 'Subword complex' self._W = W try: T = W.coxeter_matrix().coxeter_type() From 01075fc75ef9e635b0e96f62e27a2e0f8849fde4 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Thu, 17 Aug 2023 18:37:11 +0800 Subject: [PATCH 36/54] fix docs about renamed attributes --- src/doc/en/thematic_tutorials/coercion_and_categories.rst | 2 +- src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/doc/en/thematic_tutorials/coercion_and_categories.rst b/src/doc/en/thematic_tutorials/coercion_and_categories.rst index 4efe68a2617..de2349a9a3f 100644 --- a/src/doc/en/thematic_tutorials/coercion_and_categories.rst +++ b/src/doc/en/thematic_tutorials/coercion_and_categories.rst @@ -106,7 +106,6 @@ This base class provides a lot more methods than a general parent:: sage: [p for p in dir(Field) if p not in dir(Parent)] ['__fraction_field', - '__ideal_monoid', '__iter__', '__len__', '__rxor__', @@ -119,6 +118,7 @@ This base class provides a lot more methods than a general parent:: '_default_category', '_gens', '_ideal_class_', + '_ideal_monoid', '_latex_names', '_list', '_one_element', diff --git a/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst b/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst index 51aec989810..562eeac6fe9 100644 --- a/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst +++ b/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst @@ -298,7 +298,7 @@ http://docs.python.org/library/ for a complete list. :: sage: el bla sage: el.__dict__ - {'__custom_name': 'bla', 'value': 42} + {'_custom_name': 'bla', 'value': 42} Lots of Sage objects are not Python objects but compiled Cython objects. Python sees them as builtin objects and you do not have From 5e7e1ba60dac4854977a08b438334a8d278663d8 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:50:32 +0800 Subject: [PATCH 37/54] avoid naming cython attributes __module__ --- src/sage/misc/cachefunc.pxd | 4 ++-- src/sage/misc/cachefunc.pyx | 16 ++++++++++++---- 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/src/sage/misc/cachefunc.pxd b/src/sage/misc/cachefunc.pxd index d3cc677dece..8e5d9dfa42a 100644 --- a/src/sage/misc/cachefunc.pxd +++ b/src/sage/misc/cachefunc.pxd @@ -5,7 +5,7 @@ cpdef cache_key(o) cdef class CachedFunction(): cdef public str __name__ - cdef public str __module__ + cdef public str __cached_module__ cdef ArgumentFixer _argument_fixer cdef public f cdef public cache # not always of type @@ -20,7 +20,7 @@ cdef class CachedFunction(): cdef class CachedMethod(): cdef str _cache_name cdef public str __name__ - cdef public str __module__ + cdef public str __cached_module__ cdef CachedFunction _cachedfunc cdef Py_ssize_t nargs cpdef _get_instance_cache(self, inst) diff --git a/src/sage/misc/cachefunc.pyx b/src/sage/misc/cachefunc.pyx index 4c3bea61c63..0c725c1dd7d 100644 --- a/src/sage/misc/cachefunc.pyx +++ b/src/sage/misc/cachefunc.pyx @@ -774,13 +774,17 @@ cdef class CachedFunction(): else: self.__name__ = f.__name__ try: - self.__module__ = f.__module__ + self.__cached_module__ = f.__module__ except AttributeError: - self.__module__ = f.__objclass__.__module__ + self.__cached_module__ = f.__objclass__.__module__ if argument_fixer is not None: # it is None unless the argument fixer # was known previously. See #15038. self._argument_fixer = argument_fixer + @property + def __module__(self): + return self.__cached_module__ + cdef get_key_args_kwds(self, tuple args, dict kwds): """ Return the key in the cache to be used when ``args`` and @@ -841,7 +845,7 @@ cdef class CachedFunction(): sage: loads(dumps(hilbert_class_polynomial)) is hilbert_class_polynomial #indirect doctest # needs sage.schemes True """ - return _cached_function_unpickle, (self.__module__, self.__name__, self.cache) + return _cached_function_unpickle, (self.__cached_module__, self.__name__, self.cache) ######### ## Introspection @@ -2698,7 +2702,11 @@ cdef class CachedMethod(): self._cache_name = '_cache__' + (name or f.__name__) self._cachedfunc = CachedFunction(f, classmethod=True, name=name, key=key, do_pickle=do_pickle) self.__name__ = self._cachedfunc.__name__ - self.__module__ = self._cachedfunc.__module__ + self.__cached_module__ = self._cachedfunc.__module__ + + @property + def __module__(self): + return self.__cached_module__ def __call__(self, inst, *args, **kwds): """ From eaae799d164a92add8be60f22da8f507e45cfefe Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:51:30 +0800 Subject: [PATCH 38/54] force __getmetaclass__ to be a METH_NOARGS method --- src/sage/structure/element.pyx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sage/structure/element.pyx b/src/sage/structure/element.pyx index 71613de7215..36da1c0cc12 100644 --- a/src/sage/structure/element.pyx +++ b/src/sage/structure/element.pyx @@ -379,6 +379,7 @@ cdef class Element(SageObject): .. automethod:: __mod__ """ @cython.binding(False) + @cython.always_allow_keywords(False) def __getmetaclass__(_): from sage.misc.inherit_comparison import InheritComparisonMetaclass return InheritComparisonMetaclass From 96608273ce7bf38a17e816776df8ba355e38044f Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:52:33 +0800 Subject: [PATCH 39/54] fix structmember.h defines in cython 3 --- src/sage/libs/gap/gap_includes.pxd | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/sage/libs/gap/gap_includes.pxd b/src/sage/libs/gap/gap_includes.pxd index 840b8a0042e..1ed4378a6c7 100644 --- a/src/sage/libs/gap/gap_includes.pxd +++ b/src/sage/libs/gap/gap_includes.pxd @@ -144,3 +144,18 @@ cdef extern from "gap/stringobj.h" nogil: bint IS_STRING(Obj obj) bint IsStringConv(Obj obj) Obj NEW_STRING(Int) + + +cdef extern from "" nogil: + """ + /* Hack: Cython 3.0 automatically includes , which + * defines several macros that collides with enum definitions in + * gap/objects.h. We need to include the header explicitly and + * undefine these macros. + */ + #undef T_INT + #undef T_STRING + #undef T_CHAR + #undef T_BOOL + """ + pass From 6820d2aa4995f705569eb6640e3b3469df6e85ee Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 7 Aug 2023 23:53:14 +0800 Subject: [PATCH 40/54] avoid StopIteration in generators --- src/sage/numerical/linear_functions.pyx | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/sage/numerical/linear_functions.pyx b/src/sage/numerical/linear_functions.pyx index 5549ff436f5..f3fc6fe419c 100644 --- a/src/sage/numerical/linear_functions.pyx +++ b/src/sage/numerical/linear_functions.pyx @@ -1579,7 +1579,10 @@ cdef class LinearConstraint(LinearFunctionOrConstraint): while True: yield (lhs, rhs) lhs = rhs - rhs = next(term_iter) + try: + rhs = next(term_iter) + except StopIteration: + return def inequalities(self): """ @@ -1612,7 +1615,10 @@ cdef class LinearConstraint(LinearFunctionOrConstraint): while True: yield (lhs, rhs) lhs = rhs - rhs = next(term_iter) + try: + rhs = next(term_iter) + except StopIteration: + return def _repr_(self): r""" From 33eb23e65767feecebcc3d5a5a5a0e08e7bc6e4f Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Tue, 8 Aug 2023 13:00:55 +0800 Subject: [PATCH 41/54] remove coxeter CoxGraph which fails to compile with cython 3 --- src/sage/libs/coxeter3/coxeter.pxd | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/sage/libs/coxeter3/coxeter.pxd b/src/sage/libs/coxeter3/coxeter.pxd index 9d5cb2a3f5d..dbd2b8a61c6 100644 --- a/src/sage/libs/coxeter3/coxeter.pxd +++ b/src/sage/libs/coxeter3/coxeter.pxd @@ -29,6 +29,3 @@ cdef class CoxGroupElement: cdef CoxGroup _parent_group cdef CoxGroupElement _new(self) cpdef CoxGroup parent_group(self) - -cdef class CoxGraph: - cdef c_CoxGraph x From bfd17cc6f84bdeee9691e60bcd0624c21db39c5c Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 02:29:22 +0800 Subject: [PATCH 42/54] handle StopIteration in lazy_list_from_function --- src/sage/misc/lazy_list.pyx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/sage/misc/lazy_list.pyx b/src/sage/misc/lazy_list.pyx index c1fa0250a95..ba62c446b69 100644 --- a/src/sage/misc/lazy_list.pyx +++ b/src/sage/misc/lazy_list.pyx @@ -1059,7 +1059,11 @@ cdef class lazy_list_from_function(lazy_list_generic): step 1 """ while len(self.cache) <= i: - self.cache.append(self.callable(len(self.cache))) + try: + value = self.callable(len(self.cache)) + except StopIteration: + return 1 + self.cache.append(value) def __reduce__(self): r""" From 878c1f719913be9044979e5c0795924176a0426b Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 02:29:53 +0800 Subject: [PATCH 43/54] adapt for Cython 3 module names in inspection --- src/sage/misc/sageinspect.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/sage/misc/sageinspect.py b/src/sage/misc/sageinspect.py index 3dd0cc0a45b..ce5e9987027 100644 --- a/src/sage/misc/sageinspect.py +++ b/src/sage/misc/sageinspect.py @@ -224,7 +224,11 @@ def isclassinstance(obj): return (not inspect.isclass(obj) and hasattr(obj, '__class__') and hasattr(obj.__class__, '__module__') and - obj.__class__.__module__ not in builtin_mods) + obj.__class__.__module__ not in builtin_mods and + # Starting with Cython 3, Cython's builtin types have __module__ set + # to the shared module names like _cython_3_0_0. + not (isinstance(obj.__class__.__module__, str) and + obj.__class__.__module__.startswith('_cython_'))) # Parse strings of form "File: sage/rings/rational.pyx (starting at line 1080)" From 1f90bcefd80187ed7b3bf9f953a631e715c539a1 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 02:31:04 +0800 Subject: [PATCH 44/54] remove __rtruediv__ definitions which fail to compile with Cython 3 They fail to compile with Cython 3 and c_api_binop_methods=True, and are never treated as special arithmetic methods by old Cython anyway, so they can be safely removed. --- src/sage/rings/complex_mpc.pyx | 20 -------------------- src/sage/rings/complex_mpfr.pyx | 22 ---------------------- 2 files changed, 42 deletions(-) diff --git a/src/sage/rings/complex_mpc.pyx b/src/sage/rings/complex_mpc.pyx index bdd5c4e4fe6..c847a9302b5 100644 --- a/src/sage/rings/complex_mpc.pyx +++ b/src/sage/rings/complex_mpc.pyx @@ -1571,26 +1571,6 @@ cdef class MPComplexNumber(sage.structure.element.FieldElement): mpc_norm(x.value, self.value, (x._parent).rnd) return x - def __rtruediv__(self, left): - r""" - Returns the quotient of ``left`` with ``self``, that is: ``left/self`` - as a complex number. - - INPUT: - - - ``left`` -- a complex number - - EXAMPLES:: - - sage: MPC = MPComplexField() - sage: a = MPC(2, 2) - sage: a.__rtruediv__(MPC(1)) - 0.250000000000000 - 0.250000000000000*I - sage: MPC(1)/a - 0.250000000000000 - 0.250000000000000*I - """ - return MPComplexNumber(self._parent, left)/self - def __pow__(self, right, modulus): """ Compute ``self`` raised to the power of exponent, rounded in diff --git a/src/sage/rings/complex_mpfr.pyx b/src/sage/rings/complex_mpfr.pyx index 33d73d81b12..61f2cadc8e4 100644 --- a/src/sage/rings/complex_mpfr.pyx +++ b/src/sage/rings/complex_mpfr.pyx @@ -1658,28 +1658,6 @@ cdef class ComplexNumber(sage.structure.element.FieldElement): mpfr_clear(right_nm) return x - def __rtruediv__(self, left): - r""" - Return the quotient of left with ``self``, that is: - - ``left/self`` - - as a complex number. - - INPUT: - - - ``left`` -- a complex number to divide by ``self`` - - EXAMPLES:: - - sage: a = ComplexNumber(2,0) - sage: a.__rtruediv__(CC(1)) - 0.500000000000000 - sage: CC(1)/a - 0.500000000000000 - """ - return ComplexNumber(self._parent, left)/self - def __pow__(self, right, modulus): r""" Raise ``self`` to the ``right`` exponent. From f8e84bef8fc7fd36f5a415bc491934c543053330 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 02:39:13 +0800 Subject: [PATCH 45/54] ensure correct caching for no-args methods not having METH_NOARGS --- src/sage/misc/cachefunc.pyx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/sage/misc/cachefunc.pyx b/src/sage/misc/cachefunc.pyx index 0c725c1dd7d..8aa30a85272 100644 --- a/src/sage/misc/cachefunc.pyx +++ b/src/sage/misc/cachefunc.pyx @@ -2848,8 +2848,6 @@ cdef class CachedMethod(): try: if METH_NOARGS&PyCFunction_GetFlags(f.__get__(inst,cls)): self.nargs = 1 - else: - self.nargs = 2 except Exception: pass if self.nargs == 0: From 23791f1f2f2e76e8272b0614c68bdfb9d5d0e0c2 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 04:19:46 +0800 Subject: [PATCH 46/54] update docs about __getmetaclass__ --- src/sage/cpython/cython_metaclass.pyx | 9 ++++++++- src/sage/misc/inherit_comparison.pyx | 3 +++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/sage/cpython/cython_metaclass.pyx b/src/sage/cpython/cython_metaclass.pyx index a8fe853661d..a8fa92fc1a8 100644 --- a/src/sage/cpython/cython_metaclass.pyx +++ b/src/sage/cpython/cython_metaclass.pyx @@ -19,13 +19,16 @@ file if you are using one). In the extension type (a.k.a. ``cdef class``) for which you want to define a metaclass, define a method ``__getmetaclass__`` with a single -unused argument. This method should return a type to be used as +unused argument, and turn off the Cython directive +``always_allow_keywords``. This method should return a type to be used as metaclass: .. code-block:: cython + cimport cython cimport sage.cpython.cython_metaclass cdef class MyCustomType(): + @cython.always_allow_keywords(False) def __getmetaclass__(_): from foo import MyMetaclass return MyMetaclass @@ -63,8 +66,10 @@ EXAMPLES:: sage: cython( # needs sage.misc.cython ....: ''' + ....: cimport cython ....: cimport sage.cpython.cython_metaclass ....: cdef class MyCustomType(): + ....: @cython.always_allow_keywords(False) ....: def __getmetaclass__(_): ....: class MyMetaclass(type): ....: def __init__(*args): @@ -101,8 +106,10 @@ returns a non-type:: sage: cython( # needs sage.misc.cython ....: ''' + ....: cimport cython ....: cimport sage.cpython.cython_metaclass ....: cdef class MyCustomType(): + ....: @cython.always_allow_keywords(False) ....: def __getmetaclass__(_): ....: return 2 ....: ''') diff --git a/src/sage/misc/inherit_comparison.pyx b/src/sage/misc/inherit_comparison.pyx index f046f5fb8ce..aa97f664496 100644 --- a/src/sage/misc/inherit_comparison.pyx +++ b/src/sage/misc/inherit_comparison.pyx @@ -54,6 +54,8 @@ cdef class InheritComparisonMetaclass(type): sage: # needs sage.misc.cython sage: cython( ....: ''' + ....: cimport cython + ....: ....: from sage.misc.inherit_comparison cimport InheritComparisonMetaclass ....: ....: cdef class Base(): @@ -66,6 +68,7 @@ cdef class InheritComparisonMetaclass(type): ....: return 1 ....: ....: cdef class DerivedWithRichcmp(Base): + ....: @cython.always_allow_keywords(False) ....: def __getmetaclass__(_): ....: from sage.misc.inherit_comparison import InheritComparisonMetaclass ....: return InheritComparisonMetaclass From 0c4d1de032169a3b69cd249ee62e51aa1a91ca8c Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 04:20:36 +0800 Subject: [PATCH 47/54] fix detection of functions for session saving --- src/sage/misc/session.pyx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/sage/misc/session.pyx b/src/sage/misc/session.pyx index de649f80425..31454dac993 100644 --- a/src/sage/misc/session.pyx +++ b/src/sage/misc/session.pyx @@ -80,6 +80,8 @@ from sage.misc.persist import load, save, loads, dumps state_at_init = None +CythonFunctionType = type(lambda: None) + def init(state=None): """ Initialize some dictionaries needed by the :func:`show_identifiers`, @@ -311,7 +313,7 @@ def save_session(name='sage_session', verbose=False): for k in show_identifiers(hidden = True): try: x = state[k] - if isinstance(x, (types.FunctionType, types.BuiltinFunctionType, types.BuiltinMethodType, type)): + if isinstance(x, (types.FunctionType, types.BuiltinFunctionType, types.BuiltinMethodType, CythonFunctionType, type)): raise TypeError('{} is a function, method, class or type'.format(k)) # We attempt to pickle *and* unpickle every variable to From 0e2164eb423bbc4408bd67290ecb14f3f8a9630f Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 18:08:50 +0800 Subject: [PATCH 48/54] fix pickling of class methods --- src/sage/misc/fpickle.pyx | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/sage/misc/fpickle.pyx b/src/sage/misc/fpickle.pyx index 9f80a8f31aa..ff851e25167 100644 --- a/src/sage/misc/fpickle.pyx +++ b/src/sage/misc/fpickle.pyx @@ -124,9 +124,13 @@ def call_pickled_function(fpargs): def pickleMethod(method): 'support function for copyreg to pickle method refs' - # Note: On Python 3 there is no .im_class but we can get the instance's - # class through .__self__.__class__ - cls = getattr(method, 'im_class', method.__self__.__class__) + if isinstance(method.__self__, type): + # This is a class method, so get it from the type directly + return (getattr, (method.__self__, method.__func__.__name__)) + else: + # Note: On Python 3 there is no .im_class but we can get the instance's + # class through .__self__.__class__ + cls = getattr(method, 'im_class', method.__self__.__class__) return (unpickleMethod, (method.__func__.__name__, method.__self__, cls)) From 464180120ef1650f834a6fc1a143c9b4724bbfb0 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Sun, 20 Aug 2023 21:26:54 +0800 Subject: [PATCH 49/54] fix cython metaclass Sage_PyType_Ready --- src/sage/cpython/cython_metaclass.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/sage/cpython/cython_metaclass.h b/src/sage/cpython/cython_metaclass.h index da06ab75a6b..6d7dee6257d 100644 --- a/src/sage/cpython/cython_metaclass.h +++ b/src/sage/cpython/cython_metaclass.h @@ -52,6 +52,15 @@ static CYTHON_INLINE int Sage_PyType_Ready(PyTypeObject* t) if (r < 0) return r; +#if PY_VERSION_HEX >= 0x03050000 + // Cython 3 sets Py_TPFLAGS_HEAPSIZE before calling PyType_Ready, + // and resets just after the call. We need to do the same, or it may + // end up with illegal memory accesses. + // See also: + // https://github.com/cython/cython/issues/3603 + t->tp_flags &= ~Py_TPFLAGS_HEAPTYPE; +#endif + /* Set or get metaclass (the type of t) */ PyTypeObject* metaclass; From 1c4a223b057520fd9be16da81d8f9f048c372017 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Wed, 23 Aug 2023 16:19:49 +0800 Subject: [PATCH 50/54] remove python 2 compat code in pickleMethod and unpickleMethod --- src/sage/misc/fpickle.pyx | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/sage/misc/fpickle.pyx b/src/sage/misc/fpickle.pyx index ff851e25167..37c26e431ba 100644 --- a/src/sage/misc/fpickle.pyx +++ b/src/sage/misc/fpickle.pyx @@ -128,10 +128,8 @@ def pickleMethod(method): # This is a class method, so get it from the type directly return (getattr, (method.__self__, method.__func__.__name__)) else: - # Note: On Python 3 there is no .im_class but we can get the instance's - # class through .__self__.__class__ - cls = getattr(method, 'im_class', method.__self__.__class__) - return (unpickleMethod, (method.__func__.__name__, method.__self__, cls)) + cls = method.__self__.__class__ + return (unpickleMethod, (method.__func__.__name__, method.__self__, cls)) def unpickleMethod(im_name, @@ -143,10 +141,7 @@ def unpickleMethod(im_name, if __self__ is None: return unbound - # Note: On Python 2 "unbound methods" are just functions, so they don't - # have a __func__ - bound = types.MethodType(getattr(unbound, '__func__', unbound), - __self__) + bound = types.MethodType(unbound, __self__) return bound except AttributeError: assert __self__ is not None, "No recourse: no instance to guess from." @@ -154,11 +149,8 @@ def unpickleMethod(im_name, # changed around since we pickled this method, we may still be # able to get it by looking on the instance's current class. unbound = getattr(__self__.__class__, im_name) - if __self__ is None: - return unbound - bound = types.MethodType(getattr(unbound, '__func__', unbound), - __self__) + bound = types.MethodType(unbound, __self__) return bound From 08ddad90fe4c0e03e6188e619f17b15a1c2ce422 Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Fri, 25 Aug 2023 21:54:24 +0800 Subject: [PATCH 51/54] rephrase comments in cython_metaclass.h --- src/sage/cpython/cython_metaclass.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/sage/cpython/cython_metaclass.h b/src/sage/cpython/cython_metaclass.h index 6d7dee6257d..ecf7f973c3e 100644 --- a/src/sage/cpython/cython_metaclass.h +++ b/src/sage/cpython/cython_metaclass.h @@ -53,9 +53,10 @@ static CYTHON_INLINE int Sage_PyType_Ready(PyTypeObject* t) return r; #if PY_VERSION_HEX >= 0x03050000 - // Cython 3 sets Py_TPFLAGS_HEAPSIZE before calling PyType_Ready, - // and resets just after the call. We need to do the same, or it may - // end up with illegal memory accesses. + // Cython 3 sets Py_TPFLAGS_HEAPTYPE before calling PyType_Ready, + // and resets just after the call. We need to reset it earlier, + // since otherwise the call to metaclass.__init__ below may have + // illegal memory accesses. // See also: // https://github.com/cython/cython/issues/3603 t->tp_flags &= ~Py_TPFLAGS_HEAPTYPE; From d81901724038fec25522661683ba647f9fe8e25e Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Fri, 25 Aug 2023 22:34:10 +0800 Subject: [PATCH 52/54] small changes to custom names --- .../algebras/letterplace/free_algebra_letterplace.pxd | 1 - src/sage/categories/hopf_algebras_with_basis.py | 2 +- src/sage/categories/modules_with_basis.py | 4 ++-- src/sage/combinat/cluster_complex.py | 9 ++++----- src/sage/combinat/subword_complex.py | 1 - 5 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/sage/algebras/letterplace/free_algebra_letterplace.pxd b/src/sage/algebras/letterplace/free_algebra_letterplace.pxd index 9bce00e2755..47a7275aba0 100644 --- a/src/sage/algebras/letterplace/free_algebra_letterplace.pxd +++ b/src/sage/algebras/letterplace/free_algebra_letterplace.pxd @@ -29,7 +29,6 @@ cdef class FreeAlgebra_letterplace(Algebra): cdef int _ngens cdef int _nb_slackvars cdef object __monoid - cdef public object _custom_name cdef str exponents_to_string(self, E) cdef str exponents_to_latex(self, E) cdef tuple _degrees diff --git a/src/sage/categories/hopf_algebras_with_basis.py b/src/sage/categories/hopf_algebras_with_basis.py index d2c22fb4331..615fc4eae06 100644 --- a/src/sage/categories/hopf_algebras_with_basis.py +++ b/src/sage/categories/hopf_algebras_with_basis.py @@ -36,7 +36,7 @@ class HopfAlgebrasWithBasis(CategoryWithAxiom_over_base_ring): sage: A = C.example(); A # needs sage.groups An example of Hopf algebra with basis: the group algebra of the Dihedral group of order 6 as a permutation group over Rational Field - sage: A._custom_name = "A" # needs sage.groups + sage: A.rename("A") # needs sage.groups sage: A.category() # needs sage.groups Category of finite dimensional hopf algebras with basis over Rational Field diff --git a/src/sage/categories/modules_with_basis.py b/src/sage/categories/modules_with_basis.py index 7a307987651..fc1857f0c8e 100644 --- a/src/sage/categories/modules_with_basis.py +++ b/src/sage/categories/modules_with_basis.py @@ -66,8 +66,8 @@ class ModulesWithBasis(CategoryWithAxiom_over_base_ring): Let `X` and `Y` be two modules with basis. We can build `Hom(X,Y)`:: - sage: X = CombinatorialFreeModule(QQ, [1,2]); X._custom_name = "X" # needs sage.modules - sage: Y = CombinatorialFreeModule(QQ, [3,4]); Y._custom_name = "Y" # needs sage.modules + sage: X = CombinatorialFreeModule(QQ, [1,2]); X.rename("X") # needs sage.modules + sage: Y = CombinatorialFreeModule(QQ, [3,4]); Y.rename("Y") # needs sage.modules sage: H = Hom(X, Y); H # needs sage.modules Set of Morphisms from X to Y in Category of finite dimensional vector spaces with basis over Rational Field diff --git a/src/sage/combinat/cluster_complex.py b/src/sage/combinat/cluster_complex.py index 7f0f4da66f7..3c85d8db7a4 100644 --- a/src/sage/combinat/cluster_complex.py +++ b/src/sage/combinat/cluster_complex.py @@ -222,10 +222,6 @@ def __init__(self, W, k, coxeter_element, algorithm): self._W = W self._w0 = w self._k = k - if k == 1: - self._name = 'Cluster complex' - else: - self._name = 'Multi-cluster complex' self.set_immutable() @@ -271,7 +267,10 @@ def _repr_(self): sage: ClusterComplex(['A', 2])._repr_() "Cluster complex of type ['A', 2] with 5 vertices and 5 facets" """ - name = self._name + if k == 1: + name = 'Cluster complex' + else: + name = 'Multi-cluster complex' name += (' of type %s with %s vertices and %s facets' % (self.cartan_type(), len(self.vertices()), len(self._facets))) diff --git a/src/sage/combinat/subword_complex.py b/src/sage/combinat/subword_complex.py index a2480451d23..de7eefe946e 100644 --- a/src/sage/combinat/subword_complex.py +++ b/src/sage/combinat/subword_complex.py @@ -1131,7 +1131,6 @@ def __init__(self, Q, w, algorithm="inductive"): SimplicialComplex.__init__(self, maximal_faces=Fs, maximality_check=False, category=cat) - self._name = 'Subword complex' self._W = W try: T = W.coxeter_matrix().coxeter_type() From fd383651e34f99f3ab8bf837040e056c9bd5ed2a Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Fri, 25 Aug 2023 23:33:08 +0800 Subject: [PATCH 53/54] make custom name attribute private to SageObject --- .../tutorial-objects-and-classes.rst | 2 +- .../groups/perm_gps/permgroup_element.pxd | 2 +- src/sage/interfaces/interface.py | 7 +--- src/sage/interfaces/singular.py | 4 +- src/sage/libs/gap/element.pyx | 2 +- src/sage/matroids/basis_matroid.pyx | 6 +-- .../matroids/circuit_closures_matroid.pyx | 8 ++-- src/sage/matroids/dual_matroid.py | 11 ++---- src/sage/matroids/graphic_matroid.py | 8 ++-- src/sage/matroids/linear_matroid.pyx | 30 +++++++------- src/sage/matroids/matroid.pxd | 2 +- src/sage/matroids/minor_matroid.py | 8 ++-- src/sage/matroids/rank_matroid.py | 7 +--- src/sage/quivers/representation.py | 5 +-- .../drinfeld_modules/drinfeld_module.py | 4 +- src/sage/sets/set_from_iterator.py | 12 +++--- src/sage/structure/sage_object.pyx | 39 +++++++++++++++---- src/sage/topology/simplicial_set.py | 25 ++++++------ .../topology/simplicial_set_constructions.py | 3 +- 19 files changed, 94 insertions(+), 91 deletions(-) diff --git a/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst b/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst index 562eeac6fe9..553a946c4d8 100644 --- a/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst +++ b/src/doc/en/thematic_tutorials/tutorial-objects-and-classes.rst @@ -298,7 +298,7 @@ http://docs.python.org/library/ for a complete list. :: sage: el bla sage: el.__dict__ - {'_custom_name': 'bla', 'value': 42} + {'_SageObject__custom_name': 'bla', 'value': 42} Lots of Sage objects are not Python objects but compiled Cython objects. Python sees them as builtin objects and you do not have diff --git a/src/sage/groups/perm_gps/permgroup_element.pxd b/src/sage/groups/perm_gps/permgroup_element.pxd index b1ec2b09a19..0a584745f96 100644 --- a/src/sage/groups/perm_gps/permgroup_element.pxd +++ b/src/sage/groups/perm_gps/permgroup_element.pxd @@ -22,7 +22,7 @@ cdef class PermutationGroupElement(MultiplicativeGroupElement): cpdef PermutationGroupElement _generate_new_GAP(self, old) cpdef _gap_list(self) cpdef domain(self) - cdef public _custom_name + cdef public _SageObject__custom_name cpdef list _act_on_list_on_position(self, list x) cpdef ClonableIntArray _act_on_array_on_position(self, ClonableIntArray x) cpdef ETuple _act_on_etuple_on_position(self, ETuple x) diff --git a/src/sage/interfaces/interface.py b/src/sage/interfaces/interface.py index 9679c34ab5b..3180113c9c7 100644 --- a/src/sage/interfaces/interface.py +++ b/src/sage/interfaces/interface.py @@ -1169,11 +1169,8 @@ def __repr__(self): s = cr else: s = self._repr_() - if self._name in s: - try: - s = s.replace(self._name, getattr(self, '_custom_name')) - except AttributeError: - pass + if self._name in s and self.get_custom_name() is not None: + s = s.replace(self._name, self.get_custom_name()) if cr: self._cached_repr = s return s diff --git a/src/sage/interfaces/singular.py b/src/sage/interfaces/singular.py index 1ba45f6605d..705fa6f66e1 100644 --- a/src/sage/interfaces/singular.py +++ b/src/sage/interfaces/singular.py @@ -1400,8 +1400,8 @@ def _repr_(self): """ s = super(SingularElement, self)._repr_() if self._name in s: - if (not hasattr(self, "_custom_name")) and self.type() == 'matrix': - s = self.parent().eval('pmat(%s,20)'%(self.name())) + if self.get_custom_name() is None and self.type() == 'matrix': + s = self.parent().eval('pmat(%s,20)' % (self.name())) return s def __copy__(self): diff --git a/src/sage/libs/gap/element.pyx b/src/sage/libs/gap/element.pyx index 964cd18e646..478caf9f9d0 100644 --- a/src/sage/libs/gap/element.pyx +++ b/src/sage/libs/gap/element.pyx @@ -720,7 +720,7 @@ cdef class GapElement(RingElement): ... AttributeError: 'some_name' does not define a GAP function """ - if name in ('__dict__', '_getAttributeNames', '_custom_name', 'keys'): + if name in ('__dict__', '_getAttributeNames', '_SageObject__custom_name', 'keys'): raise AttributeError('Python special name, not a GAP function.') try: proxy = make_GapElement_MethodProxy\ diff --git a/src/sage/matroids/basis_matroid.pyx b/src/sage/matroids/basis_matroid.pyx index da66df5bd73..c1b6e9b04c8 100644 --- a/src/sage/matroids/basis_matroid.pyx +++ b/src/sage/matroids/basis_matroid.pyx @@ -1177,7 +1177,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): """ N = BasisMatroid(M=self) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo=None): @@ -1201,7 +1201,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): if memo is None: memo = {} N = BasisMatroid(M=self) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __reduce__(self): @@ -1230,7 +1230,7 @@ cdef class BasisMatroid(BasisExchangeMatroid): """ import sage.matroids.unpickling BB = bitset_pickle(self._bb) - data = (self._E, self._matroid_rank, getattr(self, '_custom_name'), BB) + data = (self._E, self._matroid_rank, self.get_custom_name(), BB) version = 0 return sage.matroids.unpickling.unpickle_basis_matroid, (version, data) diff --git a/src/sage/matroids/circuit_closures_matroid.pyx b/src/sage/matroids/circuit_closures_matroid.pyx index 72a95068504..4e79b0575e2 100644 --- a/src/sage/matroids/circuit_closures_matroid.pyx +++ b/src/sage/matroids/circuit_closures_matroid.pyx @@ -513,8 +513,7 @@ cdef class CircuitClosuresMatroid(Matroid): N._groundset = self._groundset N._circuit_closures = self._circuit_closures N._matroid_rank = self._matroid_rank - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo=None): @@ -539,8 +538,7 @@ cdef class CircuitClosuresMatroid(Matroid): from copy import deepcopy # Since matroids are immutable, N cannot reference itself in correct code, so no need to worry about the recursion. N = CircuitClosuresMatroid(groundset=deepcopy(self._groundset, memo), circuit_closures=deepcopy(self._circuit_closures, memo)) - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -570,7 +568,7 @@ cdef class CircuitClosuresMatroid(Matroid): 4: {{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'}}} """ import sage.matroids.unpickling - data = (self._groundset, self._circuit_closures, getattr(self, '_custom_name')) + data = (self._groundset, self._circuit_closures, self.get_custom_name()) version = 0 return sage.matroids.unpickling.unpickle_circuit_closures_matroid, (version, data) diff --git a/src/sage/matroids/dual_matroid.py b/src/sage/matroids/dual_matroid.py index 445a78bc43d..da6639827e4 100644 --- a/src/sage/matroids/dual_matroid.py +++ b/src/sage/matroids/dual_matroid.py @@ -519,9 +519,7 @@ def __copy__(self): """ N = DualMatroid(self._matroid) - if getattr(self, '_custom_name') is not None: - # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo={}): @@ -543,10 +541,7 @@ def __deepcopy__(self, memo={}): """ from copy import deepcopy N = DualMatroid(deepcopy(self._matroid, memo)) - if getattr(self, '_custom_name') is not None: - # because of name wrangling, this is not caught by the - # default deepcopy - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -575,6 +570,6 @@ def __reduce__(self): 4: {{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'}}}' """ import sage.matroids.unpickling - data = (self._matroid, getattr(self, '_custom_name')) + data = (self._matroid, self.get_custom_name()) version = 0 return sage.matroids.unpickling.unpickle_dual_matroid, (version, data) diff --git a/src/sage/matroids/graphic_matroid.py b/src/sage/matroids/graphic_matroid.py index 106cd68bf71..c727dc54e52 100644 --- a/src/sage/matroids/graphic_matroid.py +++ b/src/sage/matroids/graphic_matroid.py @@ -481,8 +481,7 @@ def __copy__(self): False """ N = GraphicMatroid(self._G) - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo={}): @@ -502,8 +501,7 @@ def __deepcopy__(self, memo={}): """ # The only real difference between this and __copy__() is the memo N = GraphicMatroid(deepcopy(self._G, memo)) - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -519,7 +517,7 @@ def __reduce__(self): Graphic matroid of rank 9 on 15 elements """ from .unpickling import unpickle_graphic_matroid - data = (self._G, getattr(self, '_custom_name')) + data = (self._G, self.get_custom_name()) version = 0 return unpickle_graphic_matroid, (version, data) diff --git a/src/sage/matroids/linear_matroid.pyx b/src/sage/matroids/linear_matroid.pyx index a648d281ab5..36f563aa433 100644 --- a/src/sage/matroids/linear_matroid.pyx +++ b/src/sage/matroids/linear_matroid.pyx @@ -2909,7 +2909,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): else: rows, cols = self._current_rows_cols() N = LinearMatroid(groundset=rows + cols, reduced_matrix=self._A) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo): @@ -2930,7 +2930,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): else: rows, cols = self._current_rows_cols() N = LinearMatroid(groundset=deepcopy(rows + cols, memo), reduced_matrix=deepcopy(self._A, memo)) - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -2979,7 +2979,7 @@ cdef class LinearMatroid(BasisExchangeMatroid): rows, cols = self._current_rows_cols() gs = rows + cols reduced = True - data = (A, gs, reduced, getattr(self, '_custom_name')) + data = (A, gs, reduced, self.get_custom_name()) return sage.matroids.unpickling.unpickle_linear_matroid, (version, data) # Binary matroid @@ -3964,7 +3964,7 @@ cdef class BinaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = BinaryMatroid(groundset=self._E, matrix=self._A, basis=basis) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo): @@ -3989,7 +3989,7 @@ cdef class BinaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = BinaryMatroid(groundset=deepcopy(self._E, memo), matrix=deepcopy(self._A, memo), basis=deepcopy(basis, memo)) - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -4047,7 +4047,7 @@ cdef class BinaryMatroid(LinearMatroid): A = self._A # current basis ordered so matrix cols form identity matrix: basis = self._current_rows_cols()[0] - data = (A, gs, basis, getattr(self, '_custom_name')) + data = (A, gs, basis, self.get_custom_name()) return sage.matroids.unpickling.unpickle_binary_matroid, (version, data) cdef class TernaryMatroid(LinearMatroid): @@ -4858,7 +4858,7 @@ cdef class TernaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = TernaryMatroid(groundset=self._E, matrix=self._A, basis=basis) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo): @@ -4883,7 +4883,7 @@ cdef class TernaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = TernaryMatroid(groundset=deepcopy(self._E, memo), matrix=deepcopy(self._A, memo), basis=deepcopy(basis, memo)) - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -4945,7 +4945,7 @@ cdef class TernaryMatroid(LinearMatroid): A = self._A # current basis ordered so matrix cols form identity matrix: basis = self._current_rows_cols()[0] - data = (A, gs, basis, getattr(self, '_custom_name')) + data = (A, gs, basis, self.get_custom_name()) return sage.matroids.unpickling.unpickle_ternary_matroid, (version, data) # Quaternary Matroids @@ -5589,7 +5589,7 @@ cdef class QuaternaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = QuaternaryMatroid(groundset=self._E, matrix=self._A, basis=basis) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo): @@ -5614,7 +5614,7 @@ cdef class QuaternaryMatroid(LinearMatroid): for e in self.basis(): basis[self._prow[self._idx[e]]] = e N = QuaternaryMatroid(groundset=deepcopy(self._E, memo), matrix=deepcopy(self._A, memo), basis=deepcopy(basis, memo)) - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -5672,7 +5672,7 @@ cdef class QuaternaryMatroid(LinearMatroid): A = self._A # current basis ordered so matrix cols form identity matrix: basis = self._current_rows_cols()[0] - data = (A, gs, basis, getattr(self, '_custom_name')) + data = (A, gs, basis, self.get_custom_name()) return sage.matroids.unpickling.unpickle_quaternary_matroid, (version, data) # Regular Matroids @@ -6524,7 +6524,7 @@ cdef class RegularMatroid(LinearMatroid): else: rows, cols = self._current_rows_cols() N = RegularMatroid(groundset=rows + cols, reduced_matrix=self._A) - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo): @@ -6544,7 +6544,7 @@ cdef class RegularMatroid(LinearMatroid): else: rows, cols = self._current_rows_cols() N = RegularMatroid(groundset=deepcopy(rows + cols, memo), reduced_matrix=deepcopy(self._A, memo)) - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -6593,5 +6593,5 @@ cdef class RegularMatroid(LinearMatroid): rows, cols = self._current_rows_cols() gs = rows + cols reduced = True - data = (A, gs, reduced, getattr(self, '_custom_name')) + data = (A, gs, reduced, self.get_custom_name()) return sage.matroids.unpickling.unpickle_regular_matroid, (version, data) diff --git a/src/sage/matroids/matroid.pxd b/src/sage/matroids/matroid.pxd index a0bb7be9f4c..e9ddfec96ae 100644 --- a/src/sage/matroids/matroid.pxd +++ b/src/sage/matroids/matroid.pxd @@ -1,7 +1,7 @@ from sage.structure.sage_object cimport SageObject cdef class Matroid(SageObject): - cdef public _custom_name + cdef public _SageObject__custom_name cdef public _cached_info cdef int _stored_full_rank cdef int _stored_size diff --git a/src/sage/matroids/minor_matroid.py b/src/sage/matroids/minor_matroid.py index 24dc60d11d0..98856348ac1 100644 --- a/src/sage/matroids/minor_matroid.py +++ b/src/sage/matroids/minor_matroid.py @@ -486,8 +486,7 @@ def __copy__(self): True """ N = MinorMatroid(self._matroid, self._contractions, self._deletions) - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo={}): @@ -512,8 +511,7 @@ def __deepcopy__(self, memo={}): from copy import deepcopy # Since matroids are immutable, N cannot reference itself in correct code, so no need to worry about the recursion. N = MinorMatroid(deepcopy(self._matroid, memo), deepcopy(self._contractions, memo), deepcopy(self._deletions, memo)) - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): @@ -534,6 +532,6 @@ def __reduce__(self): 4: {{'a', 'b', 'c', 'd', 'e', 'f', 'g', 'h'}}} """ import sage.matroids.unpickling - data = (self._matroid, self._contractions, self._deletions, getattr(self, '_custom_name')) + data = (self._matroid, self._contractions, self._deletions, self.get_custom_name()) version = 0 return sage.matroids.unpickling.unpickle_minor_matroid, (version, data) diff --git a/src/sage/matroids/rank_matroid.py b/src/sage/matroids/rank_matroid.py index dd443eb6390..6c4e9470ada 100644 --- a/src/sage/matroids/rank_matroid.py +++ b/src/sage/matroids/rank_matroid.py @@ -267,9 +267,7 @@ def __copy__(self): N = RankMatroid(groundset=[], rank_function=None) N._groundset = self._groundset N._rank_function = self._rank_function - if getattr(self, '_custom_name') is not None: - # because of name wrangling, this is not caught by the default copy - N.rename(getattr(self, '_custom_name')) + N.rename(self.get_custom_name()) return N def __deepcopy__(self, memo={}): @@ -293,8 +291,7 @@ def __deepcopy__(self, memo={}): from copy import deepcopy # Since matroids are immutable, N cannot reference itself in correct code, so no need to worry about the recursion. N = RankMatroid(groundset=deepcopy(self._groundset), rank_function=deepcopy(self._rank_function)) - if getattr(self, '_custom_name') is not None: # because of name wrangling, this is not caught by the default deepcopy - N.rename(deepcopy(getattr(self, '_custom_name'), memo)) + N.rename(deepcopy(self.get_custom_name(), memo)) return N def __reduce__(self): diff --git a/src/sage/quivers/representation.py b/src/sage/quivers/representation.py index 47d113778a6..db82cbd7c86 100644 --- a/src/sage/quivers/representation.py +++ b/src/sage/quivers/representation.py @@ -1297,10 +1297,7 @@ def copy(self): sage: v.get_element(1) (1, 0) """ - if hasattr(self, '_custom_name'): - name = self._custom_name - else: - name = None + name = self.get_custom_name() return self.parent()(self._elems.copy(), name) #################################################################### diff --git a/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py b/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py index 6c70b55a7bb..74ef125fb6a 100644 --- a/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py +++ b/src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py @@ -804,8 +804,8 @@ def _latex_(self): \phi sage: phi.reset_name() """ - if hasattr(self, '_custom_name'): - return latex_variable_name(getattr(self, '_custom_name')) + if self.get_custom_name() is not None: + return latex_variable_name(self.get_custom_name()) else: return f'\\phi: {latex(self._function_ring.gen())} \\mapsto ' \ f'{latex(self._gen)}' diff --git a/src/sage/sets/set_from_iterator.py b/src/sage/sets/set_from_iterator.py index d0e3de48f5c..11f12e6d5ea 100644 --- a/src/sage/sets/set_from_iterator.py +++ b/src/sage/sets/set_from_iterator.py @@ -214,12 +214,12 @@ def __reduce__(self): True """ return (EnumeratedSetFromIterator, - (self._func, # func - getattr(self, '_args', None), # args - getattr(self, '_kwds', None), # kwds - getattr(self, '_custom_name', None), # name - self.category(), # category - hasattr(self, '_cache')) # cache + (self._func, # func + getattr(self, '_args', None), # args + getattr(self, '_kwds', None), # kwds + self.get_custom_name(), # name + self.category(), # category + hasattr(self, '_cache')) # cache ) def _repr_(self): diff --git a/src/sage/structure/sage_object.pyx b/src/sage/structure/sage_object.pyx index 9f1a4ece91a..af9c0008672 100644 --- a/src/sage/structure/sage_object.pyx +++ b/src/sage/structure/sage_object.pyx @@ -69,6 +69,8 @@ cdef class SageObject: r""" Change self so it prints as x, where x is a string. + If x is ``None``, the existing custom name is removed. + .. NOTE:: This is *only* supported for Python classes that derive @@ -91,6 +93,9 @@ cdef class SageObject: sage: h.rename('x^300 + ...') sage: h x^300 + ... + sage: g.rename(None) + sage: g + x^3 + x - 5 Real numbers are not Python classes, so rename is not supported:: @@ -110,15 +115,16 @@ cdef class SageObject: a lot of memory. To support them for a specific class, add a - ``cdef public _custom_name`` attribute. + ``cdef public _SageObject__custom_name`` attribute. """ if x is None: - #if hasattr(self, '_custom_name'): - # that's tested in reset_name anyway... self.reset_name() else: try: - self._custom_name = str(x) + # TODO: after dropping support for Cython < 3.0.0, all + # the self._SageObject__custom_name in this class can be + # changed to self.__custom_name + self._SageObject__custom_name = str(x) except AttributeError: raise NotImplementedError("object does not support renaming: %s" % self) @@ -138,8 +144,27 @@ cdef class SageObject: sage: P Univariate Polynomial Ring in x over Rational Field """ - if hasattr(self, '_custom_name'): - del self._custom_name + if hasattr(self, '_SageObject__custom_name'): + del self._SageObject__custom_name + + def get_custom_name(self): + """ + Return the custom name of this object, or ``None`` if it is not + renamed. + + EXAMPLES:: + + sage: P. = QQ[] + sage: P.get_custom_name() is None + True + sage: P.rename('A polynomial ring') + sage: P.get_custom_name() + 'A polynomial ring' + """ + try: + return self._SageObject__custom_name + except AttributeError: + return None def __repr__(self): """ @@ -181,7 +206,7 @@ cdef class SageObject: """ try: - name = self._custom_name + name = self._SageObject__custom_name if name is not None: return name except AttributeError: diff --git a/src/sage/topology/simplicial_set.py b/src/sage/topology/simplicial_set.py index 5792c6d0f91..3ee14ae2da8 100644 --- a/src/sage/topology/simplicial_set.py +++ b/src/sage/topology/simplicial_set.py @@ -570,13 +570,12 @@ def __lt__(self, other): return True if self.degeneracies() and other.degeneracies() and self.degeneracies() != other.degeneracies(): return self.degeneracies() < other.degeneracies() - if hasattr(self.nondegenerate(), '_custom_name'): - if hasattr(other.nondegenerate(), '_custom_name'): - return str(self) < str(other) + if self.nondegenerate().get_custom_name() is not None: + if other.nondegenerate().get_custom_name() is not None: + return self.nondegenerate().get_custom_name() < other.nondegenerate().get_custom_name() return True - if (hasattr(other, '_custom_name') - or hasattr(other.nondegenerate(), '_custom_name')): + if other.nondegenerate().get_custom_name() is not None: return False return id(self) < id(other) @@ -793,8 +792,8 @@ def __copy__(self): # dimension, the degeneracies, and the name (with a prime # added). sigma = AbstractSimplex(self._dim, degeneracies=self.degeneracies()) - if hasattr(self, '_custom_name'): - sigma.rename(str(self) + "'") + if self.get_custom_name() is not None: + sigma.rename(self.get_custom_name() + "'") return sigma def __deepcopy__(self, memo): @@ -839,8 +838,8 @@ def __deepcopy__(self, memo): return memo[underlying].apply_degeneracies(*degens) except KeyError: sigma = AbstractSimplex(underlying._dim) - if hasattr(underlying, '_custom_name'): - sigma.rename(str(self) + "'") + if underlying.get_custom_name() is not None: + sigma.rename(underlying.get_custom_name() + "'") memo[underlying] = sigma return sigma.apply_degeneracies(*degens) @@ -896,12 +895,12 @@ def _latex_(self): """ if self._latex_name is not None: return self._latex_name - if hasattr(self, '_custom_name'): - return str(self) + if self.get_custom_name() is not None: + return self.get_custom_name() if self.nondegenerate()._latex_name is not None: simplex = self.nondegenerate()._latex_name - elif hasattr(self.nondegenerate(), '_custom_name'): - simplex = str(self.nondegenerate()) + elif self.nondegenerate().get_custom_name() is not None: + simplex = self.nondegenerate().get_custom_name() else: simplex = "\\Delta^{{{}}}".format(self._dim) if self.degeneracies(): diff --git a/src/sage/topology/simplicial_set_constructions.py b/src/sage/topology/simplicial_set_constructions.py index f887443abeb..3a217286ac5 100644 --- a/src/sage/topology/simplicial_set_constructions.py +++ b/src/sage/topology/simplicial_set_constructions.py @@ -176,8 +176,7 @@ def __init__(self, data, ambient=None): else: SimplicialSet_finite.__init__(self, data) if self == ambient: - if hasattr(ambient, '_custom_name'): - self.rename(str(ambient)) + self.rename(ambient.get_custom_name()) self._latex_name = latex(ambient) # When constructing the inclusion map, we do not need to check # the validity of the morphism, and more importantly, we From 4b856138923b0224b7666124419be2dd2c83942f Mon Sep 17 00:00:00 2001 From: Yutao Yuan Date: Mon, 28 Aug 2023 10:39:45 +0800 Subject: [PATCH 54/54] fix test failures --- src/sage/combinat/cluster_complex.py | 2 +- src/sage/structure/sage_object.pyx | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/sage/combinat/cluster_complex.py b/src/sage/combinat/cluster_complex.py index 3c85d8db7a4..e263d983887 100644 --- a/src/sage/combinat/cluster_complex.py +++ b/src/sage/combinat/cluster_complex.py @@ -267,7 +267,7 @@ def _repr_(self): sage: ClusterComplex(['A', 2])._repr_() "Cluster complex of type ['A', 2] with 5 vertices and 5 facets" """ - if k == 1: + if self._k == 1: name = 'Cluster complex' else: name = 'Multi-cluster complex' diff --git a/src/sage/structure/sage_object.pyx b/src/sage/structure/sage_object.pyx index af9c0008672..10000aef394 100644 --- a/src/sage/structure/sage_object.pyx +++ b/src/sage/structure/sage_object.pyx @@ -160,6 +160,9 @@ cdef class SageObject: sage: P.rename('A polynomial ring') sage: P.get_custom_name() 'A polynomial ring' + sage: P.reset_name() + sage: P.get_custom_name() is None + True """ try: return self._SageObject__custom_name