Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to the signTypedData #1396

Open
victhorbi opened this issue Oct 8, 2024 · 1 comment · May be fixed by #1409
Open

Add options to the signTypedData #1396

victhorbi opened this issue Oct 8, 2024 · 1 comment · May be fixed by #1409
Assignees
@fabiorigam
Labels
Priority: Medium Size: Medium Type: Enhancement
Milestone
Audit

Comments

@victhorbi
Copy link
Collaborator

victhorbi commented Oct 8, 2024 •
edited
Loading

Just like @Valazan did in dAppKit, we should allow the same operation using the new branch of dAppKit using the SDK only.
This ticket relates to and is the continuation of #1367.
@victhorbi victhorbi added this to the Audit milestone Oct 8, 2024
@victhorbi
Copy link
Collaborator Author

As discussed with @Valazan, @freemanzMrojo and @lucanicoladebiasi , the scope is to add options to the interface while not using it for the implementation.

@fabiorigam fabiorigam linked a pull request Oct 14, 2024 that will close this issue
feat: add SignTypedDataOptions optional param #1409
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabiorigam fabiorigam

Labels
Priority: Medium Size: Medium Type: Enhancement
Projects
None yet
Milestone
Audit
Development

Successfully merging a pull request may close this issue.

feat: add SignTypedDataOptions optional param vechain/vechain-sdk-js
2 participants
@fabiorigam @victhorbi