Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a larger health warning when trying to search an e2e room on web. #15715

Open
neilisfragile opened this issue Nov 12, 2020 · 8 comments
Labels
A-Timeline-Search O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team Z-FTUE

Comments

@neilisfragile
Copy link
Member

Anecdotally it is easy to miss the warning in the search bar when trying to search via the web client in an e2e room. So users assume that our search is simply broken.

Would it make more sense to prevent the search box appearing (with explanation) at all on clicking the search icon? Or at least have a louder warning on clicking the search icon?

A reason not to do this would be if the user wanted to search all rooms (rather than current room) so it might be worth understanding how users search today before deciding one way or the other.

@t3chguy
Copy link
Member

t3chguy commented Nov 12, 2020

Preventing search from appearing would be bad as not all rooms begin life as encrypted, not all rooms only contain encrypted content.

@MadLittleMods
Copy link
Contributor

The hint is easy to miss when most of the page is blank. Can we duplicate some information down to the "No results" to explain that you won't get any results in the web client for an encrypted room?

@aaronraimist
Copy link
Collaborator

Preventing search from appearing would be bad as not all rooms begin life as encrypted, not all rooms only contain encrypted content.

Is there any way to check if a room has been encrypted since it was created and disable search in that case? By comparing the timestamp of m.room.create and m.room.encryptionor something

Surely at least for rooms created after E2E by default happened the vast majority of encrypted rooms have been encrypted since they were created.

@t3chguy
Copy link
Member

t3chguy commented Nov 13, 2020

Additionally fixing the warning to not tell the user to use the Desktop app if they already are but it is broken would be great.

@richvdh
Copy link
Member

richvdh commented Nov 13, 2020

why does the "Use the Desktop app to search encrypted messages" warning pop up even when I am searching from the desktop app?

@t3chguy
Copy link
Member

t3chguy commented Nov 13, 2020

@richvdh

why does the "Use the Desktop app to search encrypted messages" warning pop up even when I am searching from the desktop app?

Additionally fixing the warning to not tell the user to use the Desktop app if they already are but it is broken would be great.

Because your build is either lacking Seshat or Seshat failed to build. Either the index is broken or you're missing sqlcipher

@Amcio
Copy link

Amcio commented Nov 19, 2020

Because your build is either lacking Seshat or Seshat failed to build.

Is there any information on what to do in that case? Or do I have to compile it on my own at that point? (Windows)
I tried the nightly build but the same thing happens.

Update: Managed to find an issue about it. Deleted EventStore folder and now it works.
I will leave this comment for future reference.

@paul90
Copy link

paul90 commented Feb 27, 2021

Having the warning when trying to search using the web client is too late. There needs to be a warning when a room is being created that E2EE rooms can't be searched with the web client.

Effectively #2548 only partially solves client-side search for E2EE rooms, effectively not providing a solution for those that can't use the desktop client for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Timeline-Search O-Occasional Affects or can be seen by some users regularly or most users rarely T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team Z-FTUE
Projects
None yet
Development

No branches or pull requests

10 participants