Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voice messages layout issues #18225

Closed
nadonomy opened this issue Jul 26, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6538
Closed

Voice messages layout issues #18225

nadonomy opened this issue Jul 26, 2021 · 4 comments · Fixed by matrix-org/matrix-react-sdk#6538
Assignees
@turt2live
Labels
A-Voice-Messages P1 Sponsored X-Release-Blocker

Comments

@nadonomy
Copy link
Contributor

When using voice messages, you can observe:

  1. The voice message UI building frame by frame
  2. The overall composer layout (e.g. user avatar) pixel jiggling when sending messages

We should obscure the first, and the second shouldn't happen.
@turt2live
Copy link
Member

@nadonomy are you able to screencap what you're seeing for both of these? (and include browser+OS information please)

@turt2live turt2live added P1 Sponsored X-Needs-Info This issue is blocked awaiting information from the reporter and removed X-Release-Blocker labels Jul 26, 2021
@turt2live turt2live self-assigned this Jul 26, 2021
@turt2live
Copy link
Member

ah, I guess for popping in it's the state where the first time load can be a bit slow (half the stuff shows up)

@turt2live turt2live removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jul 27, 2021
@turt2live
Copy link
Member

though I'm not able to reproduce this :(

@nadonomy
Copy link
Contributor Author

nadonomy commented Aug 3, 2021

Specifically it's these loading in frame by frame:

image
image
image

Happens most times I use voice messages (Chrome, macOS), irrespective of first load.

@nadonomy nadonomy mentioned this issue Aug 3, 2021
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 3, 2021
@turt2live
Use a default waveform when recording to ease component pop-in
3244206 
Fixes element-hq/element-web#18225
@turt2live turt2live mentioned this issue Aug 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Voice-Messages P1 Sponsored X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Polish up more of the voice messages UI matrix-org/matrix-react-sdk
2 participants
@turt2live @nadonomy