Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate and ellipsize long reactions #821

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented Jul 7, 2023

Changes

Ensure that long reactions are not displayed in their entirety by truncating at 16 characters and ellipsizing.

Note that 16 characters is arbitrary, chosen by me to allow for most simple one word reactions such as "Ok" and short phrases such as "running late!" and is subject to change in future.

Context

Part of #342

@jonnyandrew jonnyandrew requested a review from a team as a code owner July 7, 2023 13:32
@jonnyandrew jonnyandrew requested review from bmarty and removed request for a team July 7, 2023 13:32
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link:

@jonnyandrew jonnyandrew force-pushed the jonny/truncate-long-reactions branch from cb92867 to cd0beb0 Compare July 7, 2023 14:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 62.23% and project coverage change: +0.04 🎉

Comparison is base (31056f0) 56.88% compared to head (8e1b188) 56.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #821      +/-   ##
===========================================
+ Coverage    56.88%   56.93%   +0.04%     
===========================================
  Files          914      922       +8     
  Lines        23158    23564     +406     
  Branches      4684     4770      +86     
===========================================
+ Hits         13174    13416     +242     
- Misses        7904     8028     +124     
- Partials      2080     2120      +40     
Impacted Files Coverage Δ
...n/kotlin/io/element/android/appnav/BackstackExt.kt 0.00% <0.00%> (ø)
...o/element/android/appnav/LoggedInEventProcessor.kt 0.00% <0.00%> (ø)
...element/android/appnav/room/LoadingRoomNodeView.kt 0.00% <0.00%> (ø)
...ment/android/features/location/impl/map/MapView.kt 27.73% <0.00%> (-0.42%) ⬇️
...nfirmaccountprovider/ConfirmAccountProviderView.kt 35.13% <0.00%> (-1.36%) ⬇️
...ges/impl/messagecomposer/AttachmentsBottomSheet.kt 44.44% <0.00%> (+18.86%) ⬆️
...d/features/preferences/impl/DefaultCacheService.kt 0.00% <0.00%> (ø)
...atures/preferences/impl/tasks/ClearCacheUseCase.kt 0.00% <0.00%> (ø)
...nt/android/libraries/architecture/ParentNodeExt.kt 6.25% <0.00%> (-27.09%) ⬇️
...aries/designsystem/atomic/atoms/PlaceholderAtom.kt 61.11% <0.00%> (ø)
... and 50 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jonnyandrew jonnyandrew merged commit 3c6f658 into develop Jul 8, 2023
12 checks passed
@jonnyandrew jonnyandrew deleted the jonny/truncate-long-reactions branch July 8, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants