-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truncate and ellipsize long reactions #821
Conversation
cb92867
to
cd0beb0
Compare
Kudos, SonarCloud Quality Gate passed! |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #821 +/- ##
===========================================
+ Coverage 56.88% 56.93% +0.04%
===========================================
Files 914 922 +8
Lines 23158 23564 +406
Branches 4684 4770 +86
===========================================
+ Hits 13174 13416 +242
- Misses 7904 8028 +124
- Partials 2080 2120 +40
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changes
Ensure that long reactions are not displayed in their entirety by truncating at 16 characters and ellipsizing.
Note that 16 characters is arbitrary, chosen by me to allow for most simple one word reactions such as "Ok" and short phrases such as "running late!" and is subject to change in future.
Context
Part of #342
From the spec:
Related to Collapse long list of message reactions #806 (comment)
Design discussion