Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up docs on native Node modules #11517

Closed
jryans opened this issue Nov 26, 2019 · 2 comments
Closed

Clean up docs on native Node modules #11517

jryans opened this issue Nov 26, 2019 · 2 comments
Labels
T-Task Tasks for the team like planning

Comments

@jryans
Copy link
Collaborator

jryans commented Nov 26, 2019

#11125 adds integration and docs for manually enabling Seshat for desktop Riot.

At the moment it recommends:

  • yarn add matrix-seshat in electron_app for initial install
  • Usage of electron-build-env for rebuilds

There are a few issues here that leave some room for improvement:

  • The main purpose of electron-build-env seems to be ensuring that certain env vars are set, including npm_config_runtime which neon seems to need for at least Windows
    • This suggests we need some mechanism of settings these env vars for both initial install and rebuilds
  • Installing matrix-seshat as a dependency will compile a build for plain Node as part of it's own scripts, but we probably need the adjusted Electron build instead, which may awkwardly mean building it twice with electron-build-env from the parent Electron app as well
    • Despite the wasted time of two builds, this seems to be what the Neon example for Electron suggests
@jryans
Copy link
Collaborator Author

jryans commented Mar 20, 2020

We now have an auto-build process after #12452, so I suppose all that's left here is to clean up docs on our support for native node modules.

@jryans jryans changed the title Improve and validate Seshat building for all desktop platforms Clean up docs on native Node modules Apr 24, 2020
@t3chguy
Copy link
Member

t3chguy commented Apr 19, 2023

Fixed

@t3chguy t3chguy closed this as completed Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

2 participants