Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting DM verification in an encrypted DM can cause unknown device warnings you can't access #11709

Closed
turt2live opened this issue Dec 23, 2019 · 6 comments

Comments

@turt2live
Copy link
Member


This is slightly unhelpful if I have to cancel verification to verify the user...

@foldleft
Copy link
Contributor

I was unable to repro this; is it still a valid ticket?

@turt2live
Copy link
Member Author

depends on whether or not we are keeping the unknown devices concept at all. Currently I can reproduce it, but this was a time before the cross-signing flag.

@jryans is the concept gone forever with cross signing or just part of the transition?

@jryans
Copy link
Collaborator

jryans commented Feb 4, 2020

@bwindels
Copy link
Contributor

action for this ticket: don't block sending for unknown devices

@foldleft
Copy link
Contributor

if this is an issue it's extra urgent now I've landed auto-E2E for verifications 💃

@bwindels bwindels self-assigned this Feb 28, 2020
@bwindels
Copy link
Contributor

bwindels commented Feb 28, 2020

I can't repro this anymore. I've tried adding a new device, skipping the complete-security to not have it cross-signed, and then verify that user from another account. This is with the Never send encrypted messages to unverified devices from this device flag off on the initiating side. Left is what I see from the account itself, and right from the account trying to verify it:

verifyunknowndevice

I could successfully verify, without any unknown device warnings, and after verification completed I saw a red device for the account as well, so all seems to be working well.

With the Never send encrypted messages to unverified devices from this device flag on, I get this on the receiving side (on a cross signed device):

utd-unverified

#11808 seems to be about fixing that though, so closing this issue.

Looking further, it seems like matrix-org/matrix-react-sdk#3837 was a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants