Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme: redacted messages could look nicer #8559

Closed
babolivier opened this issue Feb 13, 2019 · 16 comments
Closed

Dark theme: redacted messages could look nicer #8559

babolivier opened this issue Feb 13, 2019 · 16 comments
Assignees

Comments

@babolivier
Copy link
Contributor

Currently they look like this, which is a bit too flashy for me on a dark theme:

image

@jryans
Copy link
Collaborator

jryans commented Feb 13, 2019

I think this one needs feedback from @nadonomy first.

@swedneck
Copy link

I think it'd be nice to treat deleted messages the same as join/leave/avatar change messages, it feels much more appropriate than a big band of warning tape.

@turt2live
Copy link
Member

@swedneck that is an option in your settings.

@turt2live
Copy link
Member

Worth noting that this used to work with the old dark theme:
image

@swedneck
Copy link

It is? i know about the "Show a placeholder for removed messages" toggle, but that doesn't seem to replace them with join/leave-style notifications.

@targodan
Copy link

I was missing the keyword redacted when searching for an issue. Sorry about the duplicate. I like the old version probably even better than the one I cobbled up earlier.

@turt2live
Copy link
Member

@swedneck it somewhat depends on what you mean. Redacting a join event causes it to disappear (currently). If you mean the MELS thing, that would be a new issue.

@swedneck
Copy link

@turt2live i presume MELS is the stuff like join/leave/avatar change/kick/ban, in which case that is what i mean.

@turt2live
Copy link
Member

Yup, Membership Event List Summary - it sounds like you're looking for new functionality, which is worth a new issue :)

@tebjan
Copy link

tebjan commented Feb 14, 2019

even in the old theme this was way to massive, at least for my eye. it could be very decent and don't draw attention at all.

@tebjan
Copy link

tebjan commented Feb 14, 2019

also: the ability to edit messages would make this issue much less pressing ;)

@matrixes
Copy link

I read a couple of comments in the Riot-chat from @swedneck and I think he's onto something good;

Make the redacted highlight into something visually similar to join/leave messages.

redacted-enhanced

There are a few ways you can make it "unique" if that's what you're going for. Custom icon and text color for one.

I'm actually not really sure why the redacted highlight has taken such a prominent place in the chat (I'm new to Synapse/Matrix/Riot, so I don't have the background yet), as it is.
The way it's presented right now (the striped graphic), redactions are among the single most important events in the chat.
This may be my personal view, but I definitely want them to be lowlights, not highlights. I want to be aware of them, but only in my peripheral view. If I'm interested in redacted messages, I'll go look for them, but I don't want to become aware of every single time it happens. It's impossible to ignore them at this point.
Also, having this as a text phrase instead of a striped "thing", makes it easily searchable, if that's a concern.

@aaronraimist
Copy link
Collaborator

A related issue requests that they be collapsed: #3657

@matrixes
Copy link

I think that should be considered as well.
I (as many others, I'm sure) have used both Slack and Discord and they have way less intrusive (none at all, really) indicators/highlights that a message has been removed.
They do have something for modified/edited messages, but that is another topic.
For redaction/removal, Riot is the first I've come across that makes such a "big deal", in lack of a better phrase/word for it, out of redacted messages, and I'm not geling with them, and it looks like others have had the same thought as well.

@jryans
Copy link
Collaborator

jryans commented Feb 15, 2019

This issue is about redacted messages and how they look on the dark theme. For now, I'll restore the previous behavior that @turt2live mentioned.

The other ideas people have mentioned here about new behavior don't seem to specific to the dark theme. I would recommend filing a separate issue for these.

@jryans jryans self-assigned this Feb 15, 2019
@jryans
Copy link
Collaborator

jryans commented Feb 15, 2019

Fixed by matrix-org/matrix-react-sdk@91c91c5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants