-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme: redacted messages could look nicer #8559
Comments
I think this one needs feedback from @nadonomy first. |
I think it'd be nice to treat deleted messages the same as join/leave/avatar change messages, it feels much more appropriate than a big band of warning tape. |
@swedneck that is an option in your settings. |
It is? i know about the "Show a placeholder for removed messages" toggle, but that doesn't seem to replace them with join/leave-style notifications. |
I was missing the keyword redacted when searching for an issue. Sorry about the duplicate. I like the old version probably even better than the one I cobbled up earlier. |
@swedneck it somewhat depends on what you mean. Redacting a join event causes it to disappear (currently). If you mean the MELS thing, that would be a new issue. |
@turt2live i presume MELS is the stuff like join/leave/avatar change/kick/ban, in which case that is what i mean. |
Yup, Membership Event List Summary - it sounds like you're looking for new functionality, which is worth a new issue :) |
even in the old theme this was way to massive, at least for my eye. it could be very decent and don't draw attention at all. |
also: the ability to edit messages would make this issue much less pressing ;) |
I read a couple of comments in the Riot-chat from @swedneck and I think he's onto something good; Make the redacted highlight into something visually similar to join/leave messages. There are a few ways you can make it "unique" if that's what you're going for. Custom icon and text color for one. I'm actually not really sure why the redacted highlight has taken such a prominent place in the chat (I'm new to Synapse/Matrix/Riot, so I don't have the background yet), as it is. |
A related issue requests that they be collapsed: #3657 |
I think that should be considered as well. |
This issue is about redacted messages and how they look on the dark theme. For now, I'll restore the previous behavior that @turt2live mentioned. The other ideas people have mentioned here about new behavior don't seem to specific to the dark theme. I would recommend filing a separate issue for these. |
Fixed by matrix-org/matrix-react-sdk@91c91c5. |
Currently they look like this, which is a bit too flashy for me on a dark theme:
The text was updated successfully, but these errors were encountered: