-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify Vector version in the Vector config file #1037
Comments
I think the one issue that arises with this is our use of serde and defining the config via set of structs. I'm not sure this method supports the ability to go backwards with previous versions. We may want to consider more custom config loading methods using an external schema like |
It might be not necessary to support previous versions, we can just load TOML, check version, and if the version is not the same as Vectors, exit with an error. And the "migration" steps for implementation of |
@a-rodin I am totally on board with that! I think this would provide a much better UX. |
I'm removing the |
Noting, we are deferring this until we actually need it. |
Idea from @bruceg : could version configuration at the component level. |
After talking with @a-rodin he had the following idea:
He also mentioned:
I don't think we should address this during the pre-1.0 phase of development, but I wanted to open this issue for discussion.
The text was updated successfully, but these errors were encountered: