Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust toolchain to 1.45 #3515

Closed
binarylogic opened this issue Aug 21, 2020 · 6 comments
Closed

Bump Rust toolchain to 1.45 #3515

binarylogic opened this issue Aug 21, 2020 · 6 comments
Labels
domain: releasing Anything related to releasing Vector have: must We must have this feature, it is critical to the project's success. It is high priority. type: task Generic non-code related tasks

Comments

@binarylogic
Copy link
Contributor

We need to bump the Rust toolchain to 1.45 to unblock #3514. We've bumped this in the past, but it broke nightly releases because we need to upgrade to LLVM10.

@binarylogic binarylogic added type: task Generic non-code related tasks have: must We must have this feature, it is critical to the project's success. It is high priority. domain: releasing Anything related to releasing Vector labels Aug 21, 2020
@Hoverbear
Copy link
Contributor

Hoverbear commented Aug 21, 2020

Some context:

PS C:\Users\ana> rustc +1.45.2 --version --verbose
rustc 1.45.2 (d3fb005a3 2020-07-31)
binary: rustc
commit-hash: d3fb005a39e62501b8b0b356166e515ae24e2e54
commit-date: 2020-07-31
host: x86_64-pc-windows-msvc
release: 1.45.2
LLVM version: 10.0

PS C:\Users\ana> rustc +1.44.0 --version --verbose
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-pc-windows-msvc
release: 1.44.0
LLVM version: 9.0

As you can see, updating from Rust 1.44 to Rust 1.45 increases the LLVM version our builds need to link to. We also need to refer to the musl version from https://github.com/rust-lang/rust/blob/master/src/ci/docker/scripts/musl-toolchain.sh and possibly update that.

@tyrken
Copy link
Contributor

tyrken commented Sep 3, 2020

FYI: The vector nightly builds have been failing for a week or so on Windows, which is slightly annoying as I'd like to switch from my fork to your latest builds (hopefully a release soon), and you only publish if all builds complete successfully.

The cause of the Windows fails looks suspiciously like rust-lang/rust#72470 which is confirmed as being in toolchain 1.44, they attempted to revert afterwards but don't know if its OK in 1.45 or even latest yet...

@yoshuawuyts
Copy link

but don't know if its OK in 1.45 or even latest yet...

We're still experiencing this issue at work, and remain pinned to Rust 1.43.0. To my knowledge this has not been addressed in the compiler yet.

@Hoverbear
Copy link
Contributor

@tyrken Can you open a separate issue for that? I can try to address it. :)

@jamtur01
Copy link
Contributor

jamtur01 commented Sep 8, 2020

@Hoverbear @tyrken That bug is addressed in 1.46 from what I can see from my initial take on this (#3700) but obviously that whole path is dependent on the LLVM upgrade.

@leebenson
Copy link
Member

Bumping to rustc 1.45 is no longer required in #3514, per moving to async-graphql. I think we can skip this and bump straight to 1.46 once LLVM 10 lands. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: releasing Anything related to releasing Vector have: must We must have this feature, it is critical to the project's success. It is high priority. type: task Generic non-code related tasks
Projects
None yet
Development

No branches or pull requests

6 participants