Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example in docstring of get_inline_table_names does not work. Blocks conda-forge release. #3174

Closed
binste opened this issue Aug 28, 2023 · 1 comment · Fixed by #3175
Closed
Labels

Comments

@binste
Copy link
Contributor

binste commented Aug 28, 2023

@jonmmease The example in the docstring of get_inline_table_names does not retrieve the table name. I don't know if there is a bug in the function or it's just the docstring that needs to be adapted.

spec = {
    "data": [
        {
            "name": "foo",
            "url": "https://path/to/file.csv"
        },
        {
            "name": "bar",
            "url": "table://inline_dataset_123"
        }
    ]
}
from altair.utils._vegafusion_data import get_inline_table_names
get_inline_table_names(spec)  # Returns an empty set

This came up in conda-forge/altair-feedstock#49

Btw, this did not come up in the tests as docstring tests are only run in the tests folder. We should probably change the pytest command to include the altair package -> pytest --doctest-modules altair tests.

@jonmmease
Copy link
Contributor

Fix in #3175. This was an error in the doctest itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants