fix: remove normalized spec from schema #6965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also addresses 5c0b299#r41899248 |
kanitw
reviewed
Oct 25, 2020
| @@ -53,20 +53,18 @@ export function remove(mark: string) { | |||
| delete compositeMarkRegistry[mark]; | |||
| } | |||
|
|
|||
| export type CompositeEncoding<F extends Field = Field> = Encoding<F> & ErrorExtraEncoding<F>; | |||
| export type CompositeEncoding<F extends Field> = Encoding<F> & ErrorExtraEncoding<F>; | |||
There was a problem hiding this comment.
Can you explain why do we remove the default = Field here?
There was a problem hiding this comment.
I found it less confusing to explicitly say the type. It makes me more confident that we didn't miss using string somewhere.
domoritz
force-pushed
the
dom/remove-normalized
branch
from
d8eb937
to
f7764c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6823
Needs vega/ts-json-schema-generator#549