fix: normalize selections across multi-views and selection emptiness #7204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, looks like these changes are causing a lot more specs to be normalized even though there isn't any real change in the specification. Need to investigate why. |
arvind
force-pushed
the
as/selectionCompatFixes
branch
from
6c2f671
to
1d18c49
Compare
|
Ok, should be fixed. |
domoritz
approved these changes
Feb 2, 2021
| } | ||
|
|
||
| return bin; | ||
| } | ||
|
|
||
| function normalizePredicate(op: any) { | ||
| function normalizePredicate(op: any, normParams: NormalizerParams) { |
There was a problem hiding this comment.
I know this is old code but why is op any?
| function normalizeTransforms(spec: any, normParams: NormalizerParams) { | ||
| const {transform: tx, ...rest} = spec; | ||
| if (tx) { | ||
| const transform = tx.map((t: any) => { |
| bin: normalizeBinExtent(t.bin) | ||
| }; | ||
| } else if (isLookup(t)) { | ||
| const {selection: param, ...from} = t.from as any; |
| } | ||
|
|
||
| public mapUnit(spec: UnitSpec<Field>) { | ||
| public mapUnit(spec: UnitSpec<Field>, normParams: NormalizerParams) { | ||
| const {selection, ...rest} = spec as any; |
There was a problem hiding this comment.
This is old code but why does spec need to be any?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.