Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support x/yOffset without x/y #9135

Merged
merged 4 commits into from
Oct 12, 2023
Merged

fix: support x/yOffset without x/y #9135

merged 4 commits into from
Oct 12, 2023

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Oct 12, 2023

replacing #9133

@kanitw kanitw requested review from fandu-db, lsh and a team October 12, 2023 15:41
Copy link
Contributor

@fandu-db fandu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Ham!

@kanitw kanitw changed the title fix: do not replace offset with main channel fix: support x/yOffset without x/y Oct 12, 2023
@kanitw kanitw changed the title fix: support x/yOffset without x/y fix: Support x/yOffset without x/y Oct 12, 2023
@kanitw kanitw changed the title fix: Support x/yOffset without x/y fix: support x/yOffset without x/y Oct 12, 2023
@kanitw kanitw merged commit 58294a7 into main Oct 12, 2023
10 of 12 checks passed
@kanitw kanitw deleted the xOffset-without-x branch October 12, 2023 18:18
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
* fix: remove 'replaceOffsetWithMainChannel'

* chore: update examples [CI]

* fix: support x/yOffset without x/y

* chore: update examples [CI]

---------

Co-authored-by: Fan Du <[email protected]>
Co-authored-by: GitHub Actions Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants