Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command ctrl + C does not work #1121

Closed
fabdelgado opened this issue Dec 12, 2016 · 102 comments
Closed

Command ctrl + C does not work #1121

fabdelgado opened this issue Dec 12, 2016 · 102 comments
Labels
help wanted Contributions wanted towards the issue 🐧 Platform: Linux Issue pertains to Linux 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper

Comments

@fabdelgado
Copy link

The ctrl + c command to interrupt operations does not work.

@markpanado
Copy link

I tested mine with the new update and it's working.

@mqudsi
Copy link
Contributor

mqudsi commented Dec 12, 2016

It doesn't work for me, either. Ctrl+c is completely ignored running on Windows 10 build 1607 running cmd.exe (not bash.exe). In bash.exe, ctrl+c works, but the up arrow key does not work.

@willharrison
Copy link

ctrl + c works for me. Having issues with ctrl+ r, up arrow, down arrow, and ctrl + backspace.

@timothyis timothyis added 🖼 Platform: Windows Issue pertains to Windows help wanted Contributions wanted towards the issue 🐛 Type: Bug Issue pertains to something wrong within Hyper labels Dec 12, 2016
@warpdesign
Copy link

warpdesign commented Dec 13, 2016

Here I cannot copy test to clipboard but ctrl+c to interrupt processes seems to work as expected.

When trying to copy selected text to the keyboard, the moment I press 'shift' or 'ctrl', the text I have selected gets unselected, so keeping shift+ctrl down and pressing c to paste does nothing as there's nothing left selected.

Not sure if it's related: but that's with a French keyboard layout.

@shern91
Copy link

shern91 commented Dec 13, 2016

i also facing the same problem in copy text to clipboard, no matter i click Ctrl+C or Shift+Ctrl+C, once i click any of key those text will deselected.

P/S: Windows 10 64 bit user.

@timothyis timothyis added the 🐧 Platform: Linux Issue pertains to Linux label Dec 13, 2016
@stereokai
Copy link

stereokai commented Dec 13, 2016

All of the issues described so far are happening on my machine as well. Win10 64bit with Bash on Ubuntu on Windows.

@mqudsi
Copy link
Contributor

mqudsi commented Dec 14, 2016

I just want to point out that ctrl+c works in a bash.exe shell, even though it does not work in the standard cmd.exe shell.

@stereokai
Copy link

@mqudsi just to remove any shadow of doubt, it doesn't perform a copy, but cancels the current command (as it should)

@ppot
Copy link
Contributor

ppot commented Dec 15, 2016

@warpdesign Fix in #1218

@kvj
Copy link

kvj commented Dec 15, 2016

The problem isn't only Ctrl+C alone, but any hotkeys bound to menu items under Linux and Windows. They're intercepted by Electron and not delivered to main window, I guess. For example, all my keybindings for tmux start from Ctrl+A and don't work in Hyper under Linux (instead, Select All is executed), but work well in macOS (Select All is Cmd+A there)

@LeonLiuY
Copy link

@kvj +1

@mqudsi
Copy link
Contributor

mqudsi commented Dec 15, 2016

@liuyang1204 there's a +1 button.

@kvj I'm not so sure about that. If that were the case, ctrl+c would not suddenly function if a bash.exe session is started under Windows.

@annnoo
Copy link

annnoo commented Dec 15, 2016

Having quite the same problem in #1199 . I bound the "Close Session" shortcut to another key, but Ctrl+W is not working at all in vim.

@jamiewade
Copy link

Pressing Ctrl + C closes the window for me, but I want to use this keyboard command to stop processes running, for example Gulp.

Running Windows 10 64bit.

@SirTimmyTimbit
Copy link

SirTimmyTimbit commented Dec 20, 2016

+1 on Windows 10,

@damien122
Copy link

OS version and name: windows 10 x64

Hyper.app version: 1.0.0

I have also this problem

@j-mie
Copy link

j-mie commented Dec 29, 2016

Still having this issue:

Hyper 1.0.0
Electron 1.4.7
win32 x64 10.0.14393

@halkeye
Copy link

halkeye commented Dec 29, 2016

I don't think it's really worth people continuing to state they are still having the issue. There's a subscribe button on the right of this page so you can get notified of changes.

As I understand it the accelerator keys assigned to copy (and select all) in the menus are capturing the keys before they get to the app.

@sparebytes
Copy link

It appears VSCode has a similar issue so I'm just going to leave this here.
microsoft/vscode#9347 (comment)

Something else I noticed is that the up and down keys work in PowerShell for going through history but it doesn't in the bash.exe shell even though ctrl+c works there.

@mrteye
Copy link

mrteye commented Jun 12, 2018

Ctrl + C to stop execution of a script. This is still seriously lagging for me on Mac using Hyper ver: 2.0.0 (Stable)

Tested on Terminal.app and Hyper.app ssh'd into a remote Fedora machine:
cd / && find . -mtime -2 -ls

Results:
Terminal.app stops execution right after Ctrl + C key combo.
Hyper.app keeps running after multiple attempts and then finally breaks 30 seconds to a minute after.

I read lots of the comments above although I'm not sure what the current status of this issue is. Does anyone have an update, or more examples (if that helps.)

@sgarcia-dev
Copy link

Is this not fixed yet? I'm on hyper 2.0.0 stable on Win 10 x64, and Hyper's editor break still doesn't work when using ctrl + c...

@albinekb
Copy link
Contributor

It's shift+ctrl+c by default on windows @sgarcia-dev

@giggio
Copy link

giggio commented Jul 24, 2018

It should be ctrl+c, which is the default.

@mikemaccana
Copy link

This issue is about cancelling / interrupting (Ctrl C), not copying. Please report / discuss copying in another issue, as there's many people subscribed to this issue.

@eddyekofo94
Copy link

Still not working guys, using Windows 10 WSL

@aminland
Copy link

still not working on 2.1.0 canary

@theblackturtle
Copy link

Still not working now.

@mqudsi
Copy link
Contributor

mqudsi commented Sep 16, 2018

There is no point in commenting to say it's not working. That's what the subscribe button is for, and until a developer actually cares about the problem and does something about it, it's going to continue not working because bugs don't randomly get fixed on their own.

It's very clear that cross-platform support is very low on the list of priorities for hyper developers. Anyone that actually cared about this has moved on from hyper a long time ago. There's no need for everyone to spam this issue with "new build came out today, still not working" because that accomplishes nothing.

@bgshacklett
Copy link

For anyone who's really concerned about this, you may want to follow microsoft/node-pty#216. It seems like the only way this is ever going to be fixed.

@giggio
Copy link

giggio commented Sep 20, 2018

Yes, the ConPTY will change everything, but this is something that will only work on Windows 1809, that has not yet even come out (it should be out in the next weeks).
Even then, developers of terminal apps for Windows will have to create a ton of code to get it to work, and after it is done their app won't work on older Windows versions, which is a hard decision to make. Or even worse, support two different approaches. The good news is that Windows 10 versions are consolidating really fast. The bad news is that there are still a lot of users on Windows 7 and 8.

@bitcrazed
Copy link

We hear ya @giggio and feel your pain. We wish that there was an easy solution here, but alas, there are a complex long-tail of issues preventing us from backporting the ConPTY API.

Do ping me if we can be of any help or if you find any issues, etc.: richturn at you know where .com!

@mikemaccana
Copy link

mikemaccana commented Sep 21, 2018

FYI Windows folks: it's worth trying 'Terminus' https://github.com/Eugeny/terminus until this is fixed as Ctrl C works and it's quite similar (it's electron, uses CSS for styling etc) to Hyper!

@giggio
Copy link

giggio commented Sep 21, 2018

@bitcrazed I am aware, I know this is a large effort, and I am happy it is finally happening! In time most of the terminal apps will have migrated, Windows 10 is more consolidated each day. Thank you and your team for your effort, you have been making our lives on Windows much much better.

@giggio
Copy link

giggio commented Sep 21, 2018

@mikemaccana This Terminus looks cool! Trying it now!

@bitcrazed
Copy link

bitcrazed commented Sep 21, 2018

@giggio No, thank YOU and the amazing community members who report issues and help us improve Windows and the Windows Console/Command-Line every day :) Exciting things ahead 😜 And of course, they Hyper devs and community who've built such a beautiful terminal 😁

@iamkarlson
Copy link

Any updates?

@giggio
Copy link

giggio commented Jan 8, 2019

I just saw that NodePTY is finally supporting ConPTY!
The Release:
https://github.com/Microsoft/node-pty/releases/tag/0.8.0
The PR:
microsoft/node-pty#236

And it seems to already have been integrated 2 weeks ago:
dd68286

I don't know what is needed to enable ConPTY with Hyper, but if there was an option I would love to try it.

@giggio
Copy link

giggio commented Jan 8, 2019

Ok, I just updated to the latest canary, and CTRL+C works!

Hyper and Powershell side by side

@giggio
Copy link

giggio commented Jan 8, 2019

I am on Windows version 10.0.17763.195, which is version 1809.

This works because according to Node-PTY release notes, ConPTY works by default, unless you disable it. https://github.com/Microsoft/node-pty/releases/tag/0.8.0

So now I can go back to trying Hyper. Cool! I have been trying to leave ConEmu for a while, maybe now I can.

@bitcrazed
Copy link

Thanks for confirming @giggio - glad to see @Tyriar & @zadjii-msft's work finally arrive 😁

I think it's safe to (finally) mark this as closed?

@chabou
Copy link
Collaborator

chabou commented Jan 9, 2019

Awesome! Thank you so much @bitcrazed 🙏

@chabou chabou closed this as completed Jan 9, 2019
@bitcrazed
Copy link

LOL :) Thanks @chabou, but all credit to @Tyriar & @zadjii-msft who did the work ;)

@Tyriar
Copy link
Contributor

Tyriar commented Jan 10, 2019

@chabou FYI I've disabled conpty in vscode because:

  • It's too slow currently (improvements coming to Windows Insiders soon)
  • There's a bug in Powershell where the cursor will flicker in the top left (fixed in Windows Insiders)
  • Kill doesn't clean up all the processes (I need to fix this Conpty breaks ptyProcess.kill() microsoft/node-pty#253)

After I fix the last problem I'm going to enable it by default on the latest Windows Insiders version.

@mikemaccana
Copy link

mikemaccana commented Jan 14, 2019

Link to canary builds for those wondering https://github.com/zeit/hyper/releases

You'll also need to fix a couple of settings as it looks like Hyper doesn't start powershell by default:

shell: 'C:\\Program Files\\PowerShell\\6-preview\\pwsh.exe',
shellArgs: [],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Contributions wanted towards the issue 🐧 Platform: Linux Issue pertains to Linux 🖼 Platform: Windows Issue pertains to Windows 🐛 Type: Bug Issue pertains to something wrong within Hyper
Projects
None yet
Development

No branches or pull requests