-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command ctrl + C does not work #1121
Comments
I tested mine with the new update and it's working. |
It doesn't work for me, either. Ctrl+c is completely ignored running on Windows 10 build 1607 running cmd.exe (not bash.exe). In bash.exe, ctrl+c works, but the up arrow key does not work. |
ctrl + c works for me. Having issues with ctrl+ r, up arrow, down arrow, and ctrl + backspace. |
Here I cannot copy test to clipboard but ctrl+c to interrupt processes seems to work as expected. When trying to copy selected text to the keyboard, the moment I press 'shift' or 'ctrl', the text I have selected gets unselected, so keeping shift+ctrl down and pressing c to paste does nothing as there's nothing left selected. Not sure if it's related: but that's with a French keyboard layout. |
i also facing the same problem in copy text to clipboard, no matter i click Ctrl+C or Shift+Ctrl+C, once i click any of key those text will deselected. P/S: Windows 10 64 bit user. |
All of the issues described so far are happening on my machine as well. Win10 64bit with Bash on Ubuntu on Windows. |
I just want to point out that ctrl+c works in a bash.exe shell, even though it does not work in the standard cmd.exe shell. |
@mqudsi just to remove any shadow of doubt, it doesn't perform a copy, but cancels the current command (as it should) |
@warpdesign Fix in #1218 |
The problem isn't only Ctrl+C alone, but any hotkeys bound to menu items under Linux and Windows. They're intercepted by Electron and not delivered to main window, I guess. For example, all my keybindings for tmux start from Ctrl+A and don't work in Hyper under Linux (instead, Select All is executed), but work well in macOS (Select All is Cmd+A there) |
@kvj +1 |
@liuyang1204 there's a +1 button. @kvj I'm not so sure about that. If that were the case, ctrl+c would not suddenly function if a bash.exe session is started under Windows. |
Having quite the same problem in #1199 . I bound the "Close Session" shortcut to another key, but Ctrl+W is not working at all in vim. |
Pressing Running Windows 10 64bit. |
+1 on Windows 10, |
OS version and name: windows 10 x64 Hyper.app version: 1.0.0 I have also this problem |
Still having this issue: Hyper 1.0.0 |
I don't think it's really worth people continuing to state they are still having the issue. There's a subscribe button on the right of this page so you can get notified of changes. As I understand it the accelerator keys assigned to copy (and select all) in the menus are capturing the keys before they get to the app. |
It appears VSCode has a similar issue so I'm just going to leave this here. Something else I noticed is that the up and down keys work in PowerShell for going through history but it doesn't in the bash.exe shell even though |
Ctrl + C to stop execution of a script. This is still seriously lagging for me on Mac using Hyper ver: 2.0.0 (Stable) Tested on Terminal.app and Hyper.app ssh'd into a remote Fedora machine: Results: I read lots of the comments above although I'm not sure what the current status of this issue is. Does anyone have an update, or more examples (if that helps.) |
Is this not fixed yet? I'm on hyper 2.0.0 stable on Win 10 x64, and Hyper's editor break still doesn't work when using |
It's shift+ctrl+c by default on windows @sgarcia-dev |
It should be |
This issue is about cancelling / interrupting (Ctrl C), not copying. Please report / discuss copying in another issue, as there's many people subscribed to this issue. |
Still not working guys, using Windows 10 WSL |
still not working on 2.1.0 canary |
Still not working now. |
There is no point in commenting to say it's not working. That's what the subscribe button is for, and until a developer actually cares about the problem and does something about it, it's going to continue not working because bugs don't randomly get fixed on their own. It's very clear that cross-platform support is very low on the list of priorities for hyper developers. Anyone that actually cared about this has moved on from hyper a long time ago. There's no need for everyone to spam this issue with "new build came out today, still not working" because that accomplishes nothing. |
For anyone who's really concerned about this, you may want to follow microsoft/node-pty#216. It seems like the only way this is ever going to be fixed. |
Yes, the |
We hear ya @giggio and feel your pain. We wish that there was an easy solution here, but alas, there are a complex long-tail of issues preventing us from backporting the ConPTY API. Do ping me if we can be of any help or if you find any issues, etc.: richturn at you know where .com! |
FYI Windows folks: it's worth trying 'Terminus' https://github.com/Eugeny/terminus until this is fixed as Ctrl C works and it's quite similar (it's electron, uses CSS for styling etc) to Hyper! |
@bitcrazed I am aware, I know this is a large effort, and I am happy it is finally happening! In time most of the terminal apps will have migrated, Windows 10 is more consolidated each day. Thank you and your team for your effort, you have been making our lives on Windows much much better. |
@mikemaccana This Terminus looks cool! Trying it now! |
@giggio No, thank YOU and the amazing community members who report issues and help us improve Windows and the Windows Console/Command-Line every day :) Exciting things ahead 😜 And of course, they Hyper devs and community who've built such a beautiful terminal 😁 |
Any updates? |
I just saw that NodePTY is finally supporting ConPTY! And it seems to already have been integrated 2 weeks ago: I don't know what is needed to enable ConPTY with Hyper, but if there was an option I would love to try it. |
I am on Windows version This works because according to Node-PTY release notes, ConPTY works by default, unless you disable it. https://github.com/Microsoft/node-pty/releases/tag/0.8.0 So now I can go back to trying Hyper. Cool! I have been trying to leave ConEmu for a while, maybe now I can. |
Thanks for confirming @giggio - glad to see @Tyriar & @zadjii-msft's work finally arrive 😁 I think it's safe to (finally) mark this as closed? |
Awesome! Thank you so much @bitcrazed 🙏 |
LOL :) Thanks @chabou, but all credit to @Tyriar & @zadjii-msft who did the work ;) |
@chabou FYI I've disabled conpty in vscode because:
After I fix the last problem I'm going to enable it by default on the latest Windows Insiders version. |
Link to canary builds for those wondering https://github.com/zeit/hyper/releases You'll also need to fix a couple of settings as it looks like Hyper doesn't start powershell by default:
|
The ctrl + c command to interrupt operations does not work.
The text was updated successfully, but these errors were encountered: