-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable minification for sourcemap-register.js #631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
reviewed
Dec 24, 2020
styfle
changed the title
Enable minification
Enable minification for sourcemap-register.js
Dec 24, 2020
styfle
reviewed
Dec 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Let's use the existing minify
variable like the others above
Co-authored-by: Steven <[email protected]>
styfle
approved these changes
Dec 24, 2020
@styfle yes you are right!) |
zeroooooooo
added a commit
to hitheres/ncc
that referenced
this pull request
Dec 25, 2020
Enable minification for sourcemap-register.js (vercel#631)
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File
scripts/build.js
contains invalid configuration forncc
.Most likely it does not do what was expected. After fixed, the
/dist/ncc/sourcemap-register.js.cache.js
file becomes minified. And its weight is reduced by86kb
.File:
/dist/ncc/sourcemap-register.js.cache.js
Original size:
127kb
Fixed:
41kb