From 99b9304bf15c630d5811285c2383a25b09fbf516 Mon Sep 17 00:00:00 2001 From: Tobias Koppers Date: Wed, 6 Dec 2023 17:34:06 +0100 Subject: [PATCH] disable unused next/dynamic walking in app dir (#59338) ### What? remove expensive unused code Closes PACK-2108 --- packages/next-swc/crates/next-api/src/app.rs | 49 ++++++++++---------- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/packages/next-swc/crates/next-api/src/app.rs b/packages/next-swc/crates/next-api/src/app.rs index 1f4c52511d754..10a0c8f539942 100644 --- a/packages/next-swc/crates/next-api/src/app.rs +++ b/packages/next-swc/crates/next-api/src/app.rs @@ -22,7 +22,7 @@ use next_core::{ next_client_reference::{ ClientReferenceGraph, ClientReferenceType, NextEcmascriptClientReferenceTransition, }, - next_dynamic::{NextDynamicEntries, NextDynamicTransition}, + next_dynamic::NextDynamicTransition, next_edge::route_regex::get_named_middleware_regex, next_manifests::{ AppBuildManifest, AppPathsManifest, BuildManifest, ClientReferenceManifest, @@ -584,30 +584,31 @@ impl AppEndpoint { let client_reference_types = client_reference_graph.types(); let client_references = client_reference_graph.entry(rsc_entry_asset); - let app_ssr_entries: Vec<_> = client_reference_types - .await? - .iter() - .map(|client_reference_ty| async move { - let ClientReferenceType::EcmascriptClientReference(entry) = client_reference_ty - else { - return Ok(None); - }; - - Ok(Some(entry.await?.ssr_module)) - }) - .try_join() - .await? - .into_iter() - .flatten() - .collect(); - - let app_node_entries: Vec<_> = app_ssr_entries.iter().copied().chain([rsc_entry]).collect(); - // TODO(alexkirsz) Handle dynamic entries and dynamic chunks. - let _dynamic_entries = NextDynamicEntries::from_entries(Vc::cell( - app_node_entries.iter().copied().map(Vc::upcast).collect(), - )) - .await?; + // let app_ssr_entries: Vec<_> = client_reference_types + // .await? + // .iter() + // .map(|client_reference_ty| async move { + // let ClientReferenceType::EcmascriptClientReference(entry) = + // client_reference_ty else { + // return Ok(None); + // }; + + // Ok(Some(entry.await?.ssr_module)) + // }) + // .try_join() + // .await? + // .into_iter() + // .flatten() + // .collect(); + + // let app_node_entries: Vec<_> = + // app_ssr_entries.iter().copied().chain([rsc_entry]).collect(); + + // let _dynamic_entries = NextDynamicEntries::from_entries(Vc::cell( + // app_node_entries.iter().copied().map(Vc::upcast).collect(), + // )) + // .await?; let app_entry_client_references = client_reference_graph .entry(Vc::upcast(app_entry.rsc_entry))