Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade webpack 5 #22864

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Upgrade webpack 5 #22864

merged 4 commits into from
Mar 8, 2021

Conversation

timneutkens
Copy link
Member

Upgrades webpack 5 to the latest version.

@ijjk ijjk added the type: next label Mar 8, 2021
@ijjk
Copy link
Member

ijjk commented Mar 8, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
buildDuration 12.6s 12.6s ⚠️ +93ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +283 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.319 2.271 -0.05
/ avg req/sec 1077.93 1100.98 +23.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.564 1.54 -0.02
/error-in-render avg req/sec 1598.6 1623.19 +24.59
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
index.html gzip 615 B 615 B ✓
link.html gzip 623 B 623 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
buildDuration 14.9s 15.1s ⚠️ +133ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +283 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
buildDuration 15s 15.2s ⚠️ +216ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +283 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.25 2.304 ⚠️ +0.05
/ avg req/sec 1111.24 1085.01 ⚠️ -26.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.619 1.565 -0.05
/error-in-render avg req/sec 1543.81 1597.04 +53.23
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
index.html gzip 586 B 586 B ✓
link.html gzip 594 B 594 B ✓
withRouter.html gzip 582 B 582 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "8u7YzT9oXyUGDQ5TAXtAY",
+        "buildId": "mFU9Dsb4P_f6sH8h7hS8o",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8u7YzT9oXyUGDQ5TAXtAY/_buildManifest.js"
+      src="/_next/static/mFU9Dsb4P_f6sH8h7hS8o/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8u7YzT9oXyUGDQ5TAXtAY/_ssgManifest.js"
+      src="/_next/static/mFU9Dsb4P_f6sH8h7hS8o/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "8u7YzT9oXyUGDQ5TAXtAY",
+        "buildId": "mFU9Dsb4P_f6sH8h7hS8o",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8u7YzT9oXyUGDQ5TAXtAY/_buildManifest.js"
+      src="/_next/static/mFU9Dsb4P_f6sH8h7hS8o/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8u7YzT9oXyUGDQ5TAXtAY/_ssgManifest.js"
+      src="/_next/static/mFU9Dsb4P_f6sH8h7hS8o/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "8u7YzT9oXyUGDQ5TAXtAY",
+        "buildId": "mFU9Dsb4P_f6sH8h7hS8o",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/8u7YzT9oXyUGDQ5TAXtAY/_buildManifest.js"
+      src="/_next/static/mFU9Dsb4P_f6sH8h7hS8o/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/8u7YzT9oXyUGDQ5TAXtAY/_ssgManifest.js"
+      src="/_next/static/mFU9Dsb4P_f6sH8h7hS8o/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 34c4c6b

Timer
Timer previously approved these changes Mar 8, 2021
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Mar 8, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
buildDuration 11.6s 11.3s -289ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +287 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.166 2.077 -0.09
/ avg req/sec 1154.36 1203.5 +49.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.439 1.491 ⚠️ +0.05
/error-in-render avg req/sec 1737.22 1676.3 ⚠️ -60.92
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
buildDuration 13.7s 13.9s ⚠️ +162ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +287 B
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
677f882d2ed8..a2e7.js gzip 13.4 kB 13.4 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.65 kB 6.65 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
amp-e3e9bc99..932c.js gzip 536 B 536 B ✓
hooks-5023ef..3670.js gzip 888 B 888 B ✓
index-3a2b03..c677.js gzip 227 B 227 B ✓
link-177412b..043e.js gzip 1.67 kB 1.67 kB ✓
routerDirect..1a66.js gzip 303 B 303 B ✓
withRouter-9..1b7d.js gzip 302 B 302 B ✓
Overall change 8.66 kB 8.66 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_buildManifest.js gzip 347 B 347 B ✓
Overall change 347 B 347 B ✓
Serverless bundles
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_error.js 1.02 MB 1.02 MB ✓
404.html 2.67 kB 2.67 kB ✓
500.html 2.65 kB 2.65 kB ✓
amp.amp.html 10.5 kB 10.5 kB ✓
amp.html 1.86 kB 1.86 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
buildDuration 13.6s 13.7s ⚠️ +131ms
nodeModulesSize 42.8 MB 42.8 MB ⚠️ +287 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.043 2.138 ⚠️ +0.09
/ avg req/sec 1223.62 1169.33 ⚠️ -54.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.489 1.5 ⚠️ +0.01
/error-in-render avg req/sec 1678.5 1667.12 ⚠️ -11.38
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
597-2bc2376a..203d.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.59 kB 6.59 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 60.2 kB 60.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_app-aedc815..1421.js gzip 1.26 kB 1.26 kB ✓
_error-71ec2..1a96.js gzip 3.38 kB 3.38 kB ✓
amp-33a09cb0..6745.js gzip 536 B 536 B ✓
hooks-4e968a..f870.js gzip 902 B 902 B ✓
index-5c6845..f75c.js gzip 230 B 230 B ✓
link-99f0c6c..b84a.js gzip 1.65 kB 1.65 kB ✓
routerDirect..bb56.js gzip 306 B 306 B ✓
withRouter-7..2133.js gzip 302 B 302 B ✓
Overall change 8.57 kB 8.57 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
_buildManifest.js gzip 326 B 326 B ✓
Overall change 326 B 326 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/upgrade-next-webpack5 Change
index.html gzip 586 B 586 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "Lp-5uLAZsO8Sm1x7P7oj7",
+        "buildId": "Bv0gf8LMjnV3Fq0cpQEjR",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Lp-5uLAZsO8Sm1x7P7oj7/_buildManifest.js"
+      src="/_next/static/Bv0gf8LMjnV3Fq0cpQEjR/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Lp-5uLAZsO8Sm1x7P7oj7/_ssgManifest.js"
+      src="/_next/static/Bv0gf8LMjnV3Fq0cpQEjR/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "Lp-5uLAZsO8Sm1x7P7oj7",
+        "buildId": "Bv0gf8LMjnV3Fq0cpQEjR",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Lp-5uLAZsO8Sm1x7P7oj7/_buildManifest.js"
+      src="/_next/static/Bv0gf8LMjnV3Fq0cpQEjR/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Lp-5uLAZsO8Sm1x7P7oj7/_ssgManifest.js"
+      src="/_next/static/Bv0gf8LMjnV3Fq0cpQEjR/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "Lp-5uLAZsO8Sm1x7P7oj7",
+        "buildId": "Bv0gf8LMjnV3Fq0cpQEjR",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/Lp-5uLAZsO8Sm1x7P7oj7/_buildManifest.js"
+      src="/_next/static/Bv0gf8LMjnV3Fq0cpQEjR/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/Lp-5uLAZsO8Sm1x7P7oj7/_ssgManifest.js"
+      src="/_next/static/Bv0gf8LMjnV3Fq0cpQEjR/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 3df25bd

@kodiakhq kodiakhq bot merged commit 9e06f82 into vercel:canary Mar 8, 2021
This was referenced Mar 15, 2021
Merged
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
This was referenced Mar 16, 2021
Merged
Merged
Closed
Closed
Merged
Closed
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Merged
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@Timer Timer Timer left review comments

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @Timer