-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom amphtml-validator for invalid amp #9176
Comments
I will try to send PR later. |
@yosuke-furukawa this doesn't explain the "why" you'd want to do that. Can you elaborate on that? |
@timneutkens
|
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Feature request
I would like to customize amphtml validator.
our project are using amp html, and we would like to customize our own amp validator.
Is your feature request related to a problem? Please describe.
Currently next.js worker uses buit-in
amphtml-validator
.https://github.com/zeit/next.js/blob/canary/packages/next/export/worker.js#L6
https://github.com/zeit/next.js/blob/canary/packages/next/export/worker.js#L151
However
amphtml-validator
has options to customize validators in here. https://github.com/ampproject/amphtml/blob/master/validator/nodejs/index.js#L295We would like to inject the custom validators using this options.
If next.js could pass the options, that is really helpful.
Describe the solution you'd like
Add validator options in worker.js.
Describe alternatives you've considered
N/A
Additional context
Related issues:
#9164
#8389
The text was updated successfully, but these errors were encountered: