From 2092c657da7ec1e69a917fd8997e671d1a2cef7a Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Thu, 5 Mar 2020 23:40:43 -0500 Subject: [PATCH 1/2] Fix Prerender Test Cases --- test/integration/prerender/test/index.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/integration/prerender/test/index.test.js b/test/integration/prerender/test/index.test.js index df33449812b02..dc9a62a452155 100644 --- a/test/integration/prerender/test/index.test.js +++ b/test/integration/prerender/test/index.test.js @@ -377,10 +377,10 @@ const runTests = (dev = false, looseMode = false) => { it('should reload page on failed data request', async () => { const browser = await webdriver(appPort, '/') - await browser.eval('window.beforeClick = true') + await browser.eval('window.beforeClick = "abc"') await browser.elementByCss('#broken-post').click() await waitFor(1000) - expect(await browser.eval('window.beforeClick')).not.toBe('true') + expect(await browser.eval('window.beforeClick')).not.toBe('abc') }) // TODO: dev currently renders this page as blocking, meaning it shows the @@ -388,10 +388,10 @@ const runTests = (dev = false, looseMode = false) => { if (!dev) { it('should reload page on failed data request, and retry', async () => { const browser = await webdriver(appPort, '/') - await browser.eval('window.beforeClick = true') + await browser.eval('window.beforeClick = "abc"') await browser.elementByCss('#broken-at-first-post').click() await waitFor(3000) - expect(await browser.eval('window.beforeClick')).not.toBe('true') + expect(await browser.eval('window.beforeClick')).not.toBe('abc') const text = await browser.elementByCss('#params').text() expect(text).toMatch(/post.*?post-999/) From e35390ab039f7daecb492df943e5a5ec7366b8e5 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Fri, 6 Mar 2020 01:18:00 -0500 Subject: [PATCH 2/2] fix test --- test/integration/prerender/pages/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integration/prerender/pages/index.js b/test/integration/prerender/pages/index.js index d94150aa8f224..b1e2a18e4dab1 100644 --- a/test/integration/prerender/pages/index.js +++ b/test/integration/prerender/pages/index.js @@ -33,7 +33,7 @@ const Page = ({ world, time }) => { to broken - + to broken at first