-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support multiple useSWRInfinite hooks in a page #1009
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1b111ef:
|
Why has the CodeSandbox build been failed?
|
After #995 codesandbox ci seems broken 🥲 . I am working on it |
@promer94 I got it, thank you! |
2e43289
to
d670348
Compare
I've confirmed that this doesn't work, so I'll investigate more. |
3c6ed90
to
16ac68f
Compare
f3b375c
to
abf9c5c
Compare
all tests now have been passed 🎉 But I have to refactor the implementation to get this merged. |
175b782
to
4ef0de7
Compare
I wanted to re-use |
This is now ready for review again 🚀 |
fixes #976
This PR fixes issues caused by using multiple
useSWRInfinite
on a page.You can see the issues in the following link (v0.42).
This PR also fixes #976.
https://codesandbox.io/s/swr-basic-forked-mbx6y
I guess this is a naive implementation and would change some behaviors of
useSWRInfinite
, so it should be merged carefully.