test: refactor use-swr-config-callbacks.test.tsx #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8b3db69:
|
koba04
force-pushed
the
refactor-use-swr-config-callbacks-test
branch
from
59d37fc
to
87eecea
Compare
This was referenced Jan 28, 2021
koba04
force-pushed
the
refactor-use-swr-config-callbacks-test
branch
from
080bbc9
to
ace7818
Compare
|
Thank you! |
This was referenced Mar 9, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
This was referenced Mar 18, 2021
This was referenced Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #932, so this should be merged after #932.
The following are the commits for this PR.
I've refactored
use-swr-config-callbacks.test.tsxas the same way with #932.But in this PR, I've added the
createResponsefunction intest/utils.ts. This is used to create afetcherfunction.It's to minimize the usage of
setTimeoutbecause tests that depend on the actual time is fragile, so I think we should avoid it and wait for a promise for a response from afetcherfunction.