[turborepo] examples/with-tailwind
, and others, potential misleading TSConfigs
#4146
Labels
examples/with-tailwind
, and others, potential misleading TSConfigs
#4146
What version of Turborepo are you using?
N/A
What package manager are you using / does the bug impact?
pnpm
What operating system are you using?
Linux
Describe the Bug
Examples may be showing TSConfig
include
andexclude
settings that are misleading because they technically have no effect given that the Typescript spec says that they are resolved relative to the location of thetsconfig.json
file. For example, these have no effect:https://github.com/vercel/turbo/blob/baf6504e4ef80e1bc0eb4038481663df820d1283/examples/with-tailwind/packages/tsconfig/nextjs.json#L20-L21
Because the source to include and
node_modules
to exclude are relative to the NextJS app's TSConfig:https://github.com/vercel/turbo/blob/baf6504e4ef80e1bc0eb4038481663df820d1283/examples/with-tailwind/apps/web/tsconfig.json#L1-L5
I believe this is an issue that should be resolved, but I'm new to JS/TS so not absolutely sure. I came across build errors related to this when I tried compiling the Turborepo's example with a different build system. Perhaps there could be a separate issue raised that a Turbo linter could pick up on this?
Expected Behavior
The examples in the repo shouldn't have these options set in the shared TSConfig libraries.
To Reproduce
N/A
Reproduction Repo
No response
The text was updated successfully, but these errors were encountered: