Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes of jasync were not ported from 3.6 branch to 3.7 and 3.8 #166

Open
oshai opened this issue Nov 20, 2019 · 2 comments
Open

Changes of jasync were not ported from 3.6 branch to 3.7 and 3.8 #166

oshai opened this issue Nov 20, 2019 · 2 comments

Comments

@oshai
Copy link

oshai commented Nov 20, 2019

Hi @codepitbull ,
I noticed that some PR's were not ported across branches.
Is there a reason for that or just something missed some how?
Here are few PR examples:
#154
#141

Thanks,
Ohad.

@codepitbull
Copy link

If PRs are merged before a new version is created they should be part of the new branch.

If PRs are created for older branches I think there should be individual PRs for each branch, especially since the one merging the branch might have tro adjust code to port fixes.

At least that how I handle things normally:
If I have to fix something in an older branch I will provide additional PRs for the others (in most cases those are just cherry picks).

@oshai
Copy link
Author

oshai commented Jan 16, 2020

Do you want me to do that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants