Support skipping directories in backup tool #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1792 +/- ##
==========================================
- Coverage 95.03% 89.13% -5.91%
==========================================
Files 139 139
Lines 26649 26657 +8
==========================================
- Hits 25326 23760 -1566
- Misses 1323 2897 +1574
Continue to review full report at Codecov.
|
invisig0th
reviewed
Jul 8, 2020
synapse/tools/backup.py
Outdated
| continue | ||
|
|
||
| logger.info(f'making dir:{dstpath}') | ||
| s_common.gendir(dstpath) | ||
|
|
||
| for name in fnames: | ||
| if name in skipfns: |
There was a problem hiding this comment.
Could we make this a glob match so i could specify "layers/*" as a skip?
There was a problem hiding this comment.
Updated to do a glob match on the relative dir. I left the exclusion specifically for directories, but we could of course extend it to match filenames as well (either as separate skip option, or just make one generic skip option).
vEpiphyte
approved these changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.