Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Axon HTTPAPI tweaks #1822

Merged
merged 6 commits into from
Jul 29, 2020
Merged

Axon HTTPAPI tweaks #1822

merged 6 commits into from
Jul 29, 2020

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Jul 28, 2020

Changes from #1817 based on integration feedback:

  • Use a hashset in the axon httpapi handler for uploading a file so all the hashes for the given file are made available to the user.
  • Rename HTTPAPI handlers to be more descriptive.
  • Add $lib.bytes.has() stormtypes api
  • Add a /has HTTPAPI for axon
  • Small Axon doc updates

… the hashes for the given file are made available to the user.
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1822 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
- Coverage   96.25%   96.23%   -0.02%     
==========================================
  Files         139      139              
  Lines       27249    27266      +17     
==========================================
+ Hits        26228    26239      +11     
- Misses       1021     1027       +6     
Flag Coverage Δ
#linux 96.23% <100.00%> (-0.02%) ⬇️
#linux_replay 66.42% <54.16%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/axon.py 99.11% <100.00%> (+0.04%) ⬆️
synapse/lib/stormtypes.py 97.39% <100.00%> (+<0.01%) ⬆️
synapse/lib/spawn.py 95.48% <0.00%> (-1.94%) ⬇️
synapse/lib/base.py 91.96% <0.00%> (-0.90%) ⬇️
synapse/lib/agenda.py 94.11% <0.00%> (-0.23%) ⬇️
synapse/lib/lmdbslab.py 98.76% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4039f06...845ceba. Read the comment docs.

@vEpiphyte vEpiphyte added this to the v2.5.0 milestone Jul 29, 2020
@vEpiphyte vEpiphyte merged commit 5e86314 into master Jul 29, 2020
@vEpiphyte vEpiphyte deleted the feature_axonhttpv2 branch July 29, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants