Allow benchmark script to run on remote cortices #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add --remote parameter to benchmark_cortex script. It causes temporary layers to be created for benchmarking. Update benchmark tests to use APIs that accept view parameters (and aren't deprecated).
This reverts commit 3385062.
Codecov Report
@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
- Coverage 96.19% 90.69% -5.51%
==========================================
Files 140 140
Lines 27387 27402 +15
==========================================
- Hits 26345 24852 -1493
- Misses 1042 2550 +1508
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
invisig0th
reviewed
Aug 3, 2020
Use the new metho in the benchmarking script. While I'm in there, modify lmdbslab countByPref to take advantage of the Scan/ScanKeys refactor
…synapse into remote-benchmark2
invisig0th
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add --remote parameter to benchmark_cortex script. It causes temporary layers and views to be created for benchmarking.
Also fix a getTagCount/bump heisenbug I stumbled upon.