Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper runtsafe scope for commands and detect undeclared vars #1916

Merged
merged 10 commits into from
Oct 16, 2020

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 14, 2020

Codecov Report

Merging #1916 into master will increase coverage by 0.08%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
+ Coverage   96.59%   96.68%   +0.08%     
==========================================
  Files         139      139              
  Lines       26470    26500      +30     
==========================================
+ Hits        25570    25621      +51     
+ Misses        900      879      -21     
Flag Coverage Δ
#linux 96.68% <97.36%> (+0.08%) ⬆️
#linux_replay 70.93% <96.05%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/stormtypes.py 97.54% <90.00%> (-0.08%) ⬇️
synapse/lib/ast.py 98.09% <100.00%> (+<0.01%) ⬆️
synapse/lib/node.py 97.75% <100.00%> (+0.01%) ⬆️
synapse/lib/storm.py 98.30% <100.00%> (-0.01%) ⬇️
synapse/lib/lmdbslab.py 99.59% <0.00%> (+0.20%) ⬆️
synapse/common.py 97.48% <0.00%> (+0.31%) ⬆️
synapse/lib/spawn.py 95.51% <0.00%> (+6.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40486ca...34bd632. Read the comment docs.

synapse/tests/test_lib_stormtypes.py Outdated Show resolved Hide resolved
synapse/tests/test_lib_stormtypes.py Show resolved Hide resolved
synapse/lib/ast.py Outdated Show resolved Hide resolved
synapse/lib/ast.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte added this to the 2.9.0 milestone Oct 15, 2020
@vEpiphyte vEpiphyte added the bug label Oct 15, 2020
@vEpiphyte vEpiphyte merged commit dc407f6 into master Oct 16, 2020
@vEpiphyte vEpiphyte deleted the bug-cmdopts branch October 16, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants