Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time repr - Reuse epoch object instead if making a new object. #1919

Merged
merged 3 commits into from
Oct 22, 2020

Conversation

vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Oct 19, 2020

according to my timeit tests, this is about 10% faster than constructing the new object each time

@vEpiphyte vEpiphyte added this to the 2.9.1 milestone Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1919 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1919      +/-   ##
==========================================
- Coverage   96.69%   96.61%   -0.08%     
==========================================
  Files         139      139              
  Lines       26501    26501              
==========================================
- Hits        25624    25603      -21     
- Misses        877      898      +21     
Flag Coverage Δ
#linux 96.61% <100.00%> (-0.08%) ⬇️
#linux_replay 70.92% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/time.py 98.79% <100.00%> (ø)
synapse/lib/spawn.py 89.10% <0.00%> (-6.42%) ⬇️
synapse/common.py 97.16% <0.00%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0d395...9827d1b. Read the comment docs.

@invisig0th invisig0th merged commit 5117134 into master Oct 22, 2020
@invisig0th invisig0th deleted the bug_time branch October 22, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants