Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug background capture #1957

Merged
merged 3 commits into from
Nov 16, 2020
Merged

Bug background capture #1957

merged 3 commits into from
Nov 16, 2020

Conversation

vEpiphyte
Copy link
Contributor

  • Background command syn:task captured the AST and not the original query.
  • Background command variable capture could capture heavy objects, breaking ps commands.

For background command from #1931

@vEpiphyte vEpiphyte added the bug label Nov 16, 2020
@vEpiphyte vEpiphyte added this to the 2.10.0 milestone Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #1957 (f779a75) into master (637c061) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1957      +/-   ##
==========================================
- Coverage   96.73%   96.49%   -0.24%     
==========================================
  Files         142      142              
  Lines       26956    26959       +3     
==========================================
- Hits        26075    26015      -60     
- Misses        881      944      +63     
Flag Coverage Δ
linux 96.49% <100.00%> (-0.24%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/storm.py 98.12% <100.00%> (+<0.01%) ⬆️
synapse/lib/spawn.py 89.74% <0.00%> (-6.74%) ⬇️
synapse/tests/utils.py 93.56% <0.00%> (-2.20%) ⬇️
synapse/cortex.py 95.52% <0.00%> (-0.79%) ⬇️
synapse/lib/hiveauth.py 95.96% <0.00%> (-0.77%) ⬇️
synapse/lib/view.py 95.37% <0.00%> (-0.73%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/lmdbslab.py 99.39% <0.00%> (-0.21%) ⬇️
synapse/lib/layer.py 97.80% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637c061...f779a75. Read the comment docs.

@vEpiphyte vEpiphyte merged commit 7d37a56 into master Nov 16, 2020
@vEpiphyte vEpiphyte deleted the bug_background_capture branch November 16, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants