Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent overflow errors in integer lifts #1980

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Prevent overflow errors in integer lifts #1980

merged 3 commits into from
Dec 2, 2020

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Dec 1, 2020

No description provided.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1980 (7bdb581) into master (f2b4bd8) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1980      +/-   ##
==========================================
- Coverage   96.75%   96.59%   -0.16%     
==========================================
  Files         146      146              
  Lines       27797    27815      +18     
==========================================
- Hits        26896    26869      -27     
- Misses        901      946      +45     
Flag Coverage Δ
linux 96.59% <100.00%> (-0.16%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/layer.py 97.83% <100.00%> (-0.05%) ⬇️
synapse/tests/utils.py 93.59% <0.00%> (-2.18%) ⬇️
synapse/lib/spawn.py 96.47% <0.00%> (-0.97%) ⬇️
synapse/lib/hiveauth.py 95.96% <0.00%> (-0.77%) ⬇️
synapse/cortex.py 95.60% <0.00%> (-0.77%) ⬇️
synapse/lib/view.py 95.37% <0.00%> (-0.73%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/lmdbslab.py 99.39% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b4bd8...7bdb581. Read the comment docs.

@invisig0th invisig0th added this to the v2.12.3 milestone Dec 1, 2020
@Cisphyx Cisphyx merged commit 430aa45 into master Dec 2, 2020
@Cisphyx Cisphyx deleted the int-overflow branch December 2, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants