Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a problem in syncLayerNodeEdits/syncLayersEvents #1996

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

jnwatson
Copy link
Contributor

Once caught up and pending, those methods wouldn't yield a brand new layer's events until another after another event occured.

Once caught up and pending, those methods wouldn't
yield a brand new layer's events until another after
another event occured.
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1996 (5d7f06b) into master (53bee2f) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1996      +/-   ##
==========================================
- Coverage   96.83%   96.67%   -0.16%     
==========================================
  Files         146      146              
  Lines       28585    28595      +10     
==========================================
- Hits        27679    27645      -34     
- Misses        906      950      +44     
Flag Coverage Δ
linux 96.67% <100.00%> (-0.16%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/cortex.py 95.98% <100.00%> (-0.77%) ⬇️
synapse/tests/utils.py 93.64% <0.00%> (-2.17%) ⬇️
synapse/lib/hiveauth.py 96.24% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 95.35% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/lmdbslab.py 99.40% <0.00%> (-0.20%) ⬇️
synapse/lib/layer.py 98.09% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bee2f...5d7f06b. Read the comment docs.

@invisig0th invisig0th merged commit f3eba62 into master Dec 11, 2020
@invisig0th invisig0th deleted the layeredit-pend-fix branch December 11, 2020 18:19
@vEpiphyte vEpiphyte added the bug label Dec 11, 2020
@vEpiphyte vEpiphyte added this to the v2.15.0 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants