Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature StormVarListError messages #2013

Merged
merged 3 commits into from
Dec 17, 2020
Merged

Feature StormVarListError messages #2013

merged 3 commits into from
Dec 17, 2020

Conversation

vEpiphyte
Copy link
Contributor

Make them more useful.

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #2013 (3b5a34e) into master (f8d202f) will decrease coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2013      +/-   ##
==========================================
- Coverage   96.83%   96.60%   -0.24%     
==========================================
  Files         147      147              
  Lines       28752    28756       +4     
==========================================
- Hits        27842    27779      -63     
- Misses        910      977      +67     
Flag Coverage Δ
linux 96.60% <100.00%> (-0.24%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/ast.py 98.22% <100.00%> (+0.09%) ⬆️
synapse/lib/spawn.py 89.20% <0.00%> (-8.26%) ⬇️
synapse/tests/utils.py 93.64% <0.00%> (-2.17%) ⬇️
synapse/cortex.py 95.79% <0.00%> (-0.76%) ⬇️
synapse/lib/hiveauth.py 96.05% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 94.19% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/common.py 97.43% <0.00%> (-0.29%) ⬇️
synapse/lib/layer.py 98.10% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d202f...3b5a34e. Read the comment docs.

synapse/lib/ast.py Outdated Show resolved Hide resolved
@vEpiphyte vEpiphyte merged commit 64f7d8c into master Dec 17, 2020
@vEpiphyte vEpiphyte deleted the feature_err_mesg branch December 17, 2020 21:13
@vEpiphyte vEpiphyte added this to the v2.17.1 milestone Dec 29, 2020
@vEpiphyte vEpiphyte added bug and removed enhancement labels Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants