Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in parsing of cmdr and storm arguments #2033

Merged
merged 3 commits into from
Dec 29, 2020
Merged

Conversation

jnwatson
Copy link
Contributor

Also sneak in a doc grammar fix

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #2033 (a94de28) into master (a233336) will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2033      +/-   ##
==========================================
- Coverage   96.77%   96.62%   -0.16%     
==========================================
  Files         148      148              
  Lines       29126    29125       -1     
==========================================
- Hits        28188    28141      -47     
- Misses        938      984      +46     
Flag Coverage Δ
linux 96.62% <ø> (-0.16%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/parser.py 98.00% <ø> (-0.01%) ⬇️
synapse/models/economic.py 100.00% <ø> (ø)
synapse/tests/utils.py 93.66% <0.00%> (-2.16%) ⬇️
synapse/lib/spawn.py 89.20% <0.00%> (-0.96%) ⬇️
synapse/cortex.py 95.75% <0.00%> (-0.76%) ⬇️
synapse/lib/hiveauth.py 96.05% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 94.22% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/common.py 97.43% <0.00%> (-0.29%) ⬇️
synapse/lib/layer.py 98.24% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a233336...a94de28. Read the comment docs.

@invisig0th invisig0th merged commit cdf69ce into master Dec 29, 2020
@invisig0th invisig0th deleted the cmd-parse-bug branch December 29, 2020 16:53
@vEpiphyte vEpiphyte added this to the v2.20.0 milestone Dec 29, 2020
@vEpiphyte vEpiphyte added the bug label Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants